)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"fc3c0eeae1dcb04f7206e073b8a0ad4775eaf12d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the self.threads list and call the wait or stop method on each one."},{"line_number":11,"context_line":"This list could potentially be edited concurrently by the _thread_done"},{"line_number":12,"context_line":"callbacks and remove some items in the list.  As a result, the wait"},{"line_number":13,"context_line":"method would not actually wait for all threads in the thread group."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia49d7096180b2942cf49b1f0dacde3c5e933337c"},{"line_number":16,"context_line":"Closes-Bug: #1196525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9juE%3D","line":13,"updated":"2013-12-10 09:16:57.000000000","message":"I would prefer that we were explicit when syncing oslo, as this as written isn\u0027t clear if you\u0027ve sync\u0027d threadgroup.py to the latest oslo version, or cherry-picked your commit, or done a fix local to the heat tree (I see that it is in oslo so that\u0027s fine, but the commit message is unclear, so I had to go and look in the oslo code to find out, which means the commit message is lacking sufficient detail).\n\nI\u0027d prefer us to generally sync with oslo (single files or modules is OK, it doesn\u0027t have to be everything) rather than cherry-picks as it makes it much easier to figure out what oslo version we\u0027re at.  I\u0027d also like us to mention the commit sha we\u0027re syncing to in the commit message, so we stand some chance of figuring out what version of stuff we have in our tree when bugs happen.\n\nSo I would do something like:\n\nSync oslo threadgroup.py to fix wait \u0026 stop methods\n\nSync oslo threadgroup.py to 25ff65e955b7ef1091722224f7c71f14fc971354 so we\ninclude the fix for bug #1196525, which resolves a problem where the wait method\nwould not actually wait for all threads in the thread group.\n\nOr something similar.","commit_id":"5c251f1ce3de269ed8670588c5f2368356703977"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"192b8ede6d6632a741cf39ee1d6903da23076b5f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the self.threads list and call the wait or stop method on each one."},{"line_number":11,"context_line":"This list could potentially be edited concurrently by the _thread_done"},{"line_number":12,"context_line":"callbacks and remove some items in the list.  As a result, the wait"},{"line_number":13,"context_line":"method would not actually wait for all threads in the thread group."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia49d7096180b2942cf49b1f0dacde3c5e933337c"},{"line_number":16,"context_line":"Closes-Bug: #1196525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9hSM%3D","line":13,"in_reply_to":"AAAATn%2F9juE%3D","updated":"2013-12-10 16:44:29.000000000","message":"It was a sync from Oslo.  I used:\n\n python update.py --nodeps --base heat --dest-dir ../heat --modules threa group\n\nI will update the commit message.  Thanks.","commit_id":"5c251f1ce3de269ed8670588c5f2368356703977"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"fc3c0eeae1dcb04f7206e073b8a0ad4775eaf12d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"method would not actually wait for all threads in the thread group."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia49d7096180b2942cf49b1f0dacde3c5e933337c"},{"line_number":16,"context_line":"Closes-Bug: #1196525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9jts%3D","line":16,"updated":"2013-12-10 09:16:57.000000000","message":"If you\u0027re going to tag this Closes-Bug in the Heat commit (which is not essential IMO), you should set the bug as \"also affects project\" Heat, as currently this looks like we\u0027re closing an oslo bug in a Heat commit.","commit_id":"5c251f1ce3de269ed8670588c5f2368356703977"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"192b8ede6d6632a741cf39ee1d6903da23076b5f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"method would not actually wait for all threads in the thread group."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia49d7096180b2942cf49b1f0dacde3c5e933337c"},{"line_number":16,"context_line":"Closes-Bug: #1196525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9hTk%3D","line":16,"in_reply_to":"AAAATn%2F9jts%3D","updated":"2013-12-10 16:44:29.000000000","message":"Done","commit_id":"5c251f1ce3de269ed8670588c5f2368356703977"}]}