)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"550b87640028ef42fa4915e8b1ebc7c4bd67cb37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add and initialize marconi client in engine.clients, so it can"},{"line_number":10,"context_line":"be used in later patches."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint mqaas-marconi-resource"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1f25145386428a6d127e41f1fff839d6d88a512d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9iHs%3D","line":12,"updated":"2013-12-10 14:28:58.000000000","message":"Implements: blueprint xxxxx","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"bfae8214d0f46a10240825945204dc96defdd5d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add and initialize marconi client in engine.clients, so it can"},{"line_number":10,"context_line":"be used in later patches."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Blueprint mqaas-marconi-resource"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1f25145386428a6d127e41f1fff839d6d88a512d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9V6M%3D","line":12,"in_reply_to":"AAAATn%2F9iHs%3D","updated":"2013-12-12 14:27:17.000000000","message":"Doesn\u0027t seem necessary, but will do ;)","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"}],"heat/engine/clients.py":[{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"0818a328695f11c54c4fff00ecb4b3570202dc5e","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9iVU%3D","line":241,"updated":"2013-12-10 13:49:40.000000000","message":"except queuing, will we pass other service_type to marconi?\nIf no, I suggest remove the  parameter.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"bfae8214d0f46a10240825945204dc96defdd5d2","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9V7o%3D","line":241,"in_reply_to":"AAAATn%2F9fcE%3D","updated":"2013-12-12 14:27:17.000000000","message":"Yeah. Someone would call it messaging ;)","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"550b87640028ef42fa4915e8b1ebc7c4bd67cb37","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9iIY%3D","line":241,"in_reply_to":"AAAATn%2F9iVU%3D","updated":"2013-12-10 14:28:58.000000000","message":"Agreed with Jun","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"80a94589a1eb57088c1eb3203484463ca2413c1e","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9fcE%3D","line":241,"in_reply_to":"AAAATn%2F9iVU%3D","updated":"2013-12-10 23:44:40.000000000","message":"IMO, this is fine. Not all service providers organize their catalog the same way. Its not a *good* practice to deviate from the \"standard\" catalog types, IMO, but keeping this as a possible configuration option seems ok to me.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"550b87640028ef42fa4915e8b1ebc7c4bd67cb37","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"},{"line_number":245,"context_line":"            return self._marconi"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9iIQ%3D","line":242,"updated":"2013-12-10 14:28:58.000000000","message":"would it be better to use \"if not marconiclient:\"","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"bfae8214d0f46a10240825945204dc96defdd5d2","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"},{"line_number":245,"context_line":"            return self._marconi"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9V9w%3D","line":242,"in_reply_to":"AAAATn%2F9ffQ%3D","updated":"2013-12-12 14:27:17.000000000","message":"Thanks! This is exactly what I would say ;)","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"20dc12b28bd9d1fb40668077d411f298b8072432","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        return self._trove"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def marconi(self, service_type\u003d\"queuing\"):"},{"line_number":242,"context_line":"        if marconiclient is None:"},{"line_number":243,"context_line":"            return None"},{"line_number":244,"context_line":"        if self._marconi:"},{"line_number":245,"context_line":"            return self._marconi"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9ffQ%3D","line":242,"in_reply_to":"AAAATn%2F9iIQ%3D","updated":"2013-12-10 23:25:29.000000000","message":"well it is explicitly set to None at the top, and thus he is testing for that.\n\"if not bla:\" is true for other things too. - just saying I don\u0027t see a problem with this.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"550b87640028ef42fa4915e8b1ebc7c4bd67cb37","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            return self._marconi"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        con \u003d self.context"},{"line_number":248,"context_line":"        if self.auth_token is None:"},{"line_number":249,"context_line":"            logger.error(_(\"Marconi connection failed, no auth_token!\"))"},{"line_number":250,"context_line":"            return None"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9iIM%3D","line":248,"updated":"2013-12-10 14:28:58.000000000","message":"same","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"bfae8214d0f46a10240825945204dc96defdd5d2","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            return self._marconi"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        con \u003d self.context"},{"line_number":248,"context_line":"        if self.auth_token is None:"},{"line_number":249,"context_line":"            logger.error(_(\"Marconi connection failed, no auth_token!\"))"},{"line_number":250,"context_line":"            return None"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9V9M%3D","line":248,"in_reply_to":"AAAATn%2F9ffI%3D","updated":"2013-12-12 14:27:17.000000000","message":"Thanks again!","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"20dc12b28bd9d1fb40668077d411f298b8072432","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            return self._marconi"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        con \u003d self.context"},{"line_number":248,"context_line":"        if self.auth_token is None:"},{"line_number":249,"context_line":"            logger.error(_(\"Marconi connection failed, no auth_token!\"))"},{"line_number":250,"context_line":"            return None"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9ffI%3D","line":248,"in_reply_to":"AAAATn%2F9iIM%3D","updated":"2013-12-10 23:25:29.000000000","message":"he is been consistent with the rest of the file.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"550b87640028ef42fa4915e8b1ebc7c4bd67cb37","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        auth_opts \u003d {\u0027backend\u0027: \u0027keystone\u0027,"},{"line_number":259,"context_line":"                     \u0027options\u0027: opts}"},{"line_number":260,"context_line":"        conf \u003d {\u0027auth_opts\u0027: auth_opts}"},{"line_number":261,"context_line":"        endpoint \u003d self.url_for(service_type\u003d\u0027queuing\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self._marconi \u003d marconiclient.Client(url\u003dendpoint, conf\u003dconf)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9iH8%3D","line":261,"updated":"2013-12-10 14:28:58.000000000","message":"endpoint \u003d self.url_for(service_type\u003d\u0027queuing\u0027) is not correct,\nit should be endpoint \u003d self.url_for(service_type\u003dservice_type)","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"change_message_id":"bfae8214d0f46a10240825945204dc96defdd5d2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        auth_opts \u003d {\u0027backend\u0027: \u0027keystone\u0027,"},{"line_number":259,"context_line":"                     \u0027options\u0027: opts}"},{"line_number":260,"context_line":"        conf \u003d {\u0027auth_opts\u0027: auth_opts}"},{"line_number":261,"context_line":"        endpoint \u003d self.url_for(service_type\u003d\u0027queuing\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self._marconi \u003d marconiclient.Client(url\u003dendpoint, conf\u003dconf)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9V60%3D","line":261,"in_reply_to":"AAAATn%2F9fbs%3D","updated":"2013-12-12 14:27:17.000000000","message":"Thanks for spotting this. I will let it reference to the service_type argument.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"80a94589a1eb57088c1eb3203484463ca2413c1e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        auth_opts \u003d {\u0027backend\u0027: \u0027keystone\u0027,"},{"line_number":259,"context_line":"                     \u0027options\u0027: opts}"},{"line_number":260,"context_line":"        conf \u003d {\u0027auth_opts\u0027: auth_opts}"},{"line_number":261,"context_line":"        endpoint \u003d self.url_for(service_type\u003d\u0027queuing\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self._marconi \u003d marconiclient.Client(url\u003dendpoint, conf\u003dconf)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9fbs%3D","line":261,"in_reply_to":"AAAATn%2F9fes%3D","updated":"2013-12-10 23:44:40.000000000","message":"Would prefer we keep the argument at the top and fix this, but not too fussed either way.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"20dc12b28bd9d1fb40668077d411f298b8072432","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        auth_opts \u003d {\u0027backend\u0027: \u0027keystone\u0027,"},{"line_number":259,"context_line":"                     \u0027options\u0027: opts}"},{"line_number":260,"context_line":"        conf \u003d {\u0027auth_opts\u0027: auth_opts}"},{"line_number":261,"context_line":"        endpoint \u003d self.url_for(service_type\u003d\u0027queuing\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        self._marconi \u003d marconiclient.Client(url\u003dendpoint, conf\u003dconf)"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9fes%3D","line":261,"in_reply_to":"AAAATn%2F9iH8%3D","updated":"2013-12-10 23:25:29.000000000","message":"agree, but if we remove the argument at the top of the method this can stay.","commit_id":"837671bfdfe4881075c5984e5e273aa4c0424031"}]}