)]}'
{"heat/engine/resources/neutron/router.py":[{"author":{"_account_id":9000,"name":"Ryo Miki","email":"miki.ryo@po.ntt-tx.co.jp","username":"miki.ryo"},"change_message_id":"f7220ef8e87ba620dc5caecad8d596997fa55bbe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            \u0027Description\u0027: _(\u0027The port id, either \u0027"},{"line_number":94,"context_line":"                             \u0027subnet_id or port_id should be specified.\u0027)}}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def add_dependencies(self, deps):"},{"line_number":97,"context_line":"        super(RouterInterface, self).add_dependencies(deps)"},{"line_number":98,"context_line":"        # depend on any RouterL3agents in this template with the same router_id"},{"line_number":99,"context_line":"        # as this router_id."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9c4A%3D","line":96,"updated":"2013-12-11 11:52:32.000000000","message":"I consider about the resource, and find that dependencies is needed to avoid unnecessary migration between l3-agents.\n\nI will add dependency between subnet and NetDHCPAgent.","commit_id":"c8545a63216145fd6e20145a5bae8b186c48d2fc"},{"author":{"_account_id":8844,"name":"Mitsuru Kanabuchi","email":"kanabuchi.mitsuru@po.ntts.co.jp","username":"kanabuchi"},"change_message_id":"01c78d427925728575f98bb83bfe9cb45f62643c","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class RouterL3Agent(neutron.NeutronResource):"},{"line_number":201,"context_line":"    properties_schema \u003d {"},{"line_number":202,"context_line":"        \u0027router_id\u0027: {"},{"line_number":203,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":204,"context_line":"            \u0027Required\u0027: True,"},{"line_number":205,"context_line":"            \u0027Description\u0027: _(\u0027The ID of the router you want to be scheduled \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Yms%3D","line":202,"updated":"2013-12-12 01:52:23.000000000","message":"A new resource should use typed Schema","commit_id":"c8545a63216145fd6e20145a5bae8b186c48d2fc"},{"author":{"_account_id":9000,"name":"Ryo Miki","email":"miki.ryo@po.ntt-tx.co.jp","username":"miki.ryo"},"change_message_id":"02616258d07325f460bc3406e00616afc9074c3d","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class RouterL3Agent(neutron.NeutronResource):"},{"line_number":201,"context_line":"    properties_schema \u003d {"},{"line_number":202,"context_line":"        \u0027router_id\u0027: {"},{"line_number":203,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":204,"context_line":"            \u0027Required\u0027: True,"},{"line_number":205,"context_line":"            \u0027Description\u0027: _(\u0027The ID of the router you want to be scheduled \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9XXs%3D","line":202,"in_reply_to":"AAAATn%2F9Yms%3D","updated":"2013-12-12 08:03:24.000000000","message":"Thank you for comment. I adopt it.","commit_id":"c8545a63216145fd6e20145a5bae8b186c48d2fc"},{"author":{"_account_id":9000,"name":"Ryo Miki","email":"miki.ryo@po.ntt-tx.co.jp","username":"miki.ryo"},"change_message_id":"db33f0082ac976757d2699784b29fe4c0401ce27","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                         \u0027admin_state_up\u0027: {\u0027Type\u0027: \u0027Boolean\u0027,"},{"line_number":38,"context_line":"                                            \u0027Default\u0027: True,"},{"line_number":39,"context_line":"                                            \u0027UpdateAllowed\u0027: True}}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    attributes_schema \u003d {"},{"line_number":42,"context_line":"        \"status\": _(\"The status of the router.\"),"},{"line_number":43,"context_line":"        \"external_gateway_info\": _(\"Gateway network for the router.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9XUk%3D","line":40,"updated":"2013-12-12 08:13:36.000000000","message":"this line must be deleted.","commit_id":"ee766287fd64edf634a49215383f8f982c83c2ac"}],"heat/tests/test_neutron.py":[{"author":{"_account_id":9000,"name":"Ryo Miki","email":"miki.ryo@po.ntt-tx.co.jp","username":"miki.ryo"},"change_message_id":"813a60825fee9f8893a1b28a7ecb24fec6a4dee8","unresolved":false,"context_lines":[{"line_number":169,"context_line":"          \"ip_address\": \"10.0.0.10\""},{"line_number":170,"context_line":"        }]"},{"line_number":171,"context_line":"      }"},{"line_number":172,"context_line":"    }, \"floating_ip\": {"},{"line_number":173,"context_line":"      \"Type\": \"OS::Neutron::FloatingIP\","},{"line_number":174,"context_line":"      \"Properties\": {"},{"line_number":175,"context_line":"        \"floating_network_id\": \"abcd1234\","}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9XS8%3D","line":172,"updated":"2013-12-12 08:18:14.000000000","message":"must be fix, too.","commit_id":"ee766287fd64edf634a49215383f8f982c83c2ac"}]}