)]}'
{"heat/tests/test_nested_stack.py":[{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"5a7168fbb24f1360fa722640064dd761781af2db","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        prop_diff \u003d {\u0027TemplateURL\u0027: \u0027https://server.test/new.template\u0027}"},{"line_number":200,"context_line":"        updater \u003d rsrc.handle_update(new_res, {}, prop_diff)"},{"line_number":201,"context_line":"        updater.run_to_completion()"},{"line_number":202,"context_line":"        self.assertIs(rsrc.check_update_complete(updater), True)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Expect the physical resource name staying the same after update,"},{"line_number":205,"context_line":"        # so that the nested was actually updated instead of replaced."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Ydw%3D","line":202,"updated":"2013-12-12 02:41:32.000000000","message":"shouldn\u0027t this be assertTrue() ?","commit_id":"36484f9fdc1412708354cad15b376e18abfa0ee4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"20d1f1453f34ac0c0bc3dee358c05f0d12652813","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        prop_diff \u003d {\u0027TemplateURL\u0027: \u0027https://server.test/new.template\u0027}"},{"line_number":200,"context_line":"        updater \u003d rsrc.handle_update(new_res, {}, prop_diff)"},{"line_number":201,"context_line":"        updater.run_to_completion()"},{"line_number":202,"context_line":"        self.assertIs(rsrc.check_update_complete(updater), True)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        # Expect the physical resource name staying the same after update,"},{"line_number":205,"context_line":"        # so that the nested was actually updated instead of replaced."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Wvw%3D","line":202,"in_reply_to":"AAAATn%2F9Ydw%3D","updated":"2013-12-12 10:26:14.000000000","message":"Angus,\nI was going from an assumption that previous authors were aware of `assertTrue` existence :) , and thus without digging into the code being tested I presumed that the author was interested in actually testing for True/False being returned, not something that evaluates to True/False (1 \u003d\u003d True \u003d\u003e True, 1 is True \u003d\u003e False). So far, such  stricter tests do pass.","commit_id":"36484f9fdc1412708354cad15b376e18abfa0ee4"}],"heat/tests/test_neutron_firewall.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"294321271b50e37d4ac6c09dd711f8c09954e98e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                          \u0027firewall_policy_id\u0027: \u0027policy-id\u0027}})"},{"line_number":190,"context_line":"        self.m.ReplayAll()"},{"line_number":191,"context_line":"        scheduler.TaskRunner(rsrc.create)()"},{"line_number":192,"context_line":"        self.assertIs(rsrc.FnGetAtt(\u0027admin_state_up\u0027), True)"},{"line_number":193,"context_line":"        self.assertEqual(\u0027policy-id\u0027, rsrc.FnGetAtt(\u0027firewall_policy_id\u0027))"},{"line_number":194,"context_line":"        self.m.VerifyAll()"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9CD8%3D","line":192,"updated":"2013-12-17 13:55:16.000000000","message":"You\u0027re re-inverting the assertions here, True should be the first argument. It needs to be fixed in several places.","commit_id":"14fd5e15d73f4c41f3ecd7e8c8346d02a156d64c"}]}
