)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"61cc1539532b738774a834b00f82ed76708c0376","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-12 10:34:08 +1100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Impove autoscaling error message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we can\u0027t find the autoscaling group name produce a more"},{"line_number":10,"context_line":"meaningful error message."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9P24%3D","line":8,"updated":"2013-12-13 15:03:34.000000000","message":"Typo here.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"2e8371c84442684d2e59f9e36c988ca353f179bd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-12 10:34:08 +1100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Impove autoscaling error message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we can\u0027t find the autoscaling group name produce a more"},{"line_number":10,"context_line":"meaningful error message."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9K8w%3D","line":8,"in_reply_to":"AAAATn%2F9P24%3D","updated":"2013-12-16 00:41:30.000000000","message":"well caught, I\u0027ll sort this out now.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"}],"heat/tests/test_autoscaling.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"61cc1539532b738774a834b00f82ed76708c0376","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  \"AWSTemplateFormatVersion\" : \"2010-09-09\","},{"line_number":106,"context_line":"  \"Parameters\" : {"},{"line_number":107,"context_line":"  \"ImageId\": {\"Type\": \"String\"},"},{"line_number":108,"context_line":"  \"KeyName\": {\"Type\": \"String\"}"},{"line_number":109,"context_line":"  },"},{"line_number":110,"context_line":"  \"Resources\" : {"},{"line_number":111,"context_line":"    \"WebServerScaleUpPolicy\" : {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Pw0%3D","line":108,"updated":"2013-12-13 15:03:34.000000000","message":"Those sounds useless.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"2e8371c84442684d2e59f9e36c988ca353f179bd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  \"AWSTemplateFormatVersion\" : \"2010-09-09\","},{"line_number":106,"context_line":"  \"Parameters\" : {"},{"line_number":107,"context_line":"  \"ImageId\": {\"Type\": \"String\"},"},{"line_number":108,"context_line":"  \"KeyName\": {\"Type\": \"String\"}"},{"line_number":109,"context_line":"  },"},{"line_number":110,"context_line":"  \"Resources\" : {"},{"line_number":111,"context_line":"    \"WebServerScaleUpPolicy\" : {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9K80%3D","line":108,"in_reply_to":"AAAATn%2F9Pw0%3D","updated":"2013-12-16 00:41:30.000000000","message":"totally, but it\u0027s to just reuse the rest of the test setup code in this test. at the moment stack_create passes in ImageId and KeyName. These are here purely so I don\u0027t have to\nadd heaps of code for my one little test.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"503c99ab02d199abb2f51cecc3fc1ead90e68fef","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"        self.assertNotEqual(None, alarm_url)"},{"line_number":1077,"context_line":"        ex \u003d self.assertRaises(exception.ResourceFailure, up_policy.signal)"},{"line_number":1078,"context_line":"        self.assertIn(\u0027Alarm WebServerScaleUpPolicy could \u0027"},{"line_number":1079,"context_line":"                      \u0027not find scaling group\u0027, str(ex))"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"        self.m.VerifyAll()"},{"line_number":1082,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9YHQ%3D","line":1079,"updated":"2013-12-12 04:02:17.000000000","message":"I think this assert will increase the maintenance of the test without adding much value. In other words, if the text of the exception changes this test will fail, and the thing that this test should ensure is that the exception is thrown when the AutoScalingGroup is not found.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"04771716e3d919c2c12499753faa1a084401729e","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"        self.assertNotEqual(None, alarm_url)"},{"line_number":1077,"context_line":"        ex \u003d self.assertRaises(exception.ResourceFailure, up_policy.signal)"},{"line_number":1078,"context_line":"        self.assertIn(\u0027Alarm WebServerScaleUpPolicy could \u0027"},{"line_number":1079,"context_line":"                      \u0027not find scaling group\u0027, str(ex))"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"        self.m.VerifyAll()"},{"line_number":1082,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9UrY%3D","line":1079,"in_reply_to":"AAAATn%2F9YHQ%3D","updated":"2013-12-12 17:01:14.000000000","message":"Probably, but IMO, it becomes an issue when the code path under test could possibly throw the same exception under different circumstances. That\u0027s probably not the case here, but if the message does change, this test fails and you fix it. NBD, IMO.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"61cc1539532b738774a834b00f82ed76708c0376","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"        self.assertNotEqual(None, alarm_url)"},{"line_number":1077,"context_line":"        ex \u003d self.assertRaises(exception.ResourceFailure, up_policy.signal)"},{"line_number":1078,"context_line":"        self.assertIn(\u0027Alarm WebServerScaleUpPolicy could \u0027"},{"line_number":1079,"context_line":"                      \u0027not find scaling group\u0027, str(ex))"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"        self.m.VerifyAll()"},{"line_number":1082,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9PwQ%3D","line":1079,"in_reply_to":"AAAATn%2F9YHQ%3D","updated":"2013-12-13 15:03:34.000000000","message":"We need to make sure that particular exception is raised, not a generic ResourceFailure, and unfortunately checking the text is the only way now.\n\nAlso to me it\u0027s nice that a test break if you change something, even an exception message.","commit_id":"0c7df35aacb7fc6a0577d076fc2e69e792dc3a8b"}]}