)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0da111856a00db9cc41276aa780032d0bb3eee7c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds a new resource to support import of glance web-download."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"TODO:"},{"line_number":12,"context_line":" * Graceful failure when web-download is not present"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iae66aa82d6b90738e4f32ee254b9f0c8275a8c87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_cbe64749","line":12,"updated":"2018-12-19 09:28:46.000000000","message":"We decided in the meeting that this can probably be added later. Users want the feature now; on clouds where it is not enabled they\u0027ll probably fail fairly early anyway.\n\nhttp://eavesdrop.openstack.org/meetings/heat/2018/heat.2018-12-19-08.01.log.html#l-152","commit_id":"8d68b759d5f67d1886d537eeff423d19d6690d3c"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0da111856a00db9cc41276aa780032d0bb3eee7c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"TODO:"},{"line_number":12,"context_line":" * Graceful failure when web-download is not present"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iae66aa82d6b90738e4f32ee254b9f0c8275a8c87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_abd18b5c","line":14,"updated":"2018-12-19 09:28:46.000000000","message":"Storyboard link would be a bonus.","commit_id":"8d68b759d5f67d1886d537eeff423d19d6690d3c"}],"heat/engine/resources/openstack/glance/image.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0074ad1751f8b962e013af69587f5f455f17ff4f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        version\u003d\u00278.0.0\u0027,"},{"line_number":32,"context_line":"        message\u003d_(\u0027Creating a Glance Image based on an existing URL location \u0027"},{"line_number":33,"context_line":"                  \u0027requires the Glance v1 API, which is deprecated.\u0027),"},{"line_number":34,"context_line":"        previous_status\u003dsupport.SupportStatus(version\u003d\u00272014.2\u0027)"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    PROPERTIES \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e62b0ae6","line":34,"updated":"2018-11-26 18:30:12.000000000","message":"Can we set substitute_class so that users can upgrade seamlessly? (Does that even make sense?)","commit_id":"b5548eb24ccf16cb5ccf7175833688ea38e616ed"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8b9bb77eed44757dd35173cdd687755f5dd49bc7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        version\u003d\u00278.0.0\u0027,"},{"line_number":32,"context_line":"        message\u003d_(\u0027Creating a Glance Image based on an existing URL location \u0027"},{"line_number":33,"context_line":"                  \u0027requires the Glance v1 API, which is deprecated.\u0027),"},{"line_number":34,"context_line":"        previous_status\u003dsupport.SupportStatus(version\u003d\u00272014.2\u0027)"},{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    PROPERTIES \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_12af52e1","line":34,"in_reply_to":"3f79a3b5_e62b0ae6","updated":"2018-11-27 09:35:07.000000000","message":"Done","commit_id":"b5548eb24ccf16cb5ccf7175833688ea38e616ed"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0074ad1751f8b962e013af69587f5f455f17ff4f","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            properties.Schema.LIST,"},{"line_number":376,"context_line":"            _(\u0027List of image tags.\u0027),"},{"line_number":377,"context_line":"            update_allowed\u003dTrue,"},{"line_number":378,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u00277.0.0\u0027)"},{"line_number":379,"context_line":"        ),"},{"line_number":380,"context_line":"        ARCHITECTURE: properties.Schema("},{"line_number":381,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_06e166ce","line":378,"updated":"2018-11-26 18:30:12.000000000","message":"These don\u0027t make sense for a new resource type.","commit_id":"b5548eb24ccf16cb5ccf7175833688ea38e616ed"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"8b9bb77eed44757dd35173cdd687755f5dd49bc7","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            properties.Schema.LIST,"},{"line_number":376,"context_line":"            _(\u0027List of image tags.\u0027),"},{"line_number":377,"context_line":"            update_allowed\u003dTrue,"},{"line_number":378,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u00277.0.0\u0027)"},{"line_number":379,"context_line":"        ),"},{"line_number":380,"context_line":"        ARCHITECTURE: properties.Schema("},{"line_number":381,"context_line":"            properties.Schema.STRING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_32aa8ecf","line":378,"in_reply_to":"3f79a3b5_06e166ce","updated":"2018-11-27 09:35:07.000000000","message":"Done","commit_id":"b5548eb24ccf16cb5ccf7175833688ea38e616ed"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0da111856a00db9cc41276aa780032d0bb3eee7c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class GlanceImageDownload(resource.Resource):"},{"line_number":23,"context_line":"    \"\"\"A resource managing images in Glance using the C{web-download} import."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    This provides image support for recent Glance installation."},{"line_number":26,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_30c4060d","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":69},"updated":"2018-12-19 09:28:46.000000000","message":"This syntax doesn\u0027t seem to do anything special:\nhttp://logs.openstack.org/15/617915/3/check/openstack-tox-docs/c06125c/html/template_guide/openstack.html#OS::Glance::ImageDownload\n\nDoes it mean something?","commit_id":"8d68b759d5f67d1886d537eeff423d19d6690d3c"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0da111856a00db9cc41276aa780032d0bb3eee7c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    This provides image support for recent Glance installation."},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002714.0.0\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    PROPERTIES \u003d ("},{"line_number":31,"context_line":"        NAME, IMAGE_ID, MIN_DISK, MIN_RAM, PROTECTED,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_cb63a7df","line":28,"range":{"start_line":28,"start_character":51,"end_line":28,"end_character":58},"updated":"2018-12-19 09:28:46.000000000","message":"This seems a little pessimistic given that Stein is 12.0.0 ;)","commit_id":"8d68b759d5f67d1886d537eeff423d19d6690d3c"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0da111856a00db9cc41276aa780032d0bb3eee7c","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        message\u003d_(\u0027Creating a Glance Image based on an existing URL location \u0027"},{"line_number":254,"context_line":"                  \u0027requires the Glance v1 API, which is deprecated.\u0027),"},{"line_number":255,"context_line":"        previous_status\u003dsupport.SupportStatus(version\u003d\u00272014.2\u0027),"},{"line_number":256,"context_line":"        substitute_class\u003dGlanceImageDownload"},{"line_number":257,"context_line":"    )"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    PROPERTIES \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eb01c303","line":256,"updated":"2018-12-19 09:28:46.000000000","message":"Based on discussion in the meeting:\n\n* this will break if the is_public or os_distro properties were included in the resource definition.\n* translations could handle that, but according to Rico that means we\u0027d have to add those properties to the new resource type (presumably deprecated).\n* at that point you might as well just reuse the existing resource type.\n* this thing has been deprecated for 4 releases and the Glance V1 API is long gone; it\u0027s probably not worth messing up the new API for a theoretical possibility of upgrades.\n\nhttp://eavesdrop.openstack.org/meetings/heat/2018/heat.2018-12-19-08.01.log.html#l-176","commit_id":"8d68b759d5f67d1886d537eeff423d19d6690d3c"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"0da111856a00db9cc41276aa780032d0bb3eee7c","unresolved":false,"context_lines":[{"line_number":514,"context_line":"def resource_mapping():"},{"line_number":515,"context_line":"    return {"},{"line_number":516,"context_line":"        \u0027OS::Glance::Image\u0027: GlanceImage,"},{"line_number":517,"context_line":"        \u0027OS::Glance::ImageDownload\u0027: GlanceImageDownload"},{"line_number":518,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_d0dd92da","line":517,"range":{"start_line":517,"start_character":21,"end_line":517,"end_character":34},"updated":"2018-12-19 09:28:46.000000000","message":"I guess \u0027download\u0027 can be a noun, but it can also be a verb, which makes me uncomfortable when naming a resource type.\n\nHow would we feel about \"WebImage\"? Or \"DownloadedImage\"?","commit_id":"8d68b759d5f67d1886d537eeff423d19d6690d3c"}]}