)]}'
{"heat/engine/resources/server.py":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"120176b7d979459729792ba35b6614180465d437","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        if metadata is not None:"},{"line_number":461,"context_line":"            if len(metadata) \u003e limits[\u0027maxServerMeta\u0027]:"},{"line_number":462,"context_line":"                msg \u003d _(\u0027Instance metadata must not contain greater than %s \u0027"},{"line_number":463,"context_line":"                        \u0027entries\u0027) % limits[\u0027maxServerMeta\u0027]"},{"line_number":464,"context_line":"                raise exception.StackValidationFailed(message\u003dmsg)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def handle_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9TX0%3D","line":463,"updated":"2013-12-12 21:03:58.000000000","message":"Hi Jason, patch looks great just one thing here. As an end user this msg doesn\u0027t tell me why the metadata entries can not be greater than some number. If the msg can also tell that it can not contain greater than %s because it is the max limit allowed by provider...I think that will be more useful message. What do you think? If it doesn\u0027t make sense, please let me know I will change to +1.","commit_id":"e69ed8ef9a135e52abeb1952ef389df60e0edc52"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"92d799610b654e2a2cfee191881567310672edc6","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        if metadata is not None:"},{"line_number":461,"context_line":"            if len(metadata) \u003e limits[\u0027maxServerMeta\u0027]:"},{"line_number":462,"context_line":"                msg \u003d _(\u0027Instance metadata must not contain greater than %s \u0027"},{"line_number":463,"context_line":"                        \u0027entries\u0027) % limits[\u0027maxServerMeta\u0027]"},{"line_number":464,"context_line":"                raise exception.StackValidationFailed(message\u003dmsg)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def handle_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9TU8%3D","line":463,"in_reply_to":"AAAATn%2F9TX0%3D","updated":"2013-12-12 21:11:49.000000000","message":"Good point.  I will add a description of where the limit came from.","commit_id":"e69ed8ef9a135e52abeb1952ef389df60e0edc52"},{"author":{"_account_id":7256,"name":"Randall Burt","email":"randall.burt@rackspace.com","username":"randall-burt"},"change_message_id":"c142df96439749b968edb40302047e8c2ee8a79e","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # verify that the number of metadata entries is not greater"},{"line_number":456,"context_line":"        # than the maximum number allowed in the provider\u0027s absolute"},{"line_number":457,"context_line":"        # limits"},{"line_number":458,"context_line":"        limits \u003d nova_utils.absolute_limits(self.nova())"},{"line_number":459,"context_line":"        metadata \u003d self.properties.get(\u0027metadata\u0027)"},{"line_number":460,"context_line":"        if metadata is not None:"},{"line_number":461,"context_line":"            if len(metadata) \u003e limits[\u0027maxServerMeta\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9SfI%3D","line":458,"updated":"2013-12-13 17:10:29.000000000","message":"A nit, but I wouldn\u0027t make this call until we know we need it (after line 460), but nbd.","commit_id":"f97701bc648ca9c2ea18d886391456d4d64f1255"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"3a9d9a8a97b96b958de2b5466e054074880ef2e5","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        # verify that the number of metadata entries is not greater"},{"line_number":456,"context_line":"        # than the maximum number allowed in the provider\u0027s absolute"},{"line_number":457,"context_line":"        # limits"},{"line_number":458,"context_line":"        limits \u003d nova_utils.absolute_limits(self.nova())"},{"line_number":459,"context_line":"        metadata \u003d self.properties.get(\u0027metadata\u0027)"},{"line_number":460,"context_line":"        if metadata is not None:"},{"line_number":461,"context_line":"            if len(metadata) \u003e limits[\u0027maxServerMeta\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9O%2BQ%3D","line":458,"in_reply_to":"AAAATn%2F9SfI%3D","updated":"2013-12-13 17:37:26.000000000","message":"Done","commit_id":"f97701bc648ca9c2ea18d886391456d4d64f1255"},{"author":{"_account_id":7225,"name":"Serg Melikyan","email":"smelikyan@mirantis.com","username":"smelikyan"},"change_message_id":"f4dcd61069fd2bcb60fd09f28c76813fbe023b12","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            \u0027Type\u0027: \u0027Map\u0027,"},{"line_number":146,"context_line":"            \u0027UpdateAllowed\u0027: True,"},{"line_number":147,"context_line":"            \u0027Description\u0027: _(\u0027Arbitrary key/value metadata to store for this \u0027"},{"line_number":148,"context_line":"                             \u0027server.  Both keys and values must be 255 \u0027"},{"line_number":149,"context_line":"                             \u0027characters or less.\u0027)},"},{"line_number":150,"context_line":"        \u0027user_data_format\u0027: {"},{"line_number":151,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9Dcg%3D","line":148,"updated":"2013-12-17 08:57:41.000000000","message":"Redundant space","commit_id":"1c5db54b043ef3aaf6c31be2be35caa5de4a7159"}]}