)]}'
{"doc/source/template_guide/hot_spec.rst":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"bf2c0bd22edca0856edccd5866fdd2f58d4fb96e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"  parameters:"},{"line_number":193,"context_line":"    user_name:"},{"line_number":194,"context_line":"      type: string"},{"line_number":195,"context_line":"      label: Username"},{"line_number":196,"context_line":"      description: User name to be configured for the application"},{"line_number":197,"context_line":"    port_number:"},{"line_number":198,"context_line":"      type: number"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAATn%2F8uaQ%3D","line":195,"updated":"2013-12-21 03:00:45.000000000","message":"Unless I am wrong, this needs to be consistent with the way other label\u0027s are declared i.e. use \"User Name\" instead of \"Username\"","commit_id":"9aacfc7aeb403d1f50f9ec623082f47511143a93"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"bf2c0bd22edca0856edccd5866fdd2f58d4fb96e","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  parameters:"},{"line_number":246,"context_line":"    user_name:"},{"line_number":247,"context_line":"      type: string"},{"line_number":248,"context_line":"      label: Username"},{"line_number":249,"context_line":"      description: User name to be configured for the application"},{"line_number":250,"context_line":"      constraints:"},{"line_number":251,"context_line":"        - length: { min: 6, max: 8 }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAATn%2F8uaM%3D","line":248,"updated":"2013-12-21 03:00:45.000000000","message":"Same as above - use \"User Name\" instead of \"Username\"","commit_id":"9aacfc7aeb403d1f50f9ec623082f47511143a93"},{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"bf2c0bd22edca0856edccd5866fdd2f58d4fb96e","unresolved":false,"context_lines":[{"line_number":343,"context_line":"  parameters:"},{"line_number":344,"context_line":"    user_name:"},{"line_number":345,"context_line":"      type: string"},{"line_number":346,"context_line":"      label: Username"},{"line_number":347,"context_line":"      description: User name to be configured for the application"},{"line_number":348,"context_line":"      constraints:"},{"line_number":349,"context_line":"        - allowed_pattern: \"[A-Z]+[a-zA-Z0-9]*\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAATn%2F8uaI%3D","line":346,"updated":"2013-12-21 03:00:45.000000000","message":"Same as above.","commit_id":"9aacfc7aeb403d1f50f9ec623082f47511143a93"}],"heat/engine/hot.py":[{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"13370668ddd6a3b0d3aa22a6751102db1e2142ac","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LABEL \u003d \u0027Label\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SECTIONS \u003d (VERSION, DESCRIPTION, PARAMETERS,"},{"line_number":27,"context_line":"            RESOURCES, OUTPUTS, UNDEFINED) \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Ezs%3D","line":24,"updated":"2013-12-17 02:02:37.000000000","message":"I think here `Label\u0027 should be `label\u0027","commit_id":"2d8db009e7738ca7a2ec21a4542847c5c9738cad"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"31661397872e44433396bedbb88047947f6a2b60","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LABEL \u003d \u0027Label\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SECTIONS \u003d (VERSION, DESCRIPTION, PARAMETERS,"},{"line_number":27,"context_line":"            RESOURCES, OUTPUTS, UNDEFINED) \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9EjQ%3D","line":24,"in_reply_to":"AAAATn%2F9Ezs%3D","updated":"2013-12-17 03:18:24.000000000","message":"This is following the definition of label in parameters.py which follows a convention that capitalizes the first letter. \"label\" will not be found in the schema dictionary.","commit_id":"2d8db009e7738ca7a2ec21a4542847c5c9738cad"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"13370668ddd6a3b0d3aa22a6751102db1e2142ac","unresolved":false,"context_lines":[{"line_number":269,"context_line":"class HOTParamSchema(parameters.ParamSchema):"},{"line_number":270,"context_line":"    \"\"\"HOT parameter schema.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def label(self, name):"},{"line_number":273,"context_line":"        label \u003d self.get(LABEL)"},{"line_number":274,"context_line":"        if label:"},{"line_number":275,"context_line":"            return label"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9EzQ%3D","line":272,"updated":"2013-12-17 02:02:37.000000000","message":"And no need to define one function label here.","commit_id":"2d8db009e7738ca7a2ec21a4542847c5c9738cad"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"c418ae92b6120f311055b87bbbb824c772e5e121","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LABEL \u003d \u0027Label\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SECTIONS \u003d (VERSION, DESCRIPTION, PARAMETER_GROUPS, PARAMETERS,"},{"line_number":27,"context_line":"            RESOURCES, OUTPUTS, UNDEFINED) \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8m4w%3D","line":24,"updated":"2013-12-24 11:55:25.000000000","message":"Why are you using here \u0027Label\u0027 instead \u0027label\u0027?\n\n\nAFAIK in hot standard all parameters don\u0027t started with upper case. \nAlso it has some disagreements with specification, where you have used low case \u0027label\u0027.","commit_id":"1d545b7768350c216174af9c8f7ebda9baf53dc4"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"e22363bed8f1a66966b3136dc6138eaa91817f9e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LABEL \u003d \u0027Label\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"SECTIONS \u003d (VERSION, DESCRIPTION, PARAMETER_GROUPS, PARAMETERS,"},{"line_number":27,"context_line":"            RESOURCES, OUTPUTS, UNDEFINED) \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F8mNQ%3D","line":24,"in_reply_to":"AAAATn%2F8m4w%3D","updated":"2013-12-24 15:32:41.000000000","message":"Please refer to line 30 of parameters.py where this is being defined.","commit_id":"1d545b7768350c216174af9c8f7ebda9baf53dc4"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"ffb2ab8e024ef6abe8b0538a56ba3f3a8251439c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    \"\"\"HOT parameter schema.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def label(self, name):"},{"line_number":273,"context_line":"        label \u003d self.get(LABEL)"},{"line_number":274,"context_line":"        if label:"},{"line_number":275,"context_line":"            return label"},{"line_number":276,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F66I%3D","line":273,"updated":"2014-01-06 19:54:55.000000000","message":"Why not use parameters.LABEL instead of redefining LABEL above to what we can only hope is the same value?\n\nBTW this whole function could (and IMO should) be written as:\n\n  return self.get(parameters.LABEL) or name","commit_id":"1d545b7768350c216174af9c8f7ebda9baf53dc4"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"65ab8a8fed358557043b4c332c74dec17f9ea34f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"    \"\"\"HOT parameter schema.\"\"\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def label(self, name):"},{"line_number":273,"context_line":"        label \u003d self.get(LABEL)"},{"line_number":274,"context_line":"        if label:"},{"line_number":275,"context_line":"            return label"},{"line_number":276,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F6rY%3D","line":273,"in_reply_to":"AAAAUH%2F%2F66I%3D","updated":"2014-01-06 20:18:00.000000000","message":"Done","commit_id":"1d545b7768350c216174af9c8f7ebda9baf53dc4"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"0b3f42c4674de5c2a7e09c2b82134baadbf55f7c","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                   hidden\u003dschema_dict.get(HOTParamSchema.HIDDEN, False))"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def label(self):"},{"line_number":304,"context_line":"        return self.get(parameters.LABEL) or self._name"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BMJc%3D","line":304,"updated":"2014-01-29 09:04:53.000000000","message":"Hm, maybe I am missing something, but I think this will not work. parameters.LABEL is defined as \u0027Label\u0027 (i.e. uppercase L) whereas the HOT spec says the key is lowercase \u0027label\u0027.\n\nI think it would be good to have a few test cases that really check for labels other than name (when no label is given).","commit_id":"295c81039dc8b802c3613a6636ae18755edf0e9b"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"3353424c82f82ed6f89bbf89edcd1b3a8c3bd540","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                   hidden\u003dschema_dict.get(HOTParamSchema.HIDDEN, False))"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def label(self):"},{"line_number":304,"context_line":"        return self.get(parameters.LABEL) or self._name"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BJ1c%3D","line":304,"in_reply_to":"AAAAUH%2F%2BKSY%3D","updated":"2014-01-29 16:43:03.000000000","message":"Ok. Besides the tests, one option to make sure the right spelling of LABEL is used could be to (1) add LABEL to the KEYS tuple of the parameters.Schema class as \u0027Label\u0027, (2) add/override LABEL in the HOTParamSchema class with \u0027label\u0027, and (3) change the return statement to\n\n return self.get(self.LABEL, self._name)\n\nYou could even do it this way in the super class then and not override the method here at all.  ... or maybe Zane also has a better idea when he reviews.","commit_id":"295c81039dc8b802c3613a6636ae18755edf0e9b"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"ea09de2f830294253aa4af6e5e74172be8aed8dd","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                   hidden\u003dschema_dict.get(HOTParamSchema.HIDDEN, False))"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def label(self):"},{"line_number":304,"context_line":"        return self.get(parameters.LABEL) or self._name"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUH%2F%2BKSY%3D","line":304,"in_reply_to":"AAAAUH%2F%2BMJc%3D","updated":"2014-01-29 15:42:30.000000000","message":"Yes, I meant to add these tests and I forgot. Switching this patch to WIP until I get those added.","commit_id":"295c81039dc8b802c3613a6636ae18755edf0e9b"}],"heat/engine/parameters.py":[{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"13370668ddd6a3b0d3aa22a6751102db1e2142ac","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self[LABEL] \u003d self.label(name)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def label(self, name):"},{"line_number":52,"context_line":"        return name"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def do_check(self, name, value, keys):"},{"line_number":55,"context_line":"        for k in keys:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Ey4%3D","line":52,"updated":"2013-12-17 02:02:37.000000000","message":"no need to define label and pass name","commit_id":"2d8db009e7738ca7a2ec21a4542847c5c9738cad"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"ffb2ab8e024ef6abe8b0538a56ba3f3a8251439c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, schema, name\u003dNone):"},{"line_number":48,"context_line":"        super(ParamSchema, self).__init__(schema)"},{"line_number":49,"context_line":"        self[LABEL] \u003d self.label(name)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def label(self, name):"},{"line_number":52,"context_line":"        return name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F6y4%3D","line":49,"updated":"2014-01-06 19:54:55.000000000","message":"This is kind of the opposite of what I was suggesting. This should just store self._name \u003d name and then we\u0027d have:\n\n  def label(self):\n      return self._name\n\nand for HOT:\n\n  def label(self):\n      return self.get(parameters.LABEL) or self._name\n\nThen when we want the label we can get it by calling label() (without parameters!) instead of going through the dictionary, which is the thing we need to stop doing.","commit_id":"1d545b7768350c216174af9c8f7ebda9baf53dc4"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"65ab8a8fed358557043b4c332c74dec17f9ea34f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def __init__(self, schema, name\u003dNone):"},{"line_number":48,"context_line":"        super(ParamSchema, self).__init__(schema)"},{"line_number":49,"context_line":"        self[LABEL] \u003d self.label(name)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def label(self, name):"},{"line_number":52,"context_line":"        return name"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F6rU%3D","line":49,"in_reply_to":"AAAAUH%2F%2F6y4%3D","updated":"2014-01-06 20:18:00.000000000","message":"Done","commit_id":"1d545b7768350c216174af9c8f7ebda9baf53dc4"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b3a3473fe1c743f55eb4c7a7878ded37486f8929","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def __init__(self, schema, name\u003dNone):"},{"line_number":48,"context_line":"        super(ParamSchema, self).__init__(schema)"},{"line_number":49,"context_line":"        self._name \u003d name"},{"line_number":50,"context_line":"        self[LABEL] \u003d self.label()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def label(self):"},{"line_number":53,"context_line":"        return self._name"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2F6q8%3D","line":50,"updated":"2014-01-06 20:25:53.000000000","message":"I meant to ditch this line. There should be no legitimate reason to access the label through a dictionary key instead of an API.","commit_id":"29ca8afc6aed61ee4e333bb7e623aa4ab1047e89"}],"heat/engine/service.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"fe0402ea6383960d7fb9a1a39bfb71a815e36786","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            return d"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        is_real_param \u003d lambda p: p.name not in parameters.PSEUDO_PARAMETERS"},{"line_number":478,"context_line":"        params \u003d tmpl_params.map(lambda p: format_validate_parameter(p),"},{"line_number":479,"context_line":"                                 is_real_param)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        result \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2F6E0%3D","line":478,"updated":"2014-01-06 23:39:29.000000000","message":"Uh, this line was fine how it was ;)","commit_id":"e50fb58bd6c48fc9ed7db054ebaed094baba5b98"}],"heat/engine/template.py":[{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"13370668ddd6a3b0d3aa22a6751102db1e2142ac","unresolved":false,"context_lines":[{"line_number":474,"context_line":"    def param_schemata(self):"},{"line_number":475,"context_line":"        parameters \u003d self[PARAMETERS].iteritems()"},{"line_number":476,"context_line":"        return dict((name, ParamSchema(schema, name\u003dname))"},{"line_number":477,"context_line":"                    for name, schema in parameters)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"def _resolve(match, handle, snippet, transform\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9EyY%3D","line":477,"updated":"2013-12-17 02:02:37.000000000","message":"so no change here.","commit_id":"2d8db009e7738ca7a2ec21a4542847c5c9738cad"}],"heat/rpc/api.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"fe0402ea6383960d7fb9a1a39bfb71a815e36786","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \u0027timeout_mins\u0027, \u0027disable_rollback\u0027"},{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"PARAM_LABEL \u003d \u0027label\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"STACK_KEYS \u003d ("},{"line_number":26,"context_line":"    STACK_NAME, STACK_ID,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2F6Eg%3D","line":23,"updated":"2014-01-06 23:39:29.000000000","message":"This belongs in the VALIDATE_PARAM_KEYS tuple at the very end of this file.","commit_id":"e50fb58bd6c48fc9ed7db054ebaed094baba5b98"}]}
