)]}'
{"heat/engine/resources/network_interface.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"a228c1c75aaa2a557cd7183d56a3e1c7274b8dd9","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if self.properties[\u0027GroupSet\u0027]:"},{"line_number":85,"context_line":"            sgs \u003d neutron.NeutronResource.get_secgroup_uuids("},{"line_number":86,"context_line":"                self.properties.get(\u0027GroupSet\u0027), self.neutron())"},{"line_number":87,"context_line":"            props[\u0027security_groups\u0027] \u003d sgs"},{"line_number":88,"context_line":"        port \u003d client.create_port({\u0027port\u0027: props})[\u0027port\u0027]"},{"line_number":89,"context_line":"        self.resource_id_set(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89jI%3D","line":86,"updated":"2013-12-18 11:16:32.000000000","message":"I don\u0027t think this is valid - GroupSet is an optional property, and if the user doesn\u0027t pass it, we\u0027ll now use None instead of an empty list.\n\nSee https://bugs.launchpad.net/heat/+bug/1255903","commit_id":"2d51d799495a4e859acae6474748d2e86e2c70e7"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c1633f419176b600f8c579a1db8972b0a2b049a7","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        if self.properties[\u0027GroupSet\u0027]:"},{"line_number":85,"context_line":"            sgs \u003d neutron.NeutronResource.get_secgroup_uuids("},{"line_number":86,"context_line":"                self.properties.get(\u0027GroupSet\u0027), self.neutron())"},{"line_number":87,"context_line":"            props[\u0027security_groups\u0027] \u003d sgs"},{"line_number":88,"context_line":"        port \u003d client.create_port({\u0027port\u0027: props})[\u0027port\u0027]"},{"line_number":89,"context_line":"        self.resource_id_set(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F88AQ%3D","line":86,"in_reply_to":"AAAATn%2F89jI%3D","updated":"2013-12-18 15:52:52.000000000","message":"This doesn\u0027t change any behaviour because properties.get() is broken (because __getitem__() never raises KeyError for any valid property, even if it is not supplied).\n\nWhat you really want to do though is to set the default value for the GroupSet to [] in the schema.","commit_id":"2d51d799495a4e859acae6474748d2e86e2c70e7"}],"heat/engine/resources/subnet.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"ae4237ca59a6715ce20a6a909a8dfc975fb8ac25","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":34,"context_line":"            \u0027Description\u0027: _(\u0027Availablity zone in which you want the \u0027"},{"line_number":35,"context_line":"                             \u0027subnet.\u0027),"},{"line_number":36,"context_line":"            \u0027Default\u0027: \"\"},"},{"line_number":37,"context_line":"        \u0027CidrBlock\u0027: {"},{"line_number":38,"context_line":"            \u0027Type\u0027: \u0027String\u0027,"},{"line_number":39,"context_line":"            \u0027Required\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F87S0%3D","line":36,"updated":"2013-12-18 17:46:50.000000000","message":"In this case I think the intent of the author was actually wrong, and the implementation was (accidentally) right. If no AvailabilityZone is provided, we want to pass None to Neutron, so we shouldn\u0027t set a default here.","commit_id":"62b1905926def713f1382006e49077dd21c63d3e"}]}