)]}'
{"heat/tests/db/test_migrations.py":[{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"92cdc5aa36ba6ce41dcc2be4c3aafc4594961001","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.assertEqual(sorted(members), sorted(index_columns))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _load_mysql_dump_file(self, engine, file_name):"},{"line_number":117,"context_line":"        for key, eng in self.engines.items():"},{"line_number":118,"context_line":"            if eng is engine:"},{"line_number":119,"context_line":"                conn_string \u003d self.test_databases[key]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2Fxwc%3D","line":116,"updated":"2014-01-01 07:03:33.000000000","message":"This function looks quite common, may be we can merge to oslo after it\u0027s stable enough.","commit_id":"5dce3c8b605d1928ff347e22812e06584e739482"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"bd99c2c54a32673ec74838ebd99f11d71b1c87a4","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        self.assertEqual(sorted(members), sorted(index_columns))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _load_mysql_dump_file(self, engine, file_name):"},{"line_number":117,"context_line":"        for key, eng in self.engines.items():"},{"line_number":118,"context_line":"            if eng is engine:"},{"line_number":119,"context_line":"                conn_string \u003d self.test_databases[key]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FxJE%3D","line":116,"in_reply_to":"AAAAT3%2F%2Fxwc%3D","updated":"2014-01-03 04:40:15.000000000","message":"maybe, lets see how useful it is first.","commit_id":"5dce3c8b605d1928ff347e22812e06584e739482"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"92cdc5aa36ba6ce41dcc2be4c3aafc4594961001","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                if conn_string.startswith(\u0027mysql\u0027):"},{"line_number":122,"context_line":"                    break"},{"line_number":123,"context_line":"                else:"},{"line_number":124,"context_line":"                    return"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        (user, password, database, host) \u003d \\"},{"line_number":127,"context_line":"            test_migrations.get_db_connection_info(conn_pieces)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2Fxwg%3D","line":124,"updated":"2014-01-01 07:03:33.000000000","message":"Should we log some warning or error message, if conn_string is invalid?","commit_id":"5dce3c8b605d1928ff347e22812e06584e739482"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"9cd791b26475588972ebe436f8da386a83e22675","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                if conn_string.startswith(\u0027mysql\u0027):"},{"line_number":122,"context_line":"                    break"},{"line_number":123,"context_line":"                else:"},{"line_number":124,"context_line":"                    return"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        (user, password, database, host) \u003d \\"},{"line_number":127,"context_line":"            test_migrations.get_db_connection_info(conn_pieces)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FspQ%3D","line":124,"in_reply_to":"AAAAT3%2F%2FtOY%3D","updated":"2014-01-03 09:21:59.000000000","message":"it would be a generic test, it doesn\u0027t have to assume what engine it is.\nnot sure why we would want to put the coding load on each test to check for mysql.","commit_id":"5dce3c8b605d1928ff347e22812e06584e739482"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"ca22ed9e74a5c2c9726d3773452fad7d4682f8ed","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                if conn_string.startswith(\u0027mysql\u0027):"},{"line_number":122,"context_line":"                    break"},{"line_number":123,"context_line":"                else:"},{"line_number":124,"context_line":"                    return"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        (user, password, database, host) \u003d \\"},{"line_number":127,"context_line":"            test_migrations.get_db_connection_info(conn_pieces)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FtOY%3D","line":124,"in_reply_to":"AAAAT3%2F%2FxJI%3D","updated":"2014-01-03 05:27:51.000000000","message":"Just curious why sqlite engine will call _load_mysql_dump_file?","commit_id":"5dce3c8b605d1928ff347e22812e06584e739482"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"bd99c2c54a32673ec74838ebd99f11d71b1c87a4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                if conn_string.startswith(\u0027mysql\u0027):"},{"line_number":122,"context_line":"                    break"},{"line_number":123,"context_line":"                else:"},{"line_number":124,"context_line":"                    return"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        (user, password, database, host) \u003d \\"},{"line_number":127,"context_line":"            test_migrations.get_db_connection_info(conn_pieces)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2FxJI%3D","line":124,"in_reply_to":"AAAAT3%2F%2Fxwg%3D","updated":"2014-01-03 04:40:15.000000000","message":"This will be called with each engine. So if you have mysql and sqlite you just want to\nignore the sqlite one.","commit_id":"5dce3c8b605d1928ff347e22812e06584e739482"}]}