)]}'
{"tools/config/check_uptodate.sh":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"03860ede39d36c4b0c0177b241a277aa6b453e8f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":6,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":7,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat"},{"line_number":8,"context_line":"if ! (cd $TEMPDIR; diff -Naur a b)"},{"line_number":9,"context_line":"then"},{"line_number":10,"context_line":"    echo \"E: heat.conf.sample is not up to date, please run tools/config/generate_sample.sh\" 1\u003e\u00262"},{"line_number":11,"context_line":"    exit 42"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAT3%2F%2FzG8%3D","line":8,"updated":"2013-12-31 09:24:23.000000000","message":"i think it would be nice to check that b exists (since genrate_sample.sh doesn\u0027t work on non Linuxes and that would give clue to the user)","commit_id":"3be3391a4b4a939f7ae354e00ec996391de3a0cf"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"9b6da85dcc45643057d9b4a587e49c24700af40c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":6,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":7,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat"},{"line_number":8,"context_line":"if ! (cd $TEMPDIR; diff -Naur a b)"},{"line_number":9,"context_line":"then"},{"line_number":10,"context_line":"    echo \"E: heat.conf.sample is not up to date, please run tools/config/generate_sample.sh\" 1\u003e\u00262"},{"line_number":11,"context_line":"    exit 42"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAT3%2F%2FzGc%3D","line":8,"in_reply_to":"AAAAT3%2F%2FzG8%3D","updated":"2013-12-31 09:34:38.000000000","message":"You mean to check whether $TEMPDIR/b/etc/heat/$CFGFILE exists?\nIf it does not exist, diff will exit with non zero.","commit_id":"3be3391a4b4a939f7ae354e00ec996391de3a0cf"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"d156a92b57da0f88ce72f4d294c2abeee5412313","unresolved":false,"context_lines":[{"line_number":5,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":6,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":7,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat"},{"line_number":8,"context_line":"if ! (cd $TEMPDIR; diff -Naur a b)"},{"line_number":9,"context_line":"then"},{"line_number":10,"context_line":"    echo \"E: heat.conf.sample is not up to date, please run tools/config/generate_sample.sh\" 1\u003e\u00262"},{"line_number":11,"context_line":"    exit 42"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAT3%2F%2FyTs%3D","line":8,"in_reply_to":"AAAAT3%2F%2FzGc%3D","updated":"2013-12-31 16:44:26.000000000","message":"If diff exits with a non-zero exit code for the reason Chmouel pointed out, the error message (\"please run tools/config/generate_sample.sh\") wouldn\u0027t make sense.  The script should check that generate_sample.sh produced a heat.conf.sample file before looking at the contents of the file with diff.","commit_id":"3be3391a4b4a939f7ae354e00ec996391de3a0cf"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"00fe7f3eea00ad546538a220147ca0d516f0c2f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"CFGFILE\u003dheat.conf.sample"},{"line_number":5,"context_line":"GENERATOR\u003dtools/config/generate_sample.sh"},{"line_number":6,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":7,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":8,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat \u0026\u003e /dev/null"},{"line_number":9,"context_line":"test -f \"$TEMPDIR/b/etc/heat/$CFGFILE\" || ("},{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2Fx5M%3D","line":7,"updated":"2014-01-01 05:44:37.000000000","message":"Why don\u0027t we just use \"set -o errexit\", instead of bothering to use the two temporary directories of a and b?","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"9087ee07b89d69e25438234432c21ac6454e7883","unresolved":false,"context_lines":[{"line_number":4,"context_line":"CFGFILE\u003dheat.conf.sample"},{"line_number":5,"context_line":"GENERATOR\u003dtools/config/generate_sample.sh"},{"line_number":6,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":7,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":8,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat \u0026\u003e /dev/null"},{"line_number":9,"context_line":"test -f \"$TEMPDIR/b/etc/heat/$CFGFILE\" || ("},{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2FrfM%3D","line":7,"in_reply_to":"AAAAT3%2F%2Fw2w%3D","updated":"2014-01-03 16:19:10.000000000","message":"Where we need to apply the diff? The previous way already  served the purpose of diffing two files well, imho.\n\nThis also aligns to Angus\u0027s link:\nhttps://github.com/stackforge/solum/commit/8169d794327ad14990b7a9a6e86aa4499db93e63\n\nDon\u0027t get me wrong. I\u0027m OK with the new version, but just can\u0027t get the point of necessity for the two temporary directories.","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"cc7c3f5998beafb9172f666a7eb2fde57e67e192","unresolved":false,"context_lines":[{"line_number":4,"context_line":"CFGFILE\u003dheat.conf.sample"},{"line_number":5,"context_line":"GENERATOR\u003dtools/config/generate_sample.sh"},{"line_number":6,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":7,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":8,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat \u0026\u003e /dev/null"},{"line_number":9,"context_line":"test -f \"$TEMPDIR/b/etc/heat/$CFGFILE\" || ("},{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2FxGo%3D","line":7,"in_reply_to":"AAAAT3%2F%2Fx5M%3D","updated":"2014-01-02 02:09:28.000000000","message":"We need to generate unified style diff patch, so introduce directories a and b.","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"2d0e29bf9012638041341ccb9ee15e0056a9f8c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"CFGFILE\u003dheat.conf.sample"},{"line_number":5,"context_line":"GENERATOR\u003dtools/config/generate_sample.sh"},{"line_number":6,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":7,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":8,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat \u0026\u003e /dev/null"},{"line_number":9,"context_line":"test -f \"$TEMPDIR/b/etc/heat/$CFGFILE\" || ("},{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2Fw2w%3D","line":7,"in_reply_to":"AAAAT3%2F%2FxBM%3D","updated":"2014-01-02 05:35:44.000000000","message":"Since $TEMPDIR is deleted, diff -Naur can provide a unified sytle patch to apply.","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"df91d8a01e155256dc8764fc3e4476b17cb002a7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"CFGFILE\u003dheat.conf.sample"},{"line_number":5,"context_line":"GENERATOR\u003dtools/config/generate_sample.sh"},{"line_number":6,"context_line":"mkdir -p $TEMPDIR/{a,b}/etc/heat"},{"line_number":7,"context_line":"cp etc/heat/$CFGFILE $TEMPDIR/a/etc/heat"},{"line_number":8,"context_line":"tools/config/generate_sample.sh -b ./ -p heat -o $TEMPDIR/b/etc/heat \u0026\u003e /dev/null"},{"line_number":9,"context_line":"test -f \"$TEMPDIR/b/etc/heat/$CFGFILE\" || ("},{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2FxBM%3D","line":7,"in_reply_to":"AAAAT3%2F%2FxGo%3D","updated":"2014-01-02 02:43:36.000000000","message":"JunJie, what\u0027s the problem, if we keep using \"iif ! diff $TEMPDIR/$CFGFILE etc/heat/$CFGFILE\"?\n\nEven in the revised one, we only check $? of diff in L10.","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"00fe7f3eea00ad546538a220147ca0d516f0c2f1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"},{"line_number":11,"context_line":"if ! (cd $TEMPDIR; diff -Naur a b)"},{"line_number":12,"context_line":"then"},{"line_number":13,"context_line":"    echo \"E: $CFGFILE is not up to date, please run $GENERATOR.\" 1\u003e\u00262"},{"line_number":14,"context_line":"    exit 42"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2Fx5Q%3D","line":13,"updated":"2014-01-01 05:44:37.000000000","message":"Change \"E:\" to \"Error:\", to make the error message more straightforward?","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"cc7c3f5998beafb9172f666a7eb2fde57e67e192","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    echo \"E: $GENERATOR can not generate $CFGFILE.\" 1\u003e\u00262; exit 2)"},{"line_number":11,"context_line":"if ! (cd $TEMPDIR; diff -Naur a b)"},{"line_number":12,"context_line":"then"},{"line_number":13,"context_line":"    echo \"E: $CFGFILE is not up to date, please run $GENERATOR.\" 1\u003e\u00262"},{"line_number":14,"context_line":"    exit 42"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2FxGw%3D","line":13,"in_reply_to":"AAAAT3%2F%2Fx5Q%3D","updated":"2014-01-02 02:09:28.000000000","message":"Done","commit_id":"5b4c71d76915b04fc52d34667719e64dbd85cd89"}]}