)]}'
{"heat/tests/test_hot.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4280b2a1e9687aab245ea568b862b1cc658eae54","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # check if we get the right class"},{"line_number":39,"context_line":"        self.assertTrue(isinstance(tmpl, hot.HOTemplate))"},{"line_number":40,"context_line":"        # test getting an invalid section"},{"line_number":41,"context_line":"        self.assertRaises(KeyError, lambda: tmpl[\u0027foobar\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # test defaults for valid sections"},{"line_number":44,"context_line":"        self.assertEqual(tmpl[hot.VERSION], \u00272013-05-23\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Frxk%3D","line":41,"updated":"2014-01-03 14:57:49.000000000","message":"isn\u0027t that making more sense like that :\n\nself.assertNotIn(\u0027foobar\u0027, tmp)","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"443025c31febb76918d96ac5282e6f3385055ddd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # check if we get the right class"},{"line_number":39,"context_line":"        self.assertTrue(isinstance(tmpl, hot.HOTemplate))"},{"line_number":40,"context_line":"        # test getting an invalid section"},{"line_number":41,"context_line":"        self.assertRaises(KeyError, lambda: tmpl[\u0027foobar\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # test defaults for valid sections"},{"line_number":44,"context_line":"        self.assertEqual(tmpl[hot.VERSION], \u00272013-05-23\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2F2c%3D","line":41,"in_reply_to":"AAAAT3%2F%2Frxk%3D","updated":"2014-01-04 06:41:15.000000000","message":"Done","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"}],"heat/tests/test_parser.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4280b2a1e9687aab245ea568b862b1cc658eae54","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_defaults(self):"},{"line_number":128,"context_line":"        empty \u003d parser.Template({})"},{"line_number":129,"context_line":"        self.assertRaises(KeyError, lambda: empty[template.VERSION])"},{"line_number":130,"context_line":"        self.assertEqual(empty[template.DESCRIPTION], \u0027No description\u0027)"},{"line_number":131,"context_line":"        self.assertEqual(empty[template.MAPPINGS], {})"},{"line_number":132,"context_line":"        self.assertEqual(empty[template.PARAMETERS], {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Frxc%3D","line":129,"updated":"2014-01-03 14:57:49.000000000","message":"same comment as before.","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"443025c31febb76918d96ac5282e6f3385055ddd","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_defaults(self):"},{"line_number":128,"context_line":"        empty \u003d parser.Template({})"},{"line_number":129,"context_line":"        self.assertRaises(KeyError, lambda: empty[template.VERSION])"},{"line_number":130,"context_line":"        self.assertEqual(empty[template.DESCRIPTION], \u0027No description\u0027)"},{"line_number":131,"context_line":"        self.assertEqual(empty[template.MAPPINGS], {})"},{"line_number":132,"context_line":"        self.assertEqual(empty[template.PARAMETERS], {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2F2g%3D","line":129,"in_reply_to":"AAAAT3%2F%2Frxc%3D","updated":"2014-01-04 06:41:15.000000000","message":"Done","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4280b2a1e9687aab245ea568b862b1cc658eae54","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_invalid_section(self):"},{"line_number":153,"context_line":"        tmpl \u003d parser.Template({\u0027Foo\u0027: [\u0027Bar\u0027]})"},{"line_number":154,"context_line":"        self.assertRaises(KeyError, lambda: tmpl[\u0027Foo\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_find_in_map(self):"},{"line_number":157,"context_line":"        tmpl \u003d parser.Template(mapping_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FrxY%3D","line":154,"updated":"2014-01-03 14:57:49.000000000","message":"same comment as before.","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"443025c31febb76918d96ac5282e6f3385055ddd","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_invalid_section(self):"},{"line_number":153,"context_line":"        tmpl \u003d parser.Template({\u0027Foo\u0027: [\u0027Bar\u0027]})"},{"line_number":154,"context_line":"        self.assertRaises(KeyError, lambda: tmpl[\u0027Foo\u0027])"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_find_in_map(self):"},{"line_number":157,"context_line":"        tmpl \u003d parser.Template(mapping_template)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2F2k%3D","line":154,"in_reply_to":"AAAAT3%2F%2FrxY%3D","updated":"2014-01-04 06:41:15.000000000","message":"Done","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"}],"heat/tests/test_resource_group.py":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"4280b2a1e9687aab245ea568b862b1cc658eae54","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        stack \u003d utils.parse_stack(template2)"},{"line_number":151,"context_line":"        snip \u003d stack.t[\u0027Resources\u0027][\u0027group1\u0027]"},{"line_number":152,"context_line":"        resgrp \u003d resource_group.ResourceGroup(\u0027test\u0027, snip, stack)"},{"line_number":153,"context_line":"        resgrp.validate()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @utils.stack_delete_after"},{"line_number":156,"context_line":"    def test_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FrxU%3D","line":153,"updated":"2014-01-03 14:57:49.000000000","message":"shouldn\u0027t be catched and tested?","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":7761,"name":"Jun Jie Nan","email":"nanjunjie@gmail.com","username":"nanjj"},"change_message_id":"443025c31febb76918d96ac5282e6f3385055ddd","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        stack \u003d utils.parse_stack(template2)"},{"line_number":151,"context_line":"        snip \u003d stack.t[\u0027Resources\u0027][\u0027group1\u0027]"},{"line_number":152,"context_line":"        resgrp \u003d resource_group.ResourceGroup(\u0027test\u0027, snip, stack)"},{"line_number":153,"context_line":"        resgrp.validate()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @utils.stack_delete_after"},{"line_number":156,"context_line":"    def test_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2F%2F2o%3D","line":153,"in_reply_to":"AAAAT3%2F%2FrkI%3D","updated":"2014-01-04 06:41:15.000000000","message":"Done","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"163428853253efa6726ef480c8daaf7987672eb8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        stack \u003d utils.parse_stack(template2)"},{"line_number":151,"context_line":"        snip \u003d stack.t[\u0027Resources\u0027][\u0027group1\u0027]"},{"line_number":152,"context_line":"        resgrp \u003d resource_group.ResourceGroup(\u0027test\u0027, snip, stack)"},{"line_number":153,"context_line":"        resgrp.validate()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @utils.stack_delete_after"},{"line_number":156,"context_line":"    def test_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FrkI%3D","line":153,"in_reply_to":"AAAAT3%2F%2Frtc%3D","updated":"2014-01-03 16:11:21.000000000","message":"It\u0027s not the same because the original test looks specifically for StackValidationFailed.  Although most tests aren\u0027t that particular.  IMO assertIsNone(resgrp.validate()) or even just resgrp.validate() would be fine.","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"},{"author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"change_message_id":"9af366cc9fd2a66c6200cc38ae5f18bd9f4d850c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        stack \u003d utils.parse_stack(template2)"},{"line_number":151,"context_line":"        snip \u003d stack.t[\u0027Resources\u0027][\u0027group1\u0027]"},{"line_number":152,"context_line":"        resgrp \u003d resource_group.ResourceGroup(\u0027test\u0027, snip, stack)"},{"line_number":153,"context_line":"        resgrp.validate()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @utils.stack_delete_after"},{"line_number":156,"context_line":"    def test_delete(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2Frtc%3D","line":153,"in_reply_to":"AAAAT3%2F%2FrxU%3D","updated":"2014-01-03 15:19:23.000000000","message":"I though about that, too. But if you look at the original code, all it does is catch the exception and then raise it again to indicate that the test failed in case that happens.\n\nBut the test would fail with the exception without the try/catch block, too.","commit_id":"6f627385b0cda119a9a95271a9af620ddade2985"}]}