)]}'
{"heat/engine/resources/openstack/neutron/neutron.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"482de6482673eb5bdbe1f8b00e33886cec3912a6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        2. Defaults resource name to physical resource name if None"},{"line_number":108,"context_line":"        \"\"\""},{"line_number":109,"context_line":"        if \u0027value_specs\u0027 in prop_diff and prop_diff[\u0027value_specs\u0027]:"},{"line_number":110,"context_line":"            NeutronResource.merge_value_specs(prop_diff, before_value_specs)"},{"line_number":111,"context_line":"        if \u0027name\u0027 in prop_diff and prop_diff[\u0027name\u0027] is None:"},{"line_number":112,"context_line":"            prop_diff[\u0027name\u0027] \u003d self.physical_resource_name()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_5e9260f8","line":110,"range":{"start_line":110,"start_character":57,"end_line":110,"end_character":75},"updated":"2019-04-23 21:01:23.000000000","message":"We could just pass self.properties[\u0027value_specs\u0027] here and avoid having to change the method signature and all of the subclasses.","commit_id":"97d5a8a4a98c3346d1f103f2f988dec66d582387"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e7535f0bd987842d8c76c3764bc20d4d33fc2368","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        2. Defaults resource name to physical resource name if None"},{"line_number":108,"context_line":"        \"\"\""},{"line_number":109,"context_line":"        if \u0027value_specs\u0027 in prop_diff and prop_diff[\u0027value_specs\u0027]:"},{"line_number":110,"context_line":"            NeutronResource.merge_value_specs(prop_diff, before_value_specs)"},{"line_number":111,"context_line":"        if \u0027name\u0027 in prop_diff and prop_diff[\u0027name\u0027] is None:"},{"line_number":112,"context_line":"            prop_diff[\u0027name\u0027] \u003d self.physical_resource_name()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_45acc78b","line":110,"range":{"start_line":110,"start_character":57,"end_line":110,"end_character":75},"in_reply_to":"ffb9cba7_5e9260f8","updated":"2019-04-24 03:11:15.000000000","message":"Oh yeah. Somehow, I always think neutron.py as a utility module and not NeutronResource as the base class:)","commit_id":"97d5a8a4a98c3346d1f103f2f988dec66d582387"}]}