)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c8fe750903bf6e8edfa8939b845456a76a0bd150","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-05-30 09:01:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"GroupUserAssignment Resource: The resource"},{"line_number":8,"context_line":"adds users to a group"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: If73ab29f1f2a99fb3b544362679757ffb8fa2574"},{"line_number":11,"context_line":"Story: 2005795"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_6dbfd8a9","line":8,"updated":"2019-05-30 14:10:04.000000000","message":"nit: don\u0027t line-wrap the headline","commit_id":"50e93e00cd48053a37795f65d1ffcd7bb4bca752"}],"heat/engine/resources/openstack/keystone/group_assignments.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c8fe750903bf6e8edfa8939b845456a76a0bd150","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from keystoneclient import exceptions as keystone_exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class KeystoneUserAssignmentMixin(object):"},{"line_number":24,"context_line":"    \"\"\"Implements user assignment to group."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    heat_template_version: 2013-05-23"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_8d76cc6f","line":23,"updated":"2019-05-30 14:10:04.000000000","message":"I don\u0027t understand the purpose of splitting this into two classes.","commit_id":"50e93e00cd48053a37795f65d1ffcd7bb4bca752"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c8fe750903bf6e8edfa8939b845456a76a0bd150","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":243,"context_line":"        version\u003d\u00275.0.0\u0027,"},{"line_number":244,"context_line":"        message\u003d_(\u0027Supported versions: keystone v3\u0027))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    default_client_name \u003d \u0027keystone\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_edde683c","line":243,"updated":"2019-05-30 14:10:04.000000000","message":"Train is 13.0.0","commit_id":"50e93e00cd48053a37795f65d1ffcd7bb4bca752"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c8fe750903bf6e8edfa8939b845456a76a0bd150","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":243,"context_line":"        version\u003d\u00275.0.0\u0027,"},{"line_number":244,"context_line":"        message\u003d_(\u0027Supported versions: keystone v3\u0027))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    default_client_name \u003d \u0027keystone\u0027"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_edb748f4","line":244,"updated":"2019-05-30 14:10:04.000000000","message":"You don\u0027t need a message here (that\u0027s for deprecated resources).","commit_id":"50e93e00cd48053a37795f65d1ffcd7bb4bca752"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c8fe750903bf6e8edfa8939b845456a76a0bd150","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    @property"},{"line_number":281,"context_line":"    def group_id(self):"},{"line_number":282,"context_line":"        try:"},{"line_number":283,"context_line":"            return self.client_plugin().get_group_id("},{"line_number":284,"context_line":"                self.properties.get(self.GROUP),"},{"line_number":285,"context_line":"                domain\u003dself.group_domain_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_ed850808","line":282,"updated":"2019-05-30 14:10:04.000000000","message":"Tidier way:\n\n  with self.client_plugin().ignore_not_found:\n      return ...\n\nI don\u0027t understand why we\u0027re ignoring not found though. Surely if you\u0027re creating the resource and the group doesn\u0027t exist, that\u0027s an error?","commit_id":"50e93e00cd48053a37795f65d1ffcd7bb4bca752"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"c8fe750903bf6e8edfa8939b845456a76a0bd150","unresolved":false,"context_lines":[{"line_number":303,"context_line":"        self.update_assignment(group_id\u003dself.group_id, prop_diff\u003dprop_diff)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def handle_delete(self):"},{"line_number":306,"context_line":"        self.delete_assignment(group_id\u003dself.group_id)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def validate(self):"},{"line_number":309,"context_line":"        super(KeystoneGroupUserAssignment, self).validate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_0dbbbcc4","line":306,"updated":"2019-05-30 14:10:04.000000000","message":"Definitely want ignore_not_found here though.","commit_id":"50e93e00cd48053a37795f65d1ffcd7bb4bca752"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"4fff482e47c04354cac04c5b33afd18df9d88c2e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    support_status \u003d support.SupportStatus("},{"line_number":243,"context_line":"        version\u003d\u00275.0.0\u0027,"},{"line_number":244,"context_line":"        message\u003d_(\u0027Supported versions: keystone v3\u0027))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    default_client_name \u003d \u0027keystone\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_e36607bb","line":243,"range":{"start_line":243,"start_character":17,"end_line":243,"end_character":18},"updated":"2020-11-17 15:20:52.000000000","message":"16","commit_id":"379f79868540d19b94231781f80fa926b3e82832"}]}