)]}'
{"id":"openstack%2Fheat~66741","triplet_id":"openstack%2Fheat~master~I908879827d6460ecbef30e9db98ac5597dc323cd","project":"openstack/heat","branch":"master","topic":"bug/1260282","hashtags":[],"change_id":"I908879827d6460ecbef30e9db98ac5597dc323cd","subject":"Fix AWS::StackId pseudo-parameter during stack update","status":"MERGED","created":"2014-01-15 00:47:27.000000000","updated":"2014-01-30 14:38:15.000000000","submitted":"2014-01-30 14:38:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"46757822a7ba093fdf216a96b0c8eb6445c7d538","_number":66741,"virtual_id_number":66741,"owner":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":2,"date":"2014-01-30 14:38:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},{"value":0,"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"all":[{"value":0,"date":"2014-01-29 18:48:35.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":2,"date":"2014-01-30 09:53:36.000000000","_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},{"value":2,"date":"2014-01-30 11:00:28.000000000","_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"all":[{"value":0,"date":"2014-01-29 18:48:35.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"value":0,"date":"2014-01-30 09:53:36.000000000","_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},{"value":0,"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},{"value":1,"date":"2014-01-30 11:00:28.000000000","_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-15 00:47:44.000000000","updated_by":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"reviewer":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"state":"REVIEWER"},{"updated":"2014-01-15 00:47:56.000000000","updated_by":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"reviewer":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"state":"REVIEWER"},{"updated":"2014-01-30 09:53:36.000000000","updated_by":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"reviewer":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"state":"REVIEWER"},{"updated":"2014-01-30 11:00:28.000000000","updated_by":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"reviewer":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"state":"REVIEWER"},{"updated":"2014-01-30 14:38:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d0349a08528efcf8cbb7644dc28ddbc3616eb876","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-15 00:48:07.000000000","message":"Patch Set 1: Work In Progress\n\nNeeds tests.","accounts_in_message":[],"_revision_number":1},{"id":"1918907c01f72668147132736987d33abc27537a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-15 02:11:48.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-heat-pep8 http://logs.openstack.org/41/66741/1/check/gate-heat-pep8/d21ccd9 : SUCCESS in 3m 03s\n- gate-heat-docs http://docs-draft.openstack.org/41/66741/1/check/gate-heat-docs/4eceaf1/doc/build/html/ : SUCCESS in 3m 56s\n- gate-heat-python26 http://logs.openstack.org/41/66741/1/check/gate-heat-python26/a9b7bcf : SUCCESS in 2m 14s\n- gate-heat-python27 http://logs.openstack.org/41/66741/1/check/gate-heat-python27/5dc8772 : SUCCESS in 4m 05s\n- check-tempest-dsvm-full http://logs.openstack.org/41/66741/1/check/check-tempest-dsvm-full/eb88de1 : SUCCESS in 45m 52s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/41/66741/1/check/check-tempest-dsvm-postgres-full/19e0b38 : SUCCESS in 58m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/41/66741/1/check/check-tempest-dsvm-neutron/8c6d985 : SUCCESS in 36m 13s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/66741/1/check/gate-tempest-dsvm-large-ops/c05ad8b : SUCCESS in 12m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/66741/1/check/gate-tempest-dsvm-neutron-large-ops/f41707a : SUCCESS in 12m 25s\n","accounts_in_message":[],"_revision_number":1},{"id":"a9f2959a578d80dac8d342683c52bc00be00ab9f","author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"date":"2014-01-15 09:40:42.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis doesn\u0027t seem to work on my local devstack. Using the same templates as described in bug #1260282, both instances are deleted then created when I update the main stack.","accounts_in_message":[],"_revision_number":1},{"id":"bcc2577348ab3a0759923d4af33f3709a9f76964","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-23 06:03:14.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"5c8f30a7922d6039735f794cb9b02f60bebef3b1","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-01-23 06:03:14.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"9b7e87efcdf638bd72828ed939047e07e8318f40","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-24 02:35:29.000000000","message":"Patch Set 1: Restored\n\nUnit tests on the way","accounts_in_message":[],"_revision_number":1},{"id":"c1ec12cce63f42f0ef6023b95168b542ee47ffcc","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-24 02:35:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9e56b35221df6494fcdd94ef9b152f998c5282ba","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-24 02:37:58.000000000","message":"Patch Set 2:\n\nI\u0027ve managed to come up with a unit test that is fixed by this change. Before, the resource referencing AWS::StackId gets updated in a no-op stack updated, but after it does not.\n\nI can\u0027t rule out that other issues exist, but this seems worth retesting.","accounts_in_message":[],"_revision_number":2},{"id":"1fc199a75b0a0aa0887a3cc19c45b3de16cc6c3d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-24 04:10:45.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-heat-pep8 http://logs.openstack.org/41/66741/2/check/gate-heat-pep8/018b996 : SUCCESS in 3m 43s\n- gate-heat-docs http://docs-draft.openstack.org/41/66741/2/check/gate-heat-docs/e46fe0f/doc/build/html/ : SUCCESS in 4m 35s\n- gate-heat-python26 http://logs.openstack.org/41/66741/2/check/gate-heat-python26/cbed276 : SUCCESS in 2m 51s\n- gate-heat-python27 http://logs.openstack.org/41/66741/2/check/gate-heat-python27/97c4ec0 : SUCCESS in 3m 42s\n- check-tempest-dsvm-full http://logs.openstack.org/41/66741/2/check/check-tempest-dsvm-full/565c608 : SUCCESS in 1h 01m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/41/66741/2/check/check-tempest-dsvm-postgres-full/b24f7c5 : SUCCESS in 57m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/41/66741/2/check/check-tempest-dsvm-neutron/c4e43d2 : SUCCESS in 31m 20s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/66741/2/check/gate-tempest-dsvm-large-ops/1730812 : SUCCESS in 11m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/66741/2/check/gate-tempest-dsvm-neutron-large-ops/49818cb : SUCCESS in 12m 39s\n","accounts_in_message":[],"_revision_number":2},{"id":"220e90b79bec75bcd07b9360a67167a91196be53","author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"date":"2014-01-24 08:30:57.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nIt seems this patch does enable {Ref: \u0027xlcloud:stackId\u0027} to be correctly resolved, and The code looks good for fixing that part of the bug.\n\nThe reason why Node1 will be replaced during update is it has {Ref: \u0027AWS::StackId\u0027} in its userdata property. The pseudo parameter of the nested stack isn\u0027t ready by the time in-place update for Node1 is attempted. But at creation time it\u0027s there, and the existing resource has the correct value for {Ref: \u0027AWS::StackId\u0027} .","accounts_in_message":[],"_revision_number":2},{"id":"4ceb0e8640184c9a4da506a15ae77bd1dbc9c6a4","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-24 19:19:59.000000000","message":"Patch Set 2:\n\nThanks for looking at this Liang.\n\nIn theory - and my testing confirms this - the resources of the updated_stack will be created when they are first accessed, during the validate call, and will resolve the AWS::StackId parameter at this time. So in order for this to work, the stack_id has to be set before that, hence this change.\n\nIn the bug report, the resource getting the wrong AWS::StackId value was a nested stack, but I don\u0027t believe that is necessary to reproduce the issue - any resource that references AWS::StackId will get the wrong value during an update.\n\nSo the key point is that AWS::StackId resolves correctly at the time the resource is updated - everything else should fall into place after that. From what I can tell, this change does that. If it didn\u0027t, the resource in the unit test would detect the change and raise UpdateReplace (which is, in fact, what happens if you run this unit test without the fix). (A nested stack would respond differently, by starting a stack update.)","accounts_in_message":[],"_revision_number":2},{"id":"0798e2f0375982ff0deed40f5749a31f6d018cf0","author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"date":"2014-01-26 15:20:50.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nZane, thanks for the detailed explanation! \n\nI agree the patch makes sure the AWS::StackId parameter resolved correctly for any resources in a stack including nested stack resources. That\u0027s why {Ref: \u0027xlcloud:stackId\u0027} can be resolved correctly in the nested stack - the AWS::StackId reference (\u0027xlcloud:stackId\u0027 : {Ref: \u0027AWS::StackId\u0027}) in the property of the parent nested stack resource is resovled successfully, thus being able to pass xlcloud:stackId param to the nested stack. \n\nThe reason Node1 wasn\u0027t updated in place is that the AWS::StackId reference in the nested stack wasn\u0027t resolved properly by the time in-place update is attempted. But it finally got resolved at created time, which is why the stack_id was there when we looked up Node1 after stack creation. A later update operation, however, would cause Node1 being replaced as Simon observed. Since update_template_diff_properties will notice the difference between the properties referencing AWS::StackId in the existing stack and new stack - existing stack has AWS::StackId resolved properly but not new stack at this moment.\n\nProbably we can do the same thing for nested stack - inserting stack.parameters.set_stack_id(nested_stack.identifier().arn()) at https://github.com/openstack/heat/blob/master/heat/engine/stack_resource.py#L157.\n\nAnyway, this patch does address the major issue of the bug. IMO, it\u0027s perfectly fine to deal with the nested stack in a subsequent patch and mark the current commit as a partial fix.","accounts_in_message":[],"_revision_number":2},{"id":"4067c991a5ed97ad574a37816cda8c55cd9451cf","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-27 21:19:29.000000000","message":"Patch Set 2:\n\nOh! I understand now. You are completely correct, thank you!\n\nI will write a unit test for the nested stack case and submit the fix, either in this patch or another.","accounts_in_message":[],"_revision_number":2},{"id":"c58d6dae62ca58c4b350d1ef812a7219d42bcf38","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-28 23:28:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"910dad55c518ca764000452e361c5cd12aaa3292","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-29 00:27:51.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-heat-pep8 http://logs.openstack.org/41/66741/3/check/gate-heat-pep8/9fe9ed4 : SUCCESS in 3m 23s\n- gate-heat-docs http://docs-draft.openstack.org/41/66741/3/check/gate-heat-docs/84d4b00/doc/build/html/ : SUCCESS in 5m 50s\n- gate-heat-python26 http://logs.openstack.org/41/66741/3/check/gate-heat-python26/34ac2df : SUCCESS in 3m 24s\n- gate-heat-python27 http://logs.openstack.org/41/66741/3/check/gate-heat-python27/501b46c : SUCCESS in 3m 50s\n- check-tempest-dsvm-full http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-full/1f1b45d : FAILURE in 55m 10s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-postgres-full/469016d : SUCCESS in 50m 34s\n- check-tempest-dsvm-neutron http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-neutron/4f1b3f8 : SUCCESS in 32m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/66741/3/check/gate-tempest-dsvm-large-ops/7ea1c2e : SUCCESS in 15m 13s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/66741/3/check/gate-tempest-dsvm-neutron-large-ops/9b8f168 : SUCCESS in 14m 08s\n","accounts_in_message":[],"_revision_number":3},{"id":"92b8900a4b68ee7d6c367f6f39ca584aa510353c","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-29 00:29:28.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1258848\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1258848\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1258848","accounts_in_message":[],"_revision_number":3},{"id":"76ace469915d7204ebb0b1a9acca8e55676f92a5","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-29 18:48:35.000000000","message":"Patch Set 3:\n\nrecheck bug 1258848","accounts_in_message":[],"_revision_number":3},{"id":"ad8fe39d54463ac0cbbcf13f0ca739fd8cb77cee","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-29 20:06:45.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-heat-pep8 http://logs.openstack.org/41/66741/3/check/gate-heat-pep8/ddf5120 : SUCCESS in 3m 15s\n- gate-heat-docs http://docs-draft.openstack.org/41/66741/3/check/gate-heat-docs/d03ebcc/doc/build/html/ : SUCCESS in 4m 34s\n- gate-heat-python26 http://logs.openstack.org/41/66741/3/check/gate-heat-python26/dd634e7 : SUCCESS in 2m 58s\n- gate-heat-python27 http://logs.openstack.org/41/66741/3/check/gate-heat-python27/aa73ab2 : SUCCESS in 4m 17s\n- check-tempest-dsvm-full http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-full/13c5e44 : SUCCESS in 56m 24s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-postgres-full/390e5c2 : FAILURE in 1h 01m 23s\n- check-tempest-dsvm-neutron http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-neutron/788a845 : SUCCESS in 32m 12s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/66741/3/check/gate-tempest-dsvm-large-ops/bc62b4e : SUCCESS in 11m 27s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/66741/3/check/gate-tempest-dsvm-neutron-large-ops/feaf7d3 : SUCCESS in 14m 15s\n","accounts_in_message":[],"_revision_number":3},{"id":"8035336df0ece0258010b302155af99cf8169075","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-01-29 20:08:23.000000000","message":"Patch Set 3:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1258848\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1258848\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1258848","accounts_in_message":[],"_revision_number":3},{"id":"81d965006e7839e2d0783f975b56f46004f87a3d","author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"date":"2014-01-29 21:23:05.000000000","message":"Patch Set 3:\n\nrecheck bug 1258848","accounts_in_message":[],"_revision_number":3},{"id":"9e0a4d2ebd21196f8b61b084ba386bfcf6e8dacc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-29 22:32:30.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-heat-pep8 http://logs.openstack.org/41/66741/3/check/gate-heat-pep8/d31d2c8 : SUCCESS in 3m 51s\n- gate-heat-docs http://docs-draft.openstack.org/41/66741/3/check/gate-heat-docs/e3362e0/doc/build/html/ : SUCCESS in 4m 35s\n- gate-heat-python26 http://logs.openstack.org/41/66741/3/check/gate-heat-python26/469ee98 : SUCCESS in 3m 42s\n- gate-heat-python27 http://logs.openstack.org/41/66741/3/check/gate-heat-python27/1141dea : SUCCESS in 4m 05s\n- check-tempest-dsvm-full http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-full/93e832e : SUCCESS in 48m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-postgres-full/624968b : SUCCESS in 48m 57s\n- check-tempest-dsvm-neutron http://logs.openstack.org/41/66741/3/check/check-tempest-dsvm-neutron/0877285 : SUCCESS in 33m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/66741/3/check/gate-tempest-dsvm-large-ops/4ffec3d : SUCCESS in 12m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/66741/3/check/gate-tempest-dsvm-neutron-large-ops/85933b9 : SUCCESS in 14m 21s\n","accounts_in_message":[],"_revision_number":3},{"id":"3af5a1c02cb69537238d64e2da1d8e27e753ca69","author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"date":"2014-01-30 09:53:36.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"b5472be25d9384e9b6c0fbbab9bed3a659cd7457","author":{"_account_id":7135,"name":"Liang Chen","email":"liangchen.linux@gmail.com","username":"Liang"},"date":"2014-01-30 11:00:28.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d98eb46d1a0a89fa66dc73cd0f5dec4b51dee98f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-30 11:05:29.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"e2abb20a093ca3ec45eebec212137cf1513454c3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-30 14:38:15.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- gate-heat-docs http://docs-draft.openstack.org/41/66741/3/gate/gate-heat-docs/4d79460/doc/build/html/ : SUCCESS in 4m 07s\n- gate-heat-pep8 http://logs.openstack.org/41/66741/3/gate/gate-heat-pep8/78ee87a : SUCCESS in 4m 12s\n- gate-heat-python26 http://logs.openstack.org/41/66741/3/gate/gate-heat-python26/fe2ec7a : SUCCESS in 3m 04s\n- gate-heat-python27 http://logs.openstack.org/41/66741/3/gate/gate-heat-python27/6dd7f6d : SUCCESS in 4m 13s\n- gate-tempest-dsvm-full http://logs.openstack.org/41/66741/3/gate/gate-tempest-dsvm-full/b97ef8e : SUCCESS in 55m 25s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/41/66741/3/gate/gate-tempest-dsvm-postgres-full/af79001 : SUCCESS in 51m 12s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/41/66741/3/gate/gate-tempest-dsvm-neutron/8f74869 : SUCCESS in 29m 05s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/66741/3/gate/gate-tempest-dsvm-large-ops/6135714 : SUCCESS in 22m 25s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/66741/3/gate/gate-tempest-dsvm-neutron-large-ops/0a2377e : SUCCESS in 17m 06s\n","accounts_in_message":[],"_revision_number":3},{"id":"1fbbf682f8a9ee737d0c3fd4bffc5c0630562d81","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-30 14:38:15.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"92583c6c79ebcece89eb90c8581634b9ea10832a","revisions":{"7c66004ff42c10ba2cef65262bce0a1be69943ec":{"kind":"REWORK","_number":1,"created":"2014-01-15 00:47:27.000000000","uploader":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"ref":"refs/changes/41/66741/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/41/66741/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/41/66741/1"}}},"commit":{"parents":[{"commit":"21f97a026228d8258f9bfd7c66c7a94d05b54cb9","subject":"Merge \"Add filter and pagination to stack_get_all\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/21f97a026228d8258f9bfd7c66c7a94d05b54cb9"}]}],"author":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2014-01-15 00:46:55.000000000","tz":-300},"committer":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2014-01-15 00:46:55.000000000","tz":-300},"subject":"Fix AWS::StackId pseudo-parameter during stack update","message":"Fix AWS::StackId pseudo-parameter during stack update\n\nParameters, including pseudo-parameters, are resolved at the time that\nresources are created, which is as soon as they are first accessed (in the\ncase of a stack update, this means during the validation of the new\ntemplate). As a result, by the time we set the AWS::StackId\npseudo-parameter in the process of doing an update it is already too late\nfor resources in the new stack to resolve them correctly. This was leading\nto spurious differences being detected on stack update.\n\nThis patch fixes the issue by setting the pseudo-parameter before any\nresources in the new stack are created.\n\nFixes bug 1260282\n\nChange-Id: I908879827d6460ecbef30e9db98ac5597dc323cd\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/7c66004ff42c10ba2cef65262bce0a1be69943ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/7c66004ff42c10ba2cef65262bce0a1be69943ec"}]},"branch":"refs/heads/master"},"dfbcd5bed0450cc4825fafeda13ff56dc0c82a77":{"kind":"REWORK","_number":2,"created":"2014-01-24 02:35:39.000000000","uploader":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"ref":"refs/changes/41/66741/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/41/66741/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/41/66741/2"}}},"commit":{"parents":[{"commit":"f4337bc58cac12cb0d78558e4da2819fb1f396c0","subject":"Merge \"add the validation of MaxSize ,MinSize and DesiredCapacity\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/f4337bc58cac12cb0d78558e4da2819fb1f396c0"}]}],"author":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2014-01-24 02:01:10.000000000","tz":-300},"committer":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2014-01-24 02:33:58.000000000","tz":-300},"subject":"Fix AWS::StackId pseudo-parameter during stack update","message":"Fix AWS::StackId pseudo-parameter during stack update\n\nParameters, including pseudo-parameters, are resolved at the time that\nresources are created, which is as soon as they are first accessed (in the\ncase of a stack update, this means during the validation of the new\ntemplate). As a result, by the time we set the AWS::StackId\npseudo-parameter in the process of doing an update it is already too late\nfor resources in the new stack to resolve them correctly. This was leading\nto spurious differences being detected on stack update.\n\nThis patch fixes the issue by setting the pseudo-parameter before any\nresources in the new stack are created.\n\nFixes bug 1260282\n\nChange-Id: I908879827d6460ecbef30e9db98ac5597dc323cd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/dfbcd5bed0450cc4825fafeda13ff56dc0c82a77"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/dfbcd5bed0450cc4825fafeda13ff56dc0c82a77"}]},"branch":"refs/heads/master"},"92583c6c79ebcece89eb90c8581634b9ea10832a":{"kind":"REWORK","_number":3,"created":"2014-01-28 23:28:06.000000000","uploader":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"ref":"refs/changes/41/66741/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/41/66741/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/41/66741/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/41/66741/3"}}},"commit":{"parents":[{"commit":"3d2517b2c792afc40b5a7af7734e7d822020a1bf","subject":"Merge \"Refactor Parameters Schema based on common Schema\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/3d2517b2c792afc40b5a7af7734e7d822020a1bf"}]}],"author":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2014-01-28 23:27:34.000000000","tz":-300},"committer":{"name":"Zane Bitter","email":"zbitter@redhat.com","date":"2014-01-28 23:27:34.000000000","tz":-300},"subject":"Fix AWS::StackId pseudo-parameter during stack update","message":"Fix AWS::StackId pseudo-parameter during stack update\n\nParameters, including pseudo-parameters, are resolved at the time that\nresources are created, which is as soon as they are first accessed (in the\ncase of a stack update, this means during the validation of the new\ntemplate). As a result, by the time we set the AWS::StackId\npseudo-parameter in the process of doing an update it is already too late\nfor resources in the new stack to resolve them correctly. This was leading\nto spurious differences being detected on stack update.\n\nThis patch fixes the issue by setting the pseudo-parameter before any\nresources in the new stack are created.\n\nFixes bug 1260282\n\nChange-Id: I908879827d6460ecbef30e9db98ac5597dc323cd","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/92583c6c79ebcece89eb90c8581634b9ea10832a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/92583c6c79ebcece89eb90c8581634b9ea10832a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}