)]}'
{"heat/engine/stack.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"dcc3ba5a48c9368e9a252315c416019321291cd8","unresolved":false,"context_lines":[{"line_number":1573,"context_line":"                rsrc.state_set(rsrc.action,"},{"line_number":1574,"context_line":"                               rsrc.FAILED,"},{"line_number":1575,"context_line":"                               six.text_type(reason))"},{"line_number":1576,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1577,"context_line":"        if self.action \u003d\u003d self.UPDATE:"},{"line_number":1578,"context_line":"            existing_params \u003d environment.Environment({env_fmt.PARAMETERS:"},{"line_number":1579,"context_line":"                                                      self.t.env.params})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e8c2f233","line":1576,"updated":"2019-07-16 16:10:12.000000000","message":"It would probably help avoid races if this happened last.","commit_id":"40bfd2a0e982aaac365f2b7cbd21387864008696"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"87dbf89b0c01a6d4fef00b690477a97c6c5a41a9","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"                               rsrc.FAILED,"},{"line_number":1575,"context_line":"                               six.text_type(reason))"},{"line_number":1576,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1577,"context_line":"        if self.action \u003d\u003d self.UPDATE:"},{"line_number":1578,"context_line":"            existing_params \u003d environment.Environment({env_fmt.PARAMETERS:"},{"line_number":1579,"context_line":"                                                      self.t.env.params})"},{"line_number":1580,"context_line":"            template \u003d tmpl.Template.load(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2198201a","line":1577,"updated":"2019-07-16 23:40:34.000000000","message":"It just occurred to me that we also need to check that we are resetting a legacy stack. This would do very bad things to a convergence stack :)","commit_id":"40bfd2a0e982aaac365f2b7cbd21387864008696"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"25b54b6e63fee86b8351e5e662370cea36a737d5","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"                               rsrc.FAILED,"},{"line_number":1575,"context_line":"                               six.text_type(reason))"},{"line_number":1576,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1577,"context_line":"        if self.action \u003d\u003d self.UPDATE:"},{"line_number":1578,"context_line":"            existing_params \u003d environment.Environment({env_fmt.PARAMETERS:"},{"line_number":1579,"context_line":"                                                      self.t.env.params})"},{"line_number":1580,"context_line":"            template \u003d tmpl.Template.load(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c4959a88","line":1577,"in_reply_to":"7faddb67_2198201a","updated":"2019-07-17 00:42:39.000000000","message":"Is it called anywhere in the convergence?\n\nWe reset stack staus only for legacy stack\n\nhttps://github.com/openstack/heat/blob/master/heat/engine/service.py#L2384\n\nAnd then it\u0027s called in update_task which is only used for legacy.\n\nhttps://github.com/openstack/heat/blob/master/heat/engine/stack.py#L1604","commit_id":"40bfd2a0e982aaac365f2b7cbd21387864008696"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"a7f7c69a6caaf7e14f70ea7e65599eb2586a2a4f","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"                               rsrc.FAILED,"},{"line_number":1575,"context_line":"                               six.text_type(reason))"},{"line_number":1576,"context_line":"        self.state_set(self.action, self.FAILED, six.text_type(reason))"},{"line_number":1577,"context_line":"        if self.action \u003d\u003d self.UPDATE:"},{"line_number":1578,"context_line":"            existing_params \u003d environment.Environment({env_fmt.PARAMETERS:"},{"line_number":1579,"context_line":"                                                      self.t.env.params})"},{"line_number":1580,"context_line":"            template \u003d tmpl.Template.load(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9e284a97","line":1577,"in_reply_to":"7faddb67_c4959a88","updated":"2019-07-17 14:15:43.000000000","message":"Yeah, you\u0027re right. Doesn\u0027t hurt to check here though.","commit_id":"40bfd2a0e982aaac365f2b7cbd21387864008696"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"dcc3ba5a48c9368e9a252315c416019321291cd8","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"                backup_stack.t.t[newstack.t.version[0]] \u003d max("},{"line_number":1713,"context_line":"                    newstack.t.version[1], self.t.version[1])"},{"line_number":1714,"context_line":"                backup_stack.t.merge_snippets(newstack.t)"},{"line_number":1715,"context_line":"                backup_stack.t.store(self.context)"},{"line_number":1716,"context_line":"            self.store()"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"            if previous_template_id is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_889b3e64","line":1715,"updated":"2019-07-16 16:10:12.000000000","message":"I can\u0027t think of a reason right now that we shouldn\u0027t update the backup stack template as well in the case where we\u0027re resetting the stack status. Was there a theory behind this?","commit_id":"40bfd2a0e982aaac365f2b7cbd21387864008696"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7278c0ad29b1da5e6948bb48e9dc5698fbe013a9","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"                backup_stack.t.t[newstack.t.version[0]] \u003d max("},{"line_number":1713,"context_line":"                    newstack.t.version[1], self.t.version[1])"},{"line_number":1714,"context_line":"                backup_stack.t.merge_snippets(newstack.t)"},{"line_number":1715,"context_line":"                backup_stack.t.store(self.context)"},{"line_number":1716,"context_line":"            self.store()"},{"line_number":1717,"context_line":""},{"line_number":1718,"context_line":"            if previous_template_id is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_644706be","line":1715,"in_reply_to":"7faddb67_889b3e64","updated":"2019-07-17 01:59:56.000000000","message":"I noticed that backup stack template got updated for some reason, though I could not find out why and how.","commit_id":"40bfd2a0e982aaac365f2b7cbd21387864008696"}]}