)]}'
{"contrib/rackspace/heat/engine/plugins/auto_scale.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e6b743b4dd1f293cdef384bf7b817066536216b2","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \u0027key_name\u0027,"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    _LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_KEYS \u003d ("},{"line_number":108,"context_line":"        LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_UUID,"},{"line_number":109,"context_line":"    ) \u003d ("},{"line_number":110,"context_line":"        \u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B6pE%3D","line":107,"updated":"2014-01-20 19:20:42.000000000","message":"For consistency of naming, it would be better to rename this ..._SERVER_NETWORK_UUID, i.e. the uuid of a singular network (and rename the ..._KEYS tuple also).","commit_id":"379c96249ddc7e68e78207ddb5f3c32876f8a412"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"caea151680361a656b7c7e73d510b20c70e93a86","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \u0027key_name\u0027,"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    _LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_KEYS \u003d ("},{"line_number":108,"context_line":"        LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_UUID,"},{"line_number":109,"context_line":"    ) \u003d ("},{"line_number":110,"context_line":"        \u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B0h4%3D","line":107,"in_reply_to":"AAAAUH%2F%2B0ns%3D","updated":"2014-01-21 18:58:47.000000000","message":"Done","commit_id":"379c96249ddc7e68e78207ddb5f3c32876f8a412"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"98542d9e979959b9d7248b11bf5e284519372a6f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \u0027key_name\u0027,"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    _LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_KEYS \u003d ("},{"line_number":108,"context_line":"        LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_UUID,"},{"line_number":109,"context_line":"    ) \u003d ("},{"line_number":110,"context_line":"        \u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B0ns%3D","line":107,"in_reply_to":"AAAAUH%2F%2B32c%3D","updated":"2014-01-21 18:47:42.000000000","message":"Yes, because my original script that created all of these key names named them so that things inside a list would carry a prefix that was a singular version of the list properties name. i.e. a \"network\" is a thing in a list of \"networks\". This should not be very controversial.\n\nFor example the subkeys of maps in the LAUNCH_CONFIG_ARGS_LOAD_BALANCERS list are called things like LAUNCH_CONFIG_ARGS_LOAD_BALANCER_ID not LAUNCH_CONFIG_ARGS_LOAD_BALANCERS_ID because each ID is for exactly one load balancer.\n\nThis patch moves the \"networks\" map inside a list because each map actually only represents one \"network\". Therefore this patch is absolutely an appropriate place to change the name from networks to network to (a) be consistent with how this would have been named if the original schema were correct and (b) actually describe what it is.","commit_id":"379c96249ddc7e68e78207ddb5f3c32876f8a412"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"27b42427f37196275d296ee02cc9c4693bc1601d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \u0027key_name\u0027,"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    _LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_KEYS \u003d ("},{"line_number":108,"context_line":"        LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_UUID,"},{"line_number":109,"context_line":"    ) \u003d ("},{"line_number":110,"context_line":"        \u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B32c%3D","line":107,"in_reply_to":"AAAAUH%2F%2B5Ls%3D","updated":"2014-01-21 08:23:56.000000000","message":"Are you really want fix it in this patch? )","commit_id":"379c96249ddc7e68e78207ddb5f3c32876f8a412"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"5e9474124ead90932c1f55f7efc0885293f03848","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \u0027key_name\u0027,"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    _LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_KEYS \u003d ("},{"line_number":108,"context_line":"        LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_UUID,"},{"line_number":109,"context_line":"    ) \u003d ("},{"line_number":110,"context_line":"        \u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B5Ls%3D","line":107,"in_reply_to":"AAAAUH%2F%2B6mk%3D","updated":"2014-01-21 00:46:51.000000000","message":"I wasn\u0027t suggesting removing the _LAUNCH_CONFIG_ARGS_, just removing the \u0027S\u0027 in \u0027NETWORKS\u0027.","commit_id":"379c96249ddc7e68e78207ddb5f3c32876f8a412"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"1af0287bfde9251096599aeecdba1759672338b8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        \u0027key_name\u0027,"},{"line_number":105,"context_line":"    )"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    _LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_KEYS \u003d ("},{"line_number":108,"context_line":"        LAUNCH_CONFIG_ARGS_SERVER_NETWORKS_UUID,"},{"line_number":109,"context_line":"    ) \u003d ("},{"line_number":110,"context_line":"        \u0027uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B6mk%3D","line":107,"in_reply_to":"AAAAUH%2F%2B6pE%3D","updated":"2014-01-20 19:31:12.000000000","message":"I don\u0027t understand.  They all start with \"_LAUNCH_CONFIG_ARGS_\".  How is that more consistent?  Also, shouldn\u0027t that be done in a separate review?","commit_id":"379c96249ddc7e68e78207ddb5f3c32876f8a412"}]}