)]}'
{"heat/engine/clients/os/designate.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"617729e2d18a69f9e023b6ff4d4a8deb52d3f1e7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                         kwargs.pop(\u0027id\u0027))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class DesignateDomainConstraint(constraints.BaseCustomConstraint):"},{"line_number":118,"context_line":"    resource_client_name \u003d CLIENT_NAME"},{"line_number":119,"context_line":"    resource_getter_name \u003d \u0027get_domain_id\u0027"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ff671ce8","side":"PARENT","line":117,"updated":"2019-09-25 14:04:59.000000000","message":"This is still referenced in setup.cfg. I think we need to replace it with a constrain that does nothing, otherwise existing templates might break (though not sure if they\u0027d be undeletable, which is the thing we really want to avoid?).","commit_id":"73f2cdef7a173d9ead15e1dd42ec83597cd9551a"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a765eea980c37024b91b499e9a83b2dfe20b8822","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                         kwargs.pop(\u0027id\u0027))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class DesignateDomainConstraint(constraints.BaseCustomConstraint):"},{"line_number":118,"context_line":"    resource_client_name \u003d CLIENT_NAME"},{"line_number":119,"context_line":"    resource_getter_name \u003d \u0027get_domain_id\u0027"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b9b9b5cc","side":"PARENT","line":117,"in_reply_to":"3fa7e38b_ff671ce8","updated":"2019-09-26 04:28:48.000000000","message":"I think we can remove the constraint from setup.cfg like some other broken constraints we did earlier. \n\nUsers clearly need to migrate their templates to use designate v2 resources and constraints. IMO, replacing it with constraint that does nothing would probably be misleading. Same applies to resources too, but we\u0027ve never removed resource plugins.\n\nAlso, I don\u0027t think anyone who uses latest heat would be using desgnate v1.","commit_id":"73f2cdef7a173d9ead15e1dd42ec83597cd9551a"}]}