)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6bcc0397a8bddb06fcfd6d2c8f1f6f1b8ada6b29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huangtianhua \u003chuangtianhua@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-25 15:37:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix errors on OS::Neutron::Port resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. The properties \"NAME\" and \"DEVICE_ID\" should be update_allowed."},{"line_number":10,"context_line":"2. The properties_schema missing \"DEVICE_OWNER\" and \"TENANT_ID\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BbnY%3D","line":7,"updated":"2014-01-26 20:18:48.000000000","message":"This change doesn\u0027t fix any errors, it just adds features and changes behaviour. The first line should describe what the actual change is.","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"e684537923adf2627d85c32e6c2df47a5a7af2d2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huangtianhua \u003chuangtianhua@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-25 15:37:25 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix errors on OS::Neutron::Port resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. The properties \"NAME\" and \"DEVICE_ID\" should be update_allowed."},{"line_number":10,"context_line":"2. The properties_schema missing \"DEVICE_OWNER\" and \"TENANT_ID\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BaVo%3D","line":7,"in_reply_to":"AAAAUH%2F%2BbnY%3D","updated":"2014-01-27 08:40:26.000000000","message":"Thanks. \nDone.","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6bcc0397a8bddb06fcfd6d2c8f1f6f1b8ada6b29","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix errors on OS::Neutron::Port resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. The properties \"NAME\" and \"DEVICE_ID\" should be update_allowed."},{"line_number":10,"context_line":"2. The properties_schema missing \"DEVICE_OWNER\" and \"TENANT_ID\""},{"line_number":11,"context_line":"definition."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BbnQ%3D","line":9,"updated":"2014-01-26 20:18:48.000000000","message":"When I was implementing update_allowed I attempted to enable this for name and device_id. If I remember correctly, updating either of these properties resulted in neutron assigning a new ID to the port - which means that heat no longer has a valid reference to the port. Before proposing this change again can you please confirm that you are not observing this behaviour?","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"e684537923adf2627d85c32e6c2df47a5a7af2d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix errors on OS::Neutron::Port resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. The properties \"NAME\" and \"DEVICE_ID\" should be update_allowed."},{"line_number":10,"context_line":"2. The properties_schema missing \"DEVICE_OWNER\" and \"TENANT_ID\""},{"line_number":11,"context_line":"definition."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BaPE%3D","line":9,"in_reply_to":"AAAAUH%2F%2BbnQ%3D","updated":"2014-01-27 08:40:26.000000000","message":"Thanks.\nI have some questions on stack_update.\n\nMy operates:\n\n1. Create a stack which has only a neutron port resource.\n\n2. stack-update to update the name of the port.\n\n3. The result : the port name is updated to which I wanted it to be, but in fact the port is a new one. Heat posted a create request to neutron and then deleted the old one. This isn\u0027t what I want. And this because the heat executed the _create_resource() code branch on _process_new_resource_update() in engine/update.py file when catch the resource.UpdateReplace exception. I don\u0027t know whether this is correct. In my opinion, we should raise exception to user to tell that some property can\u0027t be update if the property is not update_allowed. What do you think about this?\n\n4. I modify the \"name\" properties to update_allowed. \n\n5. Then stack-update to update the name of the port again. This time is correct or may say it\u0027s what I want to do(just modify the name of the port). So I modify the \"NAME\" and \"DEVICE_ID\" to  update_allowed in this patch. And what do you think about this?\n\nThanks very much.","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6bcc0397a8bddb06fcfd6d2c8f1f6f1b8ada6b29","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix errors on OS::Neutron::Port resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. The properties \"NAME\" and \"DEVICE_ID\" should be update_allowed."},{"line_number":10,"context_line":"2. The properties_schema missing \"DEVICE_OWNER\" and \"TENANT_ID\""},{"line_number":11,"context_line":"definition."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5fa9eab2493e7b60d1540fffc4f883ff362f4847"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BbnA%3D","line":10,"updated":"2014-01-26 20:18:48.000000000","message":"We are not adding neutron tenant_id properties until we\u0027ve figured out the right way to handle access control to admin-like properties.","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"e684537923adf2627d85c32e6c2df47a5a7af2d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix errors on OS::Neutron::Port resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. The properties \"NAME\" and \"DEVICE_ID\" should be update_allowed."},{"line_number":10,"context_line":"2. The properties_schema missing \"DEVICE_OWNER\" and \"TENANT_ID\""},{"line_number":11,"context_line":"definition."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5fa9eab2493e7b60d1540fffc4f883ff362f4847"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BaPA%3D","line":10,"in_reply_to":"AAAAUH%2F%2BbnA%3D","updated":"2014-01-27 08:40:26.000000000","message":"Done.","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"}],"heat/engine/resources/neutron/port.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"6bcc0397a8bddb06fcfd6d2c8f1f6f1b8ada6b29","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        ),"},{"line_number":129,"context_line":"        DEVICE_OWNER: properties.Schema("},{"line_number":130,"context_line":"            properties.Schema.STRING,"},{"line_number":131,"context_line":"            _(\u0027Device owner of this port.\u0027),"},{"line_number":132,"context_line":"            update_allowed\u003dTrue"},{"line_number":133,"context_line":"        ),"},{"line_number":134,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Bbmw%3D","line":131,"updated":"2014-01-26 20:18:48.000000000","message":"A better description of what this property is for and what values are expected would be good.","commit_id":"1cf4805835f484e1afbbbfe430a3c5645bfc5426"}]}