)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"d8854630048c2df07b9b9bc82913472e3c98de8b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huangtianhua \u003chuangtianhua@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 12:41:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes environment file not using the YAML format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An internal unexpected exception is raised while create a stack with an"},{"line_number":10,"context_line":"environment file which only has string content. We should handle the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BSg0%3D","line":7,"updated":"2014-01-28 11:16:04.000000000","message":"IMO, \u0027not using\u0027 sounds like we will not use YAML format at all.\nHow about: \u0027... using correct (acceptable) YAML format\u0027?","commit_id":"77ce611b3d582bd1a12f582abaa93e98df6ff2ff"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8485a2e887ce5a7ad19b00a062907848aeb273a2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huangtianhua \u003chuangtianhua@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 12:41:46 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes environment file not using the YAML format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An internal unexpected exception is raised while create a stack with an"},{"line_number":10,"context_line":"environment file which only has string content. We should handle the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BRVw%3D","line":7,"in_reply_to":"AAAAUH%2F%2BSg0%3D","updated":"2014-01-28 14:34:11.000000000","message":"Done","commit_id":"77ce611b3d582bd1a12f582abaa93e98df6ff2ff"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"d8854630048c2df07b9b9bc82913472e3c98de8b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"format\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie226d122593dd97c3607c269899c0743a9d917d3"},{"line_number":15,"context_line":"Closes-Bug: #bug/1273538"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BSig%3D","line":15,"updated":"2014-01-28 11:16:04.000000000","message":"Please add correct link to bug description.","commit_id":"77ce611b3d582bd1a12f582abaa93e98df6ff2ff"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"8485a2e887ce5a7ad19b00a062907848aeb273a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"format\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie226d122593dd97c3607c269899c0743a9d917d3"},{"line_number":15,"context_line":"Closes-Bug: #bug/1273538"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BRVs%3D","line":15,"in_reply_to":"AAAAUH%2F%2BSig%3D","updated":"2014-01-28 14:34:11.000000000","message":"Done","commit_id":"77ce611b3d582bd1a12f582abaa93e98df6ff2ff"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"b4d299393f2bf17a77f7a6dad5ba3a189cd946d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     huangtianhua \u003chuangtianhua@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-28 22:39:38 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes environment file using correct YAML format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An internal unexpected exception is raised while create a stack with an"},{"line_number":10,"context_line":"environment file which only has string content. We should handle the case"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BJ%2B0%3D","line":7,"updated":"2014-01-29 16:26:38.000000000","message":"I\u0027d prefer something like:\n\n Verify that parsed environment file maps to a dictionary","commit_id":"99aff9138a57647afa77332968b221a2a2b7e1b8"},{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"e2f49bd3034d0cde6223caa20aad93385aa82d06","unresolved":false,"context_lines":[{"line_number":12,"context_line":"mapping\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie226d122593dd97c3607c269899c0743a9d917d3"},{"line_number":15,"context_line":"Closes-Bug: #bug/1273538"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUX%2F%2F3gU%3D","line":15,"updated":"2014-02-10 09:36:48.000000000","message":"Hm. I have thought, that you have fixed it. Unfortunately, it still doen\u0027t work. So please use:\n\nCloses-Bug: #1273538\ninstead \nCloses-Bug: #bug/1273538","commit_id":"f6556b74f8df77ff4d615cc864556efb151d2801"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9f89053c2d5b31dc0bff52ec157ef4318cd76527","unresolved":false,"context_lines":[{"line_number":12,"context_line":"mapping\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie226d122593dd97c3607c269899c0743a9d917d3"},{"line_number":15,"context_line":"Closes-Bug: #bug/1273538"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUX%2F%2FwSo%3D","line":15,"in_reply_to":"AAAAUX%2F%2F3gU%3D","updated":"2014-02-11 01:19:09.000000000","message":"Done","commit_id":"f6556b74f8df77ff4d615cc864556efb151d2801"}],"heat/common/environment_format.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"d8854630048c2df07b9b9bc82913472e3c98de8b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027\u0027"},{"line_number":26,"context_line":"    Takes a string and returns a dict containing the parsed structure."},{"line_number":27,"context_line":"    This includes determination of whether the string is using the"},{"line_number":28,"context_line":"    YAML format."},{"line_number":29,"context_line":"    \u0027\u0027\u0027"},{"line_number":30,"context_line":"    try:"},{"line_number":31,"context_line":"        env \u003d yaml.load(env_str, Loader\u003dyaml_loader)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSjE%3D","line":28,"updated":"2014-01-28 11:16:04.000000000","message":"Hm. It looks very confusing. I don\u0027t know why it was (JSON or YAML).\nI agree with you, because in code we only try parse yaml format.","commit_id":"77ce611b3d582bd1a12f582abaa93e98df6ff2ff"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"b4d299393f2bf17a77f7a6dad5ba3a189cd946d3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            env \u003d {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if not isinstance(env, dict):"},{"line_number":39,"context_line":"        raise ValueError(_(\u0027The environment is not YAML mapping.\u0027))"},{"line_number":40,"context_line":"    for param in env:"},{"line_number":41,"context_line":"        if param not in SECTIONS:"},{"line_number":42,"context_line":"            raise ValueError(_(\u0027environment has wrong section \"%s\"\u0027) % param)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BJ9k%3D","line":39,"updated":"2014-01-29 16:26:38.000000000","message":"Regarding the error message, this isn\u0027t technically true.  An environment file could contain nothing but a YAML list and still be valid YAML, but not a valid environment file.","commit_id":"99aff9138a57647afa77332968b221a2a2b7e1b8"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"1c76a371cb9666eafe0b80c5e04cd2d80741bb7d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            env \u003d {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if not isinstance(env, dict):"},{"line_number":39,"context_line":"        raise ValueError(_(\u0027The environment is not YAML mapping.\u0027))"},{"line_number":40,"context_line":"    for param in env:"},{"line_number":41,"context_line":"        if param not in SECTIONS:"},{"line_number":42,"context_line":"            raise ValueError(_(\u0027environment has wrong section \"%s\"\u0027) % param)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2F6GU%3D","line":39,"in_reply_to":"AAAAUH%2F%2BJ9k%3D","updated":"2014-02-10 02:10:52.000000000","message":"Thanks.\nIn my opinion, the list is a valid Yaml format, but isn\u0027t yaml mapping. What do you think about?","commit_id":"99aff9138a57647afa77332968b221a2a2b7e1b8"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"a772c58eb5d52243417b451a62ae5cfd38ae7578","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            env \u003d {}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    if not isinstance(env, dict):"},{"line_number":40,"context_line":"        raise ValueError(_(\u0027The environment is not YAML mapping.\u0027))"},{"line_number":41,"context_line":"    for param in env:"},{"line_number":42,"context_line":"        if param not in SECTIONS:"},{"line_number":43,"context_line":"            raise ValueError(_(\u0027environment has wrong section \"%s\"\u0027) % param)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F0sE%3D","line":40,"updated":"2014-02-10 15:57:21.000000000","message":"How about: \"The environment is not a valid YAML mapping data type.\"","commit_id":"f6556b74f8df77ff4d615cc864556efb151d2801"},{"author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"change_message_id":"9f89053c2d5b31dc0bff52ec157ef4318cd76527","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            env \u003d {}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    if not isinstance(env, dict):"},{"line_number":40,"context_line":"        raise ValueError(_(\u0027The environment is not YAML mapping.\u0027))"},{"line_number":41,"context_line":"    for param in env:"},{"line_number":42,"context_line":"        if param not in SECTIONS:"},{"line_number":43,"context_line":"            raise ValueError(_(\u0027environment has wrong section \"%s\"\u0027) % param)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2FwSk%3D","line":40,"in_reply_to":"AAAAUX%2F%2F0sE%3D","updated":"2014-02-11 01:19:09.000000000","message":"Done","commit_id":"f6556b74f8df77ff4d615cc864556efb151d2801"}]}