)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"cd781b7810b97ded20b7486aaae6349e7a6a36cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nafiz Haider \u003cnafizhaider22@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-25 23:41:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update OS::Nova::Quota Resource to remove injected_file_content_bytes and injected_files properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2006937"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_38001167","line":7,"updated":"2019-11-26 13:39:46.000000000","message":"Commit message needs to be more detailed; the storyboard is good obviously but the commit needs to be self-explanatory.","commit_id":"13da6c5e602cb38d88231661ca84fc5aa927d640"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b4a0eb70346c2ff9304cbe190e5c56a8a4f82ac6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nafiz Haider \u003cnafizhaider22@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-11 21:32:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update OS::Nova::Quota Resource to remove injected_file_content_bytes, injected_file_path_bytes, and injected_files properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following properties are deprecated in nova and need to be removed from the nova quota resource."},{"line_number":10,"context_line":"Corresponding nova PS deprecating properties:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_380ca337","line":7,"updated":"2019-12-13 02:11:53.000000000","message":"A shorter title for this would be good. e.g.\n\n  Deprecate injected_file properties in Nova Quota","commit_id":"234fe5a7528f06186f5db5dc13b26d7b539e5298"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b4a0eb70346c2ff9304cbe190e5c56a8a4f82ac6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update OS::Nova::Quota Resource to remove injected_file_content_bytes, injected_file_path_bytes, and injected_files properties"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following properties are deprecated in nova and need to be removed from the nova quota resource."},{"line_number":10,"context_line":"Corresponding nova PS deprecating properties:"},{"line_number":11,"context_line":"https://review.opendev.org/#/c/509013/"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_f8112b51","line":9,"updated":"2019-12-13 02:11:53.000000000","message":"Ideally lines should be wrapped at \u003c\u003d72 columns.","commit_id":"234fe5a7528f06186f5db5dc13b26d7b539e5298"}],"heat/engine/resources/openstack/nova/quota.py":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"cd781b7810b97ded20b7486aaae6349e7a6a36cf","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    PROPERTIES \u003d ("},{"line_number":55,"context_line":"        PROJECT, CORES, FIXED_IPS, FLOATING_IPS, INSTANCES,"},{"line_number":56,"context_line":"        INJECTED_FILE_PATH_BYTES,"},{"line_number":57,"context_line":"        KEYPAIRS, METADATA_ITEMS, RAM, SECURITY_GROUPS, SECURITY_GROUP_RULES,"},{"line_number":58,"context_line":"        SERVER_GROUPS, SERVER_GROUP_MEMBERS"},{"line_number":59,"context_line":"    ) \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_78068988","line":56,"updated":"2019-11-26 13:39:46.000000000","message":"nit pick:\n\nthis seems like it needs whitespace formatting work to me","commit_id":"13da6c5e602cb38d88231661ca84fc5aa927d640"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"05e382d2a2472ddb6e27fd908b3d8f11ff4c4c84","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            properties.Schema.STRING,"},{"line_number":70,"context_line":"            _(\u0027Name or id of the project to set the quota for.\u0027),"},{"line_number":71,"context_line":"            required\u003dTrue,"},{"line_number":72,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u00278.0.0\u0027),"},{"line_number":73,"context_line":"            constraints\u003d["},{"line_number":74,"context_line":"                constraints.CustomConstraint(\u0027keystone.project\u0027)"},{"line_number":75,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_635e0a46","line":72,"updated":"2019-12-11 16:59:47.000000000","message":"Please don\u0027t add a SupportStatus to properties that are not changing.","commit_id":"8e150a8f71343f78cde92d01c6cb804329e0bf3f"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"a40b0ebd054643a2ca1d995f9dd4930c3479cdca","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            properties.Schema.STRING,"},{"line_number":70,"context_line":"            _(\u0027Name or id of the project to set the quota for.\u0027),"},{"line_number":71,"context_line":"            required\u003dTrue,"},{"line_number":72,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u00278.0.0\u0027),"},{"line_number":73,"context_line":"            constraints\u003d["},{"line_number":74,"context_line":"                constraints.CustomConstraint(\u0027keystone.project\u0027)"},{"line_number":75,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_78a1d439","line":72,"in_reply_to":"3fa7e38b_635e0a46","updated":"2019-12-13 20:46:13.000000000","message":"Should I leave the support_status variable as is in line 50 of the file, and remove all support_status declarations for the properties that aren\u0027t changing?","commit_id":"8e150a8f71343f78cde92d01c6cb804329e0bf3f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"05e382d2a2472ddb6e27fd908b3d8f11ff4c4c84","unresolved":false,"context_lines":[{"line_number":120,"context_line":"              \u0027Setting the value to -1 removes the limit.\u0027),"},{"line_number":121,"context_line":"            support_status\u003dsupport.SupportStatus("},{"line_number":122,"context_line":"                status\u003dsupport.DEPRECATED,"},{"line_number":123,"context_line":"                version\u003d\u00278.0.0\u0027,"},{"line_number":124,"context_line":"                message\u003d_(\u0027File injection is deprecated \u0027"},{"line_number":125,"context_line":"                          \u0027from compute REST API \u0027"},{"line_number":126,"context_line":"                          \u0027OS::Nova::Quota resource will not support \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_953fb9b3","line":123,"updated":"2019-12-11 16:59:47.000000000","message":"Next release is 14.0.0, not 8.0.0.","commit_id":"8e150a8f71343f78cde92d01c6cb804329e0bf3f"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b4a0eb70346c2ff9304cbe190e5c56a8a4f82ac6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u00278.0.0\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    default_client_name \u003d \u0027nova\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    entity \u003d \u0027quotas\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_150c1040","side":"PARENT","line":51,"updated":"2019-12-13 02:11:53.000000000","message":"It\u0027d be best if we could not make unrelated whitespace changes.","commit_id":"ed7add1638b862cb5e682fea2c70fb104eb65d87"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b4a0eb70346c2ff9304cbe190e5c56a8a4f82ac6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            constraints\u003d["},{"line_number":119,"context_line":"                constraints.Range(min\u003d-1),"},{"line_number":120,"context_line":"            ],"},{"line_number":121,"context_line":"            update_allowed\u003dTrue"},{"line_number":122,"context_line":"        ),"},{"line_number":123,"context_line":"        INJECTED_FILE_CONTENT_BYTES: properties.Schema("},{"line_number":124,"context_line":"            properties.Schema.INTEGER,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_550e083d","side":"PARENT","line":121,"updated":"2019-12-13 02:11:53.000000000","message":"I don\u0027t think we should remove update_allowed\u003dTrue, as this will cause resources to get replaced if e.g. users update their existing stack to remove these properties.","commit_id":"ed7add1638b862cb5e682fea2c70fb104eb65d87"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b4a0eb70346c2ff9304cbe190e5c56a8a4f82ac6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            constraints\u003d["},{"line_number":128,"context_line":"                constraints.Range(min\u003d-1),"},{"line_number":129,"context_line":"            ],"},{"line_number":130,"context_line":"            update_allowed\u003dTrue"},{"line_number":131,"context_line":"        ),"},{"line_number":132,"context_line":"        INJECTED_FILE_PATH_BYTES: properties.Schema("},{"line_number":133,"context_line":"            properties.Schema.INTEGER,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_7511c45b","side":"PARENT","line":130,"updated":"2019-12-13 02:11:53.000000000","message":"ditto","commit_id":"ed7add1638b862cb5e682fea2c70fb104eb65d87"}]}