)]}'
{"heat/engine/clients/client_plugin.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"024dbf34756eb86dd33f1ffdbfe31647d8fa62e7","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"def retry_if_connection_err(exception):"},{"line_number":189,"context_line":"    if isinstance(exception, requests.ConnectionError) or isinstance("},{"line_number":190,"context_line":"            exception, exceptions.ConnectionError):"},{"line_number":191,"context_line":"        return True"},{"line_number":192,"context_line":"    return False"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_30acfae9","line":190,"updated":"2020-02-11 14:19:48.000000000","message":"simpler syntax:\n\n  return isinstance(exception, (requests.ConnectionError, exceptions.ConnectionError))","commit_id":"1d36d46b07d3448dfd1cf204a7887dce56f1b95d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a3f5851cbc940b467ce1cdc7f1125fc3ac29478a","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"def retry_if_connection_err(exception):"},{"line_number":189,"context_line":"    if isinstance(exception, ("},{"line_number":190,"context_line":"            requests.ConnectionError, exceptions.RetriableConnectionFailure)):"},{"line_number":191,"context_line":"        return True"},{"line_number":192,"context_line":"    return False"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_ab0e2d30","line":190,"range":{"start_line":190,"start_character":38,"end_line":190,"end_character":76},"updated":"2020-02-12 13:46:57.000000000","message":"Did you see issue on master? Did you try increasing \u0027client_retry_limit\u0027 in heat.conf?\n\nWe do allow keystone retries[1] with[2][3]\n\n\n[1] https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L1026-L1028\n\n[2] https://github.com/openstack/heat/blob/stable/queens/heat/engine/clients/os/nova.py#L90\n\n[3] https://github.com/openstack/heat/commit/54f1119d695270bc0b92a27c84e332b102846b51#diff-c23b69996a4fccb21697528e1901f0a5 (not backported)\n\nGood to have details of issues you faced and surely a bug would help.","commit_id":"e3f2ae09140938669078f11212a024776910984e"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"362a7fea0d106a64de4c5331986e0ce4364d4c61","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"def retry_if_connection_err(exception):"},{"line_number":189,"context_line":"    if isinstance(exception, ("},{"line_number":190,"context_line":"            requests.ConnectionError, exceptions.RetriableConnectionFailure)):"},{"line_number":191,"context_line":"        return True"},{"line_number":192,"context_line":"    return False"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_da15514d","line":190,"range":{"start_line":190,"start_character":38,"end_line":190,"end_character":76},"in_reply_to":"3fa7e38b_ab0e2d30","updated":"2020-02-14 02:56:15.000000000","message":"Thanks for pointing out the links, I encounter this issue on queens. \n\nFrom the codes you pasted, I guess this issue was fixed in master.","commit_id":"e3f2ae09140938669078f11212a024776910984e"}]}