)]}'
{"heat/api/openstack/v1/stacks.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"cfe3430e457e4d184089374ed7bec9a22b40398b","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                              data.args())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        if \u0027Error\u0027 in result:"},{"line_number":244,"context_line":"            raise exc.HTTPBadRequest(result[\u0027Error\u0027])"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        formatted_stack \u003d stacks_view.format_stack("},{"line_number":247,"context_line":"            req,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fvc0%3D","line":244,"updated":"2014-03-04 11:10:24.000000000","message":"Do we need a text search for Error here, shouldn\u0027t all error paths raise an exception and the mapping to HTTPBadRequest happen in the FaultWrapper code?","commit_id":"1892bb655f09af792953bef826532e9945a51665"}],"heat/engine/constraints.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"cfe3430e457e4d184089374ed7bec9a22b40398b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            for constraint in self.constraints:"},{"line_number":151,"context_line":"                constraint.validate(value)"},{"line_number":152,"context_line":"                constraint.validate(value, context)"},{"line_number":153,"context_line":"        except ValueError as ex:"},{"line_number":154,"context_line":"            raise exception.StackValidationFailed(message\u003dstr(ex))"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2FveM%3D","line":152,"updated":"2014-03-04 11:10:24.000000000","message":"Why are we validating the constraint twice?","commit_id":"1892bb655f09af792953bef826532e9945a51665"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"e94e03dff72879e237e27b9c2fd08e7bdabd46f3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        try:"},{"line_number":150,"context_line":"            for constraint in self.constraints:"},{"line_number":151,"context_line":"                constraint.validate(value)"},{"line_number":152,"context_line":"                constraint.validate(value, context)"},{"line_number":153,"context_line":"        except ValueError as ex:"},{"line_number":154,"context_line":"            raise exception.StackValidationFailed(message\u003dstr(ex))"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fuyc%3D","line":152,"in_reply_to":"AAAAVn%2F%2FveM%3D","updated":"2014-03-04 12:37:03.000000000","message":"I made a mistake during the latest rebase.","commit_id":"1892bb655f09af792953bef826532e9945a51665"}],"heat/engine/service.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"cfe3430e457e4d184089374ed7bec9a22b40398b","unresolved":false,"context_lines":[{"line_number":444,"context_line":"            stack \u003d parser.Stack(cnxt, stack_name, tmpl,"},{"line_number":445,"context_line":"                                 env, **common_params)"},{"line_number":446,"context_line":"        except exception.StackValidationFailed as ex:"},{"line_number":447,"context_line":"            return {\u0027Error\u0027: str(ex)}"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        self._validate_deferred_auth_context(cnxt, stack)"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fva0%3D","line":447,"updated":"2014-03-04 11:10:24.000000000","message":"This seems like a mistake to me, isn\u0027t this what rpc_common.client_exceptions and FaultWrapper etc are supposed to do for us?","commit_id":"1892bb655f09af792953bef826532e9945a51665"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"e94e03dff72879e237e27b9c2fd08e7bdabd46f3","unresolved":false,"context_lines":[{"line_number":444,"context_line":"            stack \u003d parser.Stack(cnxt, stack_name, tmpl,"},{"line_number":445,"context_line":"                                 env, **common_params)"},{"line_number":446,"context_line":"        except exception.StackValidationFailed as ex:"},{"line_number":447,"context_line":"            return {\u0027Error\u0027: str(ex)}"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        self._validate_deferred_auth_context(cnxt, stack)"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Fuxc%3D","line":447,"in_reply_to":"AAAAVn%2F%2Fva0%3D","updated":"2014-03-04 12:37:03.000000000","message":"You\u0027re right! I wrongly tried to copy the behavior from validate_template. Presumably we may want to fix it there at some point.","commit_id":"1892bb655f09af792953bef826532e9945a51665"}]}