)]}'
{"devstack/lib/heat":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"c924a108d09b951b8e0d8a2a50c58ef3fb412473","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    iniset $HEAT_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    # reduce Heat engine workers"},{"line_number":139,"context_line":"    iniset $HEAT_CONF DEFAULT num_engine_workers \"$API_WORKERS\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    local no_format\u003d\"False\""},{"line_number":142,"context_line":"    if [[ \"$HEAT_USE_APACHE\" \u003d\u003d \"True\" \u0026\u0026 \"$WSGI_MODE\" !\u003d \"uwsgi\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df33271e_61289285","line":139,"range":{"start_line":139,"start_character":51,"end_line":139,"end_character":62},"updated":"2020-04-10 08:52:22.000000000","message":"I think we can use new variable like `HEAT_ENGINE_WORKWRS` since I might be confused when using API_WORKERS for engine side","commit_id":"b1bd6a809de7342c7af0b8df0ced1571d2c94a83"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"d4bff64a567e819c1cd393fa511ab9deb5359c68","unresolved":false,"context_lines":[{"line_number":78,"context_line":"fi"},{"line_number":79,"context_line":"HEAT_PLUGIN_DIR\u003d${HEAT_PLUGIN_DIR:-$DATA_DIR/heat/plugins}"},{"line_number":80,"context_line":"ENABLE_HEAT_PLUGINS\u003d${ENABLE_HEAT_PLUGINS:-}"},{"line_number":81,"context_line":"HEAT_ENGINE_WORKERS\u003d${HEAT_ENGINE_WORKERS:-$API_WORKERS}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Functions"},{"line_number":84,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f4c43b2_f9d6b0f1","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":56},"updated":"2020-04-13 05:59:31.000000000","message":"We don\u0027t have exact correlation between the number of API_WORKERS vs HEAT_ENGINE_WORKERS. Though the default of cpu count[1] can probably be a stretch at times.\n\nDo we see any issues with the current default with devstack? I don\u0027t see any bugs linked..\n\n[1] https://github.com/openstack/heat/blob/master/heat/cmd/engine.py#L74","commit_id":"6abdac7989251f7e6068c7d9f78e94a43ec4e469"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"0c96257681090f8c6678c0407b1a8bc88c358647","unresolved":false,"context_lines":[{"line_number":78,"context_line":"fi"},{"line_number":79,"context_line":"HEAT_PLUGIN_DIR\u003d${HEAT_PLUGIN_DIR:-$DATA_DIR/heat/plugins}"},{"line_number":80,"context_line":"ENABLE_HEAT_PLUGINS\u003d${ENABLE_HEAT_PLUGINS:-}"},{"line_number":81,"context_line":"HEAT_ENGINE_WORKERS\u003d${HEAT_ENGINE_WORKERS:\u003d$(( ($(nproc)/4)\u003c2 ? 2 : ($(nproc)/4) ))}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Functions"},{"line_number":84,"context_line":"# ---------"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f4c43b2_06c0147b","line":81,"range":{"start_line":81,"start_character":43,"end_line":81,"end_character":83},"updated":"2020-04-16 06:05:47.000000000","message":"you don\u0027t need to specify default value here (as it\u0027s not much difference with the default). We can just avoid running $HEAT_CONF DEFAULT num_engine_workers \"$HEAT_ENGINE_WORKERS\" if HEAT_ENGINE_WORKERS is not set.","commit_id":"a3be28bed790f2603dc59f8ad0d179183605d7ba"}]}