)]}'
{"heat/engine/resources/openstack/glance/image.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"567413fa42f31b1f99c545565655084dc971d777","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            # calling format to images.update"},{"line_number":224,"context_line":"            images.update(self.resource_id, remove_props, **prop_diff)"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            images.update(self.resource_id, **prop_diff)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def validate(self):"},{"line_number":229,"context_line":"        super(GlanceWebImage, self).validate()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f493fa4_89013c6d","line":226,"updated":"2020-04-30 19:13:49.000000000","message":"why not just set remove_props \u003d None (or []) and then only have one call to images.update() outside the if/else?","commit_id":"b887d096784ebe2135a51a2ce157eb442b70be5e"},{"author":{"_account_id":30495,"name":"Nafiz Haider","email":"nafizhaider22@gmail.com","username":"nafh27"},"change_message_id":"b1c39b8421bfb861b79a3b2fb4c70b3717e6032e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            # calling format to images.update"},{"line_number":224,"context_line":"            images.update(self.resource_id, remove_props, **prop_diff)"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            images.update(self.resource_id, **prop_diff)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def validate(self):"},{"line_number":229,"context_line":"        super(GlanceWebImage, self).validate()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_108ff1cc","line":226,"in_reply_to":"1f493fa4_89013c6d","updated":"2020-05-12 06:01:33.000000000","message":"Updated in my latest PS along with concerns for overriding existing properties","commit_id":"b887d096784ebe2135a51a2ce157eb442b70be5e"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"aa0fc7c319958c1b0708b5742f4fb90dbb0f0d28","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            _(\u0027Arbitrary properties to associate with the image.\u0027),"},{"line_number":115,"context_line":"            update_allowed\u003dTrue,"},{"line_number":116,"context_line":"            default\u003d{}"},{"line_number":117,"context_line":"        ),"},{"line_number":118,"context_line":"        ARCHITECTURE: properties.Schema("},{"line_number":119,"context_line":"            properties.Schema.STRING,"},{"line_number":120,"context_line":"            _(\u0027Operating system architecture.\u0027),"}],"source_content_type":"text/x-python","patch_set":20,"id":"ff570b3c_5f30dfe8","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":10},"updated":"2020-05-15 17:12:07.000000000","message":"support_status\u003dsupport.SupportStatus(version\u003d\u002715.0.0\u0027),","commit_id":"9eda22ca679451525c4d984354eaf6e9274bc412"}]}
