)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e90d02f9245e629d393532c838f16ee346bb7aff","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic4c50b36d40592e1159827376ef78eaa86c31b53"},{"line_number":20,"context_line":"Task: #39994"},{"line_number":21,"context_line":"Story: #39994"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_4e779ed5","line":21,"updated":"2020-06-19 21:40:37.000000000","message":"2007770","commit_id":"e17d05cd93d19a0d678ecc332a68d774769f8b0e"}],"heat/engine/resources/openstack/cinder/qos_specs.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e90d02f9245e629d393532c838f16ee346bb7aff","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        for vt in self.properties[self.VOLUME_TYPES]:"},{"line_number":162,"context_line":"            self.client().qos_specs.associate(self.properties[self.QOS_SPECS],"},{"line_number":163,"context_line":"                                              vt)"},{"line_number":164,"context_line":"            self.resource_id_set(self.properties[self.QOS_SPECS])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":167,"context_line":"        \"\"\"Associate volume types to QoS.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8e81b692","line":164,"updated":"2020-06-19 21:40:37.000000000","message":"This could be slightly dangerous, as it\u0027s also likely the physical resource id of another resource, and it is possible to look up resources by physical resource id. So theoretically this could break someone who expected that lookup to find a unique resource.\n\nI\u0027d suggest using self.uuid instead.","commit_id":"e17d05cd93d19a0d678ecc332a68d774769f8b0e"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"43e8d160f64dcec4acdad118bce97e9d4ee9c112","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        for vt in self.properties[self.VOLUME_TYPES]:"},{"line_number":162,"context_line":"            self.client().qos_specs.associate(self.properties[self.QOS_SPECS],"},{"line_number":163,"context_line":"                                              vt)"},{"line_number":164,"context_line":"            self.resource_id_set(self.uuid)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":167,"context_line":"        \"\"\"Associate volume types to QoS.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_b3860813","line":164,"updated":"2020-07-17 21:28:24.000000000","message":"Not sure why this is inside the for loop?","commit_id":"bb71d6b95dffbb1e7c6970f1c2111d1423f6f7ad"},{"author":{"_account_id":32068,"name":"Arun Vinod","email":"arunvinod.tech@gmail.com","username":"arva"},"change_message_id":"dedd516e7edf05bcf4161fbfcafe5b70efaf95df","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        for vt in self.properties[self.VOLUME_TYPES]:"},{"line_number":162,"context_line":"            self.client().qos_specs.associate(self.properties[self.QOS_SPECS],"},{"line_number":163,"context_line":"                                              vt)"},{"line_number":164,"context_line":"            self.resource_id_set(self.uuid)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":167,"context_line":"        \"\"\"Associate volume types to QoS.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_2e4fcabe","line":164,"in_reply_to":"bf51134e_63f71ed6","updated":"2020-07-29 08:57:00.000000000","message":"Done","commit_id":"bb71d6b95dffbb1e7c6970f1c2111d1423f6f7ad"},{"author":{"_account_id":32068,"name":"Arun Vinod","email":"arunvinod.tech@gmail.com","username":"arva"},"change_message_id":"9f78bfa23a3c17b42e2fc68c89092576a00b0e55","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        for vt in self.properties[self.VOLUME_TYPES]:"},{"line_number":162,"context_line":"            self.client().qos_specs.associate(self.properties[self.QOS_SPECS],"},{"line_number":163,"context_line":"                                              vt)"},{"line_number":164,"context_line":"            self.resource_id_set(self.uuid)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":167,"context_line":"        \"\"\"Associate volume types to QoS.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_bb11b607","line":164,"in_reply_to":"bf51134e_b3860813","updated":"2020-07-20 07:54:27.000000000","message":"I guess,its because when we have multiple volume types to associate a single qos, each association must have the unique id. Hence, we can make sure each qos-association resource should be unique in terms of resource_id","commit_id":"bb71d6b95dffbb1e7c6970f1c2111d1423f6f7ad"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"00e760d690c54de0b8846c51f2dc37520fbdd48e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        for vt in self.properties[self.VOLUME_TYPES]:"},{"line_number":162,"context_line":"            self.client().qos_specs.associate(self.properties[self.QOS_SPECS],"},{"line_number":163,"context_line":"                                              vt)"},{"line_number":164,"context_line":"            self.resource_id_set(self.uuid)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def handle_update(self, json_snippet, tmpl_diff, prop_diff):"},{"line_number":167,"context_line":"        \"\"\"Associate volume types to QoS.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_63f71ed6","line":164,"in_reply_to":"bf51134e_bb11b607","updated":"2020-07-24 03:04:03.000000000","message":"1. There\u0027s only one resource ID, so the last one wins.\n2. self.uuid is constant.","commit_id":"bb71d6b95dffbb1e7c6970f1c2111d1423f6f7ad"}]}