)]}'
{"heat/engine/hot/__init__.py":[{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"21993589f88e6aecc726ad548d3eb9261ad1ee64","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        if stack_identifier is not None:"},{"line_number":230,"context_line":"            self.params[self.PARAM_STACK_ID].schema.set_default("},{"line_number":231,"context_line":"                stack_identifier.stack_id)"},{"line_number":232,"context_line":"            return True"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _pseudo_parameters(self, stack_identifier):"},{"line_number":235,"context_line":"        stack_id \u003d getattr(stack_identifier, \u0027stack_id\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F4cs%3D","line":232,"updated":"2014-03-03 16:50:38.000000000","message":"Why are you not throwing an exception anymore if the ID is None? I get the \"return True\" bot was wondering about the removed exception.","commit_id":"888cd7d11e1ccd76ce9eab40588822872da95ceb"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"458d42ebc92d02fa618de2649380822793a3c76d","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        if stack_identifier is not None:"},{"line_number":230,"context_line":"            self.params[self.PARAM_STACK_ID].schema.set_default("},{"line_number":231,"context_line":"                stack_identifier.stack_id)"},{"line_number":232,"context_line":"            return True"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _pseudo_parameters(self, stack_identifier):"},{"line_number":235,"context_line":"        stack_id \u003d getattr(stack_identifier, \u0027stack_id\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F3Qk%3D","line":232,"in_reply_to":"AAAAVn%2F%2F4aM%3D","updated":"2014-03-03 18:39:45.000000000","message":"Ok, got it. I was missing that one piece.","commit_id":"888cd7d11e1ccd76ce9eab40588822872da95ceb"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"67f87bcc3d0329f267f5c3e6cbb13924c9ceed19","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        if stack_identifier is not None:"},{"line_number":230,"context_line":"            self.params[self.PARAM_STACK_ID].schema.set_default("},{"line_number":231,"context_line":"                stack_identifier.stack_id)"},{"line_number":232,"context_line":"            return True"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _pseudo_parameters(self, stack_identifier):"},{"line_number":235,"context_line":"        stack_id \u003d getattr(stack_identifier, \u0027stack_id\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FsXI%3D","line":232,"in_reply_to":"AAAAVn%2F%2F4aM%3D","updated":"2014-03-04 16:33:56.000000000","message":"We should explicitly return False in the failure case rather than either returning True or implicitly returning None. In heat.engine.properties as well.","commit_id":"888cd7d11e1ccd76ce9eab40588822872da95ceb"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"7eda4d96165785d4bea8b9f19cb0b77c22f07632","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        if stack_identifier is not None:"},{"line_number":230,"context_line":"            self.params[self.PARAM_STACK_ID].schema.set_default("},{"line_number":231,"context_line":"                stack_identifier.stack_id)"},{"line_number":232,"context_line":"            return True"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _pseudo_parameters(self, stack_identifier):"},{"line_number":235,"context_line":"        stack_id \u003d getattr(stack_identifier, \u0027stack_id\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F4aM%3D","line":232,"in_reply_to":"AAAAVn%2F%2F4cs%3D","updated":"2014-03-03 16:53:21.000000000","message":"Well in Stack._set_stack_id we consider the False clause as a warning. I don\u0027t get why it would be an exception for HOT for not for CFN.","commit_id":"888cd7d11e1ccd76ce9eab40588822872da95ceb"}]}