)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fb9d66c594b93f1ad350a49c79ebd20ee72789f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Baker \u003csbaker@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-19 08:30:30 +1300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow stack domain credentials to be used for deployments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to allow stack domain credentials to be used for"},{"line_number":10,"context_line":"deployments operations, the stack_user_project_id needs to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FAaI%3D","line":7,"updated":"2014-03-21 00:21:49.000000000","message":"This is \u003e 50 chars","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ef549976e85c507e2fd5a4ecf3150257713b187","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Baker \u003csbaker@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-19 08:30:30 +1300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow stack domain credentials to be used for deployments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to allow stack domain credentials to be used for"},{"line_number":10,"context_line":"deployments operations, the stack_user_project_id needs to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2B1AY%3D","line":7,"in_reply_to":"AAAAWH%2F%2FAaI%3D","updated":"2014-03-23 23:49:42.000000000","message":"Done","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fb9d66c594b93f1ad350a49c79ebd20ee72789f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to allow stack domain credentials to be used for"},{"line_number":10,"context_line":"deployments operations, the stack_user_project_id needs to"},{"line_number":11,"context_line":"be passed on deployment create and stored in the database."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"stack_user_project_id can then be used to compare to the context"},{"line_number":14,"context_line":"tenant_id, just as for stack_get."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2FAZ0%3D","line":11,"updated":"2014-03-21 00:21:49.000000000","message":"I feel like \"deployments\" and \"deployment\" need quotations, as they are not being used as standard terms, but jargon/identifiers for Heat resources.","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ef549976e85c507e2fd5a4ecf3150257713b187","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to allow stack domain credentials to be used for"},{"line_number":10,"context_line":"deployments operations, the stack_user_project_id needs to"},{"line_number":11,"context_line":"be passed on deployment create and stored in the database."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"stack_user_project_id can then be used to compare to the context"},{"line_number":14,"context_line":"tenant_id, just as for stack_get."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2B1AQ%3D","line":11,"in_reply_to":"AAAAWH%2F%2FAZ0%3D","updated":"2014-03-23 23:49:42.000000000","message":"I\u0027ve reworded a bit and elaborated.","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"520705ddc102b8bbdd7e4e9b8ec77e51f0be97b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This change is needed since the blueprint hot-software-config and"},{"line_number":18,"context_line":"blueprint instance-users landed at the same time. Some stack"},{"line_number":19,"context_line":"operations can now be performed with credentials which are scoped"},{"line_number":20,"context_line":"to a single resource. It would be very useful allow these credentials"},{"line_number":21,"context_line":"to be used for that polling for deployment metadata too."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1293234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2BvP4%3D","line":20,"updated":"2014-03-24 17:56:56.000000000","message":"s/useful allow/useful to allow/","commit_id":"2708d2a8029b75e1f11e1dada429401ac7562609"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"520705ddc102b8bbdd7e4e9b8ec77e51f0be97b8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"blueprint instance-users landed at the same time. Some stack"},{"line_number":19,"context_line":"operations can now be performed with credentials which are scoped"},{"line_number":20,"context_line":"to a single resource. It would be very useful allow these credentials"},{"line_number":21,"context_line":"to be used for that polling for deployment metadata too."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Closes-Bug: #1293234"},{"line_number":24,"context_line":"Change-Id: Iea9d8bfe216d17fa2d3a9e9251102292be48486d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2BvPg%3D","line":21,"updated":"2014-03-24 17:56:56.000000000","message":"YES PLEASE!","commit_id":"2708d2a8029b75e1f11e1dada429401ac7562609"}],"heat/engine/service.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fb9d66c594b93f1ad350a49c79ebd20ee72789f9","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"    @request_context"},{"line_number":1131,"context_line":"    def create_software_deployment(self, cnxt, server_id, config_id,"},{"line_number":1132,"context_line":"                                   input_values, action, status,"},{"line_number":1133,"context_line":"                                   status_reason, stack_user_project_id):"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        sd \u003d db_api.software_deployment_create(cnxt, {"},{"line_number":1136,"context_line":"            \u0027config_id\u0027: config_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FAYY%3D","line":1133,"updated":"2014-03-21 00:21:49.000000000","message":"I believe new, optional parameters should bump the minor version of the RPC API, should they not?","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ef549976e85c507e2fd5a4ecf3150257713b187","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"    @request_context"},{"line_number":1131,"context_line":"    def create_software_deployment(self, cnxt, server_id, config_id,"},{"line_number":1132,"context_line":"                                   input_values, action, status,"},{"line_number":1133,"context_line":"                                   status_reason, stack_user_project_id):"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        sd \u003d db_api.software_deployment_create(cnxt, {"},{"line_number":1136,"context_line":"            \u0027config_id\u0027: config_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B1AA%3D","line":1133,"in_reply_to":"AAAAWH%2F%2B%2Bhs%3D","updated":"2014-03-23 23:49:42.000000000","message":"In this case I don\u0027t think a bump is needed. The deployment API hasn\u0027t been used in the wild yet so there shouldn\u0027t be any concerns about backwards compatibility.","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"82829c6f63f94bbb89ea8286e1579be20f8c41e8","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"    @request_context"},{"line_number":1131,"context_line":"    def create_software_deployment(self, cnxt, server_id, config_id,"},{"line_number":1132,"context_line":"                                   input_values, action, status,"},{"line_number":1133,"context_line":"                                   status_reason, stack_user_project_id):"},{"line_number":1134,"context_line":""},{"line_number":1135,"context_line":"        sd \u003d db_api.software_deployment_create(cnxt, {"},{"line_number":1136,"context_line":"            \u0027config_id\u0027: config_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B%2Bhs%3D","line":1133,"in_reply_to":"AAAAWH%2F%2FAYY%3D","updated":"2014-03-21 08:33:32.000000000","message":"That\u0027s a kind-of-odd observation to make specifically about this patch, considering we\u0027ve never bumped the RPC API version in the entire history of the project..\n\nThere\u0027s certainly a discussion to be had on that topic, but I\u0027m not sure gating this patch on it makes sense, given that it\u0027s essentially fixing up a new feature, rather than modifying some long-established interface?","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"}],"heat/tests/test_engine_service.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"fb9d66c594b93f1ad350a49c79ebd20ee72789f9","unresolved":false,"context_lines":[{"line_number":2655,"context_line":"            ctx, server_id\u003dserver_id)"},{"line_number":2656,"context_line":"        self.assertEqual(3, len(metadata))"},{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"        # assert get no results with an unknown tenant_id"},{"line_number":2659,"context_line":"        ctx \u003d utils.dummy_context(tenant_id\u003dstr(uuid.uuid4()))"},{"line_number":2660,"context_line":"        metadata \u003d self.engine.metadata_software_deployments("},{"line_number":2661,"context_line":"            ctx, server_id\u003dserver_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2FAY8%3D","line":2658,"updated":"2014-03-21 00:21:49.000000000","message":"In the comment above you used \u0027project_id\u0027 ... now using \u0027tenant_id\u0027. Consistency would be valuable here I think.","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4ef549976e85c507e2fd5a4ecf3150257713b187","unresolved":false,"context_lines":[{"line_number":2655,"context_line":"            ctx, server_id\u003dserver_id)"},{"line_number":2656,"context_line":"        self.assertEqual(3, len(metadata))"},{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"        # assert get no results with an unknown tenant_id"},{"line_number":2659,"context_line":"        ctx \u003d utils.dummy_context(tenant_id\u003dstr(uuid.uuid4()))"},{"line_number":2660,"context_line":"        metadata \u003d self.engine.metadata_software_deployments("},{"line_number":2661,"context_line":"            ctx, server_id\u003dserver_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2B0%2Bc%3D","line":2658,"in_reply_to":"AAAAWH%2F%2FAY8%3D","updated":"2014-03-23 23:49:42.000000000","message":"Done","commit_id":"eae7bf9750cab9152b9987b754171ffd0189d2dc"}]}