)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"84d17fc15d3c3db10ad8ee0c93d3df634d2a9872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef7be64e_d5bd4798","updated":"2026-10-14 13:40:03.000000000","message":"Hi. I know it\u0027s been 5 years, but I think we still need to address this issue.\n\nZane: you were right, and my earlier objection was based on a wrong mental model. The catalog is already part of the request: keystonemiddleware\u0027s auth_token middleware exposes the requester\u0027s service catalog to the WSGI application through the HTTP_X_SERVICE_CATALOG environ key, so no extra call to Keystone is needed and no service credentials are required. Thanks for the pointer, and sorry for the slow uptake.\n\nTakashi: this also addresses your point about deployments having different URLs per endpoint type. Nothing is configured any more: links are now built from the requester\u0027s own catalog, using the public endpoint of the \"orchestration\" service type in the configured region (region_name_for_services). Links returned in API responses should point to the public endpoint, and they now follow whatever the deployment actually registered, instead of a single hard-coded point.\n\n2 notes on the implementation:\n\n- Keystone expands the %(tenant_id)s template when building the token catalog. So the endpoint URL already contains the tenant: the code handles both that case and endpoints registered without the template, let me know if that\u0027s useful or not, but as much as I know, we (as a community) had the project to remove the templates from all endpoints, so this makes the code ready for this move.\n\n- When the request carries no catalog (the version discovery endpoint is served before authentication, and some tokens don\u0027t include one), the URL is derived from the request, like before.","commit_id":"fc56f083db34b9c7c99c5ac9d9961ee6caef0cfd"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a3c05c10803a411dbe45c981e812dce89c95b853","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d13b6e8_c104e752","in_reply_to":"ef7be64e_d5bd4798","updated":"2026-10-25 14:56:57.000000000","message":"\u003e Links returned in API responses should point to the public endpoint, and they now follow whatever the deployment actually registered, instead of a single hard-coded point.\n\nI\u0027m afraid this doesn\u0027t handle the case where users use intrnal/admin endpoint (this redirects access to internal/admin endpoint to public eventuelly).\nWe should detect the endpoint from actual request environment, as I mentioned earlier.","commit_id":"fc56f083db34b9c7c99c5ac9d9961ee6caef0cfd"}],"heat/common/wsgi.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b962e74e6b7a4f8e2153eefaea6e828c12dc3f11","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                      \u0027influences the way href links are written inside \u0027"},{"line_number":95,"context_line":"                      \u0027stacks when doing a stack show. Leave this value \u0027"},{"line_number":96,"context_line":"                      \u0027commented or set to None if Heat API is served at the \u0027"},{"line_number":97,"context_line":"                      \u0027root of your server.\u0027)),"},{"line_number":98,"context_line":"]"},{"line_number":99,"context_line":"api_group \u003d cfg.OptGroup(\u0027heat_api\u0027)"},{"line_number":100,"context_line":"cfg.CONF.register_group(api_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e8189e0e_0cd65b29","line":97,"updated":"2021-10-07 14:56:30.000000000","message":"Can\u0027t this be obtained automatically from the keystone catalog?","commit_id":"63468b34160d8acdccf19444b93581a52aadf454"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"b40f709c974a127a68deb95c62d30f764d31e86d","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                      \u0027influences the way href links are written inside \u0027"},{"line_number":95,"context_line":"                      \u0027stacks when doing a stack show. Leave this value \u0027"},{"line_number":96,"context_line":"                      \u0027commented or set to None if Heat API is served at the \u0027"},{"line_number":97,"context_line":"                      \u0027root of your server.\u0027)),"},{"line_number":98,"context_line":"]"},{"line_number":99,"context_line":"api_group \u003d cfg.OptGroup(\u0027heat_api\u0027)"},{"line_number":100,"context_line":"cfg.CONF.register_group(api_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e24b5d85_b9d52bcb","line":97,"in_reply_to":"49805c74_ed457550","updated":"2023-01-03 23:50:45.000000000","message":"It is my recollection that we get a copy of the keystone catalog as part of authenticating the request. If that\u0027s accurate then it wouldn\u0027t take any extra time, but it\u0027s been a few years so I might be misremembering.","commit_id":"63468b34160d8acdccf19444b93581a52aadf454"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a25e8669d7cf7b67a922db19c0aae742668279a9","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                      \u0027influences the way href links are written inside \u0027"},{"line_number":95,"context_line":"                      \u0027stacks when doing a stack show. Leave this value \u0027"},{"line_number":96,"context_line":"                      \u0027commented or set to None if Heat API is served at the \u0027"},{"line_number":97,"context_line":"                      \u0027root of your server.\u0027)),"},{"line_number":98,"context_line":"]"},{"line_number":99,"context_line":"api_group \u003d cfg.OptGroup(\u0027heat_api\u0027)"},{"line_number":100,"context_line":"cfg.CONF.register_group(api_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"49805c74_ed457550","line":97,"in_reply_to":"a64b1769_4ba15797","updated":"2022-07-22 04:26:09.000000000","message":"This does not work in a deployment which uses different url for different endpoint types(admin, internal and public), because this always directs the url to a single point.\n\nWe need to find out the way to guess better the actual request url from the request object so that url is generated according to the actual endpoint used. This has been done in most components like keystone, cinder and so on as far as I know, though I need to find out the difference.","commit_id":"63468b34160d8acdccf19444b93581a52aadf454"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"84d17fc15d3c3db10ad8ee0c93d3df634d2a9872","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                      \u0027influences the way href links are written inside \u0027"},{"line_number":95,"context_line":"                      \u0027stacks when doing a stack show. Leave this value \u0027"},{"line_number":96,"context_line":"                      \u0027commented or set to None if Heat API is served at the \u0027"},{"line_number":97,"context_line":"                      \u0027root of your server.\u0027)),"},{"line_number":98,"context_line":"]"},{"line_number":99,"context_line":"api_group \u003d cfg.OptGroup(\u0027heat_api\u0027)"},{"line_number":100,"context_line":"cfg.CONF.register_group(api_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d95ecc23_5ec40d26","line":97,"in_reply_to":"e24b5d85_b9d52bcb","updated":"2026-10-14 13:40:03.000000000","message":"Done","commit_id":"63468b34160d8acdccf19444b93581a52aadf454"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"07343f351ef04c83190624b8907b8932f2b988f9","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                      \u0027influences the way href links are written inside \u0027"},{"line_number":95,"context_line":"                      \u0027stacks when doing a stack show. Leave this value \u0027"},{"line_number":96,"context_line":"                      \u0027commented or set to None if Heat API is served at the \u0027"},{"line_number":97,"context_line":"                      \u0027root of your server.\u0027)),"},{"line_number":98,"context_line":"]"},{"line_number":99,"context_line":"api_group \u003d cfg.OptGroup(\u0027heat_api\u0027)"},{"line_number":100,"context_line":"cfg.CONF.register_group(api_group)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a64b1769_4ba15797","line":97,"in_reply_to":"e8189e0e_0cd65b29","updated":"2021-10-07 15:00:29.000000000","message":"Probably, but this:\n1/ adds a lot of complicated code.\n2/ Reading the Keystone catalogue takes some time to execute.","commit_id":"63468b34160d8acdccf19444b93581a52aadf454"}]}
