)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"01e7c43cc0f81ce120b843e48f9e404faa94bf60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"039f85ce_5f5da244","updated":"2021-10-14 07:19:57.000000000","message":"recheck","commit_id":"9aedaa6d8ab2a799f140fd7c01ad30342d0cc2aa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ddf6abcfda9458eacde4487584845c701634b0d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa1728eb_046ab0cd","updated":"2021-10-13 06:56:55.000000000","message":"recheck","commit_id":"9aedaa6d8ab2a799f140fd7c01ad30342d0cc2aa"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0e1ed00cad0d9dd157fc052cd65cfef83d7da20b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f968ecaa_b0c901a1","updated":"2021-10-13 08:52:38.000000000","message":"recheck POST_FAILURE","commit_id":"9aedaa6d8ab2a799f140fd7c01ad30342d0cc2aa"}],"heat/engine/resources/openstack/nova/server_group.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"9498c2c91e6b0c4b7b305eda2b7055c1f7c2a8dd","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            properties.Schema.MAP,"},{"line_number":64,"context_line":"            _(\u0027Rules for a policy. Currently, only the \u0027"},{"line_number":65,"context_line":"              \u0027\"max_server_per_host\" rule is supported for the \u0027"},{"line_number":66,"context_line":"              \u0027\"anti-affinity\" policy.\u0027),"},{"line_number":67,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u002717.0.0\u0027),"},{"line_number":68,"context_line":"        ),"},{"line_number":69,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"36ce1069_0974f39b","line":66,"updated":"2021-10-08 14:37:15.000000000","message":"Shouldn\u0027t we specify a schema for this Map?","commit_id":"eaf10851d88a81910336f56b432225dad01b641d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"99276f7fa5dc9e2c32c1a8cc429793ebab368b8d","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            properties.Schema.MAP,"},{"line_number":64,"context_line":"            _(\u0027Rules for a policy. Currently, only the \u0027"},{"line_number":65,"context_line":"              \u0027\"max_server_per_host\" rule is supported for the \u0027"},{"line_number":66,"context_line":"              \u0027\"anti-affinity\" policy.\u0027),"},{"line_number":67,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u002717.0.0\u0027),"},{"line_number":68,"context_line":"        ),"},{"line_number":69,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"abdf7a34_be9050aa","line":66,"in_reply_to":"36ce1069_0974f39b","updated":"2021-10-09 04:25:25.000000000","message":"Though currently only {\"max_server_per_host\": \u003cnumber\u003e} is supported, the rule \u0027values\u0027 can be any type for a policy i.e numbers, booleans etc.\n\nAlso, replacement of a CREATE_FAILED is not that expensive:), wdyt?","commit_id":"eaf10851d88a81910336f56b432225dad01b641d"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"9eb08f63afced9a64e738943eea7cdfdcda4699f","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            properties.Schema.MAP,"},{"line_number":64,"context_line":"            _(\u0027Rules for a policy. Currently, only the \u0027"},{"line_number":65,"context_line":"              \u0027\"max_server_per_host\" rule is supported for the \u0027"},{"line_number":66,"context_line":"              \u0027\"anti-affinity\" policy.\u0027),"},{"line_number":67,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u002717.0.0\u0027),"},{"line_number":68,"context_line":"        ),"},{"line_number":69,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"bc9b5ddc_dccebd71","line":66,"in_reply_to":"abdf7a34_be9050aa","updated":"2021-10-11 14:23:52.000000000","message":"\u003e Though currently only {\"max_server_per_host\": \u003cnumber\u003e} is supported, the rule \u0027values\u0027 can be any type for a policy i.e numbers, booleans etc.\n\nThe schema for a Map allow us to define different types for each key (unlike List), so I don\u0027t think that\u0027s an obstacle. The downside of having a schema I guess is that as new rules are added they have to be explicitly added to the schema before anyone can use them.\n\nFWIW there\u0027s an `ANY` type now: https://opendev.org/openstack/heat/src/branch/master/heat/engine/constraints.py#L86\n\n\u003e Also, replacement of a CREATE_FAILED is not that expensive:), wdyt?\n\nI don\u0027t care that much, but any time we\u0027re typing instructions about allowed values into the help string instead in machine-readable format (that also produces nice docs!), that seems... suboptimal.\nIf more rules are added here in the future it will quickly become unwieldy to describe all their constraints in the description of the map.","commit_id":"eaf10851d88a81910336f56b432225dad01b641d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"df47277dd3b6c5fc3a755589cbeae751ea755b1e","unresolved":true,"context_lines":[{"line_number":63,"context_line":"            properties.Schema.MAP,"},{"line_number":64,"context_line":"            _(\u0027Rules for a policy. Currently, only the \u0027"},{"line_number":65,"context_line":"              \u0027\"max_server_per_host\" rule is supported for the \u0027"},{"line_number":66,"context_line":"              \u0027\"anti-affinity\" policy.\u0027),"},{"line_number":67,"context_line":"            support_status\u003dsupport.SupportStatus(version\u003d\u002717.0.0\u0027),"},{"line_number":68,"context_line":"        ),"},{"line_number":69,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":6,"id":"f816a65e_8e12330e","line":66,"in_reply_to":"bc9b5ddc_dccebd71","updated":"2021-10-11 14:51:52.000000000","message":"\u003e The schema for a Map allow us to define different types for each key (unlike List), so I don\u0027t think that\u0027s an obstacle\n\nThe rule keys we add here won\u0027t be valid for all types of policies. The only rule that\u0027s available atm is valid for \u0027anti-affinity\u0027 rule. Unless we add a bunch of validations we would always be depending on nova validations.","commit_id":"eaf10851d88a81910336f56b432225dad01b641d"}]}