)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"465c291ffcf7826839d0e9413b92cd64949a192c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98523c09_72d9d9a4","updated":"2021-11-20 00:02:16.000000000","message":"Waiting for Wallaby. wf -1 in the meantime.","commit_id":"d71b1aedd8946e73ffee79b9797e5d60e4106dfb"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a79b0f1caed3d2830ff77a9be1c6275e66fed20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2669fa4e_d1fd8c66","updated":"2021-11-22 15:18:55.000000000","message":"If this patch is only for fixing the \u0027docs\u0027 tox target then I think this is not correct. See my comments below.","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ae15cb07fadf96d8b795949972cb0235372e6048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f312d552_130e1cad","updated":"2021-12-08 06:07:59.000000000","message":"Let\u0027s merge this to clear this branch and not block other patches. Once https://review.opendev.org/c/openstack/heat/+/818802 merges we can backport it.","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"343edd88aa922049e5dce0c4078a4d762f267da3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aea35390_628c60ec","in_reply_to":"f312d552_130e1cad","updated":"2021-12-08 10:35:17.000000000","message":"Ok, sorry, removing my -1. Let\u0027s unblock the gate.","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"}],"tox.ini":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a79b0f1caed3d2830ff77a9be1c6275e66fed20e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":11,"context_line":"         OS_TEST_PATH\u003dheat/tests"},{"line_number":12,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria} {opts} {packages}"},{"line_number":13,"context_line":"usedevelop \u003d True"},{"line_number":14,"context_line":"deps \u003d -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria}"},{"line_number":15,"context_line":"       -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":2,"id":"6d6f67c3_88e2a0b7","line":12,"updated":"2021-11-22 15:18:55.000000000","message":"I think this is not the right solution as the upper constraints are used below in deps. Instead of this \u0027double\u0027 definition of upper constraints I recommend to use the constraints explicitly for \u0027docs\u0027 tox target.","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a79b0f1caed3d2830ff77a9be1c6275e66fed20e","unresolved":true,"context_lines":[{"line_number":57,"context_line":"[testenv:docs]"},{"line_number":58,"context_line":"whitelist_externals \u003d"},{"line_number":59,"context_line":"  rm"},{"line_number":60,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":61,"context_line":"commands \u003d"},{"line_number":62,"context_line":"  rm -rf doc/build"},{"line_number":63,"context_line":"  sphinx-build -W --keep-going -b html doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"47d093db_d320401d","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":41},"updated":"2021-11-22 15:18:55.000000000","message":"replace this to below lines would fix the issue:\n\ndeps \u003d -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria}\n       -r{toxinidir}/doc/requirements.txt\n       -r{toxinidir}/requirements.txt\n       -r{toxinidir}/test-requirements.txt\n\n(sphinx installs \u0027requirements\u0027 (i.e. requirements.txt) anyway, so it needs to be added here so that they will be installed with constraints)","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"276a9a8b03749cb7ef619c8ac3a756ad2c9af4f5","unresolved":true,"context_lines":[{"line_number":57,"context_line":"[testenv:docs]"},{"line_number":58,"context_line":"whitelist_externals \u003d"},{"line_number":59,"context_line":"  rm"},{"line_number":60,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":61,"context_line":"commands \u003d"},{"line_number":62,"context_line":"  rm -rf doc/build"},{"line_number":63,"context_line":"  sphinx-build -W --keep-going -b html doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"cd2c4f7a_9c819f4b","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":41},"in_reply_to":"47d093db_d320401d","updated":"2021-11-22 15:43:39.000000000","message":"actually, it is enough without test-requirements.txt, like this:\n\ndeps \u003d -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/victoria}\n       -r{toxinidir}/doc/requirements.txt\n       -r{toxinidir}/requirements.txt","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2ff653ae9589b8926529e9975f191f97d10ea7b2","unresolved":true,"context_lines":[{"line_number":57,"context_line":"[testenv:docs]"},{"line_number":58,"context_line":"whitelist_externals \u003d"},{"line_number":59,"context_line":"  rm"},{"line_number":60,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":61,"context_line":"commands \u003d"},{"line_number":62,"context_line":"  rm -rf doc/build"},{"line_number":63,"context_line":"  sphinx-build -W --keep-going -b html doc/source doc/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"b273d8f6_ddaded46","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":41},"in_reply_to":"cd2c4f7a_9c819f4b","updated":"2021-11-22 16:32:33.000000000","message":"I\u0027ve created a patch on master, with explanation regarding the above issue:\n\nhttps://review.opendev.org/c/openstack/heat/+/818802","commit_id":"cbe9be5e7625d374fc6cfbb63b7e3ef5335bf330"}]}