)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"79768a3b8f021df15532f030fab51121ebc51f53","unresolved":true,"context_lines":[{"line_number":16,"context_line":"target."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch removes the install_command as that is not needed and it"},{"line_number":19,"context_line":"even could lead to errors: when multiple constraints (-c) are passed to"},{"line_number":20,"context_line":"pip it only uses the 1st constraints file. Which means the constraints"},{"line_number":21,"context_line":"defined in \u0027deps\u0027 will never take effect if install_command has already"},{"line_number":22,"context_line":"a constraints file defined there. Therefore it\u0027s better to avoid the"},{"line_number":23,"context_line":"use of install_command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0eefea7b_1d9d720f","line":20,"range":{"start_line":19,"start_character":27,"end_line":20,"end_character":41},"updated":"2021-11-23 03:11:06.000000000","message":"That would not be the case for a branch as the same constraints file would be used. We can get rid of install_command. But, the only issue is, every target where userdevelop \u003d True, someone has to duplicate requirements in deps.","commit_id":"b15114c6934400b6dff99151f4329c720105eb18"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b93b0340eebdbc6f4fc04535a6cfd633d1782462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f21d4c81_bfe2c88e","updated":"2024-01-29 02:09:37.000000000","message":"Seems this was already done by 38238b88f74983534215bd4c0afdfd67fdbeaaa4","commit_id":"b15114c6934400b6dff99151f4329c720105eb18"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"25b24ec196499d746784b97ba3ee3d9ba8f670a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdd84cac_0adaac19","updated":"2021-11-22 22:44:28.000000000","message":"Thanks Elod, this sounds fine to me. Looks like it resolves the issue we were having.","commit_id":"b15114c6934400b6dff99151f4329c720105eb18"}],"tox.ini":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"79768a3b8f021df15532f030fab51121ebc51f53","unresolved":true,"context_lines":[{"line_number":75,"context_line":"[testenv:api-ref]"},{"line_number":76,"context_line":"# This environment is called from CI scripts to test and publish"},{"line_number":77,"context_line":"# the API Ref to docs.openstack.org."},{"line_number":78,"context_line":"deps \u003d {[testenv:docs]deps}"},{"line_number":79,"context_line":"whitelist_externals \u003d rm"},{"line_number":80,"context_line":"commands \u003d"},{"line_number":81,"context_line":"  rm -rf api-ref/build"}],"source_content_type":"text/x-properties","patch_set":2,"id":"60621a5c_6839fb65","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":27},"updated":"2021-11-23 03:11:06.000000000","message":"We don\u0027t need all docs deps here. I think usedevelop \u003d False would do.","commit_id":"b15114c6934400b6dff99151f4329c720105eb18"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"79768a3b8f021df15532f030fab51121ebc51f53","unresolved":true,"context_lines":[{"line_number":138,"context_line":"[testenv:releasenotes]"},{"line_number":139,"context_line":"whitelist_externals \u003d"},{"line_number":140,"context_line":"  rm"},{"line_number":141,"context_line":"deps \u003d {[testenv:docs]deps}"},{"line_number":142,"context_line":"commands \u003d"},{"line_number":143,"context_line":"  rm -rf releasenotes/build"},{"line_number":144,"context_line":"  sphinx-build -a -E -W -d releasenotes/build/doctrees --keep-going -b html releasenotes/source releasenotes/build/html"}],"source_content_type":"text/x-properties","patch_set":2,"id":"839c5f52_cdd627d5","line":141,"range":{"start_line":141,"start_character":0,"end_line":141,"end_character":27},"updated":"2021-11-23 03:11:06.000000000","message":"Same here, usedevelop \u003d False","commit_id":"b15114c6934400b6dff99151f4329c720105eb18"}]}
