)]}'
{"id":"openstack%2Fheat~818802","triplet_id":"openstack%2Fheat~master~I151ff9a6e5953b0942c92fe8b04da9f4f1d5f151","project":"openstack/heat","branch":"master","topic":"remove-install-command","attention_set":{},"removed_from_attention_set":{"17685":{"account":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"last_update":"2024-01-29 02:13:13.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I151ff9a6e5953b0942c92fe8b04da9f4f1d5f151","subject":"Remove install_command from tox.ini","status":"ABANDONED","created":"2021-11-22 16:29:01.000000000","updated":"2024-01-29 02:13:13.000000000","total_comment_count":5,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"95ef5bb23dcf643e068e05b55040d4fe5a394d80","_number":818802,"virtual_id_number":818802,"owner":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-11-22 18:09:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"all":[{"value":1,"date":"2021-11-23 03:11:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":2,"date":"2021-11-22 22:44:28.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"}],"CC":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-22 17:00:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-22 18:09:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-22 22:44:28.000000000","updated_by":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"reviewer":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"state":"REVIEWER"},{"updated":"2021-11-23 03:11:06.000000000","updated_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"REVIEWER"},{"updated":"2024-01-29 02:09:37.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"CC"}],"messages":[{"id":"485f9c8173c2117ba95ccb7cf46de61aec4662ae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-11-22 16:29:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c59556007e32ff8d62f3f478fe27f38159e8401d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2021-11-22 16:37:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"db35d3261f1192a312665fb55b2b1503705441f3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-22 17:00:59.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/5ab2529f9e474a30b63317803d83530e : SUCCESS in 15m 06s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/925ee82ee8794cc293bf709d8d916a87 : SUCCESS in 20m 59s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6376b43d0dd8ab0da41e3829c6c0def8c9ada3f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-22 18:09:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/3b128bc70b7a49c88bbaff7646b83a16 : SUCCESS in 5m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7a696843ce414b8c97b2441b169ed93c : SUCCESS in 10m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2f9a9c07fbd7454e8582937470a0ac91 : SUCCESS in 9m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a532029e19c44d0c8603ed3ef4226090 : SUCCESS in 6m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/27253f855336429d854e9065ad77337f : SUCCESS in 8m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9fca1eb4726f44b6909e729408615d35 : SUCCESS in 9m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ad42de2e11a7430b8d7aeb0bf340a66f : SUCCESS in 9m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3ee7f09373b46f594d20308e350e6ba : SUCCESS in 11m 35s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2c5e5ea483a34bb8aed1e059d2a4a372 : SUCCESS in 7m 54s\n- grenade-heat-multinode https://zuul.opendev.org/t/openstack/build/2039732e56d44fe18a8bd39a7bb75adb : SUCCESS in 1h 27m 49s\n- heat-functional https://zuul.opendev.org/t/openstack/build/a3041e831582424f9ddd8c55d14eda28 : SUCCESS in 59m 13s\n- heat-functional-legacy https://zuul.opendev.org/t/openstack/build/0c9952906d924b7eb5866dbbd97bfbac : SUCCESS in 55m 05s","accounts_in_message":[],"_revision_number":2},{"id":"25b24ec196499d746784b97ba3ee3d9ba8f670a6","author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"date":"2021-11-22 22:44:28.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"79768a3b8f021df15532f030fab51121ebc51f53","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2021-11-23 03:11:06.000000000","message":"Patch Set 2: Code-Review+1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b93b0340eebdbc6f4fc04535a6cfd633d1782462","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-01-29 02:09:37.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"95ef5bb23dcf643e068e05b55040d4fe5a394d80","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2024-01-29 02:13:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b15114c6934400b6dff99151f4329c720105eb18","revisions":{"54f241e8abc01dd10d0d1ef7ab8a727f4ffc3d0d":{"kind":"REWORK","_number":1,"created":"2021-11-22 16:29:01.000000000","uploader":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"ref":"refs/changes/02/818802/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/02/818802/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/02/818802/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/02/818802/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/02/818802/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/02/818802/1"}}},"commit":{"parents":[{"commit":"213e6b1304b83a85e1a64eacb8255459088dc413","subject":"Merge \"Fix None comparision when sorting by `updated_at`\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/213e6b1304b83a85e1a64eacb8255459088dc413"}]}],"author":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2021-11-22 15:47:58.000000000","tz":60},"committer":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2021-11-22 16:13:55.000000000","tz":60},"subject":"Remove install_command from tox.ini","message":"Remove install_command from tox.ini\n\nWhen tox \u0027docs\u0027 target is called, first it installs the dependencies\n(listed in \u0027deps\u0027) in \u0027installdeps\u0027 phase, then it installs heat (with\nits requirements) in \u0027develop-inst\u0027 phase. In the latter case \u0027deps\u0027 is\nnot used so that the constraints defined in \u0027deps\u0027 are not used.\nThis could lead to failures on stable branches when new packages are\nreleased that break the build. To avoid this, the simplest solution is\nto pre-install requirements, i.e. add requirements.txt to \u0027docs\u0027 tox\ntarget.\n\nThis patch removes the install_command as that is not needed and it\neven could lead to errors: when multiple constraints (-c) are passed to\npip it only uses the 1st constraints file. Which means the constraints\ndefined in \u0027deps\u0027 will never take effect if install_command has already\na constraints file defined there. Therefore it\u0027s better to avoid the\nuse of install_command.\n\nFurthermore, let\u0027s use the deps defined in \u0027docs\u0027 target for every docs\nrelated other tox targets.\n\nChange-Id: I151ff9a6e5953b0942c92fe8b04da9f4f1d5f151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/54f241e8abc01dd10d0d1ef7ab8a727f4ffc3d0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/54f241e8abc01dd10d0d1ef7ab8a727f4ffc3d0d"}]},"branch":"refs/heads/master"},"b15114c6934400b6dff99151f4329c720105eb18":{"kind":"REWORK","_number":2,"created":"2021-11-22 16:37:26.000000000","uploader":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"ref":"refs/changes/02/818802/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/02/818802/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/02/818802/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/02/818802/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/02/818802/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/02/818802/2"}}},"commit":{"parents":[{"commit":"213e6b1304b83a85e1a64eacb8255459088dc413","subject":"Merge \"Fix None comparision when sorting by `updated_at`\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/213e6b1304b83a85e1a64eacb8255459088dc413"}]}],"author":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2021-11-22 15:47:58.000000000","tz":60},"committer":{"name":"Elod Illes","email":"elod.illes@est.tech","date":"2021-11-22 16:36:50.000000000","tz":60},"subject":"Remove install_command from tox.ini","message":"Remove install_command from tox.ini\n\nWhen tox \u0027docs\u0027 target is called, first it installs the dependencies\n(listed in \u0027deps\u0027) in \u0027installdeps\u0027 phase, then it installs heat (with\nits requirements) in \u0027develop-inst\u0027 phase. In the latter case \u0027deps\u0027 is\nnot used so that the constraints defined in \u0027deps\u0027 are not used.\nThis could lead to failures on stable branches when new packages are\nreleased that break the build. To avoid this, the simplest solution is\nto pre-install requirements, i.e. add requirements.txt to \u0027docs\u0027 tox\ntarget.\n\nThis patch removes the install_command as that is not needed and it\neven could lead to errors: when multiple constraints (-c) are passed to\npip it only uses the 1st constraints file. Which means the constraints\ndefined in \u0027deps\u0027 will never take effect if install_command has already\na constraints file defined there. Therefore it\u0027s better to avoid the\nuse of install_command.\n\nFurthermore, let\u0027s use the deps defined in \u0027docs\u0027 target for every docs\nrelated other tox targets.\n\nChange-Id: I151ff9a6e5953b0942c92fe8b04da9f4f1d5f151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/b15114c6934400b6dff99151f4329c720105eb18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/b15114c6934400b6dff99151f4329c720105eb18"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}