)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"b264945a519893e5e0756fcd30e666968c71910c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following patch proposes the addition of a new variables"},{"line_number":10,"context_line":"top level section and several intrinsic functions to"},{"line_number":11,"context_line":"operation on the variables."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The variables can be used in any number of places, but there is"},{"line_number":14,"context_line":"a limitation on not allowing the use of resource objects in variable"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F9Xwk%3D","line":11,"updated":"2014-04-05 03:03:42.000000000","message":"grammer is wrong here","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"b193501a6c77eeb8c2d5b58e9df3a7c6159cf352","unresolved":false,"context_lines":[{"line_number":15,"context_line":"evaluation."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"My major opposition to conditionals in the past has been that they"},{"line_number":18,"context_line":"make HOT a non-declartive language.  With the approach used, even"},{"line_number":19,"context_line":"though variables delcared, all of the variables are resolveable at"},{"line_number":20,"context_line":"template validation."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAW3%2F%2FzHM%3D","line":18,"updated":"2014-04-10 10:54:20.000000000","message":"typo: non-declarative","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"b193501a6c77eeb8c2d5b58e9df3a7c6159cf352","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"My major opposition to conditionals in the past has been that they"},{"line_number":18,"context_line":"make HOT a non-declartive language.  With the approach used, even"},{"line_number":19,"context_line":"though variables delcared, all of the variables are resolveable at"},{"line_number":20,"context_line":"template validation."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Variables may not be circular.  Any attempt to use a variable in a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAW3%2F%2FzGg%3D","line":19,"updated":"2014-04-10 10:54:20.000000000","message":"typo: declared","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"}],"doc/source/template_guide/hot_spec.rst":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"20a86ef52c7bf00f28500a892c2ab667ada6baba","unresolved":false,"context_lines":[{"line_number":396,"context_line":"These conditionals may only be used within the conditional property of a"},{"line_number":397,"context_line":"resource.  If the condition evaluates to true, the resource is created.  If"},{"line_number":398,"context_line":"the conditional evalues to false, the resource is not created."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"::"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93Hs%3D","line":399,"updated":"2014-04-01 15:49:39.000000000","message":"I feel that the usecase here is a little bit limited. IMHO, you don\u0027t care so much about conditional resources, but more about conditional values of properties. Eg, use this image in that case, or this other image in this other case. Using your proposal, I would need to duplicate the 2 resources, with one or the other created, instead of just having a conditional on the image property.","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"493e882249975beb7f877d79f67a807653870f1e","unresolved":false,"context_lines":[{"line_number":396,"context_line":"These conditionals may only be used within the conditional property of a"},{"line_number":397,"context_line":"resource.  If the condition evaluates to true, the resource is created.  If"},{"line_number":398,"context_line":"the conditional evalues to false, the resource is not created."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"::"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F926k%3D","line":399,"in_reply_to":"AAAAWH%2F93Hs%3D","updated":"2014-04-01 16:12:45.000000000","message":"one option is to add a cond_if intrinsic and allow the results of the cond_if output to be applied to properties.  For example:\n\nimage_id: { cond_if: [ {get_cond: wants_fedora } , \u0027fedora\u0027, \u0027ubuntu\u0027] }\n\nthis is essentially\nif wants_fedora is true\n  image_id \u003d \u0027fedora\u0027\nelse\n  image_id \u003d \u0027ubuntu\u0027\n\nvariable still created and evaluated in one place so still declarative, but the results are a bit imperative, since there is either one possible return or another, implying steps in the processing.  Since is can be calculated at template parsing time, I\u0027m still good with such a change.","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0872f540a68d4b9039303b9fc63b2e7a302e5e93","unresolved":false,"context_lines":[{"line_number":698,"context_line":"get_cond"},{"line_number":699,"context_line":"--------"},{"line_number":700,"context_line":"The *get_cond* function allows for referencing a conditional result from the "},{"line_number":701,"context_line":"conditional section of a template."},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"::"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93R8%3D","line":701,"updated":"2014-04-01 15:52:57.000000000","message":"`Conditions Section`_","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0872f540a68d4b9039303b9fc63b2e7a302e5e93","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":"::"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"  get_cond: \u003cconditional ID\u003e"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"The *conditional ID* of the referenced conditional is retrieved for"},{"line_number":708,"context_line":"evaluation by the conditions parameter of the resource."}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93RA%3D","line":705,"updated":"2014-04-01 15:52:57.000000000","message":"get_cond: \u003ccondition ID\u003e","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0872f540a68d4b9039303b9fc63b2e7a302e5e93","unresolved":false,"context_lines":[{"line_number":840,"context_line":""},{"line_number":841,"context_line":"The example below demonstrates *cond_and* usage and its impact on the creation"},{"line_number":842,"context_line":"of a resource.  Note the resource is only created if the create_small"},{"line_number":843,"context_line":"parameter is set to yes and instance_type is m1.small."},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"::"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93Pk%3D","line":843,"updated":"2014-04-01 15:52:57.000000000","message":"Note the resource is only created if the ``create_small``\nparameter is set to \u0027yes\u0027 and ``instance_type`` is \u0027m1.small\u0027.","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0872f540a68d4b9039303b9fc63b2e7a302e5e93","unresolved":false,"context_lines":[{"line_number":856,"context_line":"      label: Instance Type"},{"line_number":857,"context_line":"      description: Instance type to be used."},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"  conditionals:"},{"line_number":860,"context_line":"    small_desired: { cond_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":861,"context_line":"    type_valid: { cond_equals: [ { get_param: instance_type }, \u0027m1.small\u0027 ] }"},{"line_number":862,"context_line":"    server_create: { cond_and: [ { get_cond: type_valid },"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93KU%3D","line":859,"updated":"2014-04-01 15:52:57.000000000","message":"conditions?","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0872f540a68d4b9039303b9fc63b2e7a302e5e93","unresolved":false,"context_lines":[{"line_number":883,"context_line":""},{"line_number":884,"context_line":"The example below demonstrates *cond_equals* usage and its impact on the"},{"line_number":885,"context_line":"creation of a resource.  Note the resource is only created if the"},{"line_number":886,"context_line":"create_small parameter is set to yes.small."},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"::"},{"line_number":889,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93MI%3D","line":886,"updated":"2014-04-01 15:52:57.000000000","message":"is set to \u0027yes\u0027","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"20a86ef52c7bf00f28500a892c2ab667ada6baba","unresolved":false,"context_lines":[{"line_number":896,"context_line":""},{"line_number":897,"context_line":"  conditionals:"},{"line_number":898,"context_line":"    small_desired: { cond_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"  resources:"},{"line_number":901,"context_line":"    my_instance:"},{"line_number":902,"context_line":"      type: OS::Nova::Server"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F93G8%3D","line":899,"updated":"2014-04-01 15:49:39.000000000","message":"I don\u0027t think this is a really good example. In that case, what we really is having a type: bool parameter type, which does the job for you.","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"493e882249975beb7f877d79f67a807653870f1e","unresolved":false,"context_lines":[{"line_number":896,"context_line":""},{"line_number":897,"context_line":"  conditionals:"},{"line_number":898,"context_line":"    small_desired: { cond_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"  resources:"},{"line_number":901,"context_line":"    my_instance:"},{"line_number":902,"context_line":"      type: OS::Nova::Server"}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F9258%3D","line":899,"in_reply_to":"AAAAWH%2F93G8%3D","updated":"2014-04-01 16:12:45.000000000","message":"yes I couldn\u0027t find the specification for the types that are supported by parameters in the hot_spec.rst and didn\u0027t look in detail at the code.  This example could probably be cleaned up","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"0872f540a68d4b9039303b9fc63b2e7a302e5e93","unresolved":false,"context_lines":[{"line_number":900,"context_line":"  resources:"},{"line_number":901,"context_line":"    my_instance:"},{"line_number":902,"context_line":"      type: OS::Nova::Server"},{"line_number":903,"context_line":"      conditional: { get_cond: small_desired }"},{"line_number":904,"context_line":"      properties:"},{"line_number":905,"context_line":"        # general properties ..."},{"line_number":906,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F92%2Bg%3D","line":903,"updated":"2014-04-01 15:52:57.000000000","message":"these condition/conditionals only leave me a boolean result, i.e. whether \u0027my_instance\u0027 should be created.\nHow can I express this requirement --\n\"If \u0027small_desired\u0027 then m1.small else m1.tiny\"\n\ncan we do this multi-valued evaluation as mappings?\n\n  parameters:\n    yum_proxy:\n        type: boolean\n        default: false\n    yum_source:\n        type: string\n        default: local\n        constraints:\n           allowed_values: [local, company_repo, community_repo]\n   mappings:\n      yum_source:\n          local: http://127.0.1.2/...\n          company_repo: http://77.88.99.11/...\n          community_repo: http://well-known.site.com/...\n\nresources:\n   yum_proxy_config:\n      type: OS::Heat::SoftwareConfig\n      enabled: {get_param: yum_proxy}\n      group: script\n      config: |\n         \u003cuse yum_source in the script\u003e","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"493e882249975beb7f877d79f67a807653870f1e","unresolved":false,"context_lines":[{"line_number":900,"context_line":"  resources:"},{"line_number":901,"context_line":"    my_instance:"},{"line_number":902,"context_line":"      type: OS::Nova::Server"},{"line_number":903,"context_line":"      conditional: { get_cond: small_desired }"},{"line_number":904,"context_line":"      properties:"},{"line_number":905,"context_line":"        # general properties ..."},{"line_number":906,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAAWH%2F92yk%3D","line":903,"in_reply_to":"AAAAWH%2F92%2Bg%3D","updated":"2014-04-01 16:12:45.000000000","message":"I responded to Therve with a proposal for such a if/then/else conditional above which doesn\u0027t violate the declarative nature of hot.","commit_id":"97dae6c9e6c45e353c01e56c18d216a6e820d2ec"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":389,"context_line":"-----------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"In the *variables* section, variables are defined which can store strings or"},{"line_number":392,"context_line":"booleans.  Varibles are created by either direct assignment, or through the"},{"line_number":393,"context_line":"use of intrinsic functions (see :ref:`hot_spec_intrinsic_functions`)."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Wsc%3D","line":392,"updated":"2014-04-05 19:27:04.000000000","message":"Typo: Varibles -\u003e Variables","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":389,"context_line":"-----------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"In the *variables* section, variables are defined which can store strings or"},{"line_number":392,"context_line":"booleans.  Varibles are created by either direct assignment, or through the"},{"line_number":393,"context_line":"use of intrinsic functions (see :ref:`hot_spec_intrinsic_functions`)."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NWw%3D","line":392,"updated":"2014-04-07 23:06:42.000000000","message":"Why couldn\u0027t a variable hold anything that e.g. a Parameter could?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"cd16265e166dfaf8a459993167c81f60d4bb3cad","unresolved":false,"context_lines":[{"line_number":389,"context_line":"-----------------"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"In the *variables* section, variables are defined which can store strings or"},{"line_number":392,"context_line":"booleans.  Varibles are created by either direct assignment, or through the"},{"line_number":393,"context_line":"use of intrinsic functions (see :ref:`hot_spec_intrinsic_functions`)."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NI0%3D","line":392,"in_reply_to":"AAAAWH%2F9NWw%3D","updated":"2014-04-08 02:39:15.000000000","message":"agree should be able to hold all the types.  Are those documented somewhere?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":393,"context_line":"use of intrinsic functions (see :ref:`hot_spec_intrinsic_functions`)."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WsY%3D","line":396,"updated":"2014-04-05 19:27:04.000000000","message":"Shouldn\u0027t it be \u0027resource property inputs\u0027, not \u0027resource attribute inputs\u0027?\n\nAnd I think we should add here that get_attr must also not be used.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"85a11da39607a42bddaaf12d8ea490ec5686cd66","unresolved":false,"context_lines":[{"line_number":393,"context_line":"use of intrinsic functions (see :ref:`hot_spec_intrinsic_functions`)."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Wcc%3D","line":396,"in_reply_to":"AAAAWH%2F9WsY%3D","updated":"2014-04-06 01:28:57.000000000","message":"good points, not sure why I wrote attribute other then it was early when I submitted the change.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"0bb99ecc0d420aa76a8cf596dd2e94a29cfe06ce","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XUw%3D","line":397,"updated":"2014-04-05 08:49:32.000000000","message":"Do we have to put this constraint? I understand it makes things easier, but I can see that storing for example the ip address a server would be really useful in a variable.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NSs%3D","line":397,"in_reply_to":"AAAAWH%2F9Vh0%3D","updated":"2014-04-07 23:06:42.000000000","message":"I initially thought this was a horrible idea, but it occurs to me that with the way functions are lazily evaluated, we probably could just manage this. It still makes me nervous, though. The idea of not having to make a special case for what functions are allowed in this section is attractive... though we might have to make one anyway for get_var.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3c001ce4b9bfff4c134b847e18ef37f3b2289d93","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Vh0%3D","line":397,"in_reply_to":"AAAAWH%2F9VuY%3D","updated":"2014-04-06 18:38:43.000000000","message":"As far as future feature enhancement, I definitely feel it is a really bad idea to not enable validation on templates, and let them run wild inside the heat engine.  One option would be to calculate if the conditional evaluation at runtime would ever result in a situation where validation *could* fail, and reject those templates at validation time.\n\nI think actually implementing such logic would be tricky.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"761e3d449cf5a987caae7518b99c3fec4bc2c102","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9VuY%3D","line":397,"in_reply_to":"AAAAWH%2F9WsU%3D","updated":"2014-04-06 14:47:08.000000000","message":"OK, fair enough. I feel like it reduces the usefulness quite a bit though. Maybe future enhancement?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WsU%3D","line":397,"in_reply_to":"AAAAWH%2F9XCU%3D","updated":"2014-04-05 19:27:04.000000000","message":"I agree that we should probably let out get_resource and get_attr so we can do validation time evalution. Othewise, I think we can get in all kinds of nasty situations.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"38762104f8173eb89b81d6ade0ddf37eec42eb54","unresolved":false,"context_lines":[{"line_number":394,"context_line":""},{"line_number":395,"context_line":"These variables may only be used with other intrinsic functions or as"},{"line_number":396,"context_line":"resource attribute inputs.  A variable may not use the get_resource intrinsic"},{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XCU%3D","line":397,"in_reply_to":"AAAAWH%2F9XUw%3D","updated":"2014-04-05 15:38:31.000000000","message":"In the example you mention, I assume the IP address of the server is created by the attributes for  the OS::Nova::Server.  These attributes are not created until the resource is instantiated.  If we allowed get_resource (and by extension get_attr), it wouldn\u0027t be possible to validate the template and resolve all variables at validate time.  Rather it would require run-time evaluation, which I really really think we want to avoid.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":397,"context_line":"in any part of the calculation of the variable."},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"Any variable evaluation which results in a circular reference will result in a"},{"line_number":400,"context_line":"validation error."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"::"},{"line_number":403,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NL0%3D","line":400,"updated":"2014-04-07 23:06:42.000000000","message":"This will be a real pain to implement. It might be nicer if we could disallow variables referencing other variables (though that is also a pain to implement in its own way).","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"0bb99ecc0d420aa76a8cf596dd2e94a29cfe06ce","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  variables:"},{"line_number":405,"context_line":"    \u003cvariable ID\u003e: \u003cvariable value\u003e"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"variable ID:"},{"line_number":408,"context_line":"    A variable block is headed by the variable ID, which must be unique"},{"line_number":409,"context_line":"    within the variable section of a template."},{"line_number":410,"context_line":"variable value:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XUs%3D","line":407,"updated":"2014-04-05 08:49:32.000000000","message":"variable name? ID makes it think that it should be something more than a string.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  variables:"},{"line_number":405,"context_line":"    \u003cvariable ID\u003e: \u003cvariable value\u003e"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"variable ID:"},{"line_number":408,"context_line":"    A variable block is headed by the variable ID, which must be unique"},{"line_number":409,"context_line":"    within the variable section of a template."},{"line_number":410,"context_line":"variable value:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NwA%3D","line":407,"in_reply_to":"AAAAWH%2F9VuU%3D","updated":"2014-04-07 21:50:19.000000000","message":"Done","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"761e3d449cf5a987caae7518b99c3fec4bc2c102","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  variables:"},{"line_number":405,"context_line":"    \u003cvariable ID\u003e: \u003cvariable value\u003e"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"variable ID:"},{"line_number":408,"context_line":"    A variable block is headed by the variable ID, which must be unique"},{"line_number":409,"context_line":"    within the variable section of a template."},{"line_number":410,"context_line":"variable value:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9VuU%3D","line":407,"in_reply_to":"AAAAWH%2F9WsQ%3D","updated":"2014-04-06 14:47:08.000000000","message":"Sorry my bad.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  variables:"},{"line_number":405,"context_line":"    \u003cvariable ID\u003e: \u003cvariable value\u003e"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"variable ID:"},{"line_number":408,"context_line":"    A variable block is headed by the variable ID, which must be unique"},{"line_number":409,"context_line":"    within the variable section of a template."},{"line_number":410,"context_line":"variable value:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WsQ%3D","line":407,"in_reply_to":"AAAAWH%2F9XCQ%3D","updated":"2014-04-05 19:27:04.000000000","message":"Yes, we used ID so far since we are talking about keys in the YAML. If we want to switch to \u0027name\u0027 we should do it consistently.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"38762104f8173eb89b81d6ade0ddf37eec42eb54","unresolved":false,"context_lines":[{"line_number":404,"context_line":"  variables:"},{"line_number":405,"context_line":"    \u003cvariable ID\u003e: \u003cvariable value\u003e"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"variable ID:"},{"line_number":408,"context_line":"    A variable block is headed by the variable ID, which must be unique"},{"line_number":409,"context_line":"    within the variable section of a template."},{"line_number":410,"context_line":"variable value:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XCQ%3D","line":407,"in_reply_to":"AAAAWH%2F9XUs%3D","updated":"2014-04-05 15:38:31.000000000","message":"The rest of the hot spec uses the term \"xyz ID\" to reference a name.  I am just following semantics in rest of spec, but can change if you think it is necessary.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"27f75c2705c1011479300204acca96b247413cb4","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    the resource section of a template."},{"line_number":443,"context_line":"type"},{"line_number":444,"context_line":"    This attribute specifies the type of resource, such as OS::Nova::Server."},{"line_number":445,"context_line":"create:"},{"line_number":446,"context_line":"    This *opitonal* attribute indicates whether the resource should be created."},{"line_number":447,"context_line":"    A value of true will always create, and a value of false will result in the"},{"line_number":448,"context_line":"    resource not created.  If this parameter is unspecified, the resource will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWn%2F%2F%2FqQ%3D","line":445,"updated":"2014-04-08 02:26:04.000000000","message":"How about naming this property \u0027enable\u0027 or \u0027enabled\u0027?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"b264945a519893e5e0756fcd30e666968c71910c","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    the resource section of a template."},{"line_number":443,"context_line":"type"},{"line_number":444,"context_line":"    This attribute specifies the type of resource, such as OS::Nova::Server."},{"line_number":445,"context_line":"create:"},{"line_number":446,"context_line":"    This *opitonal* attribute indicates whether the resource should be created."},{"line_number":447,"context_line":"    A value of true will always create, and a value of false will result in the"},{"line_number":448,"context_line":"    resource not created.  If this parameter is unspecified, the resource will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Xww%3D","line":445,"updated":"2014-04-05 03:03:42.000000000","message":"need to break this use case into a separate patch","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    the resource section of a template."},{"line_number":443,"context_line":"type"},{"line_number":444,"context_line":"    This attribute specifies the type of resource, such as OS::Nova::Server."},{"line_number":445,"context_line":"create:"},{"line_number":446,"context_line":"    This *opitonal* attribute indicates whether the resource should be created."},{"line_number":447,"context_line":"    A value of true will always create, and a value of false will result in the"},{"line_number":448,"context_line":"    resource not created.  If this parameter is unspecified, the resource will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NKk%3D","line":445,"in_reply_to":"AAAAWH%2F9Nv4%3D","updated":"2014-04-07 23:06:42.000000000","message":"IMO this is a bad name because it leaves unanswered the question of whether the resource will be deleted on update if the \"create\" value becomes false. (It will.)","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    the resource section of a template."},{"line_number":443,"context_line":"type"},{"line_number":444,"context_line":"    This attribute specifies the type of resource, such as OS::Nova::Server."},{"line_number":445,"context_line":"create:"},{"line_number":446,"context_line":"    This *opitonal* attribute indicates whether the resource should be created."},{"line_number":447,"context_line":"    A value of true will always create, and a value of false will result in the"},{"line_number":448,"context_line":"    resource not created.  If this parameter is unspecified, the resource will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Nv4%3D","line":445,"in_reply_to":"AAAAWH%2F9WsE%3D","updated":"2014-04-07 21:50:19.000000000","message":"agree will address","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":442,"context_line":"    the resource section of a template."},{"line_number":443,"context_line":"type"},{"line_number":444,"context_line":"    This attribute specifies the type of resource, such as OS::Nova::Server."},{"line_number":445,"context_line":"create:"},{"line_number":446,"context_line":"    This *opitonal* attribute indicates whether the resource should be created."},{"line_number":447,"context_line":"    A value of true will always create, and a value of false will result in the"},{"line_number":448,"context_line":"    resource not created.  If this parameter is unspecified, the resource will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WsE%3D","line":445,"in_reply_to":"AAAAWH%2F9Xww%3D","updated":"2014-04-05 19:27:04.000000000","message":"+1 on making this a separate patch. I guess this will also be something additional in terms of implementation work, so it makes sense to deliver both on-top.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":443,"context_line":"type"},{"line_number":444,"context_line":"    This attribute specifies the type of resource, such as OS::Nova::Server."},{"line_number":445,"context_line":"create:"},{"line_number":446,"context_line":"    This *opitonal* attribute indicates whether the resource should be created."},{"line_number":447,"context_line":"    A value of true will always create, and a value of false will result in the"},{"line_number":448,"context_line":"    resource not created.  If this parameter is unspecified, the resource will"},{"line_number":449,"context_line":"    always be created."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NLk%3D","line":446,"updated":"2014-04-07 23:06:42.000000000","message":"typo, *optional*","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"::"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"  get_var \u003cvariable ID\u003e"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"The *variable ID* of the referenced variable is retrieved for use in other"},{"line_number":712,"context_line":"variable calculations or direct assignment in a resource attribute."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Wro%3D","line":709,"updated":"2014-04-05 19:27:04.000000000","message":"There is a colon missing after get_var","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"::"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"  get_var \u003cvariable ID\u003e"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"The *variable ID* of the referenced variable is retrieved for use in other"},{"line_number":712,"context_line":"variable calculations or direct assignment in a resource attribute."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NwM%3D","line":709,"in_reply_to":"AAAAWH%2F9Wro%3D","updated":"2014-04-07 21:50:19.000000000","message":"agreed will fix","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"  get_var \u003cvariable ID\u003e"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"The *variable ID* of the referenced variable is retrieved for use in other"},{"line_number":712,"context_line":"variable calculations or direct assignment in a resource attribute."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"str_replace"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NXE%3D","line":711,"updated":"2014-04-07 23:06:42.000000000","message":"Slightly confusing wording. The variable ID is looked up and the variable *value* is retrieved.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"0bb99ecc0d420aa76a8cf596dd2e94a29cfe06ce","unresolved":false,"context_lines":[{"line_number":709,"context_line":"  get_var \u003cvariable ID\u003e"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"The *variable ID* of the referenced variable is retrieved for use in other"},{"line_number":712,"context_line":"variable calculations or direct assignment in a resource attribute."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"str_replace"},{"line_number":715,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XUo%3D","line":712,"updated":"2014-04-05 08:49:32.000000000","message":"I\u0027d name it get_variable (full names are great, I really don\u0027t like get_param/get_attr). Also mention \"variable name\" as my previous remark.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"38762104f8173eb89b81d6ade0ddf37eec42eb54","unresolved":false,"context_lines":[{"line_number":709,"context_line":"  get_var \u003cvariable ID\u003e"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"The *variable ID* of the referenced variable is retrieved for use in other"},{"line_number":712,"context_line":"variable calculations or direct assignment in a resource attribute."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"str_replace"},{"line_number":715,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XCM%3D","line":712,"in_reply_to":"AAAAWH%2F9XUo%3D","updated":"2014-04-05 15:38:31.000000000","message":"I\u0027ll do that on my next pass.  Notice the \"get_resource: \u003cresource ID\u003e at line 679 - just following conventions already laid out.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"0bb99ecc0d420aa76a8cf596dd2e94a29cfe06ce","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XUY%3D","line":842,"updated":"2014-04-05 08:49:32.000000000","message":"Those have little to do with variables. As your examples show you can use parameters as well. Otherwise their interface looks fine, I just think we should rename them.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"2ce1ecc266eafcd4baa57df10b11278025f3b7d2","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWn%2F%2F8Yk%3D","line":842,"in_reply_to":"AAAAWH%2F9NXo%3D","updated":"2014-04-08 11:00:19.000000000","message":"First of all: right, I was not talking about sections in the template in my last comment, but about sections in the doc.\n\nSo based on Zane\u0027s last comment it seems like we have two options: (1) only use operators in the variables section, or (2) allow them everywhere.\n\nFor (1), we could stick with short names and then my last comment would apply, i.e. this should be documented as a subsection of the variables section (in the doc) as opposed to the intrinsic functions section.\n\nFor (2), we have to have longer names and we would documented in the same place like all other intrinsic functions. I would probably prefer something like \"operator_and\" etc.\n\nI have a slight tendency to (1), but I am not opposed to (2).","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NXo%3D","line":842,"in_reply_to":"AAAAWH%2F9NvI%3D","updated":"2014-04-07 23:06:42.000000000","message":"I don\u0027t think that\u0027s what Thomas meant, he was talking about how the docs would be organised, rather than how the templates would be organised.\n\nIt seems to me that when you specify the condition in the resource then if it\u0027s one you\u0027re reusing you will probably want to define a variable, but if it isn\u0027t then you\u0027d probably want to just to calculate it inline - which would argue for the logical operators to be like other intrinsic functions.\n\nNote that this is not how CloudFormation does it - there you reference only the name of a conditional in the resource, and it looks it up from the conditionals table. (This has certain benefits in terms of being simple to implement while avoiding circular references.) But I feel like we\u0027re going down a different path by choosing to make a variables section instead. Given that we require you to resolve the value yourself (i.e. using get_var rather than just the name of the variable), there\u0027s no reason to require authors to use a variable.\n\nI would be fine with the name \"operator_and\" or \"logical_and\". Using just \"and\" would be a good idea if we are confining it to the variables section. If we are not then it is probably too generic. (CloudFormation uses Fn:: prefixes to ensure most functions are effectively in their own namespace and thus eliminate that issue, but to date we have chosen not to do that in HOT.)","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NvI%3D","line":842,"in_reply_to":"AAAAWH%2F9TzU%3D","updated":"2014-04-07 21:50:19.000000000","message":"I think we need Zane\u0027s feedback here.  I think he had something in mind for operators outside the variables section, but I\u0027m not certain.\nFor example I think what your proposing is:\n\nvariables:\n  operators:\n     zed: { or [alpha, beta] }\n\nI think the idea is the operators would be used multiple times in a variable assignment with possibly different arguments.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"7e18240f7c02972d9d2acd66c5e7bcc4860eb2d6","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9TzU%3D","line":842,"in_reply_to":"AAAAWH%2F9ViE%3D","updated":"2014-04-07 07:52:24.000000000","message":"I thought about all those \"operators\" / \"intrinsic functions\" some more and it occurred to me that we should not really call them intrinsic function and therefore we should not list them in the intrinsic functions section. They are really operators, and so far it looks like the only really appear in the variables section.\n\nSo shouldn\u0027t we just describe them as a sub-section of the variables section? This would also make the scope pretty clear. Or did any one have in mind extending the rest of a HOT template with this kind of \"programming logic\"?\n\nSteven, is this what you had in mind with your last comment?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3c001ce4b9bfff4c134b847e18ef37f3b2289d93","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9ViE%3D","line":842,"in_reply_to":"AAAAWH%2F9VuI%3D","updated":"2014-04-06 18:38:43.000000000","message":"Yup agree variables and operators are two different things.  I\u0027ll break that into a third patch. (1. variables 2. operators 3.conditional resource creates).  I think the only use case for variables then initially would be something like\n\nvariables:\n  a: { get_param: abc }\n\nI can\u0027t think of any other way to use a variable without conditionals :)","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"761e3d449cf5a987caae7518b99c3fec4bc2c102","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9VuI%3D","line":842,"in_reply_to":"AAAAWH%2F9Wqc%3D","updated":"2014-04-06 14:47:08.000000000","message":"I don\u0027t think that those should be limited to the variables section. That\u0027s also why I think we should remove them from that patch. variables and conditionals are 2 different problems IMO.\n\nRegarding the name, using \"and\", \"or\" would be cool. Otherwise operator_%s looks okay.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Wqc%3D","line":842,"in_reply_to":"AAAAWH%2F9XCE%3D","updated":"2014-04-05 19:27:04.000000000","message":"Could we have really simple names likes \u0027and\u0027, \u0027or\u0027 etc? It looks like those operators must only be used in the variables section, to the scope is considerably small and we use such simple keys here.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"38762104f8173eb89b81d6ade0ddf37eec42eb54","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"The *data type* can be `metadata`, `deletion_policy` or `update_policy`."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XCE%3D","line":842,"in_reply_to":"AAAAWH%2F9XUY%3D","updated":"2014-04-05 15:38:31.000000000","message":"have a suggestion to prefix them with?  Perhaps operator_and?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"},{"line_number":846,"context_line":"evaluate to false."},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Wrc%3D","line":845,"updated":"2014-04-05 19:27:04.000000000","message":".. or returns false ... (not \u0027return false\u0027)","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":842,"context_line":"var_and"},{"line_number":843,"context_line":"-------"},{"line_number":844,"context_line":"The *var_and* function returns true if all the specified boolean variables"},{"line_number":845,"context_line":"evaluate to true, or return false if any one of the specified boolean variables"},{"line_number":846,"context_line":"evaluate to false."},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NvE%3D","line":845,"in_reply_to":"AAAAWH%2F9Wrc%3D","updated":"2014-04-07 21:50:19.000000000","message":"agree will fix","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":854,"context_line":"    - ..."},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"The example below demonstrates *var_and* usage and its impact on the creation"},{"line_number":857,"context_line":"of a resource.  In this example, server_create is set to true if parameter if"},{"line_number":858,"context_line":"the create_small parameter is set to yes and hte instance_type parameter is set"},{"line_number":859,"context_line":"to m1.small.  This example uses the var_equals intrinsic function in the"},{"line_number":860,"context_line":"calculation of variable results."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WrY%3D","line":857,"updated":"2014-04-05 19:27:04.000000000","message":"\u0027if parameter if\u0027 and some more typos in this sentence","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":854,"context_line":"    - ..."},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"The example below demonstrates *var_and* usage and its impact on the creation"},{"line_number":857,"context_line":"of a resource.  In this example, server_create is set to true if parameter if"},{"line_number":858,"context_line":"the create_small parameter is set to yes and hte instance_type parameter is set"},{"line_number":859,"context_line":"to m1.small.  This example uses the var_equals intrinsic function in the"},{"line_number":860,"context_line":"calculation of variable results."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NvA%3D","line":857,"in_reply_to":"AAAAWH%2F9WrY%3D","updated":"2014-04-07 21:50:19.000000000","message":"agree will fix","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":886,"context_line":""},{"line_number":887,"context_line":"::"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"  var_equals:"},{"line_number":890,"context_line":"    - \u003cvalue1\u003e"},{"line_number":891,"context_line":"    - \u003cvalue2\u003e"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WrU%3D","line":889,"updated":"2014-04-05 19:27:04.000000000","message":"I would probably use the one line notation here:\n\n var_equals: [ \u003cvalue1\u003e, \u003cvalue2\u003e ]","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":886,"context_line":""},{"line_number":887,"context_line":"::"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"  var_equals:"},{"line_number":890,"context_line":"    - \u003cvalue1\u003e"},{"line_number":891,"context_line":"    - \u003cvalue2\u003e"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NPg%3D","line":889,"updated":"2014-04-07 23:06:42.000000000","message":"Prefer \"equal\" to \"equals\".\n\nMaybe \"operator_equal\"?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"cd16265e166dfaf8a459993167c81f60d4bb3cad","unresolved":false,"context_lines":[{"line_number":886,"context_line":""},{"line_number":887,"context_line":"::"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"  var_equals:"},{"line_number":890,"context_line":"    - \u003cvalue1\u003e"},{"line_number":891,"context_line":"    - \u003cvalue2\u003e"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NIQ%3D","line":889,"in_reply_to":"AAAAWH%2F9NPg%3D","updated":"2014-04-08 02:39:15.000000000","message":"agree operator_equal wfm.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":886,"context_line":""},{"line_number":887,"context_line":"::"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"  var_equals:"},{"line_number":890,"context_line":"    - \u003cvalue1\u003e"},{"line_number":891,"context_line":"    - \u003cvalue2\u003e"},{"line_number":892,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Nu8%3D","line":889,"in_reply_to":"AAAAWH%2F9WrU%3D","updated":"2014-04-07 21:50:19.000000000","message":"agree will fix","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":891,"context_line":"    - \u003cvalue2\u003e"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"The example below demonstrates *var_equals* usage.  In this example, the"},{"line_number":894,"context_line":"variable small_deesired is set to true if the parameter create_small is set"},{"line_number":895,"context_line":"to \u0027yes\u0027 otherwise the variable small_desired is set to false."},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WrQ%3D","line":894,"updated":"2014-04-05 19:27:04.000000000","message":"typo: small_deesired","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":891,"context_line":"    - \u003cvalue2\u003e"},{"line_number":892,"context_line":""},{"line_number":893,"context_line":"The example below demonstrates *var_equals* usage.  In this example, the"},{"line_number":894,"context_line":"variable small_deesired is set to true if the parameter create_small is set"},{"line_number":895,"context_line":"to \u0027yes\u0027 otherwise the variable small_desired is set to false."},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Nu0%3D","line":894,"in_reply_to":"AAAAWH%2F9WrQ%3D","updated":"2014-04-07 21:50:19.000000000","message":"agree will fix","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"b264945a519893e5e0756fcd30e666968c71910c","unresolved":false,"context_lines":[{"line_number":906,"context_line":"  variables:"},{"line_number":907,"context_line":"    small_desired: { var_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"var_not"},{"line_number":910,"context_line":"-------"},{"line_number":911,"context_line":"The *var_not* function returns true for a variable that evaluates to false"},{"line_number":912,"context_line":"otherwise returns true."}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Xw0%3D","line":909,"updated":"2014-04-05 03:03:42.000000000","message":"do we need a var_true or is var_equals good enough for this purpose?","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":914,"context_line":"::"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"  var_not:"},{"line_number":917,"context_line":"    - \u003cvariable ID\u003e"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"The example below demonstrates *var_not*.  If the parameter create_small is"},{"line_number":920,"context_line":"set to \u0027yes\u0027 the variable no_small_desired is set to true, otherwise"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WrA%3D","line":917,"updated":"2014-04-05 19:27:04.000000000","message":"I think this does not correctly specify the syntax. It should be:\n\n var_not: [ \u003cvariable ID\u003e, \u003cvalue\u003e ]","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"4a497ab58ea275c7414d54a5ac7c391d07ebd67f","unresolved":false,"context_lines":[{"line_number":914,"context_line":"::"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"  var_not:"},{"line_number":917,"context_line":"    - \u003cvariable ID\u003e"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"The example below demonstrates *var_not*.  If the parameter create_small is"},{"line_number":920,"context_line":"set to \u0027yes\u0027 the variable no_small_desired is set to true, otherwise"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Voc%3D","line":917,"in_reply_to":"AAAAWH%2F9WcU%3D","updated":"2014-04-06 16:28:34.000000000","message":"Ok but then you have to update the example below (line 934), because that currently suggests that you compare something to the value \u0027yes\u0027.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"85a11da39607a42bddaaf12d8ea490ec5686cd66","unresolved":false,"context_lines":[{"line_number":914,"context_line":"::"},{"line_number":915,"context_line":""},{"line_number":916,"context_line":"  var_not:"},{"line_number":917,"context_line":"    - \u003cvariable ID\u003e"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"The example below demonstrates *var_not*.  If the parameter create_small is"},{"line_number":920,"context_line":"set to \u0027yes\u0027 the variable no_small_desired is set to true, otherwise"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9WcU%3D","line":917,"in_reply_to":"AAAAWH%2F9WrA%3D","updated":"2014-04-06 01:28:57.000000000","message":"this is a logical not, not a comparison.  The comparison ideally would be done with var_equals.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":919,"context_line":"The example below demonstrates *var_not*.  If the parameter create_small is"},{"line_number":920,"context_line":"set to \u0027yes\u0027 the variable no_small_desired is set to true, otherwise"},{"line_number":921,"context_line":"no_small_desired is set to false."},{"line_number":922,"context_line":"parameter is not set to yes.small."},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"::"},{"line_number":925,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NKU%3D","line":922,"updated":"2014-04-07 23:06:42.000000000","message":"parse error.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"e2d93617e71dbde3d46795995d4e89cbc5d30c74","unresolved":false,"context_lines":[{"line_number":931,"context_line":"      description: Instance type to be used."},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"  variables:"},{"line_number":934,"context_line":"    no_small_desired: { var_not: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"var_or"},{"line_number":937,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9NOA%3D","line":934,"updated":"2014-04-07 23:06:42.000000000","message":"This example looks more like \"operator_not_equal\" than \"logical_not\".","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"2ce1ecc266eafcd4baa57df10b11278025f3b7d2","unresolved":false,"context_lines":[{"line_number":931,"context_line":"      description: Instance type to be used."},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"  variables:"},{"line_number":934,"context_line":"    no_small_desired: { var_not: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"var_or"},{"line_number":937,"context_line":"------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWn%2F%2F8Xw%3D","line":934,"in_reply_to":"AAAAWH%2F9NOA%3D","updated":"2014-04-08 11:00:19.000000000","message":"Yup, that\u0027s what I also meant above.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7193,"name":"Thomas Spatzier","email":"thomas.spatzier@icloud.com","username":"thomasspatzier"},"change_message_id":"e9abcbbb201c1f432b1a0af66a92c83d850d3831","unresolved":false,"context_lines":[{"line_number":979,"context_line":""},{"line_number":980,"context_line":"::"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"  var_or:"},{"line_number":983,"context_line":"    - \u003cvariable ID\u003e"},{"line_number":984,"context_line":"    - \u003ctrue result\u003e"},{"line_number":985,"context_line":"    - \u003cfalse result\u003e (optional)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Wqs%3D","line":982,"updated":"2014-04-05 19:27:04.000000000","message":"should be \u0027var_if_then:\u0027","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0044dcb4a85adfa1d2ebfa3e0c94abe5889337e0","unresolved":false,"context_lines":[{"line_number":979,"context_line":""},{"line_number":980,"context_line":"::"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"  var_or:"},{"line_number":983,"context_line":"    - \u003cvariable ID\u003e"},{"line_number":984,"context_line":"    - \u003ctrue result\u003e"},{"line_number":985,"context_line":"    - \u003cfalse result\u003e (optional)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Nuw%3D","line":982,"in_reply_to":"AAAAWH%2F9Wqs%3D","updated":"2014-04-07 21:50:19.000000000","message":"agree will fix","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":6904,"name":"Guillaume Thouvenin","email":"gthouvenin@mirantis.com","username":"guillaume-thouvenin"},"change_message_id":"b193501a6c77eeb8c2d5b58e9df3a7c6159cf352","unresolved":false,"context_lines":[{"line_number":987,"context_line":""},{"line_number":988,"context_line":"The example below demonstrates *var_if_then*.  If the variable is true, then"},{"line_number":989,"context_line":"the true response will be returned.  if the variable is false, then the false"},{"line_number":990,"context_line":"result will be returned.  The response can be any boolean, string, or valuees"},{"line_number":991,"context_line":"generated by other intrinsic operations."},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAW3%2F%2FzC0%3D","line":990,"updated":"2014-04-10 10:54:20.000000000","message":"typo: values","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"b264945a519893e5e0756fcd30e666968c71910c","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  variables"},{"line_number":1008,"context_line":"    small_desired: { var_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":1009,"context_line":"    type_valid: { var_equals: [ { get_param: instance_type }, \u0027m1.small\u0027 ] }"},{"line_number":1010,"context_line":"    server_create: var_if_then [ { get_var(small_desired } , \u0027yes\u0027, \u0027no\u0027 ] }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9Xw4%3D","line":1010,"updated":"2014-04-05 03:03:42.000000000","message":"missing a ) in get_var","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3c001ce4b9bfff4c134b847e18ef37f3b2289d93","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  variables"},{"line_number":1008,"context_line":"    small_desired: { var_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":1009,"context_line":"    type_valid: { var_equals: [ { get_param: instance_type }, \u0027m1.small\u0027 ] }"},{"line_number":1010,"context_line":"    server_create: var_if_then [ { get_var(small_desired } , \u0027yes\u0027, \u0027no\u0027 ] }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9VhY%3D","line":1010,"in_reply_to":"AAAAWH%2F9VuE%3D","updated":"2014-04-06 18:38:43.000000000","message":"Its all good, I don\u0027t feel criticized - just explaining why the examples are not spectacular.  You are right though, mapping the real world use cases would be helpful, although I honestly don\u0027t know what they are.  I can only think of a few such as image selection, optional resource launching, and some more advanced logical operations around parameters.  Beyond that I\u0027m drawing a blank.  I do expect if we take a leap of faith on this, people will find all ways to ab-use it we had not thought of :)","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"761e3d449cf5a987caae7518b99c3fec4bc2c102","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  variables"},{"line_number":1008,"context_line":"    small_desired: { var_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":1009,"context_line":"    type_valid: { var_equals: [ { get_param: instance_type }, \u0027m1.small\u0027 ] }"},{"line_number":1010,"context_line":"    server_create: var_if_then [ { get_var(small_desired } , \u0027yes\u0027, \u0027no\u0027 ] }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9VuE%3D","line":1010,"in_reply_to":"AAAAWH%2F9XAg%3D","updated":"2014-04-06 14:47:08.000000000","message":"Sorry I didn\u0027t mean to criticize what you\u0027ve done, that\u0027s great. I meant that to be able to know if the change makes sense, it\u0027d be easier if we had examples that map to real use cases that we can\u0027t solve otherwise. Maybe we should ask people that wanted mappings for example what they can do with variables.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"38762104f8173eb89b81d6ade0ddf37eec42eb54","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  variables"},{"line_number":1008,"context_line":"    small_desired: { var_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":1009,"context_line":"    type_valid: { var_equals: [ { get_param: instance_type }, \u0027m1.small\u0027 ] }"},{"line_number":1010,"context_line":"    server_create: var_if_then [ { get_var(small_desired } , \u0027yes\u0027, \u0027no\u0027 ] }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XAg%3D","line":1010,"in_reply_to":"AAAAWH%2F9XUM%3D","updated":"2014-04-05 15:38:31.000000000","message":"I\u0027ll come up with better examples once folks are satisified with the spec changes.  I didn\u0027t want to invest a whole bunch of time into creating examples until we have general agreement on the changes (or there is a -2 from the core team).\n\nI already spent a bunch of time creating examples for the conditionals interface, and that effort is essentially wasted.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"0bb99ecc0d420aa76a8cf596dd2e94a29cfe06ce","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"  variables"},{"line_number":1008,"context_line":"    small_desired: { var_equals: [ { get_param: create_small } , \u0027yes\u0027 ] }"},{"line_number":1009,"context_line":"    type_valid: { var_equals: [ { get_param: instance_type }, \u0027m1.small\u0027 ] }"},{"line_number":1010,"context_line":"    server_create: var_if_then [ { get_var(small_desired } , \u0027yes\u0027, \u0027no\u0027 ] }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"AAAAWH%2F9XUM%3D","line":1010,"in_reply_to":"AAAAWH%2F9Xw4%3D","updated":"2014-04-05 08:49:32.000000000","message":"You mean get_var: small_desired.\n\nI think we need better examples, because those particular use cases are better solved with boolean parameters and constraints.","commit_id":"f58bdfd43d00b16f01434152bf57699a30b6b2ee"}]}
