)]}'
{"id":"openstack%2Fheat~849944","triplet_id":"openstack%2Fheat~stable%2Fwallaby~I096dff2b541a5aa8afbbbcea5161e7ca1c244039","project":"openstack/heat","branch":"stable/wallaby","attention_set":{},"removed_from_attention_set":{"9816":{"account":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"last_update":"2022-07-15 09:32:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I096dff2b541a5aa8afbbbcea5161e7ca1c244039","subject":"Don\u0027t always replace FAILED ServerGroup resources","status":"MERGED","created":"2022-07-15 06:17:27.000000000","updated":"2022-07-15 09:33:37.000000000","submitted":"2022-07-15 09:32:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"849944","meta_rev_id":"8cc12a86111506e0581881e0d5ff15d59c0e933f","_number":849944,"virtual_id_number":849944,"owner":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-15 09:32:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"all":[{"value":2,"date":"2022-07-15 07:49:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"all":[{"value":1,"date":"2022-07-15 07:49:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-15 06:17:27.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"CC"},{"updated":"2022-07-15 06:41:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-07-15 07:46:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-15 07:49:15.000000000","updated_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"REVIEWER"}],"messages":[{"id":"0e6a10939201ef313d5445294271cb9cf4c8ae0d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-07-15 06:17:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5a7344bcd44b8950bdedb32a25451a23745f580b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-07-15 06:18:39.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6a8b734e2b696383102696c663eb8f67d5e215e0","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 06:41:38.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2a1810ca215448af93e86fca3bb5ae05\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7b67f9890f8e480f92b18f82096170bb : SUCCESS in 10m 58s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/e2d6d0f96828485e80560e1e2d9ce878 : SUCCESS in 21m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"fefd2f3cfde5722745dba5d6ace8f570b646495b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 07:46:46.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/50e69870f60547f8bddd4dbfae7aee65\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/29307d65705e4d87b18cccdb0f2b8b1d : SUCCESS in 10m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/efdc96ee73954435b6961947d60005e6 : SUCCESS in 7m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5c3e733da3cc4296af5a1c01377f1867 : SUCCESS in 7m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3f0c9fffff564dd0a9347be843177137 : SUCCESS in 8m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d8421bedca6e4ca3b90aa5f2c10dffdc : SUCCESS in 7m 29s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c34ad77a114b47839063c880879c9f24 : SUCCESS in 10m 15s\n- grenade-heat-multinode https://zuul.opendev.org/t/openstack/build/3fe879c43d7341028054c7c7e738152e : SUCCESS in 1h 26m 34s\n- heat-functional https://zuul.opendev.org/t/openstack/build/40155c6854624dbd96d05f660f074399 : SUCCESS in 58m 50s\n- heat-functional-legacy https://zuul.opendev.org/t/openstack/build/29a9c5b7fb6040568419d7fd8463335f : SUCCESS in 1h 01m 02s","accounts_in_message":[],"_revision_number":2},{"id":"7c2fcb826d33840711458f60fb3acc35e9d8832e","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2022-07-15 07:49:15.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"876ab1f5fe1e8ed13a52452b295469c13bab4978","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 07:49:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"bf0f538ccbbedad27210c3d5d8e5562424de90c4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 09:32:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1f4b44d7619e401e8f2ca7984ae5fe0a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef9663ac069343ee87f6bf91355f6c3d : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6eebce77dba644d589ae530b24be1d4e : SUCCESS in 9m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2491fec9d4aa44feb4a777e5398b88c3 : SUCCESS in 7m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/42af3b822c564eaf9bdb0c77acb0aaad : SUCCESS in 10m 48s\n- grenade-heat-multinode https://zuul.opendev.org/t/openstack/build/43984d7902354316b93f72fbd002c734 : SUCCESS in 1h 38m 03s\n- heat-functional https://zuul.opendev.org/t/openstack/build/820669f6eab3477c8cdbd8d2ef099464 : SUCCESS in 1h 04m 46s\n- heat-functional-legacy https://zuul.opendev.org/t/openstack/build/08f58ef5d96a4ea5ba72899114a65c69 : SUCCESS in 1h 01m 06s","accounts_in_message":[],"_revision_number":2},{"id":"a912622159bb9ec7113af0ca52f8fdc472bf4bb1","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 09:32:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"8cc12a86111506e0581881e0d5ff15d59c0e933f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-15 09:33:37.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/04b819f630644337bca6d983d365bf65\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4c63ef051dfc4481ad14d523a544a79a : SUCCESS in 51s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a4f2f6053c8b45b1e9182caad4a8af44e29ae96d","revisions":{"fa1a362235efdef62fbac5aa27f12a350d596a14":{"kind":"REWORK","_number":1,"created":"2022-07-15 06:17:27.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/44/849944/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/44/849944/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/44/849944/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/44/849944/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/44/849944/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/44/849944/1"}}},"commit":{"parents":[{"commit":"da071a07d509b8f589f934db1aaeee6daff40bd3","subject":"Use openstack commands in upgrade plugin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/da071a07d509b8f589f934db1aaeee6daff40bd3"}]}],"author":{"name":"Rabi Mishra","email":"ramishra@redhat.com","date":"2022-07-08 04:40:50.000000000","tz":330},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-07-15 06:17:16.000000000","tz":540},"subject":"Don\u0027t always replace FAILED ServerGroup resources","message":"Don\u0027t always replace FAILED ServerGroup resources\n\nServerGroup resources work as scheduler hints for server\nresources and replacement of it replaces the servers which\nis undesirable in many circumstances.\n\n- We don\u0027t allow update of ServerGroup resource properties\n- If not created (CREATE_FAILED) without resource_id they will\n  be replaced\n- If does not exist in nova they would be created\n- If exist in nova, FAILED resource status would be just\n  changed to COMPLETE\n\nConflicts:\n\theat/tests/openstack/nova/test_server_group.py\n\nTask: 45748\n\nChange-Id: I096dff2b541a5aa8afbbbcea5161e7ca1c244039\n(cherry picked from commit a0e072b3204d736b9a4a5b2ceb2157f57405ac6f)\n(cherry picked from commit f9f5d2cc368e5f850b962c8d89669a50544058d1)\n(cherry picked from commit ead7cd61bd685ea46dd21c4ef3ea6b3fde273c10)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/fa1a362235efdef62fbac5aa27f12a350d596a14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/fa1a362235efdef62fbac5aa27f12a350d596a14"}]},"branch":"refs/heads/stable/wallaby"},"a4f2f6053c8b45b1e9182caad4a8af44e29ae96d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-07-15 06:18:39.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/44/849944/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/heat","ref":"refs/changes/44/849944/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/heat refs/changes/44/849944/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/heat refs/changes/44/849944/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/heat refs/changes/44/849944/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/heat refs/changes/44/849944/2"}}},"commit":{"parents":[{"commit":"da071a07d509b8f589f934db1aaeee6daff40bd3","subject":"Use openstack commands in upgrade plugin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/da071a07d509b8f589f934db1aaeee6daff40bd3"}]}],"author":{"name":"Rabi Mishra","email":"ramishra@redhat.com","date":"2022-07-08 04:40:50.000000000","tz":330},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2022-07-15 06:18:17.000000000","tz":540},"subject":"Don\u0027t always replace FAILED ServerGroup resources","message":"Don\u0027t always replace FAILED ServerGroup resources\n\nServerGroup resources work as scheduler hints for server\nresources and replacement of it replaces the servers which\nis undesirable in many circumstances.\n\n- We don\u0027t allow update of ServerGroup resource properties\n- If not created (CREATE_FAILED) without resource_id they will\n  be replaced\n- If does not exist in nova they would be created\n- If exist in nova, FAILED resource status would be just\n  changed to COMPLETE\n\nConflicts:\n\theat/tests/openstack/nova/test_server_group.py\n\nFixed conflicts caused by 74164424016702bac6d52c6618360287ce7ea461 ,\nwhich is present in stable/xena and later.\n\nTask: 45748\n\nChange-Id: I096dff2b541a5aa8afbbbcea5161e7ca1c244039\n(cherry picked from commit a0e072b3204d736b9a4a5b2ceb2157f57405ac6f)\n(cherry picked from commit f9f5d2cc368e5f850b962c8d89669a50544058d1)\n(cherry picked from commit ead7cd61bd685ea46dd21c4ef3ea6b3fde273c10)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/a4f2f6053c8b45b1e9182caad4a8af44e29ae96d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/heat/commit/a4f2f6053c8b45b1e9182caad4a8af44e29ae96d"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"}}]}],"submit_requirements":[]}