)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ba53f0b5407175ae605c1f2794d3a4d4e979b7a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7158eb96_069ab046","updated":"2023-09-22 13:35:51.000000000","message":"@Takashi-san This can be abandoned now. I have a complete series that finishes [here](https://review.opendev.org/c/openstack/heat/+/896035/)","commit_id":"11cc25ba7274b6168621ed1c2da6939597578b9b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fd7d455355a4ed6c5ecf268574afba2f24586c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"37e3a9b7_a4caeb11","updated":"2023-06-22 13:55:47.000000000","message":"The errors you are seeing are mostly because we\u0027re now doing things within a single transactions, rather than separate transactions (one being finished and a new one started when we autocommit).\n\nI had started resolving this locally by switching to the decorator pattern that oslo.db has supported for a number of years, where DB APIs are wrapped in either a reader or writer transaction context (via a decorator) but that highlighted the exact same issues we were seeing here. This could be difficult to resolve... 😞","commit_id":"11cc25ba7274b6168621ed1c2da6939597578b9b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1e4f40aa6933ca964c3f8a784613bd16b5def6ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7103c212_e7ece991","in_reply_to":"7158eb96_069ab046","updated":"2023-09-22 16:48:51.000000000","message":"Thanks for your effort in these patches ! I\u0027ll take time to review the remaining patches !","commit_id":"11cc25ba7274b6168621ed1c2da6939597578b9b"}],"heat/db/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fd7d455355a4ed6c5ecf268574afba2f24586c2","unresolved":true,"context_lines":[{"line_number":150,"context_line":"def raw_template_create(context, values):"},{"line_number":151,"context_line":"    raw_template_ref \u003d models.RawTemplate()"},{"line_number":152,"context_line":"    raw_template_ref.update(values)"},{"line_number":153,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":154,"context_line":"        raw_template_ref.save(context.session)"},{"line_number":155,"context_line":"    return raw_template_ref"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f93258f_9d96e06d","line":153,"updated":"2023-06-22 13:55:47.000000000","message":"btw, the `subtransactions` flag is also deprecated","commit_id":"11cc25ba7274b6168621ed1c2da6939597578b9b"}]}
