)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"947f1a3266388584e6f1fba0fa3220a3ec6d810a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add OS::Aodh::PrometheusAlarm resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for Aodh alarms of type Prometheus."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5bb7c4d9086715fc22c0f7abc36d9bbfc88a60c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6e4f8238_a35471f9","line":10,"updated":"2023-09-06 10:43:29.000000000","message":"Please add https://review.opendev.org/c/openstack/aodh/+/890529 (and any other required patch to use the new alarm type) using depends-on","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ee067d91e14b07fd0a99ee8d2b7d93f17ee358b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add OS::Aodh::PrometheusAlarm resource"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for Aodh alarms of type Prometheus."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5bb7c4d9086715fc22c0f7abc36d9bbfc88a60c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff43aab2_c03d2fcc","line":10,"in_reply_to":"6e4f8238_a35471f9","updated":"2023-10-03 02:59:37.000000000","message":"Done","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ee067d91e14b07fd0a99ee8d2b7d93f17ee358b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for Aodh alarms of type Prometheus."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: Ie7477e0b11479449f7f13c7a784737ac70059964"},{"line_number":12,"context_line":"Change-Id: I5bb7c4d9086715fc22c0f7abc36d9bbfc88a60c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b95f561f_44af5f04","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":53},"updated":"2023-10-03 02:59:37.000000000","message":"should we use I72e124cca4398b78f7ed12e1db3f66bdbfcb196e instead ?","commit_id":"42b200ece80a95bfdf96957a95cfb7b85105a40c"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"d6e12a34cb785b049b0a1dd78eb9be12b1becdfd","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds support for Aodh alarms of type Prometheus."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: Ie7477e0b11479449f7f13c7a784737ac70059964"},{"line_number":12,"context_line":"Change-Id: I5bb7c4d9086715fc22c0f7abc36d9bbfc88a60c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f684abee_c998edc8","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":53},"in_reply_to":"b95f561f_44af5f04","updated":"2023-10-03 11:25:17.000000000","message":"Ah indeed.","commit_id":"42b200ece80a95bfdf96957a95cfb7b85105a40c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ab74b3ad1f4d1782ef5c39d0d3523736b50fe59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1003cc0d_d6779fb9","updated":"2023-09-06 10:41:45.000000000","message":"Could you please add some unit tests to heat/tests/openstack/aodh/test_alarm.py ?\n\nAlso, this is adds a new feature so we may need a release note.\n\nNote that heat follows stable-policy so this should not be backported.","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"d472111f0ddf0376825bdf2623739bb9a2c75395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ac50a3e_a362bd42","in_reply_to":"1003cc0d_d6779fb9","updated":"2023-09-06 11:51:46.000000000","message":"Ack","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"241c2acc169605d83e9795f727a4ca1e882242c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9fb931f1_e8848241","updated":"2023-09-25 12:43:49.000000000","message":"Few comments, otherwise LGTM.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f5453f2ce0650f027d745174e61216e9a96d7a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6d19b5ca_2d461366","updated":"2023-10-02 10:50:49.000000000","message":"I am aware that it has been noted that this patch should not be backported to older releases. I\u0027m wondering if there are some exceptions for this. Having this in stable/antelope would enable us making downstream-only patches when we will be pulling this to OSP.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8384585072826d158a909a2d30c3f6d35420c84","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ac2c6ab5_c192b376","in_reply_to":"5117a151_34e0b80a","updated":"2023-11-10 03:23:47.000000000","message":"... and as you know people prefer reducing steps for upgrade. I used to request all of my customers to complete minor upgrade before they start major upgrade but their feedback was not really good. Even RHOSP removed the requirement to complete minor update before upgrade, as you know.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"11632acb8d4b8a931b3d9fc77639b1634bbc86b9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6814a17_89fe8643","in_reply_to":"5938aa9f_b0752866","updated":"2023-10-04 06:06:23.000000000","message":"Who would upgrade from 20.1.0 to 21.0.0 instead of the latest 21.x version, which should also contain the backport?","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e93390d1285af581fd87e9a46cb1f86e3ce952c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff38e72b_a82f345c","in_reply_to":"6d19b5ca_2d461366","updated":"2023-10-03 02:52:16.000000000","message":"I don\u0027t think exception is feasible. Heat follows stable policy which declares backporting a feature is not allowed. Allowing exceptions means making heat not following the stable policy and that needs feedback from wider community considering its impact.\n\nhttps://docs.openstack.org/project-team-guide/stable-branches.html#active-maintenance","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15b7650e15a3d0e51f81b9bdba43305756329c36","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5117a151_34e0b80a","in_reply_to":"f6814a17_89fe8643","updated":"2023-10-07 02:09:03.000000000","message":"It might be rare but we don\u0027t have strict policy to prohibit upgrade to non-latest in upstream.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1cd8f49f4a0eb7c0ebdba23e3e6148d63a2dfad7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ffafb590_e06a3292","in_reply_to":"ff38e72b_a82f345c","updated":"2023-10-03 02:54:54.000000000","message":"One technical problem here is that current resource type definition does not work with feature backport. In case we backport this feature to antelope, we expect the feature may be available in 20.1.0 but not in 21.0.0. This can\u0027t be properly declared in current schema which declares the minimum supported version.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"d6e12a34cb785b049b0a1dd78eb9be12b1becdfd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5938aa9f_b0752866","in_reply_to":"ffafb590_e06a3292","updated":"2023-10-03 11:25:17.000000000","message":"Thanks for explanation.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"a34111f1499340dae3996bf109e6821b9a84351e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b002f65_3307d283","updated":"2023-10-10 05:59:23.000000000","message":"Can we proceed with this patch now that bobcat sailed, or are there other issues with this feature here?","commit_id":"f8a44f490459fb8ad2700bbbb68dcd2d7deeb488"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"305c7b7fc0e6a4365dce7e0162b4ce741689e5d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e7457e44_42998c8d","updated":"2023-11-07 18:21:20.000000000","message":"The dependency is merged already. Can we please proceed with merging now?","commit_id":"f8a44f490459fb8ad2700bbbb68dcd2d7deeb488"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6d0a972247d77d2849a4209ef8a2857fb2549766","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5a97ac17_41875e6b","in_reply_to":"2b002f65_3307d283","updated":"2023-10-10 06:53:53.000000000","message":"The change looks good to me but we have to get the dependent aodh change merged first.","commit_id":"f8a44f490459fb8ad2700bbbb68dcd2d7deeb488"}],"heat/engine/resources/openstack/aodh/alarm.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ab74b3ad1f4d1782ef5c39d0d3523736b50fe59","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                                       self.get_alarm_props(new_props))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class AodhParseLiveResourceDataMixin:"},{"line_number":39,"context_line":"    def parse_live_resource_data(self, resource_properties,"},{"line_number":40,"context_line":"                                 resource_data):"},{"line_number":41,"context_line":"        record_reality \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"21ccebe3_df995713","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":36},"updated":"2023-09-06 10:41:45.000000000","message":"This is currently used only by PrometheusAlarm so I don;t see any benefit of separate mixin.","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"d472111f0ddf0376825bdf2623739bb9a2c75395","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                       self.get_alarm_props(new_props))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class AodhParseLiveResourceDataMixin:"},{"line_number":39,"context_line":"    def parse_live_resource_data(self, resource_properties,"},{"line_number":40,"context_line":"                                 resource_data):"},{"line_number":41,"context_line":"        record_reality \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"0309bb51_b88bde19","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":36},"in_reply_to":"21ccebe3_df995713","updated":"2023-09-06 11:51:46.000000000","message":"Ack","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ab74b3ad1f4d1782ef5c39d0d3523736b50fe59","unresolved":true,"context_lines":[{"line_number":425,"context_line":"    Prometheus."},{"line_number":426,"context_line":"    \"\"\""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002720.0.0\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    PROPERTIES \u003d ("},{"line_number":431,"context_line":"        COMPARISON_OPERATOR, QUERY, THRESHOLD,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9ce456f_137b0a2e","line":428,"updated":"2023-09-06 10:41:45.000000000","message":"20.0.0 was already released. This should be 21.0.0.","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"d472111f0ddf0376825bdf2623739bb9a2c75395","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    Prometheus."},{"line_number":426,"context_line":"    \"\"\""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002720.0.0\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    PROPERTIES \u003d ("},{"line_number":431,"context_line":"        COMPARISON_OPERATOR, QUERY, THRESHOLD,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e5072692_ba93af3d","line":428,"in_reply_to":"a9ce456f_137b0a2e","updated":"2023-09-06 11:51:46.000000000","message":"Ack","commit_id":"45d68726d28f067094e610044300fe09d4c525e8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d6ed14ba18c142ef3adc4150ea7cb9abf07e4d96","unresolved":true,"context_lines":[{"line_number":409,"context_line":"    Prometheus."},{"line_number":410,"context_line":"    \"\"\""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002721.0.0\u0027)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    PROPERTIES \u003d ("},{"line_number":415,"context_line":"        COMPARISON_OPERATOR, QUERY, THRESHOLD,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f569d6f9_1ca27f42","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":58},"updated":"2023-09-12 12:46:26.000000000","message":"jfyi. we are close to release RC1, and it might be too late to include it in 21.0.0.","commit_id":"26586470fcb740703d756e142c407269f7b61144"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4ee067d91e14b07fd0a99ee8d2b7d93f17ee358b","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    Prometheus."},{"line_number":410,"context_line":"    \"\"\""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002721.0.0\u0027)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    PROPERTIES \u003d ("},{"line_number":415,"context_line":"        COMPARISON_OPERATOR, QUERY, THRESHOLD,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ab4fc651_fee541f4","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":58},"in_reply_to":"18f774c2_66b7eef7","updated":"2023-10-03 02:59:37.000000000","message":"Done","commit_id":"26586470fcb740703d756e142c407269f7b61144"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f5453f2ce0650f027d745174e61216e9a96d7a5b","unresolved":true,"context_lines":[{"line_number":409,"context_line":"    Prometheus."},{"line_number":410,"context_line":"    \"\"\""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002721.0.0\u0027)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    PROPERTIES \u003d ("},{"line_number":415,"context_line":"        COMPARISON_OPERATOR, QUERY, THRESHOLD,"}],"source_content_type":"text/x-python","patch_set":3,"id":"18f774c2_66b7eef7","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":58},"in_reply_to":"8b62ee95_998b7a60","updated":"2023-10-02 10:50:49.000000000","message":"Yup, will do.","commit_id":"26586470fcb740703d756e142c407269f7b61144"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"241c2acc169605d83e9795f727a4ca1e882242c1","unresolved":true,"context_lines":[{"line_number":409,"context_line":"    Prometheus."},{"line_number":410,"context_line":"    \"\"\""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    support_status \u003d support.SupportStatus(version\u003d\u002721.0.0\u0027)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    PROPERTIES \u003d ("},{"line_number":415,"context_line":"        COMPARISON_OPERATOR, QUERY, THRESHOLD,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8b62ee95_998b7a60","line":412,"range":{"start_line":412,"start_character":52,"end_line":412,"end_character":58},"in_reply_to":"f569d6f9_1ca27f42","updated":"2023-09-25 12:43:49.000000000","message":"RC1 has already been cut, update this to 22.0.0?","commit_id":"26586470fcb740703d756e142c407269f7b61144"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"241c2acc169605d83e9795f727a4ca1e882242c1","unresolved":true,"context_lines":[{"line_number":428,"context_line":"            properties.Schema.STRING,"},{"line_number":429,"context_line":"            _(\u0027The PromQL query string to fetch metrics data \u0027"},{"line_number":430,"context_line":"              \u0027from Prometheus.\u0027),"},{"line_number":431,"context_line":"            required\u003dTrue,"},{"line_number":432,"context_line":"            update_allowed\u003dTrue"},{"line_number":433,"context_line":"        ),"},{"line_number":434,"context_line":"        THRESHOLD: properties.Schema("}],"source_content_type":"text/x-python","patch_set":4,"id":"2cc9cff0_d1c65dec","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":26},"updated":"2023-09-25 12:43:49.000000000","message":"I guess this is intentionally set to True?","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"f5453f2ce0650f027d745174e61216e9a96d7a5b","unresolved":true,"context_lines":[{"line_number":428,"context_line":"            properties.Schema.STRING,"},{"line_number":429,"context_line":"            _(\u0027The PromQL query string to fetch metrics data \u0027"},{"line_number":430,"context_line":"              \u0027from Prometheus.\u0027),"},{"line_number":431,"context_line":"            required\u003dTrue,"},{"line_number":432,"context_line":"            update_allowed\u003dTrue"},{"line_number":433,"context_line":"        ),"},{"line_number":434,"context_line":"        THRESHOLD: properties.Schema("}],"source_content_type":"text/x-python","patch_set":4,"id":"d6bbbfa0_3fd9e07b","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":26},"in_reply_to":"2cc9cff0_d1c65dec","updated":"2023-10-02 10:50:49.000000000","message":"Yes, it is intentional. It\u0027s not possible to create reasonable autoscaling strategy without query.","commit_id":"c7f924dbec296942a926635133ebea2c70db32ba"}]}