)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87509357fb37be323c5a2c905eb6f12ad2e66490","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85c1842e_cfce73a5","updated":"2024-11-05 15:15:08.000000000","message":"Please do not propose a change directly to a stable branch unless the change is really specific to the stable branch.\n\nAlso I\u0027m unsure if this is really beneficial. Please see my comment inline.","commit_id":"4fe52f3e51c8e6d4d920efa869c592de70ea99df"},{"author":{"_account_id":36726,"name":"KwangwooPark","email":"kwangwoo49.park@gmail.com","username":"kwangwoo"},"change_message_id":"5602707d954780c890af4aa43ff67ac5c9486dc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb9b2f4c_55b6ff5d","in_reply_to":"85c1842e_cfce73a5","updated":"2024-11-06 02:11:08.000000000","message":"reopen check please~\n\nhttps://review.opendev.org/c/openstack/heat/+/934196","commit_id":"4fe52f3e51c8e6d4d920efa869c592de70ea99df"}],"heat/engine/clients/os/manila.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87509357fb37be323c5a2c905eb6f12ad2e66490","unresolved":true,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create(self):"},{"line_number":32,"context_line":"        endpoint_type \u003d self._get_client_option(CLIENT_NAME, \u0027endpoint_type\u0027)"},{"line_number":33,"context_line":"        session \u003d self.context.keystone_session"},{"line_number":34,"context_line":"        region_name \u003d self._get_region_name()"},{"line_number":35,"context_line":"        service_catalog_url \u003d session.get_endpoint(session.auth,"},{"line_number":36,"context_line":"                                                   interface\u003dendpoint_type,"},{"line_number":37,"context_line":"                                                   service_type\u003dself.SHARE,"},{"line_number":38,"context_line":"                                                   region_name\u003dregion_name)"},{"line_number":39,"context_line":"        args \u003d {"},{"line_number":40,"context_line":"            \u0027endpoint_type\u0027: endpoint_type,"},{"line_number":41,"context_line":"            \u0027service_type\u0027: self.SHARE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1c03457_74034eea","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":75},"updated":"2024-11-05 15:15:08.000000000","message":"Looking at the current manilaclinet code this is exactly dine within manilaclient if service_catalog_url is not given. I don\u0027t see any practical benefit of implementing this logic in heat layer.","commit_id":"4fe52f3e51c8e6d4d920efa869c592de70ea99df"},{"author":{"_account_id":36726,"name":"KwangwooPark","email":"kwangwoo49.park@gmail.com","username":"kwangwoo"},"change_message_id":"5602707d954780c890af4aa43ff67ac5c9486dc2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _create(self):"},{"line_number":32,"context_line":"        endpoint_type \u003d self._get_client_option(CLIENT_NAME, \u0027endpoint_type\u0027)"},{"line_number":33,"context_line":"        session \u003d self.context.keystone_session"},{"line_number":34,"context_line":"        region_name \u003d self._get_region_name()"},{"line_number":35,"context_line":"        service_catalog_url \u003d session.get_endpoint(session.auth,"},{"line_number":36,"context_line":"                                                   interface\u003dendpoint_type,"},{"line_number":37,"context_line":"                                                   service_type\u003dself.SHARE,"},{"line_number":38,"context_line":"                                                   region_name\u003dregion_name)"},{"line_number":39,"context_line":"        args \u003d {"},{"line_number":40,"context_line":"            \u0027endpoint_type\u0027: endpoint_type,"},{"line_number":41,"context_line":"            \u0027service_type\u0027: self.SHARE,"}],"source_content_type":"text/x-python","patch_set":1,"id":"36152e2f_baa1735f","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":75},"in_reply_to":"b1c03457_74034eea","updated":"2024-11-06 02:11:08.000000000","message":"If there are multiple regions  file storage (Manila) is not generated properly.\nSo I added it so that we can get the necessary region information.","commit_id":"4fe52f3e51c8e6d4d920efa869c592de70ea99df"}]}
