)]}'
{"etc/heat/templates/AWS_CloudWatch_Alarm.yaml":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"44cd938267e0057e31fb284c269966cce4e76557","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    Default: None"},{"line_number":35,"context_line":"  AlarmActions:"},{"line_number":36,"context_line":"   Type: CommaDelimitedList"},{"line_number":37,"context_line":"   Default: []"},{"line_number":38,"context_line":"  OKActions:"},{"line_number":39,"context_line":"   Type: CommaDelimitedList"},{"line_number":40,"context_line":"   Default: []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3ae8d1ca_891621a6","line":37,"updated":"2014-05-28 17:00:18.000000000","message":"Angus is right, if you had to change this then you\u0027ve found a bug, it should be a comma-delimited string list of values.","commit_id":"30021dc8df13cbc0fd76e274e5a89e9073ce39b9"},{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"565e983c812143484b8c35d3093dd4786e119948","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    Default: None"},{"line_number":35,"context_line":"  AlarmActions:"},{"line_number":36,"context_line":"   Type: CommaDelimitedList"},{"line_number":37,"context_line":"   Default: []"},{"line_number":38,"context_line":"  OKActions:"},{"line_number":39,"context_line":"   Type: CommaDelimitedList"},{"line_number":40,"context_line":"   Default: []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ae5cdf2_2c7468ce","line":37,"in_reply_to":"3ae8d1ca_2d2b4895","updated":"2014-05-30 14:03:18.000000000","message":"+1","commit_id":"30021dc8df13cbc0fd76e274e5a89e9073ce39b9"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"2a23886a92d20d319dd136120fa786fee239f424","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    Default: None"},{"line_number":35,"context_line":"  AlarmActions:"},{"line_number":36,"context_line":"   Type: CommaDelimitedList"},{"line_number":37,"context_line":"   Default: []"},{"line_number":38,"context_line":"  OKActions:"},{"line_number":39,"context_line":"   Type: CommaDelimitedList"},{"line_number":40,"context_line":"   Default: []"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3ae8d1ca_2d2b4895","line":37,"in_reply_to":"3ae8d1ca_891621a6","updated":"2014-05-29 03:10:28.000000000","message":"I think the defaults should still be a string, but I am ok with the rest.","commit_id":"30021dc8df13cbc0fd76e274e5a89e9073ce39b9"}],"heat/engine/parameters.py":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"5c4325f0abbd738ae30cfb84da92c1ea46215bbb","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            return value"},{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            if value is not None:"},{"line_number":321,"context_line":"                return value.split(\u0027,\u0027)"},{"line_number":322,"context_line":"        except (KeyError, AttributeError) as err:"},{"line_number":323,"context_line":"            message \u003d _(\u0027Value must be a comma-delimited list string: %s\u0027)"},{"line_number":324,"context_line":"            raise ValueError(message % six.text_type(err))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_614c5771","line":321,"updated":"2014-06-03 10:13:16.000000000","message":"Do we need a test for the situation where it is None, e.g when there\u0027s no default?\n\nAlso I\u0027m wondering if we should really split this up into two patches, since the commit message reads like it\u0027s just fixing the ceilometer template, but really it\u0027s making a small but significant change to the parameter interface.","commit_id":"ce62bdc1925d9e746289c43bc0b76b41df8f2d53"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"fb44d7bb21a0a2e73c31d2dabf742ea7064f04ae","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            return value"},{"line_number":319,"context_line":"        try:"},{"line_number":320,"context_line":"            if value is not None:"},{"line_number":321,"context_line":"                return value.split(\u0027,\u0027)"},{"line_number":322,"context_line":"        except (KeyError, AttributeError) as err:"},{"line_number":323,"context_line":"            message \u003d _(\u0027Value must be a comma-delimited list string: %s\u0027)"},{"line_number":324,"context_line":"            raise ValueError(message % six.text_type(err))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_814a43aa","line":321,"in_reply_to":"1ae5cdf2_614c5771","updated":"2014-06-03 10:35:58.000000000","message":"I have added a line to the commit message at the end for the \u0027parameter\u0027 interface change to accept empty string. \n\nI think there is already a test for no default \u0027test_new_list\u0027","commit_id":"ce62bdc1925d9e746289c43bc0b76b41df8f2d53"}]}
