)]}'
{"heat/engine/resources/volume.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"02385d632112ee9509ccf4101030a5d22626b816","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from cinderclient import client as cinderclient"},{"line_number":15,"context_line":"from cinderclient.v1 import volume_backups"},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from heat.common import exception"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_e5ceaa2c","line":15,"updated":"2014-06-11 08:24:31.000000000","message":"should be in separate import group below standard lib imports","commit_id":"ea32f6c06aecd93d4044c411bcc475763dbd028f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c1357095dc5a70a1cd71ec31cc1157837e177618","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from cinderclient import client as cinderclient"},{"line_number":15,"context_line":"from cinderclient.v1 import volume_backups"},{"line_number":16,"context_line":"import json"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from heat.common import exception"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_215e4a7a","line":15,"in_reply_to":"1ae5cdf2_e5ceaa2c","updated":"2014-06-15 23:16:25.000000000","message":"As an external dependency I think this should be above the heat imports","commit_id":"ea32f6c06aecd93d4044c411bcc475763dbd028f"}],"heat/tests/test_volume.py":[{"author":{"_account_id":6577,"name":"Sergey Kraynev","email":"sergejyit@gmail.com","username":"skraynev"},"change_message_id":"c30dc9a34c7a1f0d730a0e5fca2dc05aecefcaf3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.m.StubOutWithMock(fv, \u0027get\u0027)"},{"line_number":131,"context_line":"        fv.get().AndReturn(None)"},{"line_number":132,"context_line":"        fv.get().AndRaise("},{"line_number":133,"context_line":"            cinder_exp.NotFound(\u0027Not found\u0027))"},{"line_number":134,"context_line":"        self.m.ReplayAll()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _mock_create_server_volume_script(self, fva,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_14605834","line":133,"updated":"2014-06-10 08:00:33.000000000","message":"how about uniform approach for using exceptions?\nF.e. nova exception in this file has other approach:\n\nnova.novaclient.exceptions.NotFound(\u0027NotFound\u0027)\n\nMay be cinder should have the same definition here, instead of additional import?","commit_id":"ea32f6c06aecd93d4044c411bcc475763dbd028f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c1357095dc5a70a1cd71ec31cc1157837e177618","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.m.StubOutWithMock(fv, \u0027get\u0027)"},{"line_number":131,"context_line":"        fv.get().AndReturn(None)"},{"line_number":132,"context_line":"        fv.get().AndRaise("},{"line_number":133,"context_line":"            cinder_exp.NotFound(\u0027Not found\u0027))"},{"line_number":134,"context_line":"        self.m.ReplayAll()"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _mock_create_server_volume_script(self, fva,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ae5cdf2_01a5ce46","line":133,"in_reply_to":"1ae5cdf2_14605834","updated":"2014-06-15 23:16:25.000000000","message":"A uniform approach to client exceptions will be coming later in this series, and NotFound handling will probably be the first priority since that is the cause of most direct client imports.","commit_id":"ea32f6c06aecd93d4044c411bcc475763dbd028f"}]}
