)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ffee437e7fad132ffe6ace1a5f990667fefd773b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1081e80e_67ba6c8e","updated":"2026-10-22 15:52:25.000000000","message":"Thank you for the patch! It needs to be rebased, and the comments inline seem valid.","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":37170,"name":"Enrico Kern","email":"enrico.kern@stackxperts.com","username":"flyersa","status":"Uponu GmbH"},"change_message_id":"13c9e937242c9ffe6cfb3be26cbca032217e839b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7e450d8_c9b5fa42","in_reply_to":"1081e80e_67ba6c8e","updated":"2026-10-26 11:28:08.000000000","message":"Thanks Tatiana, rebased and addressed in patch set 3.","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"bf700472d1ca349aff2b03ba90b156d61fd57a36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d25e6a58_281b9172","updated":"2026-11-03 12:13:09.000000000","message":"LGTM, thanks!","commit_id":"991b795f76ebe168e20acd0f7f9bf55229a1446d"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"7876647a39c3207fffb6462d33f9f6c3225df1bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9d7268f_80884996","updated":"2026-10-26 13:40:53.000000000","message":"LGTM, thanks!","commit_id":"991b795f76ebe168e20acd0f7f9bf55229a1446d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"7db4bfb631ec06554dda08d0df4511980d34a1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6bd1bd39_c029588b","updated":"2026-11-02 10:10:08.000000000","message":"nice optimization, thanks","commit_id":"991b795f76ebe168e20acd0f7f9bf55229a1446d"}],"openstack_dashboard/dashboards/admin/networks/views.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4b725a7c1d5199a033743f69b0f547dc679302e9","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":71,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":72,"context_line":"            return None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def needs_filter_first(self, table):"},{"line_number":75,"context_line":"        return getattr(self, \"_needs_filter_first\", False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f506525_9f1ed7d2","line":72,"updated":"2026-10-14 20:56:39.000000000","message":"nit: can probably be un-indented","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":37170,"name":"Enrico Kern","email":"enrico.kern@stackxperts.com","username":"flyersa","status":"Uponu GmbH"},"change_message_id":"13c9e937242c9ffe6cfb3be26cbca032217e839b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":71,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":72,"context_line":"            return None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def needs_filter_first(self, table):"},{"line_number":75,"context_line":"        return getattr(self, \"_needs_filter_first\", False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6baa9e2_66f5c766","line":72,"in_reply_to":"2333177a_0f203f38","updated":"2026-10-26 11:28:08.000000000","message":"Done.","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"484bb836c3ce1d39c191c9d931f06f6b5df51605","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        except Exception:"},{"line_number":70,"context_line":"            msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":71,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":72,"context_line":"            return None"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def needs_filter_first(self, table):"},{"line_number":75,"context_line":"        return getattr(self, \"_needs_filter_first\", False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2333177a_0f203f38","line":72,"in_reply_to":"4f506525_9f1ed7d2","updated":"2026-10-16 14:34:47.000000000","message":"+1 just to be explicit","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"5627d00ec43f93987a8554c7f02bacb20058e0fe","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                admin_utils.is_dhcp_agent_scheduler_supported(self.request)):"},{"line_number":120,"context_line":"            self.exception \u003d False"},{"line_number":121,"context_line":"            tenant_dict \u003d self._get_tenant_list()"},{"line_number":122,"context_line":"            agent_counts \u003d self._get_agent_counts()"},{"line_number":123,"context_line":"            for n in networks:"},{"line_number":124,"context_line":"                # Set tenant name"},{"line_number":125,"context_line":"                tenant \u003d tenant_dict.get(n.tenant_id, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2511f21_0b7b004e","line":122,"updated":"2026-10-22 15:57:58.000000000","message":"Looks like the view already knows which networks it needs counts for, so we can pass them:\n\nagent_counts \u003d self._get_agent_counts([n.id for n in networks])","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":37170,"name":"Enrico Kern","email":"enrico.kern@stackxperts.com","username":"flyersa","status":"Uponu GmbH"},"change_message_id":"13c9e937242c9ffe6cfb3be26cbca032217e839b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                admin_utils.is_dhcp_agent_scheduler_supported(self.request)):"},{"line_number":120,"context_line":"            self.exception \u003d False"},{"line_number":121,"context_line":"            tenant_dict \u003d self._get_tenant_list()"},{"line_number":122,"context_line":"            agent_counts \u003d self._get_agent_counts()"},{"line_number":123,"context_line":"            for n in networks:"},{"line_number":124,"context_line":"                # Set tenant name"},{"line_number":125,"context_line":"                tenant \u003d tenant_dict.get(n.tenant_id, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9d604280_b535b962","line":122,"in_reply_to":"a2511f21_0b7b004e","updated":"2026-10-26 11:28:08.000000000","message":"Done, thanks. Neutron can\u0027t filter the networks of a DHCP agent by ID, so it is still one request per agent.","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"5627d00ec43f93987a8554c7f02bacb20058e0fe","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                if agent_counts is None:"},{"line_number":128,"context_line":"                    n.num_agents \u003d _(\"Unknown\")"},{"line_number":129,"context_line":"                else:"},{"line_number":130,"context_line":"                    n.num_agents \u003d agent_counts[n.id]"},{"line_number":131,"context_line":"        return networks"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"700d2063_a3e4b96e","line":130,"updated":"2026-10-22 15:57:58.000000000","message":"n.num_agents \u003d agent_counts.get(n.id, 0) is safer","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"},{"author":{"_account_id":37170,"name":"Enrico Kern","email":"enrico.kern@stackxperts.com","username":"flyersa","status":"Uponu GmbH"},"change_message_id":"13c9e937242c9ffe6cfb3be26cbca032217e839b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                if agent_counts is None:"},{"line_number":128,"context_line":"                    n.num_agents \u003d _(\"Unknown\")"},{"line_number":129,"context_line":"                else:"},{"line_number":130,"context_line":"                    n.num_agents \u003d agent_counts[n.id]"},{"line_number":131,"context_line":"        return networks"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def get_filters(self, filters\u003dNone, filters_map\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef8b7c2c_955a2638","line":130,"in_reply_to":"700d2063_a3e4b96e","updated":"2026-10-26 11:28:08.000000000","message":"Done.","commit_id":"a4f286a0d0b09d5681368bec128840635e243bb6"}]}
