)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b61dd884b3cc75ae00f31e7add030d41bc3ee9e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tomas Novacik \u003ctnovacik@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-06 22:58:21 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add regions module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Regions module should contains basic functionality that should be"},{"line_number":10,"context_line":"shared among multiple page objects: common tables, forms,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"baada198_8140ae07","line":7,"updated":"2014-08-07 07:24:10.000000000","message":"Please mention that this patch is related to integration tests, e.g.,\n\n   Add regions module to integration tests\n\nAt least the current summary line of the commit message is confusing. It is not an addition of regions module to the main code.","commit_id":"b73fa2421da8eda6e65a9026474eff440238e159"}],"openstack_dashboard/test/integration_tests/basewebobject.py":[{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"d23aafca9ed4293da1faba6f810a3a254c9a9c0c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self.conf \u003d conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def _is_element_present(self, *locator):"},{"line_number":24,"context_line":"        try:"},{"line_number":25,"context_line":"            self.driver.find_element(*locator)"},{"line_number":26,"context_line":"            return True"},{"line_number":27,"context_line":"        except Exceptions.NoSuchElementException:"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_3cd53ab9","line":24,"updated":"2014-09-10 14:45:25.000000000","message":"self.driver.find_element(*locator) must be changed to self._get_element(*locator) in order to work only in the scope of region","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2fbfca6355030f495e471fa3054479dcc4cf53b7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self.conf \u003d conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def _is_element_present(self, *locator):"},{"line_number":24,"context_line":"        try:"},{"line_number":25,"context_line":"            self.driver.find_element(*locator)"},{"line_number":26,"context_line":"            return True"},{"line_number":27,"context_line":"        except Exceptions.NoSuchElementException:"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_b0ff2d33","line":24,"in_reply_to":"fa98f980_3cd53ab9","updated":"2014-09-13 16:28:24.000000000","message":"Done","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"d23aafca9ed4293da1faba6f810a3a254c9a9c0c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _is_element_visible(self, *locator):"},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return self.driver.find_element(*locator).is_displayed()"},{"line_number":33,"context_line":"        except (Exceptions.NoSuchElementException,"},{"line_number":34,"context_line":"                Exceptions.ElementNotVisibleException):"},{"line_number":35,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_7c4fc2be","line":32,"updated":"2014-09-10 14:45:25.000000000","message":"return self.driver.find_element(*locator).is_displayed() must be changed to return self._get_element(*locator).is_displayed() in order to work only in the scope of region","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2fbfca6355030f495e471fa3054479dcc4cf53b7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _is_element_visible(self, *locator):"},{"line_number":31,"context_line":"        try:"},{"line_number":32,"context_line":"            return self.driver.find_element(*locator).is_displayed()"},{"line_number":33,"context_line":"        except (Exceptions.NoSuchElementException,"},{"line_number":34,"context_line":"                Exceptions.ElementNotVisibleException):"},{"line_number":35,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_d0faf141","line":32,"in_reply_to":"fa98f980_7c4fc2be","updated":"2014-09-13 16:28:24.000000000","message":"Done","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"}],"openstack_dashboard/test/integration_tests/pages/basepage.py":[{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"a0d59cfdf311eb17a8ed9077004eea5530161130","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from openstack_dashboard.test.integration_tests.pages import pageobject"},{"line_number":16,"context_line":"from openstack_dashboard.test.integration_tests.regions import messages"},{"line_number":17,"context_line":"from openstack_dashboard.test.integration_tests.regions import bars"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class BasePage(pageobject.PageObject):"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_48e9407e","line":17,"updated":"2014-08-03 14:10:23.000000000","message":"bars should come before messages (H306  imports not in alphabetical order)\n\n(http://docs.openstack.org/developer/hacking/#imports)","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"e6b9eb3505270fd1f2ef56686d2e10a13af4a9ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from openstack_dashboard.test.integration_tests.pages import pageobject"},{"line_number":16,"context_line":"from openstack_dashboard.test.integration_tests.regions import messages"},{"line_number":17,"context_line":"from openstack_dashboard.test.integration_tests.regions import bars"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class BasePage(pageobject.PageObject):"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_04b99eca","line":17,"in_reply_to":"baada198_48e9407e","updated":"2014-08-03 18:10:21.000000000","message":"right, thanks","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"}],"openstack_dashboard/test/integration_tests/pages/pageobject.py":[{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"4dd7a125ad05c685b9ff6bf287773c9944651a7c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_element(self, *locator):"},{"line_number":67,"context_line":"        return self.driver.find_element(*locator)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_alert(self):"},{"line_number":70,"context_line":"        return self.driver.switch_to.alert()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_elements(self, *locator):"}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_9953c215","line":69,"updated":"2014-08-07 11:53:48.000000000","message":"by alert you mean all JavaScript popup boxes or just alerts?\nI\u0027m no expert but I would say most of the popups are considered prompt boxes as you need to input values to them.","commit_id":"50522a4e6ffbd40af53201a12c1417031673081d"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_element(self, *locator):"},{"line_number":67,"context_line":"        return self.driver.find_element(*locator)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_alert(self):"},{"line_number":70,"context_line":"        return self.driver.switch_to.alert()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_elements(self, *locator):"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_3d066a21","line":69,"updated":"2014-09-01 08:29:02.000000000","message":"are there alert boxes in horizon? (different to those prompt boxes, like when creating a resource) if so, can you give me an example for one?","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_element(self, *locator):"},{"line_number":67,"context_line":"        return self.driver.find_element(*locator)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_alert(self):"},{"line_number":70,"context_line":"        return self.driver.switch_to.alert()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_elements(self, *locator):"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_8bd8d3f0","line":69,"in_reply_to":"fa98f980_3d066a21","updated":"2014-09-01 18:41:40.000000000","message":"Cannot find any \u003d\u003e removing.","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"a322f2d8bbf0578733b9f5bd6168e06476476991","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def get_element(self, *locator):"},{"line_number":67,"context_line":"        return self.driver.find_element(*locator)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_alert(self):"},{"line_number":70,"context_line":"        return self.driver.switch_to.alert()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_elements(self, *locator):"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_ed09b731","line":69,"in_reply_to":"fa98f980_3d066a21","updated":"2014-09-05 19:12:01.000000000","message":"Done","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"}],"openstack_dashboard/test/integration_tests/pages/projectpage.py":[{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"a0d59cfdf311eb17a8ed9077004eea5530161130","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return settingspage.SettingsPage(self.driver, self.conf)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def action_table(self):"},{"line_number":36,"context_line":"        src_elem \u003d self.get_element(*self._action_table_locator)"},{"line_number":37,"context_line":"        return tables.SimpleActionsTableRegion(self.driver, self.conf, src_elem)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_3625f85a","line":35,"updated":"2014-08-03 14:10:23.000000000","message":"is there a reason why the action_table isn\u0027t a property of basepage?","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"e6b9eb3505270fd1f2ef56686d2e10a13af4a9ac","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return settingspage.SettingsPage(self.driver, self.conf)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def action_table(self):"},{"line_number":36,"context_line":"        src_elem \u003d self.get_element(*self._action_table_locator)"},{"line_number":37,"context_line":"        return tables.SimpleActionsTableRegion(self.driver, self.conf, src_elem)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_24e302d9","line":35,"in_reply_to":"baada198_3625f85a","updated":"2014-08-03 18:10:21.000000000","message":"Hmm every page is different, not every page has this kind of table.","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"a0d59cfdf311eb17a8ed9077004eea5530161130","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def action_table(self):"},{"line_number":36,"context_line":"        src_elem \u003d self.get_element(*self._action_table_locator)"},{"line_number":37,"context_line":"        return tables.SimpleActionsTableRegion(self.driver, self.conf, src_elem)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @property"},{"line_number":40,"context_line":"    def date_form(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_b6b4a81d","line":37,"updated":"2014-08-03 14:10:23.000000000","message":"this line is too long (above 79 characters)","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"e6b9eb3505270fd1f2ef56686d2e10a13af4a9ac","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    @property"},{"line_number":35,"context_line":"    def action_table(self):"},{"line_number":36,"context_line":"        src_elem \u003d self.get_element(*self._action_table_locator)"},{"line_number":37,"context_line":"        return tables.SimpleActionsTableRegion(self.driver, self.conf, src_elem)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @property"},{"line_number":40,"context_line":"    def date_form(self):"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_047c3eea","line":37,"in_reply_to":"baada198_b6b4a81d","updated":"2014-08-03 18:10:21.000000000","message":"hmm, this is weird, pep8 did not fail in previous runs...","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"}],"openstack_dashboard/test/integration_tests/regions/bars.py":[{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"defaad6895b126ca8a1fcec21238fe0793eb34b7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                          \u0027ul#editor_list li:nth-of-type(3) \u003e a\u0027)"},{"line_number":29,"context_line":"    _logout_link_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":30,"context_line":"                            \u0027a[href*\u003d\"/auth/logout/\"]\u0027)"},{"line_number":31,"context_line":"    _openstack_brand_locator \u003d (by.By.CSS_SELECTOR, \u0027a[href*\u003d\"/home/\"]\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @property"},{"line_number":34,"context_line":"    def user(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_adee84b2","line":31,"updated":"2014-09-09 08:10:37.000000000","message":"(nit) more readable :)\n_openstack_brand_locator \u003d (by.By.CSS_SELECTOR, \n                            \u0027a[href*\u003d\"/home/\"]\u0027)","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"a846edc83607bdb187659fac9f0d0b83f17729fc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                          \u0027ul#editor_list li:nth-of-type(3) \u003e a\u0027)"},{"line_number":29,"context_line":"    _logout_link_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":30,"context_line":"                            \u0027a[href*\u003d\"/auth/logout/\"]\u0027)"},{"line_number":31,"context_line":"    _openstack_brand_locator \u003d (by.By.CSS_SELECTOR, \u0027a[href*\u003d\"/home/\"]\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @property"},{"line_number":34,"context_line":"    def user(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_8a3b63ea","line":31,"in_reply_to":"fa98f980_4a609b35","updated":"2014-09-09 09:30:23.000000000","message":"its only nit --  i think, this could be in similar style. But the best for me(for example):\n_user_indicator_locator \u003d (\n    by.By.CSS_SELECTOR,\n    \u0027#profile_editor_switcher \u003e \u0027\n    \u0027a.dropdown-toggle \u003e div\u0027\n)","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"d23aafca9ed4293da1faba6f810a3a254c9a9c0c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                          \u0027ul#editor_list li:nth-of-type(3) \u003e a\u0027)"},{"line_number":29,"context_line":"    _logout_link_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":30,"context_line":"                            \u0027a[href*\u003d\"/auth/logout/\"]\u0027)"},{"line_number":31,"context_line":"    _openstack_brand_locator \u003d (by.By.CSS_SELECTOR, \u0027a[href*\u003d\"/home/\"]\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @property"},{"line_number":34,"context_line":"    def user(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_909f1403","line":31,"in_reply_to":"fa98f980_8a3b63ea","updated":"2014-09-10 14:45:25.000000000","message":"i prefer to have it on one line if possible","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"10aaa69525fa0c7a57813aef0705765d07cc870c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                          \u0027ul#editor_list li:nth-of-type(3) \u003e a\u0027)"},{"line_number":29,"context_line":"    _logout_link_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":30,"context_line":"                            \u0027a[href*\u003d\"/auth/logout/\"]\u0027)"},{"line_number":31,"context_line":"    _openstack_brand_locator \u003d (by.By.CSS_SELECTOR, \u0027a[href*\u003d\"/home/\"]\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @property"},{"line_number":34,"context_line":"    def user(self):"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_4a609b35","line":31,"in_reply_to":"fa98f980_adee84b2","updated":"2014-09-09 08:59:29.000000000","message":"Why do you think so?","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"}],"openstack_dashboard/test/integration_tests/regions/baseregion.py":[{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"a0d59cfdf311eb17a8ed9077004eea5530161130","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def get_element(self, *locator):"},{"line_number":46,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_elements(self, *locator):"},{"line_number":49,"context_line":"        return self.src_elem.find_elements(*locator)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_d460860f","line":48,"updated":"2014-08-03 14:10:23.000000000","message":"I think you accidentally duplicated get_element method","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"e6b9eb3505270fd1f2ef56686d2e10a13af4a9ac","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def get_element(self, *locator):"},{"line_number":46,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_elements(self, *locator):"},{"line_number":49,"context_line":"        return self.src_elem.find_elements(*locator)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_84204ef9","line":48,"in_reply_to":"baada198_d460860f","updated":"2014-08-03 18:10:21.000000000","message":"I did not. I did this on purpose, to make relative search possible. When using the regions you should always specify where is the region located via src_elem. All searches for web element inside the region object will then be executed from the src_elem so you do not match some different web element(outside the region).","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"4dd7a125ad05c685b9ff6bf287773c9944651a7c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstack_dashboard.test.integration_tests.pages import pageobject"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class BaseRegion(pageobject.PageObject):"},{"line_number":30,"context_line":"    \"\"\"Base class for region module"},{"line_number":31,"context_line":"    * there is necessity to override some basic methods for obtaining elements"},{"line_number":32,"context_line":"      as in content of regions it is required to do relative searches"}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_19733217","line":29,"updated":"2014-08-07 11:53:48.000000000","message":"IMO it\u0027s quite problematic that the baseregion inherits from pageobject, as region are part of a page and not pages themselves. regions shouldn\u0027t have the capabilities allowed for pages.\nIf you take the userdropdown for example, it will be able to preform   is_the_current_page method, return page_title, close_window etc..","commit_id":"50522a4e6ffbd40af53201a12c1417031673081d"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"4dd7a125ad05c685b9ff6bf287773c9944651a7c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      would result in functionality loss, self.driver is WebDriver and"},{"line_number":36,"context_line":"      src_elem is WebElement its usage is different."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    * this does no mean that self.src_elem cannot be self.driver"},{"line_number":39,"context_line":"      \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # private methods"}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_1972524a","line":38,"updated":"2014-08-07 11:53:48.000000000","message":"Typo *not","commit_id":"50522a4e6ffbd40af53201a12c1417031673081d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0d04e5c210f35457aa751f0cf533b613a9310aab","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":14,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":23,"id":"9ab29df4_3de2f7d5","line":11,"updated":"2014-08-13 19:44:10.000000000","message":"duplicate","commit_id":"85067d5e82047eebc142eada07e68fda0c057ec4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"cd853f2f7aa8bc516d1b8e9806a53282ca5e19b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":14,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":23,"id":"9ab29df4_fd023f0a","line":11,"in_reply_to":"9ab29df4_3de2f7d5","updated":"2014-08-13 19:52:24.000000000","message":"thanks...","commit_id":"85067d5e82047eebc142eada07e68fda0c057ec4"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack_dashboard.test.integration_tests.pages import pageobject"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BaseRegion(pageobject.PageObject):"},{"line_number":18,"context_line":"    \"\"\"Base class for region module"},{"line_number":19,"context_line":"    * there is necessity to override some basic methods for obtaining elements"},{"line_number":20,"context_line":"      as in content of regions it is required to do relative searches"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_401d0166","line":17,"updated":"2014-09-01 08:29:02.000000000","message":"the BaseRegion should inherit from BaseWebObject (https://review.openstack.org/#/c/112579/4/openstack_dashboard/test/integration_tests/basewebobject.py), as we discussed.","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack_dashboard.test.integration_tests.pages import pageobject"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class BaseRegion(pageobject.PageObject):"},{"line_number":18,"context_line":"    \"\"\"Base class for region module"},{"line_number":19,"context_line":"    * there is necessity to override some basic methods for obtaining elements"},{"line_number":20,"context_line":"      as in content of regions it is required to do relative searches"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_268479d3","line":17,"in_reply_to":"fa98f980_401d0166","updated":"2014-09-01 18:41:40.000000000","message":"will do","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # private methods"},{"line_number":30,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":31,"context_line":"        super(BaseRegion, self).__init__(driver, conf)"},{"line_number":32,"context_line":"        self.src_elem \u003d src_elem or driver"},{"line_number":33,"context_line":"        # variable for storing names of dynamic properties and"},{"line_number":34,"context_line":"        # associated \u0027getters\u0027 - meaning method that are supplying"},{"line_number":35,"context_line":"        # regions or web elements"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_c020119e","line":32,"updated":"2014-09-01 08:29:02.000000000","message":"just to make sure, is there a chance the src_elem would have a field with the value False and than the driver will be chosen, even though it wasn\u0027t the intention? if that\u0027s possible, I think it\u0027s better to use something like: self.src_elem \u003d driver if src_elem in None else src_elem","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # private methods"},{"line_number":30,"context_line":"    def __init__(self, driver, conf, src_elem\u003dNone):"},{"line_number":31,"context_line":"        super(BaseRegion, self).__init__(driver, conf)"},{"line_number":32,"context_line":"        self.src_elem \u003d src_elem or driver"},{"line_number":33,"context_line":"        # variable for storing names of dynamic properties and"},{"line_number":34,"context_line":"        # associated \u0027getters\u0027 - meaning method that are supplying"},{"line_number":35,"context_line":"        # regions or web elements"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_a62069f8","line":32,"in_reply_to":"fa98f980_c020119e","updated":"2014-09-01 18:41:40.000000000","message":"No, nothing like that :). Driver will be chosen only if src_elem will be None(not supplied).","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        the protected attribute _dynamic_attributes and returning result"},{"line_number":43,"context_line":"        of the method associated with the specified attribute."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        This way is created feeling of having regions accessed as \u0027properties\u0027"},{"line_number":46,"context_line":"        which is one of the requirement of page object pattern."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_804d2975","line":45,"updated":"2014-09-01 08:29:02.000000000","message":"would write: This way *the* feeling of having regions accessed as \u0027properties\u0027 is created or This way *it creates the* feeling of having regions accessed as \u0027properties\u0027","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"a322f2d8bbf0578733b9f5bd6168e06476476991","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        the protected attribute _dynamic_attributes and returning result"},{"line_number":43,"context_line":"        of the method associated with the specified attribute."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        This way is created feeling of having regions accessed as \u0027properties\u0027"},{"line_number":46,"context_line":"        which is one of the requirement of page object pattern."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_d8103350","line":45,"in_reply_to":"fa98f980_804d2975","updated":"2014-09-05 19:12:01.000000000","message":"Done","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        the protected attribute _dynamic_attributes and returning result"},{"line_number":43,"context_line":"        of the method associated with the specified attribute."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        This way is created feeling of having regions accessed as \u0027properties\u0027"},{"line_number":46,"context_line":"        which is one of the requirement of page object pattern."},{"line_number":47,"context_line":"        \"\"\""},{"line_number":48,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_0695b532","line":45,"in_reply_to":"fa98f980_804d2975","updated":"2014-09-01 18:41:40.000000000","message":"thx","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _init_dynamic_property(self, new_attr_name, method, index\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Create new object\u0027s property at runtime. If index argument is"},{"line_number":77,"context_line":"        supplied it is assumed that method returns tupel() and only element"},{"line_number":78,"context_line":"        on ${index} position is returned."},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        if (new_attr_name in dir(self) or"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_e05c3528","line":77,"updated":"2014-09-01 08:29:02.000000000","message":"typo in tuple","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"a322f2d8bbf0578733b9f5bd6168e06476476991","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _init_dynamic_property(self, new_attr_name, method, index\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Create new object\u0027s property at runtime. If index argument is"},{"line_number":77,"context_line":"        supplied it is assumed that method returns tupel() and only element"},{"line_number":78,"context_line":"        on ${index} position is returned."},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        if (new_attr_name in dir(self) or"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_18fd5bb1","line":77,"in_reply_to":"fa98f980_e05c3528","updated":"2014-09-05 19:12:01.000000000","message":"Done","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _init_dynamic_property(self, new_attr_name, method, index\u003dNone):"},{"line_number":76,"context_line":"        \"\"\"Create new object\u0027s property at runtime. If index argument is"},{"line_number":77,"context_line":"        supplied it is assumed that method returns tupel() and only element"},{"line_number":78,"context_line":"        on ${index} position is returned."},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        if (new_attr_name in dir(self) or"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_866a8518","line":77,"in_reply_to":"fa98f980_e05c3528","updated":"2014-09-01 18:41:40.000000000","message":"thx","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_elements(self, *locator):"},{"line_number":95,"context_line":"        return self.src_elem.find_elements(*locator)"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_404b4159","line":95,"updated":"2014-09-01 08:29:02.000000000","message":"are these two methods really needed here if they\u0027ll exist in basewebobject?","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_elements(self, *locator):"},{"line_number":95,"context_line":"        return self.src_elem.find_elements(*locator)"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_cb9c9b6c","line":95,"in_reply_to":"fa98f980_404b4159","updated":"2014-09-01 18:41:40.000000000","message":"Yes.\n\nRegions needs to access web driver so they can for example manipulate with implicit timeout.(This is the reason why one cannot supply as driver web element.)\n\nOn the other hand it is particularly useful when searching for an element within region to start the search from the \u0027source element\u0027 of region. This ensures that you do not match anything out of the region scope. In some cases you can supply driver instead of src_elem because the region cannot be used multiple times or when the region is in use it covers the whole screen and matching anything else is not possible(certain forms).","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"defaad6895b126ca8a1fcec21238fe0793eb34b7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        inst_method \u003d types.MethodType(new_method, self)"},{"line_number":88,"context_line":"        self._dynamic_properties[new_attr_name] \u003d inst_method"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # public methods"},{"line_number":91,"context_line":"    def _get_element(self, *locator):"},{"line_number":92,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_ed996c20","line":90,"updated":"2014-09-09 08:10:37.000000000","message":"# public methods  --- why name of methods start with _ ?","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2fbfca6355030f495e471fa3054479dcc4cf53b7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        inst_method \u003d types.MethodType(new_method, self)"},{"line_number":88,"context_line":"        self._dynamic_properties[new_attr_name] \u003d inst_method"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # public methods"},{"line_number":91,"context_line":"    def _get_element(self, *locator):"},{"line_number":92,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_f0de15d9","line":90,"in_reply_to":"fa98f980_ed996c20","updated":"2014-09-13 16:28:24.000000000","message":"Done","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"10aaa69525fa0c7a57813aef0705765d07cc870c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        inst_method \u003d types.MethodType(new_method, self)"},{"line_number":88,"context_line":"        self._dynamic_properties[new_attr_name] \u003d inst_method"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # public methods"},{"line_number":91,"context_line":"    def _get_element(self, *locator):"},{"line_number":92,"context_line":"        return self.src_elem.find_element(*locator)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_e8995a20","line":90,"in_reply_to":"fa98f980_ed996c20","updated":"2014-09-09 08:59:29.000000000","message":"Obsolete comment, thanks","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"}],"openstack_dashboard/test/integration_tests/regions/messages.py":[{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"4dd7a125ad05c685b9ff6bf287773c9944651a7c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class ErrorMessageRegion(baseregion.BaseRegion):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    _error_msg_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":21,"context_line":"                          \u0027div.alert-danger.alert\u0027)"},{"line_number":22,"context_line":"    _close_locator \u003d (by.By.CSS_SELECTOR,"},{"line_number":23,"context_line":"                      \u0027div.alert-danger.alert \u003e a.close\u0027)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"baada198_a70ea231","line":21,"updated":"2014-08-07 11:53:48.000000000","message":"does this locator suppose to match all horizon error messages (including the pop-up windows) ?\n\nI\u0027m asking cause I\u0027ve seen different ones, for example: \n\n.messages .alert-block.alert-error\ndiv.alert.alert-message.alert-error","commit_id":"50522a4e6ffbd40af53201a12c1417031673081d"}],"openstack_dashboard/test/integration_tests/regions/tables.py":[{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"ff53549db994e94b5265d37fb66dd65d57dff234","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return self._get_action()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def execute_action(self):"},{"line_number":60,"context_line":"        self.action.click()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ComplexActionRowRegion(BaseActionRowRegion):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1abeadc6_60d9b282","line":60,"updated":"2014-08-20 07:22:40.000000000","message":"I think we don\u0027t need one of this method(action() or execute_action()).\nWhat do you think about this:\n@property\ndef _get_action(self):\n      return self.get_element(*self._action_locator)\ndef execute_action(self):\n      self._get_action.click()","commit_id":"0e368e6fc4f7aebac66d6d339a0aa7b15f55fe32"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"bd165f65084dc1093b683db9457dbae8b3f4a865","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return self._get_action()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def execute_action(self):"},{"line_number":60,"context_line":"        self.action.click()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ComplexActionRowRegion(BaseActionRowRegion):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1abeadc6_c42343bb","line":60,"in_reply_to":"1abeadc6_2b887be6","updated":"2014-08-21 13:03:16.000000000","message":"Removed the execute_action method","commit_id":"0e368e6fc4f7aebac66d6d339a0aa7b15f55fe32"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"3226c13263fd5e67613caa9b1e3ad5c6e6a221bd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return self._get_action()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def execute_action(self):"},{"line_number":60,"context_line":"        self.action.click()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class ComplexActionRowRegion(BaseActionRowRegion):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1abeadc6_2b887be6","line":60,"in_reply_to":"1abeadc6_60d9b282","updated":"2014-08-20 08:19:35.000000000","message":"You are right, thanks.\n\nBut i would maybe left the action property and remove execute_action instead. What do you think?","commit_id":"0e368e6fc4f7aebac66d6d339a0aa7b15f55fe32"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from selenium.webdriver.common import by"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstack_dashboard.test.integration_tests.regions import baseregion"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_4076e13f","line":13,"updated":"2014-09-01 08:29:02.000000000","message":"I\u0027ve noticed that a new functionality, filtering by different options, was added to some tables (e.g. images and instances).\nI\u0027m not sure, but I can\u0027t see where this is implemented in the table actions. Is this supported?","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"from selenium.webdriver.common import by"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstack_dashboard.test.integration_tests.regions import baseregion"}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_b6933ef9","line":13,"in_reply_to":"fa98f980_4076e13f","updated":"2014-09-01 18:41:40.000000000","message":"This is a new feature, it is not implemented anywhere i would encourage anyone who needs it to implement a new region that inherits from already existing one.\n\nI cannot cover all new features that are being implemented in horizon in this patch,  as i am slow compared to all devs., my patch would be then ridiculously big and probably never accepted.\n\nAnother aspect to this is that i am trying to test all implemented regions in following dependent patches. I could not guarantee that it works as expected.","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"defaad6895b126ca8a1fcec21238fe0793eb34b7","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _init_actions(self):"},{"line_number":85,"context_line":"        self._init_dynamic_property(self.primary_action_name,"},{"line_number":86,"context_line":"                                     self._get_primary_action)"},{"line_number":87,"context_line":"        self._init_dynamic_properties(self.secondary_action_names,"},{"line_number":88,"context_line":"                                      self._get_secondary_actions)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_683d6abb","line":86,"updated":"2014-09-09 08:10:37.000000000","message":"strange alignment","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2fbfca6355030f495e471fa3054479dcc4cf53b7","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _init_actions(self):"},{"line_number":85,"context_line":"        self._init_dynamic_property(self.primary_action_name,"},{"line_number":86,"context_line":"                                     self._get_primary_action)"},{"line_number":87,"context_line":"        self._init_dynamic_properties(self.secondary_action_names,"},{"line_number":88,"context_line":"                                      self._get_secondary_actions)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_10f1d96a","line":86,"in_reply_to":"fa98f980_4a125bb5","updated":"2014-09-13 16:28:24.000000000","message":"Done","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"10aaa69525fa0c7a57813aef0705765d07cc870c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _init_actions(self):"},{"line_number":85,"context_line":"        self._init_dynamic_property(self.primary_action_name,"},{"line_number":86,"context_line":"                                     self._get_primary_action)"},{"line_number":87,"context_line":"        self._init_dynamic_properties(self.secondary_action_names,"},{"line_number":88,"context_line":"                                      self._get_secondary_actions)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_4a125bb5","line":86,"in_reply_to":"fa98f980_683d6abb","updated":"2014-09-09 08:59:29.000000000","message":"thx","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"defaad6895b126ca8a1fcec21238fe0793eb34b7","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def _get_actions(self):"},{"line_number":184,"context_line":"        return self._get_elements(*self._actions_locator)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # properties"},{"line_number":187,"context_line":"    @property"},{"line_number":188,"context_line":"    def actions(self):"},{"line_number":189,"context_line":"        return self._get_actions()"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_48dc2675","line":186,"updated":"2014-09-09 08:10:37.000000000","message":"Its comment really need ?","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"10aaa69525fa0c7a57813aef0705765d07cc870c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def _get_actions(self):"},{"line_number":184,"context_line":"        return self._get_elements(*self._actions_locator)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # properties"},{"line_number":187,"context_line":"    @property"},{"line_number":188,"context_line":"    def actions(self):"},{"line_number":189,"context_line":"        return self._get_actions()"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_48afc62b","line":186,"in_reply_to":"fa98f980_48dc2675","updated":"2014-09-09 08:59:29.000000000","message":"yes :-D, it does not mess anything","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"defaad6895b126ca8a1fcec21238fe0793eb34b7","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        for elem in self._get_elements(*self._rows_locator):"},{"line_number":203,"context_line":"            row \u003d BtnActionRowRegion(self.driver, self.conf, elem,"},{"line_number":204,"context_line":"                                     self.row_action_name)"},{"line_number":205,"context_line":"            rows.append(row)"},{"line_number":206,"context_line":"        return rows"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_68e3aa05","line":205,"updated":"2014-09-09 08:10:37.000000000","message":"maybe will be best use like at 220 line ?","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"2fbfca6355030f495e471fa3054479dcc4cf53b7","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        for elem in self._get_elements(*self._rows_locator):"},{"line_number":203,"context_line":"            row \u003d BtnActionRowRegion(self.driver, self.conf, elem,"},{"line_number":204,"context_line":"                                     self.row_action_name)"},{"line_number":205,"context_line":"            rows.append(row)"},{"line_number":206,"context_line":"        return rows"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_70ea2575","line":205,"in_reply_to":"fa98f980_68e3aa05","updated":"2014-09-13 16:28:24.000000000","message":"Done","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"10aaa69525fa0c7a57813aef0705765d07cc870c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        for elem in self._get_elements(*self._rows_locator):"},{"line_number":203,"context_line":"            row \u003d BtnActionRowRegion(self.driver, self.conf, elem,"},{"line_number":204,"context_line":"                                     self.row_action_name)"},{"line_number":205,"context_line":"            rows.append(row)"},{"line_number":206,"context_line":"        return rows"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_ca3e4b29","line":205,"in_reply_to":"fa98f980_68e3aa05","updated":"2014-09-09 08:59:29.000000000","message":"it is split this way on purpose because of readability","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"a846edc83607bdb187659fac9f0d0b83f17729fc","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        for elem in self._get_elements(*self._rows_locator):"},{"line_number":203,"context_line":"            row \u003d BtnActionRowRegion(self.driver, self.conf, elem,"},{"line_number":204,"context_line":"                                     self.row_action_name)"},{"line_number":205,"context_line":"            rows.append(row)"},{"line_number":206,"context_line":"        return rows"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"fa98f980_0d34eddc","line":205,"in_reply_to":"fa98f980_ca3e4b29","updated":"2014-09-09 09:30:23.000000000","message":"Why we don\u0027t split in 220line ? :D","commit_id":"1addcd1d122741093aff1372f345749e3c743de4"}],"openstack_dashboard/test/integration_tests/tests/test_project_compute_overview.py":[{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"a0d59cfdf311eb17a8ed9077004eea5530161130","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \"\"\"This test is more likely for verification that some basic regions"},{"line_number":18,"context_line":"     functionality works as expected."},{"line_number":19,"context_line":"     \"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_invalid_date(self):"},{"line_number":22,"context_line":"        \"\"\"Submiting invalid date should result in visibility"},{"line_number":23,"context_line":"         of error message"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_762050f8","line":20,"updated":"2014-08-03 14:10:23.000000000","message":"regarding the first two methods, negative tests is something we haven\u0027t discussed yet.\nwe should keep in mind we are trying to be correlated with tempest\u0027s guidelines (though as I wrote, it\u0027s not sure whether the tests will move there in the future).\n\nhttp://docs.openstack.org/developer/tempest/HACKING.html#negative-tests","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"e6b9eb3505270fd1f2ef56686d2e10a13af4a9ac","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \"\"\"This test is more likely for verification that some basic regions"},{"line_number":18,"context_line":"     functionality works as expected."},{"line_number":19,"context_line":"     \"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_invalid_date(self):"},{"line_number":22,"context_line":"        \"\"\"Submiting invalid date should result in visibility"},{"line_number":23,"context_line":"         of error message"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_a4a8f278","line":20,"in_reply_to":"baada198_762050f8","updated":"2014-08-03 18:10:21.000000000","message":"well i have submitted this tests just to make sure that regions are working and that its functionality can be verified easily - so i picked few simple things on which it can be applied on the first page and that\u0027s it -\u003e i was thinking of moving them to separate file called region tests or smth. like this. Anyway i would not like to refactor those tests - as i said i had in mind mainly verification of my region patch -\u003e i would rather prefer to call the file differently.","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"a0d59cfdf311eb17a8ed9077004eea5530161130","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                         \"Table should be empty.\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_table_data_save_to_csv_action(self):"},{"line_number":40,"context_line":"        csv_btn \u003d self.home_pg.action_table.actions[0]"},{"line_number":41,"context_line":"        action_name \u003d \"Download CSV Summary\""},{"line_number":42,"context_line":"        self.assertEqual(action_name, csv_btn.text,"},{"line_number":43,"context_line":"                         \"Action name should be: %s\" % action_name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_f67b80f1","line":40,"updated":"2014-08-03 14:10:23.000000000","message":"IMO we should try to wrap the actions[#] in a more readable way, does that makes sense?","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"e6b9eb3505270fd1f2ef56686d2e10a13af4a9ac","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                         \"Table should be empty.\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_table_data_save_to_csv_action(self):"},{"line_number":40,"context_line":"        csv_btn \u003d self.home_pg.action_table.actions[0]"},{"line_number":41,"context_line":"        action_name \u003d \"Download CSV Summary\""},{"line_number":42,"context_line":"        self.assertEqual(action_name, csv_btn.text,"},{"line_number":43,"context_line":"                         \"Action name should be: %s\" % action_name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_2495c231","line":40,"in_reply_to":"baada198_f67b80f1","updated":"2014-08-03 18:10:21.000000000","message":"agree, i plan to do it as with forms, but there was no time","commit_id":"c74558dafb37cfb9377a1bd87a72137bee6b3256"},{"author":{"_account_id":8577,"name":"Daniel Korn","email":"dkorn@redhat.com","username":"dkorn"},"change_message_id":"19f846236fdd05767c80db26c2693d474128c6e2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def test_invalid_date(self):"},{"line_number":22,"context_line":"        \"\"\"Submission of invalid date should result in visibility"},{"line_number":23,"context_line":"         of error message"},{"line_number":24,"context_line":"         \"\"\""},{"line_number":25,"context_line":"        self.home_pg.date_form.query(\"2000-06-01\", \"1980-06-01\")"},{"line_number":26,"context_line":"        self.assertTrue(self.home_pg.is_error_message_present(),"},{"line_number":27,"context_line":"                        \"Error message is not present even though\""}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_20ce3d5b","line":24,"updated":"2014-09-01 08:29:02.000000000","message":"if we decide to include negative tests for now, I think it\u0027ll be better to add \"Negative test:\" to the docstring and perhaps also a dedicated decorator","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"9f04056fb9a397a66d83f72bfc976aa1380c0539","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def test_invalid_date(self):"},{"line_number":22,"context_line":"        \"\"\"Submission of invalid date should result in visibility"},{"line_number":23,"context_line":"         of error message"},{"line_number":24,"context_line":"         \"\"\""},{"line_number":25,"context_line":"        self.home_pg.date_form.query(\"2000-06-01\", \"1980-06-01\")"},{"line_number":26,"context_line":"        self.assertTrue(self.home_pg.is_error_message_present(),"},{"line_number":27,"context_line":"                        \"Error message is not present even though\""}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_6b3f2f26","line":24,"in_reply_to":"fa98f980_20ce3d5b","updated":"2014-09-01 18:41:40.000000000","message":"Primary goal of this tests was to ensure that region patch works as expected as now regions are used in practice i would say that it is not necessary to cover its functionality with this tests. I would suggest removing this tests.\n\nWhat do you think?","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"},{"author":{"_account_id":11473,"name":"Tomáš Nová?ik","email":"tnovacik@redhat.com","username":"tnovacik"},"change_message_id":"a322f2d8bbf0578733b9f5bd6168e06476476991","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def test_invalid_date(self):"},{"line_number":22,"context_line":"        \"\"\"Submission of invalid date should result in visibility"},{"line_number":23,"context_line":"         of error message"},{"line_number":24,"context_line":"         \"\"\""},{"line_number":25,"context_line":"        self.home_pg.date_form.query(\"2000-06-01\", \"1980-06-01\")"},{"line_number":26,"context_line":"        self.assertTrue(self.home_pg.is_error_message_present(),"},{"line_number":27,"context_line":"                        \"Error message is not present even though\""}],"source_content_type":"text/x-python","patch_set":29,"id":"fa98f980_b8fb6fbf","line":24,"in_reply_to":"fa98f980_20ce3d5b","updated":"2014-09-05 19:12:01.000000000","message":"Removed.","commit_id":"dbda895245ba83366a3369c3fa8e53b741e9f0fd"}]}
