)]}'
{"openstack_dashboard/dashboards/project/databases/forms.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"5e741228327d17d78a99be446853d09deff07cfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e24adb81","line":1,"updated":"2014-06-27 16:32:56.000000000","message":"I\u0027m not excited about having a duplicate form class of the ExtendForm in openstack_dashboard/dashboards/project/volumes/volumes/forms.py which this is copied from. I think using ExtendForm as the base class and overriding the handle method would be cleaner, but I do see use of instance_id rather than volume name in the form fields.","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"0a566fafb18ae6b67c97ae66776a20effe9384fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_a077eb39","line":1,"in_reply_to":"1ae5cdf2_e24adb81","updated":"2014-06-27 17:13:09.000000000","message":"I understand you concern here - there is a lot of similarity between trove resize-volume and the cinder one. However, the next blueprint will be for resize-instance which I believe will be significantly different to the nova resize instance form - so in that case to be consistent I chose to keep the trove forms standalone. Thoughts?","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"ef352aed54170a5a861e297ff90e0f8e093e948d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_22b3e39a","line":2,"updated":"2014-06-27 16:23:14.000000000","message":"This can\u0027t be quite right.  I thought that copyright was to be omitted?  If not, 2013 doesn\u0027t seem right.","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"091e5f1d9acb28a7e9eb620cf10864e27cd39ffb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d592ab9e","line":2,"in_reply_to":"1ae5cdf2_22b3e39a","updated":"2014-06-30 18:33:41.000000000","message":"Changed","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"1e728a174bed5bcb4c5d2e4d13bdcb17754bb3ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Tesorc Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_ec808848","line":1,"updated":"2014-07-02 09:31:13.000000000","message":"Tesorc or Tesora?","commit_id":"7c19e57b52bc6ac9be364d7f4a768bc507bb2643"}],"openstack_dashboard/dashboards/project/databases/tables.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"5e741228327d17d78a99be446853d09deff07cfb","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class ResizeVolume(tables.LinkAction):"},{"line_number":115,"context_line":"    name \u003d \"resize_volume\""},{"line_number":116,"context_line":"    verbose_name \u003d _(\"Resize Volume\")"},{"line_number":117,"context_line":"    url \u003d \"horizon:project:databases:resize_volume\""},{"line_number":118,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-resize\")"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_0586f164","line":116,"updated":"2014-06-27 16:32:56.000000000","message":"like in volumes, I think Extend is more accurate as the validator in the form is requiring the new volume size to be larger not both directions.","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"0a566fafb18ae6b67c97ae66776a20effe9384fc","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class ResizeVolume(tables.LinkAction):"},{"line_number":115,"context_line":"    name \u003d \"resize_volume\""},{"line_number":116,"context_line":"    verbose_name \u003d _(\"Resize Volume\")"},{"line_number":117,"context_line":"    url \u003d \"horizon:project:databases:resize_volume\""},{"line_number":118,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-resize\")"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_80e74f11","line":116,"in_reply_to":"1ae5cdf2_0586f164","updated":"2014-06-27 17:13:09.000000000","message":"I agree that \u0027Extend\u0027 is more accurate than resize - but then we won\u0027t be consistent with the API / CLI. I see that in cinder the API is \u0027extend\u0027 but in the trove API it is resize-volume. Thoughts?","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":8090,"name":"Chad Roberts","email":"croberts@redhat.com","username":"croberts"},"change_message_id":"ef352aed54170a5a861e297ff90e0f8e093e948d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        table_actions \u003d (LaunchLink, TerminateInstance)"},{"line_number":186,"context_line":"        row_actions \u003d (CreateBackup,"},{"line_number":187,"context_line":"                       ResizeVolume,"},{"line_number":188,"context_line":"                       RestartInstance, TerminateInstance)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class UsersTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_42e8ef7a","line":188,"updated":"2014-06-27 16:23:14.000000000","message":"row_actions could all be 1 per line for consistency.","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"091e5f1d9acb28a7e9eb620cf10864e27cd39ffb","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        table_actions \u003d (LaunchLink, TerminateInstance)"},{"line_number":186,"context_line":"        row_actions \u003d (CreateBackup,"},{"line_number":187,"context_line":"                       ResizeVolume,"},{"line_number":188,"context_line":"                       RestartInstance, TerminateInstance)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class UsersTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_75f39f0a","line":188,"in_reply_to":"1ae5cdf2_42e8ef7a","updated":"2014-06-30 18:33:41.000000000","message":"Split into one per line","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"}],"openstack_dashboard/dashboards/project/databases/templates/databases/_resize_volume.html":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"5e741228327d17d78a99be446853d09deff07cfb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% load url from future %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block form_id %}resize_instance_form{% endblock %}"},{"line_number":6,"context_line":"{% block form_action %}{% url \"horizon:project:databases:resize_volume\" instance_id %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal_id %}resize_instance_modal{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"1ae5cdf2_45571901","line":5,"updated":"2014-06-27 16:32:56.000000000","message":"nit: are we resizing a volume or an instance?","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"091e5f1d9acb28a7e9eb620cf10864e27cd39ffb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% load url from future %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block form_id %}resize_instance_form{% endblock %}"},{"line_number":6,"context_line":"{% block form_action %}{% url \"horizon:project:databases:resize_volume\" instance_id %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal_id %}resize_instance_modal{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"baada198_55d5bb41","line":5,"in_reply_to":"1ae5cdf2_45571901","updated":"2014-06-30 18:33:41.000000000","message":"Changed to resize_volume","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"5e741228327d17d78a99be446853d09deff07cfb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block form_id %}resize_instance_form{% endblock %}"},{"line_number":6,"context_line":"{% block form_action %}{% url \"horizon:project:databases:resize_volume\" instance_id %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal_id %}resize_instance_modal{% endblock %}"},{"line_number":9,"context_line":"{% block modal-header %}{% trans \"Resize Database Volume\" %}{% endblock %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% block modal-body %}"}],"source_content_type":"text/html","patch_set":2,"id":"1ae5cdf2_853cc1c0","line":8,"updated":"2014-06-27 16:32:56.000000000","message":"nit: same question","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"091e5f1d9acb28a7e9eb620cf10864e27cd39ffb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block form_id %}resize_instance_form{% endblock %}"},{"line_number":6,"context_line":"{% block form_action %}{% url \"horizon:project:databases:resize_volume\" instance_id %}{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal_id %}resize_instance_modal{% endblock %}"},{"line_number":9,"context_line":"{% block modal-header %}{% trans \"Resize Database Volume\" %}{% endblock %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% block modal-body %}"}],"source_content_type":"text/html","patch_set":2,"id":"baada198_f5bdef03","line":8,"in_reply_to":"1ae5cdf2_853cc1c0","updated":"2014-06-30 18:33:41.000000000","message":"Changed to resize_volume","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"5e741228327d17d78a99be446853d09deff07cfb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003c/div\u003e"},{"line_number":17,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":18,"context_line":"  \u003cp\u003e{% blocktrans %}Specify the new volume size for the database instance.{% endblocktrans %}\u003c/p\u003e"},{"line_number":19,"context_line":"  \u003cp\u003e{% blocktrans %}\u003cstrong\u003ePlease note:\u003c/strong\u003e The value specified in the Volume Size field should be greater than existing volume size.{% endblocktrans %}\u003c/p\u003e"},{"line_number":20,"context_line":"\u003c/div\u003e"},{"line_number":21,"context_line":"{% endblock %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/html","patch_set":2,"id":"1ae5cdf2_a55e1d11","line":19,"updated":"2014-06-27 16:32:56.000000000","message":"here it says should, but the validation in the form requires it, change should to must","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"091e5f1d9acb28a7e9eb620cf10864e27cd39ffb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\u003c/div\u003e"},{"line_number":17,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":18,"context_line":"  \u003cp\u003e{% blocktrans %}Specify the new volume size for the database instance.{% endblocktrans %}\u003c/p\u003e"},{"line_number":19,"context_line":"  \u003cp\u003e{% blocktrans %}\u003cstrong\u003ePlease note:\u003c/strong\u003e The value specified in the Volume Size field should be greater than existing volume size.{% endblocktrans %}\u003c/p\u003e"},{"line_number":20,"context_line":"\u003c/div\u003e"},{"line_number":21,"context_line":"{% endblock %}"},{"line_number":22,"context_line":""}],"source_content_type":"text/html","patch_set":2,"id":"baada198_353767b2","line":19,"in_reply_to":"1ae5cdf2_a55e1d11","updated":"2014-06-30 18:33:41.000000000","message":"Updated message","commit_id":"b516216642ec1672d49ca0a666fef7d816f0adb0"}],"openstack_dashboard/dashboards/project/databases/urls.py":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"b1f0cd3e6b678a85f12e7cd1eeee94047d4b3f4c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027,"},{"line_number":26,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":27,"context_line":"    url(r\u0027^launch$\u0027, views.LaunchInstanceView.as_view(), name\u003d\u0027launch\u0027),"},{"line_number":28,"context_line":"    url(r\u0027^(?P\u003cinstance_id\u003e[^/]+)/$\u0027, views.DetailView.as_view(),"},{"line_number":29,"context_line":"        name\u003d\u0027detail\u0027),"},{"line_number":30,"context_line":"    url(INSTANCES % \u0027resize_volume\u0027, views.ResizeVolumeView.as_view(),"},{"line_number":31,"context_line":"        name\u003d\u0027resize_volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_7b7cd671","line":28,"updated":"2014-06-26 20:09:26.000000000","message":"Would probably be cleaner to update this line to use INSTANCES as well.","commit_id":"fd07602f1a041c14e4a1398fb78e9d55bd786ae8"},{"author":{"_account_id":9750,"name":"Andrew Bramley","email":"andrew.bramley@verizonwireless.com","username":"abramley"},"change_message_id":"24d2bebbc08fb84123502b33cc365dbad66e8f9b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027\u0027,"},{"line_number":26,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":27,"context_line":"    url(r\u0027^launch$\u0027, views.LaunchInstanceView.as_view(), name\u003d\u0027launch\u0027),"},{"line_number":28,"context_line":"    url(r\u0027^(?P\u003cinstance_id\u003e[^/]+)/$\u0027, views.DetailView.as_view(),"},{"line_number":29,"context_line":"        name\u003d\u0027detail\u0027),"},{"line_number":30,"context_line":"    url(INSTANCES % \u0027resize_volume\u0027, views.ResizeVolumeView.as_view(),"},{"line_number":31,"context_line":"        name\u003d\u0027resize_volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_fb6e262b","line":28,"in_reply_to":"1ae5cdf2_7b7cd671","updated":"2014-06-26 20:27:41.000000000","message":"Done","commit_id":"fd07602f1a041c14e4a1398fb78e9d55bd786ae8"}]}