)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"b1328d0b06ebd8596d0ac4ab79145092c7c09351","unresolved":false,"context_lines":[{"line_number":17,"context_line":"by using the \u0027View Password\u0027 the user can see the"},{"line_number":18,"context_line":"admin password to access the rescued instance and"},{"line_number":19,"context_line":"come out from the rescue mode by clicking the"},{"line_number":20,"context_line":"\u0027UnRescue Instance\u0027 option."},{"line_number":21,"context_line":"Change-Id: I844c86c95aae6426514fe6220ece5b2100aa95bc"},{"line_number":22,"context_line":"Implements: blueprint instance-rescue-horizon-support"},{"line_number":23,"context_line":"Co-Authored-By: Cédric Soulas \u003ccedric.soulas@cloudwatt.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aa7fdbe_43b98f2d","line":20,"updated":"2014-10-20 13:50:55.000000000","message":"Codestylel does not require this explicitly, but usually commit message tags are separated by a blank line.","commit_id":"507d444508773cc193ec4c940af890855885e34d"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"1179a80278dd328be5b2be1b94df599f3830dff3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the file system via the \u0027nova rescue\u0027 command."},{"line_number":12,"context_line":"This support is added in the horizon, now the user"},{"line_number":13,"context_line":"can rescue the instance via horizon. \u0027Rescue Instance\u0027"},{"line_number":14,"context_line":"option will be available in row action. once the"},{"line_number":15,"context_line":"instance is rescued the \u0027UnRescue Instance\u0027 and"},{"line_number":16,"context_line":"\u0027View Password\u0027 options will be shown in the row action."},{"line_number":17,"context_line":"by using the \u0027View Password\u0027 the user can see the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a8c0949_5e512c0d","line":14,"updated":"2014-11-05 12:51:15.000000000","message":"(nit) once -\u003e Once","commit_id":"32167455288b89949cc518a5e75df5b833cb76fa"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"1179a80278dd328be5b2be1b94df599f3830dff3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"option will be available in row action. once the"},{"line_number":15,"context_line":"instance is rescued the \u0027UnRescue Instance\u0027 and"},{"line_number":16,"context_line":"\u0027View Password\u0027 options will be shown in the row action."},{"line_number":17,"context_line":"by using the \u0027View Password\u0027 the user can see the"},{"line_number":18,"context_line":"admin password to access the rescued instance and"},{"line_number":19,"context_line":"come out from the rescue mode by clicking the"},{"line_number":20,"context_line":"\u0027UnRescue Instance\u0027 option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a8c0949_7e58a832","line":17,"updated":"2014-11-05 12:51:15.000000000","message":"(nit) \tby -\u003e By","commit_id":"32167455288b89949cc518a5e75df5b833cb76fa"}],"horizon/static/horizon/js/horizon.modals.js":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"796a642ffba5138def817584b8079540454b1c1f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  return modal;"},{"line_number":39,"context_line":"};"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"/* create a rescue model template for client-side*/"},{"line_number":42,"context_line":"horizon.modals.createRescue \u003d function (title, body, confirm, cancel) {"},{"line_number":43,"context_line":"  if (!cancel) {"},{"line_number":44,"context_line":"    cancel \u003d gettext(\"Cancel\");"}],"source_content_type":"text/javascript","patch_set":2,"id":"baada198_ede36304","line":41,"updated":"2014-07-22 13:13:32.000000000","message":"modal","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"796a642ffba5138def817584b8079540454b1c1f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"};"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"/* create a rescue model template for client-side*/"},{"line_number":42,"context_line":"horizon.modals.createRescue \u003d function (title, body, confirm, cancel) {"},{"line_number":43,"context_line":"  if (!cancel) {"},{"line_number":44,"context_line":"    cancel \u003d gettext(\"Cancel\");"},{"line_number":45,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":2,"id":"baada198_ca43e511","line":42,"updated":"2014-07-22 13:13:32.000000000","message":"I don\u0027t think you need to pass around the cancel parameter for this dialog.  It\u0027s useful above because its a generic dialog and it might be useful to rename the cancel button.  Since this dialog is specifically for rescue you don\u0027t need that complexity.  Just hardcode translated cancel in the params list for the template.","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"}],"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"796a642ffba5138def817584b8079540454b1c1f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    modal \u003d horizon.modals.createRescue(title, body, action_string);"},{"line_number":188,"context_line":"  } else {"},{"line_number":189,"context_line":"    name_string \u003d interpolate(gettext(\"You have selected %s. \"), [name_string]);"},{"line_number":190,"context_line":"    body \u003d name_string + interpolate(gettext(\"Please confirm your selection. This action cannot be undone.\"));"},{"line_number":191,"context_line":"    modal \u003d horizon.modals.create(title, body, action_string);"},{"line_number":192,"context_line":"  }"},{"line_number":193,"context_line":"  modal.modal();"}],"source_content_type":"text/javascript","patch_set":2,"id":"baada198_c4acbb39","line":190,"updated":"2014-07-22 13:13:32.000000000","message":"interpolate is not needed here","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"}],"horizon/templates/horizon/client_side/_rescue_confirm.html":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"796a642ffba5138def817584b8079540454b1c1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block id %}rescue_template{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"\u003cdiv class\u003d\"modal hide in\" style\u003d\"top: 80px; display: block;\"\u003e"},{"line_number":9,"context_line":"  \u003cdiv class\u003d\u0027modal-header\u0027\u003e"},{"line_number":10,"context_line":"    \u003ca class\u003d\u0027close\u0027 data-dismiss\u003d\u0027modal\u0027\u003e\u0026times;\u003c/a\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"baada198_8e6ae4eb","line":7,"updated":"2014-07-22 13:13:32.000000000","message":"I\u0027d like to see the jstemplate/endjstemplate at the same level.  It\u0027s not a bug; it just that the enclosed area has mismatched tags, which looks weird to me.","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"09e68c7f521835b95542a4a97076d3291c840258","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    {% blocktrans %}"},{"line_number":19,"context_line":"    \u003cp\u003eThe rescue mode is only for emergency purpose, for example in case of a system or access failure.\u003c/p\u003e"},{"line_number":20,"context_line":"    \u003cdiv class\u003d\u0027alert\u0027\u003e"},{"line_number":21,"context_line":"    \u003cp\u003eThis will shut down your instance and mount the root disk to a temporary server. Then, you will be able to connect to this server, repair the system configuration or recover your data.\u003c/p\u003e"},{"line_number":22,"context_line":"    \u003c/div\u003e"},{"line_number":23,"context_line":"    {% endblocktrans %}"},{"line_number":24,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"baada198_948d80d6","line":21,"updated":"2014-07-22 16:27:03.000000000","message":"Smallest nit possible here:  shouldn\u0027t the above \u003cp\u003e be indented one more time?","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"796a642ffba5138def817584b8079540454b1c1f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \u003ca href\u003d\u0027#\u0027 class\u003d\u0027btn cancel\u0027 data-dismiss\u003d\u0027modal\u0027\u003e[[cancel]]\u003c/a\u003e"},{"line_number":29,"context_line":"  \u003c/div\u003e"},{"line_number":30,"context_line":"\u003c/div\u003e"},{"line_number":31,"context_line":"{% endjstemplate %}"},{"line_number":32,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"baada198_2e00f801","line":31,"updated":"2014-07-22 13:13:32.000000000","message":"Same concern as above.  Moving this up one line/in one level would just look right to me.","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"}],"horizon/templates/horizon/client_side/templates.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% include \"horizon/client_side/_table_row.html\" %}"},{"line_number":3,"context_line":"{% include \"horizon/client_side/_alert_message.html\" %}"},{"line_number":4,"context_line":"{% include \"horizon/client_side/_loading.html\" %}"},{"line_number":5,"context_line":"{% include \"horizon/client_side/_membership.html\" %}"}],"source_content_type":"text/html","patch_set":15,"id":"ba3cc151_7a2c4b4a","line":5,"updated":"2015-07-07 20:32:22.000000000","message":"?","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"3489e5906af1cc6140b7fe05176db8fed7c035e6","unresolved":false,"context_lines":[{"line_number":637,"context_line":""},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"def server_rescue(request, instance_id):"},{"line_number":640,"context_line":"    return novaclient(request).servers.rescue(instance_id)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"def server_unrescue(request, instance_id):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_0b31c8a2","line":640,"updated":"2015-05-06 09:39:36.000000000","message":"add image parameter here, so we can specify which image is used to rescue with.","commit_id":"796a1da80355facf8e5718d104dd0f3c07c7f3b4"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"9741cd1201d44ca36d2985413dfd1e3f94005b47","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    novaclient(request).servers.unpause(instance_id)"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"def server_rescue(request, instance_id):"},{"line_number":644,"context_line":"    return novaclient(request).servers.rescue(instance_id)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba3cc151_d994138c","line":643,"updated":"2015-07-03 06:35:05.000000000","message":"AFAIK, rescue API supports to specify image while rescuing the instance which seems more useful.\n\nThe custom image used during rescue might be corrupt, leading to errors, or too large, leading to timeouts. Also, if the base image is deleted, the image ref on the instance_system_metadata will be invalid, leading to the rescue operation failing.","commit_id":"261f75d9fc4a6cd553f4197b380b213e80939729"}],"openstack_dashboard/dashboards/admin/instances/templates/instances/_rescue.html":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"886438ec8adab0f2682d54a627052bbe686233ac","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% block modal-footer %}"},{"line_number":26,"context_line":"  \u003cinput class\u003d\"btn btn-primary pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Rescue Instance\" %}\" /\u003e"},{"line_number":27,"context_line":"  \u003ca href\u003d\"{% url \"horizon:admin:instances:index\" %}\" class\u003d\"btn btn-default secondary cancel close\"\u003e{% trans \"Cancel\" %}\u003c/a\u003e"},{"line_number":28,"context_line":"{% endblock %}"},{"line_number":29,"context_line":""}],"source_content_type":"text/html","patch_set":17,"id":"9a41bdd9_7d68f787","line":27,"updated":"2015-07-13 12:49:49.000000000","message":"might want to consider using the standard form fields for cancel url and cancel text, submit button text.  there is nothing in this block that really needs to be here","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"}],"openstack_dashboard/dashboards/admin/instances/urls.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"886438ec8adab0f2682d54a627052bbe686233ac","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    url(INSTANCES % \u0027vnc\u0027, \u0027vnc\u0027, name\u003d\u0027vnc\u0027),"},{"line_number":35,"context_line":"    url(INSTANCES % \u0027rescue\u0027, views.RescueView.as_view(), name\u003d\u0027rescue\u0027),"},{"line_number":36,"context_line":"    url(INSTANCES % \u0027show_password\u0027,"},{"line_number":37,"context_line":"        views.RescuePasswordView.as_view(), name\u003d\u0027show_password\u0027),"},{"line_number":38,"context_line":"    url(INSTANCES % \u0027spice\u0027, \u0027spice\u0027, name\u003d\u0027spice\u0027),"},{"line_number":39,"context_line":"    url(INSTANCES % \u0027rdp\u0027, \u0027rdp\u0027, name\u003d\u0027rdp\u0027),"},{"line_number":40,"context_line":"    url(INSTANCES % \u0027live_migrate\u0027, views.LiveMigrateView.as_view(),"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a41bdd9_1dbbebe6","line":37,"updated":"2015-07-13 12:49:49.000000000","message":"I thought this review was only for rescue - is show password another change?","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"d7cd9eb05b9f8857cddf002eac7dc6d9c37a51e8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    url(INSTANCES % \u0027vnc\u0027, \u0027vnc\u0027, name\u003d\u0027vnc\u0027),"},{"line_number":35,"context_line":"    url(INSTANCES % \u0027rescue\u0027, views.RescueView.as_view(), name\u003d\u0027rescue\u0027),"},{"line_number":36,"context_line":"    url(INSTANCES % \u0027show_password\u0027,"},{"line_number":37,"context_line":"        views.RescuePasswordView.as_view(), name\u003d\u0027show_password\u0027),"},{"line_number":38,"context_line":"    url(INSTANCES % \u0027spice\u0027, \u0027spice\u0027, name\u003d\u0027spice\u0027),"},{"line_number":39,"context_line":"    url(INSTANCES % \u0027rdp\u0027, \u0027rdp\u0027, name\u003d\u0027rdp\u0027),"},{"line_number":40,"context_line":"    url(INSTANCES % \u0027live_migrate\u0027, views.LiveMigrateView.as_view(),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a5de9d1_5e00ab34","line":37,"in_reply_to":"9a41bdd9_1dbbebe6","updated":"2016-01-28 06:34:15.000000000","message":"it is belongs to the same patch. the show password will show the password of the rescued instance.","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"}],"openstack_dashboard/dashboards/project/instances/forms.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        required\u003dFalse,"},{"line_number":124,"context_line":"        widget\u003dforms.SelectWidget(attrs\u003d{\u0027class\u0027: \u0027image-selector\u0027},"},{"line_number":125,"context_line":"                                  data_attrs\u003d(\u0027size\u0027, \u0027display-name\u0027),"},{"line_number":126,"context_line":"                                  transform\u003d_image_choice_title))"},{"line_number":127,"context_line":"    password \u003d forms.RegexField("},{"line_number":128,"context_line":"        label\u003d_(\"Password\"),"},{"line_number":129,"context_line":"        required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_cde2802f","line":126,"updated":"2015-07-07 20:32:22.000000000","message":"maybe add help_text that says: \"If not specified, Nova will use the image that the instance is based off of.\"","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        required\u003dFalse,"},{"line_number":124,"context_line":"        widget\u003dforms.SelectWidget(attrs\u003d{\u0027class\u0027: \u0027image-selector\u0027},"},{"line_number":125,"context_line":"                                  data_attrs\u003d(\u0027size\u0027, \u0027display-name\u0027),"},{"line_number":126,"context_line":"                                  transform\u003d_image_choice_title))"},{"line_number":127,"context_line":"    password \u003d forms.RegexField("},{"line_number":128,"context_line":"        label\u003d_(\"Password\"),"},{"line_number":129,"context_line":"        required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_9c69f2fb","line":126,"in_reply_to":"ba3cc151_cde2802f","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # We have to protect the entire \"data\" dict because it contains the"},{"line_number":163,"context_line":"    # password and confirm_password strings."},{"line_number":164,"context_line":"    @sensitive_variables(\u0027data\u0027, \u0027password\u0027)"},{"line_number":165,"context_line":"    def handle(self, request, data):"},{"line_number":166,"context_line":"        instance \u003d data.get(\u0027instance_id\u0027)"},{"line_number":167,"context_line":"        image \u003d data.get(\u0027image\u0027) or None"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_4d019069","line":164,"updated":"2015-07-07 20:32:22.000000000","message":"don\u0027t need \u0027password\u0027, because it\u0027s in data dict","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    # We have to protect the entire \"data\" dict because it contains the"},{"line_number":163,"context_line":"    # password and confirm_password strings."},{"line_number":164,"context_line":"    @sensitive_variables(\u0027data\u0027, \u0027password\u0027)"},{"line_number":165,"context_line":"    def handle(self, request, data):"},{"line_number":166,"context_line":"        instance \u003d data.get(\u0027instance_id\u0027)"},{"line_number":167,"context_line":"        image \u003d data.get(\u0027image\u0027) or None"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_3cb3069c","line":164,"in_reply_to":"ba3cc151_4d019069","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                              instance,"},{"line_number":172,"context_line":"                                              password,"},{"line_number":173,"context_line":"                                              image)"},{"line_number":174,"context_line":"            if None is not response and len(response) \u003e 0 \\"},{"line_number":175,"context_line":"                    and \u0027adminPass\u0027 in response[1]:"},{"line_number":176,"context_line":"                setattr(settings, instance, response[1][\u0027adminPass\u0027])"},{"line_number":177,"context_line":"            messages.success(request, _(\u0027Rescued instance %s.\u0027) % instance)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_9a8b4f1e","line":174,"updated":"2015-07-07 20:32:22.000000000","message":"\u0027response is not None\u0027, for consistency","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                                              instance,"},{"line_number":172,"context_line":"                                              password,"},{"line_number":173,"context_line":"                                              image)"},{"line_number":174,"context_line":"            if None is not response and len(response) \u003e 0 \\"},{"line_number":175,"context_line":"                    and \u0027adminPass\u0027 in response[1]:"},{"line_number":176,"context_line":"                setattr(settings, instance, response[1][\u0027adminPass\u0027])"},{"line_number":177,"context_line":"            messages.success(request, _(\u0027Rescued instance %s.\u0027) % instance)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_5cb84a75","line":174,"in_reply_to":"ba3cc151_9a8b4f1e","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        except Exception:"},{"line_number":179,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":180,"context_line":"            exceptions.handle(request, _(\"Unable to rescue instance.\"),"},{"line_number":181,"context_line":"                              redirect\u003dredirect)"},{"line_number":182,"context_line":"        return True"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_8d15589c","line":181,"updated":"2015-07-07 20:32:22.000000000","message":"return False?","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        except Exception:"},{"line_number":179,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":180,"context_line":"            exceptions.handle(request, _(\"Unable to rescue instance.\"),"},{"line_number":181,"context_line":"                              redirect\u003dredirect)"},{"line_number":182,"context_line":"        return True"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_bca7164f","line":181,"in_reply_to":"ba3cc151_8d15589c","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":180,"context_line":"            exceptions.handle(request, _(\"Unable to rescue instance.\"),"},{"line_number":181,"context_line":"                              redirect\u003dredirect)"},{"line_number":182,"context_line":"        return True"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class DecryptPasswordInstanceForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_0d22a801","line":182,"updated":"2015-07-07 20:32:22.000000000","message":"put return True in try statement?","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":180,"context_line":"            exceptions.handle(request, _(\"Unable to rescue instance.\"),"},{"line_number":181,"context_line":"                              redirect\u003dredirect)"},{"line_number":182,"context_line":"        return True"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"class DecryptPasswordInstanceForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_dca45a4c","line":182,"in_reply_to":"ba3cc151_0d22a801","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"f22791b623930f241b1f72951d59e1647459558d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    instance_id \u003d forms.CharField(widget\u003dforms.HiddenInput())"},{"line_number":121,"context_line":"    image \u003d forms.ChoiceField("},{"line_number":122,"context_line":"        label\u003d_(\"Select Image\"),"},{"line_number":123,"context_line":"        help_text\u003d_(\"If not specified, Image that is based on\""},{"line_number":124,"context_line":"                    \" the instance will be chosen.\"),"},{"line_number":125,"context_line":"        required\u003dFalse,"},{"line_number":126,"context_line":"        widget\u003dforms.SelectWidget(attrs\u003d{\u0027class\u0027: \u0027image-selector\u0027},"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_3aa2c6fd","line":123,"updated":"2016-03-03 03:06:00.000000000","message":"not sure image should be capitalized, also the wording is a bit terse.","commit_id":"2bf13f0c8b02e34bc548e50ecabfb91a781085b4"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"09e68c7f521835b95542a4a97076d3291c840258","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                and not is_deleting(instance))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def action(self, request, obj_id):"},{"line_number":163,"context_line":"        response \u003d api.nova.server_rescue(request, obj_id)"},{"line_number":164,"context_line":"        if None !\u003d response and len(response) \u003e 0 \\"},{"line_number":165,"context_line":"                            and \u0027adminPass\u0027 in response[1]:"},{"line_number":166,"context_line":"            setattr(settings, obj_id, response[1][\u0027adminPass\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_541f6870","line":163,"updated":"2014-07-22 16:27:03.000000000","message":"Should this api.nova.server_rescue call be wrapped in a try/except clause?","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"09e68c7f521835b95542a4a97076d3291c840258","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def action(self, request, obj_id):"},{"line_number":163,"context_line":"        response \u003d api.nova.server_rescue(request, obj_id)"},{"line_number":164,"context_line":"        if None !\u003d response and len(response) \u003e 0 \\"},{"line_number":165,"context_line":"                            and \u0027adminPass\u0027 in response[1]:"},{"line_number":166,"context_line":"            setattr(settings, obj_id, response[1][\u0027adminPass\u0027])"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_345bd456","line":164,"updated":"2014-07-22 16:27:03.000000000","message":"Nit: Most python style-guides prefer \"None is not response\" instead of using the \"!\u003d\" operator.","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"},{"author":{"_account_id":9659,"name":"Matt Wood","email":"matt.wood@hpe.com","username":"woodm1979"},"change_message_id":"09e68c7f521835b95542a4a97076d3291c840258","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                and instance.status \u003d\u003d \"RESCUE\")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def action(self, request, obj_id):"},{"line_number":205,"context_line":"            api.nova.server_unrescue(request, obj_id)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"class TogglePause(tables.BatchAction):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f754feff","line":205,"updated":"2014-07-22 16:27:03.000000000","message":"Should this api.nova.server_unrescue call be wrapped in a try/except?","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"},{"author":{"_account_id":8674,"name":"Yves-Gwenael Bourhis","email":"ygbourhis@gmail.com","username":"yves"},"change_message_id":"aaf3a84ea38faad34a3433398d11eec29a91365a","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    action_present \u003d _(\"Rescue\")"},{"line_number":135,"context_line":"    action_past \u003d _(\"Rescued\")"},{"line_number":136,"context_line":"    data_type_singular \u003d _(\"Instance\")"},{"line_number":137,"context_line":"    data_type_plural \u003d _(\"Instances\")"},{"line_number":138,"context_line":"    classes \u003d (\"btn-rescue\", \"btn-danger\",)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def __init__(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_24a9a3df","line":137,"updated":"2014-10-14 09:09:30.000000000","message":"action_* and data_type_* are deprecated and will be dropped because they are impossible to translate:\nhttps://launchpad.net/bugs/1307476\n\nPlease use action_present and action_past staticmethods instead of properties, see:\nhttps://review.openstack.org/#/c/91338/","commit_id":"5355b591fe05a514dc636975424ec1ca074112a0"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                            request):"},{"line_number":179,"context_line":"            return False"},{"line_number":180,"context_line":"        if not instance:"},{"line_number":181,"context_line":"            return False"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        policy \u003d ((\"compute\", \"compute_extension:admin_actions:rescue\"),)"},{"line_number":184,"context_line":"        has_permission \u003d True"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_6f5d6f78","line":181,"updated":"2015-07-07 20:32:22.000000000","message":"combine?\n\nif not api.nova.extension_supported(\u0027AdminActions\u0027, request) or not instance:\n     return False\n\nAlos, do we want to change instance.status to RESCUE?","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                            request):"},{"line_number":179,"context_line":"            return False"},{"line_number":180,"context_line":"        if not instance:"},{"line_number":181,"context_line":"            return False"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        policy \u003d ((\"compute\", \"compute_extension:admin_actions:rescue\"),)"},{"line_number":184,"context_line":"        has_permission \u003d True"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_7cbd0e67","line":181,"in_reply_to":"ba3cc151_6f5d6f78","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                            request):"},{"line_number":222,"context_line":"            return False"},{"line_number":223,"context_line":"        if not instance:"},{"line_number":224,"context_line":"            return False"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        policy \u003d ((\"compute\", \"compute_extension:admin_actions:unrescue\"),)"},{"line_number":227,"context_line":"        has_permission \u003d True"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_eff73f57","line":224,"updated":"2015-07-07 20:32:22.000000000","message":"ditto combine","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                            request):"},{"line_number":222,"context_line":"            return False"},{"line_number":223,"context_line":"        if not instance:"},{"line_number":224,"context_line":"            return False"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        policy \u003d ((\"compute\", \"compute_extension:admin_actions:unrescue\"),)"},{"line_number":227,"context_line":"        has_permission \u003d True"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_bc9076ee","line":224,"in_reply_to":"ba3cc151_eff73f57","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"886438ec8adab0f2682d54a627052bbe686233ac","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        if policy_check:"},{"line_number":185,"context_line":"            has_permission \u003d policy_check("},{"line_number":186,"context_line":"                policy, request,"},{"line_number":187,"context_line":"                target\u003d{\u0027project_id\u0027: getattr(instance, \u0027tenant_id\u0027, None)})"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        return (has_permission and instance.status in ACTIVE_STATES"},{"line_number":190,"context_line":"                and not is_deleting(instance))"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a41bdd9_5d7893f2","line":187,"updated":"2015-07-13 12:49:49.000000000","message":"see comment below","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"886438ec8adab0f2682d54a627052bbe686233ac","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        if policy_check:"},{"line_number":226,"context_line":"            has_permission \u003d policy_check("},{"line_number":227,"context_line":"                policy, request,"},{"line_number":228,"context_line":"                target\u003d{\u0027project_id\u0027: getattr(instance, \u0027tenant_id\u0027, None)})"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        return (has_permission"},{"line_number":231,"context_line":"                and instance.status \u003d\u003d \"RESCUE\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a41bdd9_7dd797ed","line":228,"updated":"2015-07-13 12:49:49.000000000","message":"can\u0027t the policy file be changed instead?  having some policy files use project, some use project_id.... etc... this would be easier if we just had consistent policy files","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"}],"openstack_dashboard/dashboards/project/instances/templates/instances/_rescue.html":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"886438ec8adab0f2682d54a627052bbe686233ac","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% block modal-footer %}"},{"line_number":26,"context_line":"  \u003cinput class\u003d\"btn btn-primary pull-right\" type\u003d\"submit\" value\u003d\"{% trans \"Rescue Instance\" %}\" /\u003e"},{"line_number":27,"context_line":"  \u003ca href\u003d\"{% url \"horizon:project:instances:index\" %}\" class\u003d\"btn btn-default secondary cancel close\"\u003e{% trans \"Cancel\" %}\u003c/a\u003e"},{"line_number":28,"context_line":"{% endblock %}"},{"line_number":29,"context_line":""}],"source_content_type":"text/html","patch_set":17,"id":"9a41bdd9_7d1c77c1","line":27,"updated":"2015-07-13 12:49:49.000000000","message":"same comment on button stuff for consideration","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"f22791b623930f241b1f72951d59e1647459558d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":18,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":19,"context_line":"  \u003cp\u003e{% trans \"The rescue mode is only for emergency purpose, for example in case of a system or access failure.\" %}\u003c/p\u003e"},{"line_number":20,"context_line":"  \u003cp\u003e{% trans \"This will shut down your instance and mount the root disk to a temporary server. Then, you will be able to connect to this server, repair the system configuration or recover your data.\" %}\u003c/p\u003e"},{"line_number":21,"context_line":"  \u003cp\u003e{% trans \"You may optionally select an image and set a password on the rescue instance server.\" %}\u003c/p\u003e"},{"line_number":22,"context_line":"\u003c/div\u003e"},{"line_number":23,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"7af24918_7a7f2e66","line":20,"updated":"2016-03-03 03:06:00.000000000","message":"how does this work - does it require an administrator to get involved, or is this 100% self service for _member_ users?","commit_id":"2bf13f0c8b02e34bc548e50ecabfb91a781085b4"}],"openstack_dashboard/dashboards/project/instances/templates/instances/_rescue_password.html":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"796a642ffba5138def817584b8079540454b1c1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block modal-header %}{% trans \"Rescue Instance Password\" %}{% endblock %}"},{"line_number":6,"context_line":"{% block modal-body %}"},{"line_number":7,"context_line":"\u003cp\u003e{%trans \"Password to access the Rescued instance is : \"%}{{adminPass}}\u003c/p\u003e"},{"line_number":8,"context_line":"{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block modal-footer %}"}],"source_content_type":"text/html","patch_set":2,"id":"baada198_4d452f42","line":7,"updated":"2014-07-22 13:13:32.000000000","message":"I don\u0027t think you should have both the verb here, just\n\"Password to access the rescued instance: \"","commit_id":"28b81d3168edf5b9c4097202e94a06edab3b6789"}],"openstack_dashboard/dashboards/project/instances/templates/instances/rescue_password.html":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"b1328d0b06ebd8596d0ac4ab79145092c7c09351","unresolved":false,"context_lines":[{"line_number":33,"context_line":"          backdrop: \u0027static\u0027,"},{"line_number":34,"context_line":"          keyboard: false"},{"line_number":35,"context_line":"        });"},{"line_number":36,"context_line":"        $(\u0027#overlay\u0027).modal(\u0027show\u0027);"},{"line_number":37,"context_line":"    });"},{"line_number":38,"context_line":"  \u003c/script\u003e"},{"line_number":39,"context_line":"    "}],"source_content_type":"text/html","patch_set":5,"id":"9aa7fdbe_e387e30d","line":36,"updated":"2014-10-20 13:50:55.000000000","message":"Incoming JavaScript best practicies guide recommend to use two spaces for code identation. Please, pay attention to this patch. https://review.openstack.org/#/c/117595/","commit_id":"507d444508773cc193ec4c940af890855885e34d"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"b1328d0b06ebd8596d0ac4ab79145092c7c09351","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        $(\u0027#overlay\u0027).modal(\u0027show\u0027);"},{"line_number":37,"context_line":"    });"},{"line_number":38,"context_line":"  \u003c/script\u003e"},{"line_number":39,"context_line":"    "},{"line_number":40,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":5,"id":"9aa7fdbe_6369338b","line":39,"updated":"2014-10-20 13:50:55.000000000","message":"Whether we need this trailing space?","commit_id":"507d444508773cc193ec4c940af890855885e34d"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u003ch3 class\u003d\"modal-title\"\u003e{% trans \"Rescued Instance Password\" %}\u003c/h3\u003e"},{"line_number":14,"context_line":"      \u003c/div\u003e"},{"line_number":15,"context_line":"      \u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":16,"context_line":"        \u003ch4\u003e\u003cp\u003e{% trans \"Password to access the rescued instance\" %}: \u003cinput type\u003d\"text\" value\u003d{{adminPass}} readonly size\u003d\"12\" align\u003d\u0027middle\u0027\u003e\u003c/p\u003e\u003c/h4\u003e"},{"line_number":17,"context_line":"        \u003cdiv class\u003d\"alert alert-warning\"\u003e"},{"line_number":18,"context_line":"          \u003cp\u003e{% trans \"This password will be shown only once. This will not available to see again. Kindly save it.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"ba3cc151_daf79757","line":16,"updated":"2015-07-07 20:32:22.000000000","message":"keep colon inside the trans statement:\n\n{% trans \"Password to access the rescued instance:\" %}","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u003ch3 class\u003d\"modal-title\"\u003e{% trans \"Rescued Instance Password\" %}\u003c/h3\u003e"},{"line_number":14,"context_line":"      \u003c/div\u003e"},{"line_number":15,"context_line":"      \u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":16,"context_line":"        \u003ch4\u003e\u003cp\u003e{% trans \"Password to access the rescued instance\" %}: \u003cinput type\u003d\"text\" value\u003d{{adminPass}} readonly size\u003d\"12\" align\u003d\u0027middle\u0027\u003e\u003c/p\u003e\u003c/h4\u003e"},{"line_number":17,"context_line":"        \u003cdiv class\u003d\"alert alert-warning\"\u003e"},{"line_number":18,"context_line":"          \u003cp\u003e{% trans \"This password will be shown only once. This will not available to see again. Kindly save it.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"ba3cc151_5ca12a45","line":16,"in_reply_to":"ba3cc151_daf79757","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      \u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":16,"context_line":"        \u003ch4\u003e\u003cp\u003e{% trans \"Password to access the rescued instance\" %}: \u003cinput type\u003d\"text\" value\u003d{{adminPass}} readonly size\u003d\"12\" align\u003d\u0027middle\u0027\u003e\u003c/p\u003e\u003c/h4\u003e"},{"line_number":17,"context_line":"        \u003cdiv class\u003d\"alert alert-warning\"\u003e"},{"line_number":18,"context_line":"          \u003cp\u003e{% trans \"This password will be shown only once. This will not available to see again. Kindly save it.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"        \u003c/div\u003e"},{"line_number":20,"context_line":"      \u003c/div\u003e"},{"line_number":21,"context_line":"      \u003cdiv class\u003d\"modal-footer\"\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"ba3cc151_fa893bcb","line":18,"updated":"2015-07-07 20:32:22.000000000","message":"nit: \u0027This will not be available to view again.\u0027","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      \u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":16,"context_line":"        \u003ch4\u003e\u003cp\u003e{% trans \"Password to access the rescued instance\" %}: \u003cinput type\u003d\"text\" value\u003d{{adminPass}} readonly size\u003d\"12\" align\u003d\u0027middle\u0027\u003e\u003c/p\u003e\u003c/h4\u003e"},{"line_number":17,"context_line":"        \u003cdiv class\u003d\"alert alert-warning\"\u003e"},{"line_number":18,"context_line":"          \u003cp\u003e{% trans \"This password will be shown only once. This will not available to see again. Kindly save it.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"        \u003c/div\u003e"},{"line_number":20,"context_line":"      \u003c/div\u003e"},{"line_number":21,"context_line":"      \u003cdiv class\u003d\"modal-footer\"\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"ba3cc151_3c9c660d","line":18,"in_reply_to":"ba3cc151_fa893bcb","updated":"2015-07-08 09:53:16.000000000","message":"Done","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"686a66703e2bf0b5ddd9c03d0129e4613c94f662","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \u003ch3 class\u003d\"modal-title\"\u003e{% trans \"Rescued Instance Password\" %}\u003c/h3\u003e"},{"line_number":14,"context_line":"      \u003c/div\u003e"},{"line_number":15,"context_line":"      \u003cdiv class\u003d\"modal-body\"\u003e"},{"line_number":16,"context_line":"        \u003ch4\u003e\u003cp\u003e{% trans \"Password to access the rescued instance:\" %} \u003cinput type\u003d\"text\" value\u003d{{adminPass}} readonly size\u003d\"12\" align\u003d\u0027middle\u0027\u003e\u003c/p\u003e\u003c/h4\u003e"},{"line_number":17,"context_line":"        \u003cdiv class\u003d\"alert alert-warning\"\u003e"},{"line_number":18,"context_line":"          \u003cp\u003e{% trans \"This password will be shown only once. This will not available to view again. Kindly save it.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"da20952f_144a97ac","line":16,"updated":"2015-08-29 17:39:56.000000000","message":"We shouldn\u0027t be putting style specific stuff into the html like this.  Use css to do this please.  There might be classes that already exist that you can make use of: \u0027text-center\u0027\n\nSame goes for size.  You can likely just remove the \u003ch4\u003e if you want it to have the standard size.","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"686a66703e2bf0b5ddd9c03d0129e4613c94f662","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003c/div\u003e"},{"line_number":27,"context_line":"{% endblock %}"},{"line_number":28,"context_line":"{% block js %}"},{"line_number":29,"context_line":"{% include \"horizon/_scripts.html\" %}"},{"line_number":30,"context_line":"  \u003cscript type\u003d\"text/javascript\"\u003e"},{"line_number":31,"context_line":"  $(window).load(function(){"},{"line_number":32,"context_line":"    $(\u0027#overlay\u0027).modal({"}],"source_content_type":"text/html","patch_set":17,"id":"da20952f_34cd5b66","line":29,"updated":"2015-08-29 17:39:56.000000000","message":"This should go in its own javascript file so that we can lint it, and though this is simple now, it can always get more complicated.","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"686a66703e2bf0b5ddd9c03d0129e4613c94f662","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      backdrop: \u0027static\u0027,"},{"line_number":34,"context_line":"      keyboard: false"},{"line_number":35,"context_line":"    });"},{"line_number":36,"context_line":"      $(\u0027#overlay\u0027).modal(\u0027show\u0027);"},{"line_number":37,"context_line":"  });"},{"line_number":38,"context_line":"  \u003c/script\u003e"},{"line_number":39,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":17,"id":"da20952f_748193c2","line":36,"updated":"2015-08-29 17:39:56.000000000","message":"You are searching the dom and then creating the same jquery object twice.  Cache this into a variable.","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"2efe525540aea5e45e83eeffa3dc96f76c69945d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":140,"context_line":"        context \u003d super(RescuePasswordView, self).get_context_data(**kwargs)"},{"line_number":141,"context_line":"        instance_id \u003d self.kwargs[\u0027instance_id\u0027]"},{"line_number":142,"context_line":"        #print \"IID::\", instance_id"},{"line_number":143,"context_line":"        context[\u0027adminPass\u0027] \u003d getattr(settings, instance_id, \"not available\")"},{"line_number":144,"context_line":"        return context"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_901a4c6d","line":142,"updated":"2014-07-21 09:21:56.000000000","message":"The line above should be removed.","commit_id":"3fe1309464b1f347ab90fe0f43ab296dd46fc69a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a1ba4a050cee6c32a0e20c788d11c968c520e5b1","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def get_success_url(self):"},{"line_number":298,"context_line":"        show_rescue_password \u003d getattr(settings,"},{"line_number":299,"context_line":"                                       \u0027SHOW_RESCUE_PASSWORD\u0027, True)"},{"line_number":300,"context_line":"        if show_rescue_password:"},{"line_number":301,"context_line":"            return reverse(\"horizon:project:instances:show_password\","},{"line_number":302,"context_line":"                           args\u003d[self.kwargs[\u0027instance_id\u0027]])"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_3509f42c","line":299,"updated":"2015-07-07 20:32:22.000000000","message":"isn\u0027t it False by default?","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"b15603a8200804f02b1be59128adb40566270b9a","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def get_success_url(self):"},{"line_number":298,"context_line":"        show_rescue_password \u003d getattr(settings,"},{"line_number":299,"context_line":"                                       \u0027SHOW_RESCUE_PASSWORD\u0027, True)"},{"line_number":300,"context_line":"        if show_rescue_password:"},{"line_number":301,"context_line":"            return reverse(\"horizon:project:instances:show_password\","},{"line_number":302,"context_line":"                           args\u003d[self.kwargs[\u0027instance_id\u0027]])"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba3cc151_1c016238","line":299,"in_reply_to":"ba3cc151_3509f42c","updated":"2015-07-08 09:53:16.000000000","message":"by default it is true, if some one don\u0027t want to display the admin pass. they can disable in settings.","commit_id":"9ebb8af39b2f6535d7cae8dcca53b3e8bd2aee1e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"ef4b6137cc1862e6b7ccdad1fd6be52ea9319264","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            return reverse(\"horizon:project:instances:show_password\","},{"line_number":302,"context_line":"                           args\u003d[self.kwargs[\u0027instance_id\u0027]])"},{"line_number":303,"context_line":"        else:"},{"line_number":304,"context_line":"            return reverse_lazy(\u0027horizon:project:instances:index\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"class DecryptPasswordView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_ab1d5d74","line":304,"updated":"2015-07-09 01:01:00.000000000","message":"you need to specify the success url in admin like \u0027horizon:admin:instances:index\u0027, otherwise, admin rescue operation will redirect to project.","commit_id":"c529ea5549b558463882ae607ddc2ee504e50761"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"05a7ae82e8e835545aead28df047611f6c4dcdbb","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            return reverse(\"horizon:project:instances:show_password\","},{"line_number":302,"context_line":"                           args\u003d[self.kwargs[\u0027instance_id\u0027]])"},{"line_number":303,"context_line":"        else:"},{"line_number":304,"context_line":"            return reverse_lazy(\u0027horizon:project:instances:index\u0027)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"class DecryptPasswordView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba3cc151_be97ceea","line":304,"in_reply_to":"ba3cc151_ab1d5d74","updated":"2015-07-09 07:34:50.000000000","message":"very good catch.","commit_id":"c529ea5549b558463882ae607ddc2ee504e50761"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"10127717e9f428781b2335a3c4b6e55d85c6fb94","unresolved":false,"context_lines":[{"line_number":546,"context_line":"# auth_token middleware are using. Allowed values are the"},{"line_number":547,"context_line":"# algorithms supported by Python\u0027s hashlib library."},{"line_number":548,"context_line":"#OPENSTACK_TOKEN_HASH_ALGORITHM \u003d \u0027md5\u0027"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"# show the rescue instance password"},{"line_number":551,"context_line":"# if it is set to true it will show the password model"},{"line_number":552,"context_line":"# if it is set to false it will not show."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9a80dd14_08130867","line":549,"updated":"2015-03-05 09:15:12.000000000","message":"I think that this description should be improved. Capital letters. full sentences etc. Like other descriptions in this file.","commit_id":"af15f0e539c68126031b3569644978f4d8ca9eaf"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"886438ec8adab0f2682d54a627052bbe686233ac","unresolved":false,"context_lines":[{"line_number":651,"context_line":"# Show the rescue instance password."},{"line_number":652,"context_line":"# If it is set to true, it will show the password model."},{"line_number":653,"context_line":"# If it is set to false, it will not show."},{"line_number":654,"context_line":"SHOW_RESCUE_PASSWORD\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"9a41bdd9_dd9fc301","line":654,"updated":"2015-07-13 12:49:49.000000000","message":"general pattern is to leave things like this commented out","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"d7cd9eb05b9f8857cddf002eac7dc6d9c37a51e8","unresolved":false,"context_lines":[{"line_number":651,"context_line":"# Show the rescue instance password."},{"line_number":652,"context_line":"# If it is set to true, it will show the password model."},{"line_number":653,"context_line":"# If it is set to false, it will not show."},{"line_number":654,"context_line":"SHOW_RESCUE_PASSWORD\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"7a5de9d1_de7edbe3","line":654,"in_reply_to":"9a41bdd9_dd9fc301","updated":"2016-01-28 06:34:15.000000000","message":"Done","commit_id":"d45269207e337252ac78b2d7ccafa6f3fdaeece1"}]}
