)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"1593cb70b5c246151ddaec28ffaca95c26f18154","unresolved":false,"context_lines":[{"line_number":17,"context_line":"migrate a specific instance in a specific configuration he"},{"line_number":18,"context_line":"could do it from the instance dashboard."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"blueprint migrate-all-instances-from-hosts-in-maintenance-mode"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia1260831e79ede66a9d4320b092bebeb023796bc"},{"line_number":23,"context_line":"Co-Authored-By: Bartosz Fic \u003cbartosz.fic@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da86d52c_b3edd127","line":20,"updated":"2015-02-03 19:47:03.000000000","message":"Should this be marked as partial implementation?","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"56afffb5e005af62895ec7985f76b316298a3e14","unresolved":false,"context_lines":[{"line_number":17,"context_line":"migrate a specific instance in a specific configuration he"},{"line_number":18,"context_line":"could do it from the instance dashboard."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"blueprint migrate-all-instances-from-hosts-in-maintenance-mode"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia1260831e79ede66a9d4320b092bebeb023796bc"},{"line_number":23,"context_line":"Co-Authored-By: Bartosz Fic \u003cbartosz.fic@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da86d52c_a0ae157f","line":20,"in_reply_to":"da86d52c_6986ea14","updated":"2015-02-05 06:14:10.000000000","message":"No, that is not accurate. \n\nFor partial bug fix, \"Partial-Bug:\" is used as you mentioned above, not \"partial implementation\".\n\nFor full bp implementation, it should be \"Implements: blueprint \u003cbp name\u003e\" you can find that in the link you provided.\n\nAnd for partial bp implementation, it should be: \"Partially implements: blueprint  \u003cbp name\u003e.","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"},{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"d9e93584912ae10a11cd3429e690db39b9af4b18","unresolved":false,"context_lines":[{"line_number":17,"context_line":"migrate a specific instance in a specific configuration he"},{"line_number":18,"context_line":"could do it from the instance dashboard."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"blueprint migrate-all-instances-from-hosts-in-maintenance-mode"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia1260831e79ede66a9d4320b092bebeb023796bc"},{"line_number":23,"context_line":"Co-Authored-By: Bartosz Fic \u003cbartosz.fic@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da86d52c_7eae7099","line":20,"in_reply_to":"da86d52c_a0ae157f","updated":"2015-02-05 14:25:40.000000000","message":"Done","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"},{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"a117620d9c6f3a986f82ef2828dfc9dd7acf28d0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"migrate a specific instance in a specific configuration he"},{"line_number":18,"context_line":"could do it from the instance dashboard."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"blueprint migrate-all-instances-from-hosts-in-maintenance-mode"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia1260831e79ede66a9d4320b092bebeb023796bc"},{"line_number":23,"context_line":"Co-Authored-By: Bartosz Fic \u003cbartosz.fic@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da86d52c_6986ea14","line":20,"in_reply_to":"da86d52c_b3edd127","updated":"2015-02-04 14:01:50.000000000","message":"\"The \u0027bug\u0027 line can reference a bug in a few ways. Gerrit creates a link to the bug when viewing the patch on review.openstack.org so that reviewers can quickly access the bug on Launchpad.\n\n- Closes-Bug: #1234567 -- use \u0027Closes-Bug\u0027 if the commit is intended to fully fix and close the bug being referenced.\n- Partial-Bug: #1234567 -- use \u0027Partial-Bug\u0027 if the commit is only a partial fix and more work is needed.\n- Related-Bug: #1234567 -- use \u0027Related-Bug\u0027 if the commit is merely related to the referenced bug.\n\n\"The \u0027blueprint\u0027 line should give the name of a Launchpad blueprint, if the commit is intended to implement a feature. Gerrit creates a link to the blueprint when viewing the patch on review.openstack.org so that reviewers can quickly access the blueprint on Launchpad.\"\n\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\nSummarizing I think that only bugs should be signed as \"partial implementation\".","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3f22bd91bd1ab343a984ab61aceb6fcf57422ca9","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                    response.append(server[\u0027uuid\u0027])"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    if response:"},{"line_number":640,"context_line":"        msg \u003d _(\u0027Failed to migrate instances: %s\u0027) % \u0027, \u0027.join(response)"},{"line_number":641,"context_line":"        exc \u003d nova_exceptions.ClientException(msg)"},{"line_number":642,"context_line":"        exc._safe_message \u003d msg"},{"line_number":643,"context_line":"        raise exc"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_b0d621c4","line":640,"updated":"2014-08-18 05:17:37.000000000","message":"We can have many instances on a host. Please consider a message like:\n\n  Failed to migrate 4 instance(s) on host \u0027compute98\u0027","commit_id":"a0fb8ab4ece1030ce48622b54499accb2a6a5181"}],"openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"91e90fb6f61916671078b48d7141ccddd18f826f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                disk_over_commit\u003ddisk_over_commit,"},{"line_number":157,"context_line":"                block_migration\u003dblock_migration"},{"line_number":158,"context_line":"            )"},{"line_number":159,"context_line":"            msg \u003d _(\u0027Starting migrating host: %(current)s\u0027) % \\"},{"line_number":160,"context_line":"                {\u0027current\u0027: current_host}"},{"line_number":161,"context_line":"            messages.success(request, msg)"},{"line_number":162,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_8f5187da","line":159,"updated":"2015-02-03 19:06:01.000000000","message":"Starting to migrate","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"6b7730026643c11a68454717eb483982960ff44d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    )"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    migrate_type \u003d forms.ChoiceField("},{"line_number":106,"context_line":"        label\u003d_(\u0027Running Instance Migration Type\u0027),"},{"line_number":107,"context_line":"        choices\u003d["},{"line_number":108,"context_line":"            (\u0027live_migrate\u0027, _(\u0027Live Migrate\u0027)),"},{"line_number":109,"context_line":"            (\u0027cold_migrate\u0027, _(\u0027Cold Migrate\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a80dd14_323e0d8d","line":106,"updated":"2015-03-07 06:52:46.000000000","message":"nit: use doule quote for label consistently","commit_id":"2a7860b416d38301eda43ddf424bebe2e0f31c94"}],"openstack_dashboard/dashboards/admin/hypervisors/compute/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3f22bd91bd1ab343a984ab61aceb6fcf57422ca9","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __init__(self, **kwargs):"},{"line_number":90,"context_line":"        super(MigrateMaintenanceHost, self).__init__(**kwargs)"},{"line_number":91,"context_line":"        self.name \u003d kwargs.get(\u0027name\u0027, self.name)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class ComputeHostFilterAction(tables.FilterAction):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_1081958f","line":91,"updated":"2014-08-18 05:17:37.000000000","message":"According the docstring of LinkAction docstring, \"This name should not be changed at runtime.\" Why do you need to change \"name\".","commit_id":"a0fb8ab4ece1030ce48622b54499accb2a6a5181"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"1593cb70b5c246151ddaec28ffaca95c26f18154","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    name \u003d \"migrate_maintenance\""},{"line_number":88,"context_line":"    policy_rules \u003d ((\"compute\", \"compute_extension:admin_actions:migrate\"),)"},{"line_number":89,"context_line":"    classes \u003d (\u0027ajax-modal\u0027, \u0027btn-migrate\u0027, \u0027btn-danger\u0027)"},{"line_number":90,"context_line":"    verbose_name \u003d _(\"Migrate Host\")"},{"line_number":91,"context_line":"    url \u003d \"horizon:admin:hypervisors:compute:migrate_host\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_d3588534","line":90,"updated":"2015-02-03 19:47:03.000000000","message":"is there an icon for this?","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"},{"author":{"_account_id":12814,"name":"Bartosz Fic","email":"bartosz.fic@intel.com","username":"bartosz-fic"},"change_message_id":"a117620d9c6f3a986f82ef2828dfc9dd7acf28d0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    name \u003d \"migrate_maintenance\""},{"line_number":88,"context_line":"    policy_rules \u003d ((\"compute\", \"compute_extension:admin_actions:migrate\"),)"},{"line_number":89,"context_line":"    classes \u003d (\u0027ajax-modal\u0027, \u0027btn-migrate\u0027, \u0027btn-danger\u0027)"},{"line_number":90,"context_line":"    verbose_name \u003d _(\"Migrate Host\")"},{"line_number":91,"context_line":"    url \u003d \"horizon:admin:hypervisors:compute:migrate_host\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_8604ed4a","line":90,"in_reply_to":"da86d52c_d3588534","updated":"2015-02-04 14:01:50.000000000","message":"It is weird, but currently there aren\u0027t displayed any icons on action buttons, even if they have attribute \u0027icon\u0027 set on \u0027pencil\u0027 or something. Other similar action buttons \n\n(like for example \"LiveMigrateInstance\" from \nopenstack_dashboard/dashboards/admin/instances/tables.py) \n\nsimply don\u0027t have defined icon attribute.\n\nSo....\n\nI believe that this is not necessary to place icon on that button.","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"91e90fb6f61916671078b48d7141ccddd18f826f","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        return service.status \u003d\u003d \"disabled\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def __init__(self, **kwargs):"},{"line_number":116,"context_line":"        super(MigrateMaintenanceHost, self).__init__(**kwargs)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da86d52c_47f4d386","line":115,"updated":"2015-02-03 19:06:01.000000000","message":"This seems to do nothing and should be removed.","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"}],"openstack_dashboard/dashboards/admin/hypervisors/templates/hypervisors/compute/_migrate_host.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3f22bd91bd1ab343a984ab61aceb6fcf57422ca9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"Migrate all instances from an under maintainance host. All running instances of the under maintance host can be Live Migrated.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":5,"id":"1abeadc6_50eead8c","line":18,"updated":"2014-08-18 05:17:37.000000000","message":"\"from a host under maintenance\"\n\nmaitainance -\u003e maintenance","commit_id":"a0fb8ab4ece1030ce48622b54499accb2a6a5181"}],"openstack_dashboard/dashboards/admin/hypervisors/templates/hypervisors/compute/migrate_host.html":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"91e90fb6f61916671078b48d7141ccddd18f826f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% endblock %} "}],"source_content_type":"text/html","patch_set":8,"id":"da86d52c_3dca906e","line":11,"updated":"2015-02-03 19:06:01.000000000","message":"extra trailing white space","commit_id":"ec2282eb4d86cd7981828c4f18a4f4312ed1d532"}]}
