)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"6d07b902e7c7b231072723d640920adaeeca79fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some users have been reporting that they would like the ability to start"},{"line_number":10,"context_line":"multiple instances at once, for instance after an upgrade it\u0027s common"},{"line_number":11,"context_line":"for the instances to be shut off and needing to be manually restarted."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch add \u0027Start Instances\u0027, \u0027Stop Instance\u0027 and move"},{"line_number":14,"context_line":"\u0027Soft Reboot Instances\u0027 to Instances table actions menu which is a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a890539_60bb7c0f","line":11,"updated":"2014-11-21 18:38:58.000000000","message":"\"needing\" should be changed to \"need\"","commit_id":"b231ee9892e103337951c65d4a3748efac621a5a"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"6d07b902e7c7b231072723d640920adaeeca79fc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"multiple instances at once, for instance after an upgrade it\u0027s common"},{"line_number":11,"context_line":"for the instances to be shut off and needing to be manually restarted."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch add \u0027Start Instances\u0027, \u0027Stop Instance\u0027 and move"},{"line_number":14,"context_line":"\u0027Soft Reboot Instances\u0027 to Instances table actions menu which is a"},{"line_number":15,"context_line":"newly implemented feature."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a890539_40c20086","line":13,"updated":"2014-11-21 18:38:58.000000000","message":"\"add\" should be changed to \"adds\"","commit_id":"b231ee9892e103337951c65d4a3748efac621a5a"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"2c8553e3e12dea769a738f9b1af31e6104aac5f9","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"class StartInstance(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":654,"context_line":"    name \u003d \"start\""},{"line_number":655,"context_line":"    classes \u003d (\u0027btn-start\u0027,)"},{"line_number":656,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:start\"),)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9a01c708","line":655,"updated":"2014-11-21 09:33:19.000000000","message":"Does this CSS class exist?","commit_id":"426e7693fd617a4b1481ebb5453612547ac1da02"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"bdecf018f78a1064453102009ebecb5aa3692991","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"class StartInstance(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":654,"context_line":"    name \u003d \"start\""},{"line_number":655,"context_line":"    classes \u003d (\u0027btn-start\u0027,)"},{"line_number":656,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:start\"),)"},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_51466222","line":655,"in_reply_to":"5a890539_9a01c708","updated":"2014-11-21 11:38:20.000000000","message":"no.. change to use btn-confirm","commit_id":"426e7693fd617a4b1481ebb5453612547ac1da02"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"2c8553e3e12dea769a738f9b1af31e6104aac5f9","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        if instance is not None:"},{"line_number":676,"context_line":"            return instance.status in (\"SHUTDOWN\", \"SHUTOFF\", \"CRASHED\")"},{"line_number":677,"context_line":"        else:"},{"line_number":678,"context_line":"            return True"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def action(self, request, obj_id):"},{"line_number":681,"context_line":"        api.nova.server_start(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_bd74bd9c","line":678,"updated":"2014-11-21 09:33:19.000000000","message":"Could be simplified like so:\n\n if instance is None:\n     return True\n return instance.status in (\"SHUTDOWN\", \"SHUTOFF\", \"CRASHED\")","commit_id":"426e7693fd617a4b1481ebb5453612547ac1da02"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"bdecf018f78a1064453102009ebecb5aa3692991","unresolved":false,"context_lines":[{"line_number":675,"context_line":"        if instance is not None:"},{"line_number":676,"context_line":"            return instance.status in (\"SHUTDOWN\", \"SHUTOFF\", \"CRASHED\")"},{"line_number":677,"context_line":"        else:"},{"line_number":678,"context_line":"            return True"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"    def action(self, request, obj_id):"},{"line_number":681,"context_line":"        api.nova.server_start(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_115cdaec","line":678,"in_reply_to":"5a890539_bd74bd9c","updated":"2014-11-21 11:38:20.000000000","message":"Done","commit_id":"426e7693fd617a4b1481ebb5453612547ac1da02"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"70c5e84e6fd631a5d39c18e97dd8df9b49824bc2","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        )"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def allowed(self, request, instance):"},{"line_number":675,"context_line":"        if instance is None:"},{"line_number":676,"context_line":"            return True"},{"line_number":677,"context_line":"        return instance.status in (\"SHUTDOWN\", \"SHUTOFF\", \"CRASHED\")"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_5f8736b5","line":675,"updated":"2014-11-21 23:24:54.000000000","message":"perhaps an OR rather than two returns.","commit_id":"b231ee9892e103337951c65d4a3748efac621a5a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"dfb6120d989abb89e1d81e562ff1efaa83d10e15","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        )"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def allowed(self, request, instance):"},{"line_number":675,"context_line":"        if instance is None:"},{"line_number":676,"context_line":"            return True"},{"line_number":677,"context_line":"        return instance.status in (\"SHUTDOWN\", \"SHUTOFF\", \"CRASHED\")"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_ad0aa223","line":675,"in_reply_to":"5a890539_5f8736b5","updated":"2014-11-24 01:19:05.000000000","message":"Done","commit_id":"b231ee9892e103337951c65d4a3748efac621a5a"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"70c5e84e6fd631a5d39c18e97dd8df9b49824bc2","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        )"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def allowed(self, request, instance):"},{"line_number":707,"context_line":"        if instance is None:"},{"line_number":708,"context_line":"            return True"},{"line_number":709,"context_line":"        return ((get_power_state(instance)"},{"line_number":710,"context_line":"                in (\"RUNNING\", \"SUSPENDED\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_dfc246e8","line":707,"updated":"2014-11-21 23:24:54.000000000","message":"same here","commit_id":"b231ee9892e103337951c65d4a3748efac621a5a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"dfb6120d989abb89e1d81e562ff1efaa83d10e15","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        )"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"    def allowed(self, request, instance):"},{"line_number":707,"context_line":"        if instance is None:"},{"line_number":708,"context_line":"            return True"},{"line_number":709,"context_line":"        return ((get_power_state(instance)"},{"line_number":710,"context_line":"                in (\"RUNNING\", \"SUSPENDED\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_cd036e0e","line":707,"in_reply_to":"5a890539_dfc246e8","updated":"2014-11-24 01:19:05.000000000","message":"Done","commit_id":"b231ee9892e103337951c65d4a3748efac621a5a"},{"author":{"_account_id":11592,"name":"Julie Gravel","email":"julie.gravel@suse.com","username":"jgravel"},"change_message_id":"5fb86ec4ecc4740ca2b1ad075d88d956cd8ff3c6","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                                        in (\"RUNNING\", \"SUSPENDED\"))"},{"line_number":708,"context_line":"                                       and not is_deleting(instance)))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def action(self, request, obj_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_68a8a8db","line":707,"updated":"2014-11-24 01:39:45.000000000","message":"Please adjust indentation on this line.","commit_id":"b9a5073d8465eea10ba784aea86c64badf2637ed"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"35f71a8dfe53b94dac0c1f485a83a816c36a33b4","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                                        in (\"RUNNING\", \"SUSPENDED\"))"},{"line_number":708,"context_line":"                                       and not is_deleting(instance)))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def action(self, request, obj_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_e84f3832","line":707,"in_reply_to":"5a890539_68a8a8db","updated":"2014-11-24 01:52:04.000000000","message":"Done","commit_id":"b9a5073d8465eea10ba784aea86c64badf2637ed"},{"author":{"_account_id":11592,"name":"Julie Gravel","email":"julie.gravel@suse.com","username":"jgravel"},"change_message_id":"5fb86ec4ecc4740ca2b1ad075d88d956cd8ff3c6","unresolved":false,"context_lines":[{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                                        in (\"RUNNING\", \"SUSPENDED\"))"},{"line_number":708,"context_line":"                                       and not is_deleting(instance)))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def action(self, request, obj_id):"},{"line_number":711,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_88b07444","line":708,"updated":"2014-11-24 01:39:45.000000000","message":"same here","commit_id":"b9a5073d8465eea10ba784aea86c64badf2637ed"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"35f71a8dfe53b94dac0c1f485a83a816c36a33b4","unresolved":false,"context_lines":[{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                                        in (\"RUNNING\", \"SUSPENDED\"))"},{"line_number":708,"context_line":"                                       and not is_deleting(instance)))"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def action(self, request, obj_id):"},{"line_number":711,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_086004a4","line":708,"in_reply_to":"5a890539_88b07444","updated":"2014-11-24 01:52:04.000000000","message":"Done","commit_id":"b9a5073d8465eea10ba784aea86c64badf2637ed"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"79465cf9211cb64d08b756fbe83edb02c202932f","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                in (\"RUNNING\", \"SUSPENDED\")) and not is_deleting(instance)))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def action(self, request, obj_id):"},{"line_number":710,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_913245a5","line":707,"updated":"2014-11-24 23:05:14.000000000","message":"can we split this into three lines to make it more readable? something like in  line: 132","commit_id":"879c5643c13d072a86911b6ebb812918877b0f89"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"92a5433f066fcf08d6ea06a0c91906cc65b92c73","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                in (\"RUNNING\", \"SUSPENDED\")) and not is_deleting(instance)))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def action(self, request, obj_id):"},{"line_number":710,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_58d4d5bc","line":707,"in_reply_to":"5a890539_1c7333b5","updated":"2014-12-01 19:58:13.000000000","message":"Sorry, pointed at the wrong line. I meant combining the condition into a single line like the IN condition. \n\nSomething to look like:\n\nline 1: return ((instance is None)\n\nline 2:       or ((get_power_state(instance) in (\"RUNNING\", \"SUSPENDED\"))\n\nline 3:             and not is_deleting(instance)))","commit_id":"879c5643c13d072a86911b6ebb812918877b0f89"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"05213fcebc0fefcf2b5c6655bd205129f5d5623c","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                in (\"RUNNING\", \"SUSPENDED\")) and not is_deleting(instance)))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def action(self, request, obj_id):"},{"line_number":710,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_bce1242c","line":707,"in_reply_to":"5a890539_58d4d5bc","updated":"2014-12-02 01:18:27.000000000","message":"Thanks for detail, Done","commit_id":"879c5643c13d072a86911b6ebb812918877b0f89"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a86a31cf5c50e846e8858bc7e97e502b78a10d84","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                in (\"RUNNING\", \"SUSPENDED\")) and not is_deleting(instance)))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def action(self, request, obj_id):"},{"line_number":710,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_1c7333b5","line":707,"in_reply_to":"5a890539_913245a5","updated":"2014-12-01 10:33:28.000000000","message":"Hi, Hua Cheng, do you still have opinion with this? please have a review again. thanks a lot.","commit_id":"879c5643c13d072a86911b6ebb812918877b0f89"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1764b976138cfa89b086d7e6bafc1621da8f9613","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"    def allowed(self, request, instance):"},{"line_number":706,"context_line":"        return ((instance is None) or ((get_power_state(instance)"},{"line_number":707,"context_line":"                in (\"RUNNING\", \"SUSPENDED\")) and not is_deleting(instance)))"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    def action(self, request, obj_id):"},{"line_number":710,"context_line":"        api.nova.server_stop(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a890539_ccf510ee","line":707,"in_reply_to":"5a890539_913245a5","updated":"2014-11-24 23:38:14.000000000","message":"I actually asked for the consolidation because\nif instance is None:\n  return True\n\njust feels wrong.","commit_id":"879c5643c13d072a86911b6ebb812918877b0f89"}]}
