)]}'
{"horizon/static/horizon/js/horizon.forms.js":[{"author":{"_account_id":6638,"name":"Bradley Jones","email":"jones.bradley@me.com","username":"bradjones"},"change_message_id":"4a0d303031f5cce6f4b4ce01dda11b38ded75782","unresolved":false,"context_lines":[{"line_number":289,"context_line":"      return cidr;"},{"line_number":290,"context_line":"    }"},{"line_number":291,"context_line":"    else {"},{"line_number":292,"context_line":"      return null"},{"line_number":293,"context_line":"    }"},{"line_number":294,"context_line":"  }"},{"line_number":295,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"da9df570_d5469e4e","line":292,"updated":"2014-09-26 08:21:16.000000000","message":"missing semicolon here.\n\nAlso matter of preference but the return null does not need to be inside else as previous condition returns anyway. Then this block could be condensed onto two lines:\n\nif (cidr.match(format)) return cidr;\n\nreturn null;","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"},{"author":{"_account_id":6638,"name":"Bradley Jones","email":"jones.bradley@me.com","username":"bradjones"},"change_message_id":"4a0d303031f5cce6f4b4ce01dda11b38ded75782","unresolved":false,"context_lines":[{"line_number":305,"context_line":"  $(document).on(\u0027input\u0027, \u0027#id_cidr\u0027, function (evt) {"},{"line_number":306,"context_line":"    var cidr \u003d $(\"#id_cidr\").val();"},{"line_number":307,"context_line":"    cidr \u003d check_cidr_validity(cidr);"},{"line_number":308,"context_line":"    if(cidr !\u003d null) {"},{"line_number":309,"context_line":"      var incremented_address;"},{"line_number":310,"context_line":"      var cidr_suffix \u003d parseInt(cidr.split(\u0027/\u0027)[1]);"},{"line_number":311,"context_line":"      // Make sure the subnet size is greater than two addresses"}],"source_content_type":"text/javascript","patch_set":1,"id":"da9df570_001e14bb","line":308,"updated":"2014-09-26 08:21:16.000000000","message":"should use !\u003d\u003d null here or just use if (cidr) { ...","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ef9864b6d16ac5bcaba3797bfd42ccfd2941b8e8","unresolved":false,"context_lines":[{"line_number":305,"context_line":"  $(document).on(\u0027input\u0027, \u0027#id_cidr\u0027, function (evt) {"},{"line_number":306,"context_line":"    var cidr \u003d $(\"#id_cidr\").val();"},{"line_number":307,"context_line":"    cidr \u003d check_cidr_validity(cidr);"},{"line_number":308,"context_line":"    if(cidr !\u003d null) {"},{"line_number":309,"context_line":"      var incremented_address;"},{"line_number":310,"context_line":"      var cidr_suffix \u003d parseInt(cidr.split(\u0027/\u0027)[1]);"},{"line_number":311,"context_line":"      // Make sure the subnet size is greater than two addresses"}],"source_content_type":"text/javascript","patch_set":1,"id":"da9df570_ccb1a390","line":308,"in_reply_to":"da9df570_001e14bb","updated":"2014-09-26 11:12:38.000000000","message":"In line with above comment, this will now become:\n\nif (check_cidr_validity(cidr))","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"},{"author":{"_account_id":6638,"name":"Bradley Jones","email":"jones.bradley@me.com","username":"bradjones"},"change_message_id":"4a0d303031f5cce6f4b4ce01dda11b38ded75782","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    var cidr \u003d $(\"#id_cidr\").val();"},{"line_number":307,"context_line":"    cidr \u003d check_cidr_validity(cidr);"},{"line_number":308,"context_line":"    if(cidr !\u003d null) {"},{"line_number":309,"context_line":"      var incremented_address;"},{"line_number":310,"context_line":"      var cidr_suffix \u003d parseInt(cidr.split(\u0027/\u0027)[1]);"},{"line_number":311,"context_line":"      // Make sure the subnet size is greater than two addresses"},{"line_number":312,"context_line":"      if(cidr_suffix \u003c 31) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"da9df570_b5bcba07","line":309,"updated":"2014-09-26 08:21:16.000000000","message":"set incremented_address \u003d \"\"; here then get rid of line 321","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ef9864b6d16ac5bcaba3797bfd42ccfd2941b8e8","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    var cidr \u003d $(\"#id_cidr\").val();"},{"line_number":307,"context_line":"    cidr \u003d check_cidr_validity(cidr);"},{"line_number":308,"context_line":"    if(cidr !\u003d null) {"},{"line_number":309,"context_line":"      var incremented_address;"},{"line_number":310,"context_line":"      var cidr_suffix \u003d parseInt(cidr.split(\u0027/\u0027)[1]);"},{"line_number":311,"context_line":"      // Make sure the subnet size is greater than two addresses"},{"line_number":312,"context_line":"      if(cidr_suffix \u003c 31) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"da9df570_cccb6351","line":309,"in_reply_to":"da9df570_b5bcba07","updated":"2014-09-26 11:12:38.000000000","message":"Done","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"84152bf6e9cab9eacb96f560b93c0fb4d812431a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"  horizon.modals.addModalInitFunction(function (modal) {"},{"line_number":281,"context_line":"    $(modal).find(\"#id_volume_source_type\").change();"},{"line_number":282,"context_line":"  });"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"  // Handle default gateway IP for subnet creation"},{"line_number":285,"context_line":"  // Currently supports IPv4 only"},{"line_number":286,"context_line":"  function check_cidr_validity (cidr) {"}],"source_content_type":"text/javascript","patch_set":3,"id":"da9df570_fc6614ba","line":283,"updated":"2014-09-26 14:33:07.000000000","message":"The logic is specific to network/subnet creation form, so horizon.forms.js is not an appropriate place to add this kind of logic. This file should be kept generic and should not contain openstack_dashboard specific  logic.","commit_id":"faad390ec60f3cb6e68b0d687fe08907859b7510"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"84152bf6e9cab9eacb96f560b93c0fb4d812431a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    incremented_address \u003d leading_octets.join(\u0027.\u0027);"},{"line_number":298,"context_line":"    return incremented_address;"},{"line_number":299,"context_line":"  }"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"  $(document).on(\u0027input\u0027, \u0027#id_cidr\u0027, function (evt) {"},{"line_number":302,"context_line":"    var cidr \u003d $(\"#id_cidr\").val();"},{"line_number":303,"context_line":"    if (check_cidr_validity(cidr)) {"}],"source_content_type":"text/javascript","patch_set":3,"id":"da9df570_9cfa68bb","line":300,"updated":"2014-09-26 14:33:07.000000000","message":"Does the logic work for IPv6?","commit_id":"faad390ec60f3cb6e68b0d687fe08907859b7510"}],"openstack_dashboard/dashboards/project/networks/workflows.py":[{"author":{"_account_id":6638,"name":"Bradley Jones","email":"jones.bradley@me.com","username":"bradjones"},"change_message_id":"4a0d303031f5cce6f4b4ce01dda11b38ded75782","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    \"The default value is the first IP of the \""},{"line_number":114,"context_line":"                    \"network address \""},{"line_number":115,"context_line":"                    \"(e.g. 192.168.0.1 for 192.168.0.0/24, \""},{"line_number":116,"context_line":"                    \"2001:DB8::1 for 2001:DB8::/48). \""},{"line_number":117,"context_line":"                    \"If you do not want to use a gateway, \""},{"line_number":118,"context_line":"                    \"check \u0027Disable Gateway\u0027 below.\"),"},{"line_number":119,"context_line":"        version\u003dforms.IPv4 | forms.IPv6,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_004c54c7","line":116,"updated":"2014-09-26 08:21:16.000000000","message":"Maybe this should be left in and reworded? If the gateway ip is left blank/ deleted after the js has auto filled the value the behaviour does not change it will still use the default.\n\nCould read: \"If left blank the default will be used\"","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ef9864b6d16ac5bcaba3797bfd42ccfd2941b8e8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    \"The default value is the first IP of the \""},{"line_number":114,"context_line":"                    \"network address \""},{"line_number":115,"context_line":"                    \"(e.g. 192.168.0.1 for 192.168.0.0/24, \""},{"line_number":116,"context_line":"                    \"2001:DB8::1 for 2001:DB8::/48). \""},{"line_number":117,"context_line":"                    \"If you do not want to use a gateway, \""},{"line_number":118,"context_line":"                    \"check \u0027Disable Gateway\u0027 below.\"),"},{"line_number":119,"context_line":"        version\u003dforms.IPv4 | forms.IPv6,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_8cb4fb82","line":116,"in_reply_to":"da9df570_004c54c7","updated":"2014-09-26 11:12:38.000000000","message":"That\u0027s a nice way to word it, done.","commit_id":"26d135f31aab804ed63b2e29f3f18ec2f061fe5d"}]}
