)]}'
{"horizon/test/webdriver.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"62483a86ffe1fa0384f3309ccc89af9bfaa3f675","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import subprocess"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from django.utils import unittest"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"with_sel \u003d os.environ.get(\u0027WITH_SELENIUM\u0027, False)"},{"line_number":28,"context_line":"if with_sel:"},{"line_number":29,"context_line":"    from selenium.common import exceptions as selenium_exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_05e7cbe4","line":26,"updated":"2014-10-08 08:59:38.000000000","message":"Wouldn\u0027t be easier to just add:\n\n    if not with_sel:\n        raise unittest.case.SkipTest(\n            \"The WITH_SELENIUM env variable is not set.\")","commit_id":"83fd6a7631a6a3ea6adbebca725a5f19c2c1796c"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"1e639e2801134926f48a3f39fb8b3be442c02540","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import subprocess"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from django.utils import unittest"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"with_sel \u003d os.environ.get(\u0027WITH_SELENIUM\u0027, False)"},{"line_number":28,"context_line":"if with_sel:"},{"line_number":29,"context_line":"    from selenium.common import exceptions as selenium_exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_fec7aa42","line":26,"in_reply_to":"baa201ad_05e7cbe4","updated":"2014-10-08 16:14:51.000000000","message":"Yes!  Thanks the for the tip.  That is a construct I hadn\u0027t seen before.","commit_id":"83fd6a7631a6a3ea6adbebca725a5f19c2c1796c"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"a8b1d3f872d145e19a1d3a542b5c6121bdb8bcdb","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @unittest.skipUnless(os.environ.get(\u0027WITH_SELENIUM\u0027, False),"},{"line_number":33,"context_line":"                        \"The WITH_SELENIUM env variable is not set.\")"},{"line_number":34,"context_line":"    class FirefoxBinary(firefox.firefox_binary.FirefoxBinary):"},{"line_number":35,"context_line":"        \"\"\"Workarounds selenium firefox issues."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        There is race condition in the way firefox is spawned. The exact cause"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_bb77fe9e","line":34,"updated":"2014-10-08 09:54:46.000000000","message":"In line with how it\u0027s done elsewhere in the codebase, I don\u0027t think there is a need to indent/hide the class in the condition once the skipping statement is set. Only the import needs to be conditional.","commit_id":"83fd6a7631a6a3ea6adbebca725a5f19c2c1796c"},{"author":{"_account_id":6825,"name":"Gary W. Smith","email":"garysmith123@gmail.com","username":"gary-w-smith"},"change_message_id":"1e639e2801134926f48a3f39fb8b3be442c02540","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @unittest.skipUnless(os.environ.get(\u0027WITH_SELENIUM\u0027, False),"},{"line_number":33,"context_line":"                        \"The WITH_SELENIUM env variable is not set.\")"},{"line_number":34,"context_line":"    class FirefoxBinary(firefox.firefox_binary.FirefoxBinary):"},{"line_number":35,"context_line":"        \"\"\"Workarounds selenium firefox issues."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        There is race condition in the way firefox is spawned. The exact cause"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_beb602f7","line":34,"in_reply_to":"baa201ad_bb77fe9e","updated":"2014-10-08 16:14:51.000000000","message":"That is exactly what I tried, but since these classes inherit from other ones, python will throw an error since it cannot resolve the class hierarchy properly (NameError: name \u0027firefox\u0027 is not defined).  I intended to document this in the code, but failed to.  But I will avoid this by using Tihomir\u0027s tip above.","commit_id":"83fd6a7631a6a3ea6adbebca725a5f19c2c1796c"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"a3f29807c4d3a8163c2a8922dfc70796e5013f92","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # python will throw a NameError if the import is skipped."},{"line_number":35,"context_line":"    from selenium.common import exceptions as selenium_exceptions"},{"line_number":36,"context_line":"    from selenium.webdriver import firefox"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    class FirefoxBinary(firefox.firefox_binary.FirefoxBinary):"},{"line_number":39,"context_line":"        \"\"\"Workarounds selenium firefox issues."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_fdccde8c","line":37,"updated":"2014-10-10 10:01:23.000000000","message":"Ugh, Python2.6 unittest module doesn\u0027t handle properly the Skip exceptions. I\u0027ve made a simple test with replacing in PatchSet 2:\n\n    unittest.SkipTest()\n\nwith\n\n    nose.SkipTest()\n\non Python 2.6, and it seems to work properly.\nI see that there is another place in the tests where nose.SkipTest is used:\n\n    openstack_dashboard/test/integration_tests/tests/decorators.py\n\nso let\u0027s try it.\n\nHowever I don\u0027t see nose requirement in the project..","commit_id":"2cd2fd0cbda93f05ae51c40f55c6b2b0543c0046"}]}
