)]}'
{"openstack_dashboard/dashboards/project/volumes/volumes/tests.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4b150bc3893a20a7b7550a3d06421426fc4cc67e","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        cinder.volume_get(IsA(http.HttpRequest), volume.id).AndReturn(volume)"},{"line_number":967,"context_line":"        api.nova.server_get(IsA(http.HttpRequest), server.id).AndReturn(server)"},{"line_number":968,"context_line":"        cinder.tenant_absolute_limits(IsA(http.HttpRequest))\\"},{"line_number":969,"context_line":"            .AndReturn(self.cinder_limits[\u0027absolute\u0027])"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_94fb8b46","line":968,"updated":"2014-10-12 07:26:27.000000000","message":"Should this be mocked multiple times since it is called in more than one occurrence of the allowed method in the VolumesTable?","commit_id":"1828eecc855fc86980b27796c28f7ddbbcdccfef"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0621083d50ee02076156b7682a85c4d0ff3fe080","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        cinder.volume_get(IsA(http.HttpRequest), volume.id).AndReturn(volume)"},{"line_number":967,"context_line":"        api.nova.server_get(IsA(http.HttpRequest), server.id).AndReturn(server)"},{"line_number":968,"context_line":"        cinder.tenant_absolute_limits(IsA(http.HttpRequest))\\"},{"line_number":969,"context_line":"            .AndReturn(self.cinder_limits[\u0027absolute\u0027])"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6a9dd165","line":968,"in_reply_to":"baa201ad_23c9b979","updated":"2014-10-17 07:57:16.000000000","message":"You guys are right, changing my review.  Thanks for the explanation!","commit_id":"1828eecc855fc86980b27796c28f7ddbbcdccfef"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"6533ab1bd8bf8c68fd0300cdac50dc9295e164aa","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        cinder.volume_get(IsA(http.HttpRequest), volume.id).AndReturn(volume)"},{"line_number":967,"context_line":"        api.nova.server_get(IsA(http.HttpRequest), server.id).AndReturn(server)"},{"line_number":968,"context_line":"        cinder.tenant_absolute_limits(IsA(http.HttpRequest))\\"},{"line_number":969,"context_line":"            .AndReturn(self.cinder_limits[\u0027absolute\u0027])"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_23c9b979","line":968,"in_reply_to":"baa201ad_94fb8b46","updated":"2014-10-13 12:16:48.000000000","message":"Wouldn\u0027t the fact that our api wrapper for tenant_absolute_limits is memoized mean that it\u0027s only going to be once per request?  I think Akihiro\u0027s code is correct.","commit_id":"1828eecc855fc86980b27796c28f7ddbbcdccfef"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f11597e0783fb4fbfe5ed297176d2bb3d0e3068d","unresolved":false,"context_lines":[{"line_number":965,"context_line":""},{"line_number":966,"context_line":"        cinder.volume_get(IsA(http.HttpRequest), volume.id).AndReturn(volume)"},{"line_number":967,"context_line":"        api.nova.server_get(IsA(http.HttpRequest), server.id).AndReturn(server)"},{"line_number":968,"context_line":"        cinder.tenant_absolute_limits(IsA(http.HttpRequest))\\"},{"line_number":969,"context_line":"            .AndReturn(self.cinder_limits[\u0027absolute\u0027])"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6582e953","line":968,"in_reply_to":"baa201ad_94fb8b46","updated":"2014-10-13 10:35:25.000000000","message":"tenant_absolute_limit is actually called only once.\ntenant_absolute_limit is used in allowed() in CreateVolume and CreateSnapshot, but the row action list contains only CreateSnapshot, so I think the above is enough.","commit_id":"1828eecc855fc86980b27796c28f7ddbbcdccfef"}]}
