)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"957ab844588ef241bcde0192feace402ffbffc18","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Swati Shukla \u003cswati.shukla1@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-20 17:30:08 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Confirm Dialog for Delete operation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we click a delete button in network topology,"},{"line_number":10,"context_line":"the corresponding delete operation is issued"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_e046f922","line":7,"updated":"2014-10-20 13:20:27.000000000","message":"This patch is specific to network topology panel. Could you add \"in Network Topology\" at the end of line?","commit_id":"f83299c5be6576f5b66407ea95c5ba0fdba1e013"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"826dce44cc38ef31e942b8ded671200dd53f1cd8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"It brings us better consistency with delete"},{"line_number":16,"context_line":"operations in other tables."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Updated code as per review comments."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1312364c75cea17f228eb298daacb141bf1bfdde"},{"line_number":21,"context_line":"Closes-Bug: #1242251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_aa9a1012","line":18,"updated":"2014-10-20 12:36:11.000000000","message":"This shouldn\u0027t be in the commit comment.  It _always_ happens!","commit_id":"f83299c5be6576f5b66407ea95c5ba0fdba1e013"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"957ab844588ef241bcde0192feace402ffbffc18","unresolved":false,"context_lines":[{"line_number":15,"context_line":"It brings us better consistency with delete"},{"line_number":16,"context_line":"operations in other tables."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Updated code as per review comments."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I1312364c75cea17f228eb298daacb141bf1bfdde"},{"line_number":21,"context_line":"Closes-Bug: #1242251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_20f641d8","line":18,"in_reply_to":"9aa7fdbe_aa9a1012","updated":"2014-10-20 13:20:27.000000000","message":"Changes related to patch sets are discouraged. Once the patch is merged, this information is not useful when you run \"git log\".\nInstead it is suggested to reply to review comments. Just  replying \"Done\" is useful for reviewers.","commit_id":"f83299c5be6576f5b66407ea95c5ba0fdba1e013"}],"horizon/static/horizon/js/horizon.networktopology.js":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"dfc9869ab8319f964d05e7470fa2e6d6f3e59334","unresolved":false,"context_lines":[{"line_number":605,"context_line":"    var type \u003d $(action).data(\u0027type\u0027);"},{"line_number":606,"context_line":"    var device_id \u003d $(action).data(\u0027device-id\u0027);"},{"line_number":607,"context_line":"    $modal_parent \u003d $(action).closest(\u0027.modal\u0027);"},{"line_number":608,"context_line":"    name_array \u003d [];"},{"line_number":609,"context_line":"    action_string \u003d $action.text();"},{"line_number":610,"context_line":"    name_string \u003d \"\";"},{"line_number":611,"context_line":"    title \u003d interpolate(gettext(\"Confirm %s\"), [action_string]);"}],"source_content_type":"text/javascript","patch_set":1,"id":"baa201ad_243dbf8f","line":608,"updated":"2014-10-17 06:54:46.000000000","message":"variable not used anywhere.","commit_id":"cbe56dcc5d4b0014b6a7c453594edb306f468f80"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"dfc9869ab8319f964d05e7470fa2e6d6f3e59334","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    action_string \u003d $action.text();"},{"line_number":610,"context_line":"    name_string \u003d \"\";"},{"line_number":611,"context_line":"    title \u003d interpolate(gettext(\"Confirm %s\"), [action_string]);"},{"line_number":612,"context_line":"    body \u003d name_string + gettext(\"Please confirm your selection. This action cannot be undone.\");"},{"line_number":613,"context_line":"    modal \u003d horizon.modals.create(title, body, action_string);"},{"line_number":614,"context_line":"    modal.modal();"},{"line_number":615,"context_line":"  "}],"source_content_type":"text/javascript","patch_set":1,"id":"baa201ad_c4e5d338","line":612,"updated":"2014-10-17 06:54:46.000000000","message":"forget to assign a value for \u0027name_string\u0027.","commit_id":"cbe56dcc5d4b0014b6a7c453594edb306f468f80"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"dfc9869ab8319f964d05e7470fa2e6d6f3e59334","unresolved":false,"context_lines":[{"line_number":612,"context_line":"    body \u003d name_string + gettext(\"Please confirm your selection. This action cannot be undone.\");"},{"line_number":613,"context_line":"    modal \u003d horizon.modals.create(title, body, action_string);"},{"line_number":614,"context_line":"    modal.modal();"},{"line_number":615,"context_line":"  "},{"line_number":616,"context_line":"    if($modal_parent.length) {"},{"line_number":617,"context_line":"      var child_backdrop \u003d modal.next(\u0027.modal-backdrop\u0027);"},{"line_number":618,"context_line":"      // re-arrange z-index for these stacking modal"}],"source_content_type":"text/javascript","patch_set":1,"id":"baa201ad_049efbb8","line":615,"updated":"2014-10-17 06:54:46.000000000","message":"please remove the trailing white spaces, i am surprised how this got passed in pep8.","commit_id":"cbe56dcc5d4b0014b6a7c453594edb306f468f80"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"826dce44cc38ef31e942b8ded671200dd53f1cd8","unresolved":false,"context_lines":[{"line_number":601,"context_line":"      self.balloon_id \u003d null;"},{"line_number":602,"context_line":"    }"},{"line_number":603,"context_line":"  },"},{"line_number":604,"context_line":"  confirm:function(action) {"},{"line_number":605,"context_line":"    var self \u003d this;"},{"line_number":606,"context_line":"    var $action \u003d $(action);"},{"line_number":607,"context_line":"    var type \u003d $(action).data(\u0027type\u0027);"}],"source_content_type":"text/javascript","patch_set":3,"id":"9aa7fdbe_2a3c602f","line":604,"updated":"2014-10-20 12:36:11.000000000","message":"It might be clearer if this function were named \"confirm_delete\".  It\u0027s hard coded to that function.  Or better still, I notice that the \"Delete Interface\" action still does not require confirmation.  Maybe you should pass in the action to perform after confirmation.","commit_id":"f83299c5be6576f5b66407ea95c5ba0fdba1e013"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"826dce44cc38ef31e942b8ded671200dd53f1cd8","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    var $action \u003d $(action);"},{"line_number":607,"context_line":"    var type \u003d $(action).data(\u0027type\u0027);"},{"line_number":608,"context_line":"    var device_id \u003d $(action).data(\u0027device-id\u0027);"},{"line_number":609,"context_line":"    $modal_parent \u003d $(action).closest(\u0027.modal\u0027);"},{"line_number":610,"context_line":"    action_string \u003d $action.text();"},{"line_number":611,"context_line":"    title \u003d interpolate(gettext(\"Confirm %s\"), [action_string]);"},{"line_number":612,"context_line":"    body \u003d gettext(\"Please confirm your selection. This action cannot be undone.\");"}],"source_content_type":"text/javascript","patch_set":3,"id":"9aa7fdbe_4a77e402","line":609,"updated":"2014-10-20 12:36:11.000000000","message":"each local variable should have a \"var\" declaraion.","commit_id":"f83299c5be6576f5b66407ea95c5ba0fdba1e013"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"a016aa1ff136c593134227ec48e6fd2981ee57b7","unresolved":false,"context_lines":[{"line_number":585,"context_line":"    $balloon.find(\u0027.delete-device\u0027).click(function(e){"},{"line_number":586,"context_line":"      var $this \u003d $(this);"},{"line_number":587,"context_line":"      $this.prop(\u0027disabled\u0027, true);"},{"line_number":588,"context_line":"      d3.select(\u0027#id_\u0027 + $this.data(\u0027device-id\u0027)).classed(\u0027loading\u0027,true);"},{"line_number":589,"context_line":"      self.confirm_delete(this);"},{"line_number":590,"context_line":"    });"},{"line_number":591,"context_line":"    $balloon.find(\u0027.delete-port\u0027).click(function(e){"}],"source_content_type":"text/javascript","patch_set":4,"id":"3a961159_d0e64e15","line":588,"updated":"2015-01-17 18:53:03.000000000","message":"Might not need to set this \u0027loading\u0027 class since it\u0027s being taken care of in the confirm delete function","commit_id":"4df1ad9d85992877dfc7625dfd0fad575127f33e"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"a016aa1ff136c593134227ec48e6fd2981ee57b7","unresolved":false,"context_lines":[{"line_number":608,"context_line":"    var device_id \u003d $(action).data(\u0027device-id\u0027);"},{"line_number":609,"context_line":"    var router_id \u003d $(action).data(\u0027router-id\u0027);"},{"line_number":610,"context_line":"    var port_id \u003d $(action).data(\u0027port-id\u0027);"},{"line_number":611,"context_line":"    var $modal_parent \u003d $(action).closest(\u0027.modal\u0027);"},{"line_number":612,"context_line":"    var action_string \u003d $action.text();"},{"line_number":613,"context_line":"    title \u003d interpolate(gettext(\"Confirm %s\"), [action_string]);"},{"line_number":614,"context_line":"    body \u003d gettext(\"Please confirm your selection. This action cannot be undone.\");"}],"source_content_type":"text/javascript","patch_set":4,"id":"3a961159_10fff6ab","line":611,"updated":"2015-01-17 18:53:03.000000000","message":"Use $action that was already defined instead of $(action) for device_id, router_id, etc...","commit_id":"4df1ad9d85992877dfc7625dfd0fad575127f33e"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"a016aa1ff136c593134227ec48e6fd2981ee57b7","unresolved":false,"context_lines":[{"line_number":626,"context_line":"      form.submit();"},{"line_number":627,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":628,"context_line":"      $action.addClass(\u0027deleting\u0027);"},{"line_number":629,"context_line":"      d3.select(\u0027#id_\u0027 + $action.data(\u0027device-id\u0027)).classed(\u0027loading\u0027,true);"},{"line_number":630,"context_line":"      if(action_string \u003d\u003d \u0027Delete Interface\u0027){"},{"line_number":631,"context_line":"        self.delete_port(router_id, port_id);"},{"line_number":632,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":4,"id":"3a961159_b025425c","line":629,"updated":"2015-01-17 18:53:03.000000000","message":"Use device_id rather than $action.data(\u0027device-id\u0027)","commit_id":"4df1ad9d85992877dfc7625dfd0fad575127f33e"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"6b917744a97409cf75bace9f204a2d405f3adcf9","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    var $modal_parent \u003d $action.closest(\u0027.modal\u0027);"},{"line_number":631,"context_line":"    var action_string \u003d $action.text();"},{"line_number":632,"context_line":"    title \u003d interpolate(gettext(\"Confirm %s\"), [action_string]);"},{"line_number":633,"context_line":"    body \u003d gettext(\"Please confirm your selection. This action cannot be undone.\");"},{"line_number":634,"context_line":"    modal \u003d horizon.modals.create(title, body, action_string);"},{"line_number":635,"context_line":"    modal.modal();"},{"line_number":636,"context_line":"    if($modal_parent.length) {"}],"source_content_type":"text/javascript","patch_set":5,"id":"ba7be1f8_528576ab","line":633,"updated":"2015-02-24 06:18:45.000000000","message":"similar to other modals, it should start with \"You have selected \u003cname\u003e.\"","commit_id":"299b7e4bc1cf7e0a5c6f206c96446332b130bc01"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"c657dc6ee13457219612a094626333cb84512ecc","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    }"},{"line_number":644,"context_line":"    modal.find(\u0027.btn-primary\u0027).click(function (evt) {"},{"line_number":645,"context_line":"      form \u003d $action.closest(\u0027form\u0027);"},{"line_number":646,"context_line":"      form.append(\"\u003cinput type\u003d\u0027hidden\u0027 name\u003d\u0027\" + $action.attr(\u0027name\u0027) + \"\u0027 value\u003d\u0027\" + $action.attr(\u0027value\u0027) + \"\u0027/\u003e\");"},{"line_number":647,"context_line":"      form.submit();"},{"line_number":648,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":649,"context_line":"      $action.addClass(\u0027deleting\u0027);"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba7be1f8_266dda04","line":646,"updated":"2015-02-25 16:19:24.000000000","message":"it\u0027s not valid html5 to have an end tag on an input, even self-closing.","commit_id":"3accfb9b3d65fd43254b50b15e0db598be4e1b71"},{"author":{"_account_id":13546,"name":"Swati Sharma","email":"sharma.swati6@tcs.com","username":"swati"},"change_message_id":"82c997adcf9979569819316e327d13b60b9b1c65","unresolved":false,"context_lines":[{"line_number":643,"context_line":"    }"},{"line_number":644,"context_line":"    modal.find(\u0027.btn-primary\u0027).click(function (evt) {"},{"line_number":645,"context_line":"      form \u003d $action.closest(\u0027form\u0027);"},{"line_number":646,"context_line":"      form.append(\"\u003cinput type\u003d\u0027hidden\u0027 name\u003d\u0027\" + $action.attr(\u0027name\u0027) + \"\u0027 value\u003d\u0027\" + $action.attr(\u0027value\u0027) + \"\u0027/\u003e\");"},{"line_number":647,"context_line":"      form.submit();"},{"line_number":648,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":649,"context_line":"      $action.addClass(\u0027deleting\u0027);"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba7be1f8_4b1f15b7","line":646,"in_reply_to":"ba7be1f8_266dda04","updated":"2015-02-26 09:42:42.000000000","message":"Hi Doug,\n\nThe same pattern in used in other js files also. One of them is ./horizon/static/horizon/js/horizon.tables.js. Pls check.\n\nThanks","commit_id":"3accfb9b3d65fd43254b50b15e0db598be4e1b71"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"c657dc6ee13457219612a094626333cb84512ecc","unresolved":false,"context_lines":[{"line_number":649,"context_line":"      $action.addClass(\u0027deleting\u0027);"},{"line_number":650,"context_line":"      d3.select(\u0027#id_\u0027 + device_id).classed(\u0027loading\u0027,true);"},{"line_number":651,"context_line":"      if(action_string \u003d\u003d \u0027Delete Interface\u0027){"},{"line_number":652,"context_line":"        self.delete_port(router_id, port_id);"},{"line_number":653,"context_line":"      }"},{"line_number":654,"context_line":"      self.delete_device(type, device_id);"},{"line_number":655,"context_line":"      return false;"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba7be1f8_e929d58a","line":652,"updated":"2015-02-25 16:19:24.000000000","message":"Is this the label on the button?  If so its going to be translated, so this won\u0027t work outside of english.\n\nAlso \u003d\u003d\u003d instead of \u003d\u003d","commit_id":"3accfb9b3d65fd43254b50b15e0db598be4e1b71"},{"author":{"_account_id":13546,"name":"Swati Sharma","email":"sharma.swati6@tcs.com","username":"swati"},"change_message_id":"82c997adcf9979569819316e327d13b60b9b1c65","unresolved":false,"context_lines":[{"line_number":649,"context_line":"      $action.addClass(\u0027deleting\u0027);"},{"line_number":650,"context_line":"      d3.select(\u0027#id_\u0027 + device_id).classed(\u0027loading\u0027,true);"},{"line_number":651,"context_line":"      if(action_string \u003d\u003d \u0027Delete Interface\u0027){"},{"line_number":652,"context_line":"        self.delete_port(router_id, port_id);"},{"line_number":653,"context_line":"      }"},{"line_number":654,"context_line":"      self.delete_device(type, device_id);"},{"line_number":655,"context_line":"      return false;"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba7be1f8_cb8225c7","line":652,"in_reply_to":"ba7be1f8_e929d58a","updated":"2015-02-26 09:42:42.000000000","message":"Done","commit_id":"3accfb9b3d65fd43254b50b15e0db598be4e1b71"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"1e2986d382195216bfcea3e203d7fafdee01e012","unresolved":false,"context_lines":[{"line_number":620,"context_line":"      self.balloon_id \u003d null;"},{"line_number":621,"context_line":"    }"},{"line_number":622,"context_line":"  },"},{"line_number":623,"context_line":"  confirm_delete:function(action) {"},{"line_number":624,"context_line":"    var self \u003d this;"},{"line_number":625,"context_line":"    var $action \u003d $(action);"},{"line_number":626,"context_line":"    var type \u003d $action.data(\u0027type\u0027);"}],"source_content_type":"text/javascript","patch_set":7,"id":"9a80dd14_f159ae8e","line":623,"updated":"2015-03-09 16:19:36.000000000","message":"The variable name \"action\" threw me off a little. It\u0027s the button element that was clicked that as passed in. Can we get a name that\u0027s a little more descriptive?","commit_id":"69971ada73681d9ef04e5f767953712c1c4de173"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"1e2986d382195216bfcea3e203d7fafdee01e012","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    var type \u003d $action.data(\u0027type\u0027);"},{"line_number":627,"context_line":"    var device_id \u003d $action.data(\u0027device-id\u0027);"},{"line_number":628,"context_line":"    var router_id \u003d $action.data(\u0027router-id\u0027);"},{"line_number":629,"context_line":"    var port_id \u003d $action.data(\u0027port-id\u0027);"},{"line_number":630,"context_line":"    var $modal_parent \u003d $action.closest(\u0027.modal\u0027);"},{"line_number":631,"context_line":"    var action_string \u003d $action.text();"},{"line_number":632,"context_line":"    var name_string \u003d $(\"table.detailInfoTable\").closest(\"table\").find(\"caption\").text();"}],"source_content_type":"text/javascript","patch_set":7,"id":"9a80dd14_91a792a6","line":629,"range":{"start_line":629,"start_character":8,"end_line":629,"end_character":15},"updated":"2015-03-09 16:19:36.000000000","message":"port_id, router_id, and type are each only used once. Is there a reason these are variables instead of just being put in at call time?","commit_id":"69971ada73681d9ef04e5f767953712c1c4de173"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"1e2986d382195216bfcea3e203d7fafdee01e012","unresolved":false,"context_lines":[{"line_number":633,"context_line":"    name_string \u003d interpolate(gettext(\"You have selected %s. \"), [name_string]);"},{"line_number":634,"context_line":"    title \u003d interpolate(gettext(\"Confirm %s\"), [action_string]);"},{"line_number":635,"context_line":"    body \u003d name_string + gettext(\"Please confirm your selection. This action cannot be undone.\");"},{"line_number":636,"context_line":"    modal \u003d horizon.modals.create(title, body, action_string);"},{"line_number":637,"context_line":"    modal.modal();"},{"line_number":638,"context_line":"    if($modal_parent.length) {"},{"line_number":639,"context_line":"      var child_backdrop \u003d modal.next(\u0027.modal-backdrop\u0027);"}],"source_content_type":"text/javascript","patch_set":7,"id":"9a80dd14_5100ba33","line":636,"updated":"2015-03-09 16:19:36.000000000","message":"Why don\u0027t modal, body, and title have var in front of them? They way they are they are scoped outside this function. Is there a reason for that?","commit_id":"69971ada73681d9ef04e5f767953712c1c4de173"},{"author":{"_account_id":14619,"name":"Victor Feitosa","email":"victor.feitosa@lsbd.ufc.br","username":"victorfeitosa"},"change_message_id":"80832e580b5609a205f7de0e288e78f290eb7a22","unresolved":false,"context_lines":[{"line_number":620,"context_line":"      self.balloon_id \u003d null;"},{"line_number":621,"context_line":"    }"},{"line_number":622,"context_line":"  },"},{"line_number":623,"context_line":"  confirm_delete:function(button_element) {"},{"line_number":624,"context_line":"    var self \u003d this;"},{"line_number":625,"context_line":"    var $button_element \u003d $(button_element);"},{"line_number":626,"context_line":"    var device_id \u003d $button_element.data(\u0027device-id\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_80a7110a","line":623,"updated":"2015-03-10 13:29:16.000000000","message":"Shouldn\u0027t this be under horizon.tables? You must avoid boilerplate. If you do that you could also have another commit opportunity by transforming other table actions into the generalized code.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"049182150364026bb44c3dc87fefc6ab2d995829","unresolved":false,"context_lines":[{"line_number":620,"context_line":"      self.balloon_id \u003d null;"},{"line_number":621,"context_line":"    }"},{"line_number":622,"context_line":"  },"},{"line_number":623,"context_line":"  confirm_delete:function(button_element) {"},{"line_number":624,"context_line":"    var self \u003d this;"},{"line_number":625,"context_line":"    var $button_element \u003d $(button_element);"},{"line_number":626,"context_line":"    var device_id \u003d $button_element.data(\u0027device-id\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_21b0efdc","line":623,"in_reply_to":"9a80dd14_49cd215d","updated":"2015-03-11 14:22:02.000000000","message":"The confirmation associated with tables is tied to a table. It\u0027s not general. So, there are 2 options. 1) have a second confirmation as seen here or 2) rewrite the tables confirmation to be generalized and use it in both places.\n\nIf the angularjs work continues as it has been this will all be re-written in the near future. I think a second confirmation is acceptable until that is completed.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":13546,"name":"Swati Sharma","email":"sharma.swati6@tcs.com","username":"swati"},"change_message_id":"85a733f3b52dd97a943aaba2abe3d17dff1a0552","unresolved":false,"context_lines":[{"line_number":620,"context_line":"      self.balloon_id \u003d null;"},{"line_number":621,"context_line":"    }"},{"line_number":622,"context_line":"  },"},{"line_number":623,"context_line":"  confirm_delete:function(button_element) {"},{"line_number":624,"context_line":"    var self \u003d this;"},{"line_number":625,"context_line":"    var $button_element \u003d $(button_element);"},{"line_number":626,"context_line":"    var device_id \u003d $button_element.data(\u0027device-id\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_49cd215d","line":623,"in_reply_to":"9a80dd14_7c1633a9","updated":"2015-03-11 04:02:14.000000000","message":"Hi Victor,\n\nYes, I agree with Doug here. networktopology isn\u0027t a table so I don\u0027t think its code should get generalised in horizon.tables.\n\nPls suggest on this.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"1a20f8ccdeb5682a1cdfffbe250f9e6cc29751c4","unresolved":false,"context_lines":[{"line_number":620,"context_line":"      self.balloon_id \u003d null;"},{"line_number":621,"context_line":"    }"},{"line_number":622,"context_line":"  },"},{"line_number":623,"context_line":"  confirm_delete:function(button_element) {"},{"line_number":624,"context_line":"    var self \u003d this;"},{"line_number":625,"context_line":"    var $button_element \u003d $(button_element);"},{"line_number":626,"context_line":"    var device_id \u003d $button_element.data(\u0027device-id\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_7c1633a9","line":623,"in_reply_to":"9a80dd14_80a7110a","updated":"2015-03-10 19:22:22.000000000","message":"horizon tables has horizon.datatables.confirm but it seems pretty tied to tables.  networktopology isn\u0027t a table; I\u0027m not sure there is clear opportunity to consolidate code.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":14619,"name":"Victor Feitosa","email":"victor.feitosa@lsbd.ufc.br","username":"victorfeitosa"},"change_message_id":"80832e580b5609a205f7de0e288e78f290eb7a22","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    var device_id \u003d $button_element.data(\u0027device-id\u0027);"},{"line_number":627,"context_line":"    var $modal_parent \u003d $button_element.closest(\u0027.modal\u0027);"},{"line_number":628,"context_line":"    var button_string \u003d $button_element.text();"},{"line_number":629,"context_line":"    var name_string \u003d $(\"table.detailInfoTable\").closest(\"table\").find(\"caption\").text();"},{"line_number":630,"context_line":"    name_string \u003d interpolate(gettext(\"You have selected %s. \"), [name_string]);"},{"line_number":631,"context_line":"    var title \u003d interpolate(gettext(\"Confirm %s\"), [button_string]);"},{"line_number":632,"context_line":"    var body \u003d name_string + gettext(\"Please confirm your selection. This action cannot be undone.\");"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_c093c9a0","line":629,"updated":"2015-03-10 13:29:16.000000000","message":"If you put the code in horizon.tables, this \u0027table.detailInfoTable\u0027 should not be hard coded.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"049182150364026bb44c3dc87fefc6ab2d995829","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    var $modal_parent \u003d $button_element.closest(\u0027.modal\u0027);"},{"line_number":628,"context_line":"    var button_string \u003d $button_element.text();"},{"line_number":629,"context_line":"    var name_string \u003d $(\"table.detailInfoTable\").closest(\"table\").find(\"caption\").text();"},{"line_number":630,"context_line":"    name_string \u003d interpolate(gettext(\"You have selected %s. \"), [name_string]);"},{"line_number":631,"context_line":"    var title \u003d interpolate(gettext(\"Confirm %s\"), [button_string]);"},{"line_number":632,"context_line":"    var body \u003d name_string + gettext(\"Please confirm your selection. This action cannot be undone.\");"},{"line_number":633,"context_line":"    var modal \u003d horizon.modals.create(title, body, button_string);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_21dd4f43","line":630,"updated":"2015-03-11 14:22:02.000000000","message":"To be consistent with the terminate confirmation in the instances panel the %s should be \"%s\". This spot is missing the quotes.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"1a20f8ccdeb5682a1cdfffbe250f9e6cc29751c4","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    }"},{"line_number":641,"context_line":"    modal.find(\u0027.btn-primary\u0027).click(function (evt) {"},{"line_number":642,"context_line":"      form \u003d $button_element.closest(\u0027form\u0027);"},{"line_number":643,"context_line":"      form.append(\"\u003cinput type\u003d\u0027hidden\u0027 name\u003d\u0027\" + $button_element.attr(\u0027name\u0027) + \"\u0027 value\u003d\u0027\" + $button_element.attr(\u0027value\u0027) + \"\u0027/\u003e\");"},{"line_number":644,"context_line":"      form.submit();"},{"line_number":645,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":646,"context_line":"      $button_element.addClass(\u0027deleting\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_3c459bb3","line":643,"updated":"2015-03-10 19:22:22.000000000","message":"according to the html5 spec input must not have a closing tag.\n\nhttp://www.w3.org/html/wg/drafts/html/master/semantics.html#the-input-element","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"1bd1b718dc119ed7ed36b6d774a1c5597c555d30","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    }"},{"line_number":641,"context_line":"    modal.find(\u0027.btn-primary\u0027).click(function (evt) {"},{"line_number":642,"context_line":"      form \u003d $button_element.closest(\u0027form\u0027);"},{"line_number":643,"context_line":"      form.append(\"\u003cinput type\u003d\u0027hidden\u0027 name\u003d\u0027\" + $button_element.attr(\u0027name\u0027) + \"\u0027 value\u003d\u0027\" + $button_element.attr(\u0027value\u0027) + \"\u0027/\u003e\");"},{"line_number":644,"context_line":"      form.submit();"},{"line_number":645,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":646,"context_line":"      $button_element.addClass(\u0027deleting\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_fc2063b2","line":643,"in_reply_to":"9a80dd14_3c459bb3","updated":"2015-03-10 19:27:35.000000000","message":"I\u0027m wrong.  It\u0027s not required, but it can be kept as it is here.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"049182150364026bb44c3dc87fefc6ab2d995829","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    }"},{"line_number":641,"context_line":"    modal.find(\u0027.btn-primary\u0027).click(function (evt) {"},{"line_number":642,"context_line":"      form \u003d $button_element.closest(\u0027form\u0027);"},{"line_number":643,"context_line":"      form.append(\"\u003cinput type\u003d\u0027hidden\u0027 name\u003d\u0027\" + $button_element.attr(\u0027name\u0027) + \"\u0027 value\u003d\u0027\" + $button_element.attr(\u0027value\u0027) + \"\u0027/\u003e\");"},{"line_number":644,"context_line":"      form.submit();"},{"line_number":645,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":646,"context_line":"      $button_element.addClass(\u0027deleting\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_7e8522ac","line":643,"in_reply_to":"9a80dd14_89d719ed","updated":"2015-03-11 14:22:02.000000000","message":"html5 is not xml based. There aren\u0027t technically self closing tags with the /\u003e ending. So, you would do \u003cbr\u003e instead of \u003cbr/\u003e. There is quick stackoverflow answer on the topic at http://stackoverflow.com/a/3558200.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"},{"author":{"_account_id":13546,"name":"Swati Sharma","email":"sharma.swati6@tcs.com","username":"swati"},"change_message_id":"85a733f3b52dd97a943aaba2abe3d17dff1a0552","unresolved":false,"context_lines":[{"line_number":640,"context_line":"    }"},{"line_number":641,"context_line":"    modal.find(\u0027.btn-primary\u0027).click(function (evt) {"},{"line_number":642,"context_line":"      form \u003d $button_element.closest(\u0027form\u0027);"},{"line_number":643,"context_line":"      form.append(\"\u003cinput type\u003d\u0027hidden\u0027 name\u003d\u0027\" + $button_element.attr(\u0027name\u0027) + \"\u0027 value\u003d\u0027\" + $button_element.attr(\u0027value\u0027) + \"\u0027/\u003e\");"},{"line_number":644,"context_line":"      form.submit();"},{"line_number":645,"context_line":"      modal.modal(\u0027hide\u0027);"},{"line_number":646,"context_line":"      $button_element.addClass(\u0027deleting\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"9a80dd14_89d719ed","line":643,"in_reply_to":"9a80dd14_fc2063b2","updated":"2015-03-11 04:02:14.000000000","message":"Yes Doug, I checked other js code as well and its not required.","commit_id":"434f633348c32a1109bece2ecc2dcb4ae11fc28b"}],"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7642f32d32e0ad845cbeb13c6b2cf592e73d6d63","unresolved":false,"context_lines":[{"line_number":257,"context_line":"  var name_string \u003d \"\";"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  //Assume that we are going from the \"Network Topology\" tab"},{"line_number":260,"context_line":"  //If we trying perform an action on a port or subnet"},{"line_number":261,"context_line":"  var $closest_tr \u003d $action.closest(\"tr\");"},{"line_number":262,"context_line":"  var $data_display \u003d $closest_tr.find(\u0027span[data-display]\u0027);"},{"line_number":263,"context_line":"  if ($data_display.length \u003e 0){"}],"source_content_type":"text/javascript","patch_set":12,"id":"7f231b9d_41e56fa7","line":260,"updated":"2017-06-14 12:57:52.000000000","message":"Nitpick: add spaces after the // everywhere, see the other comments. This should be really caught by the linter.","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"6937b21d864519daf8823b12e63cc62bdafe80f9","unresolved":false,"context_lines":[{"line_number":257,"context_line":"  var name_string \u003d \"\";"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"  //Assume that we are going from the \"Network Topology\" tab"},{"line_number":260,"context_line":"  //If we trying perform an action on a port or subnet"},{"line_number":261,"context_line":"  var $closest_tr \u003d $action.closest(\"tr\");"},{"line_number":262,"context_line":"  var $data_display \u003d $closest_tr.find(\u0027span[data-display]\u0027);"},{"line_number":263,"context_line":"  if ($data_display.length \u003e 0){"}],"source_content_type":"text/javascript","patch_set":12,"id":"7f231b9d_e0b455d3","line":260,"in_reply_to":"7f231b9d_41e56fa7","updated":"2017-06-19 09:45:58.000000000","message":"Done","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7642f32d32e0ad845cbeb13c6b2cf592e73d6d63","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    name_array \u003d [name_string];"},{"line_number":266,"context_line":"  }"},{"line_number":267,"context_line":"  //Else we trying to perform an action on device"},{"line_number":268,"context_line":"  else {"},{"line_number":269,"context_line":"    var $device_window \u003d $(\u0027div.topologyBalloon\u0027);"},{"line_number":270,"context_line":"    var $device_table \u003d $device_window.find(\u0027table.detailInfoTable\u0027).has(\u0027caption[data-display]\u0027);"},{"line_number":271,"context_line":"    var $data_display \u003d $device_table.find(\u0027caption[data-display]\u0027);"}],"source_content_type":"text/javascript","patch_set":12,"id":"7f231b9d_61ff4b34","line":268,"updated":"2017-06-14 12:57:52.000000000","message":"nit: move the else to the same line as } and move the comment inside the block.","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"6937b21d864519daf8823b12e63cc62bdafe80f9","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    name_array \u003d [name_string];"},{"line_number":266,"context_line":"  }"},{"line_number":267,"context_line":"  //Else we trying to perform an action on device"},{"line_number":268,"context_line":"  else {"},{"line_number":269,"context_line":"    var $device_window \u003d $(\u0027div.topologyBalloon\u0027);"},{"line_number":270,"context_line":"    var $device_table \u003d $device_window.find(\u0027table.detailInfoTable\u0027).has(\u0027caption[data-display]\u0027);"},{"line_number":271,"context_line":"    var $data_display \u003d $device_table.find(\u0027caption[data-display]\u0027);"}],"source_content_type":"text/javascript","patch_set":12,"id":"7f231b9d_e0e9f5b6","line":268,"in_reply_to":"7f231b9d_61ff4b34","updated":"2017-06-19 09:45:58.000000000","message":"Done","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"}],"openstack_dashboard/dashboards/project/network_topology/templates/network_topology/client_side/_balloon_container.html":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"5ad855e4ba9b1b5f786dc7b5f26ee99e45e5238c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"{% load i18n sizeformat %}"},{"line_number":9,"context_line":"\u003cdiv class\u003d\"topologyBalloon\" id\u003d\"[[balloon_id]]\"\u003e"},{"line_number":10,"context_line":"  \u003ca href\u003d\"#close\" class\u003d\"closeTopologyBalloon\"\u003e\u0026times;\u003c/a\u003e"},{"line_number":11,"context_line":"  \u003cdiv class\u003d\"contentBody\"\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"df140735_8900a536","line":8,"updated":"2017-05-30 04:44:50.000000000","message":"You don\u0027t need the sizeformat. i18n should be added to line 2.","commit_id":"7ad255565676f940ff94eded72c4fb87eade15ce"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"8f3fdb8c66b56ee65f5eee06a0c4fe23057bbf48","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"{% load i18n sizeformat %}"},{"line_number":9,"context_line":"\u003cdiv class\u003d\"topologyBalloon\" id\u003d\"[[balloon_id]]\"\u003e"},{"line_number":10,"context_line":"  \u003ca href\u003d\"#close\" class\u003d\"closeTopologyBalloon\"\u003e\u0026times;\u003c/a\u003e"},{"line_number":11,"context_line":"  \u003cdiv class\u003d\"contentBody\"\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"df140735_6100c535","line":8,"in_reply_to":"df140735_8900a536","updated":"2017-05-30 10:18:54.000000000","message":"Done","commit_id":"7ad255565676f940ff94eded72c4fb87eade15ce"}],"openstack_dashboard/dashboards/project/network_topology/templates/network_topology/client_side/_balloon_device.html":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7642f32d32e0ad845cbeb13c6b2cf592e73d6d63","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"\u003ctable class\u003d\"detailInfoTable\"\u003e"},{"line_number":9,"context_line":"  \u003ccaption data-display\u003d[[name]]\u003e[[name]]\u003c/caption\u003e"},{"line_number":10,"context_line":"  \u003ctbody\u003e"},{"line_number":11,"context_line":"    \u003ctr\u003e"},{"line_number":12,"context_line":"      \u003cth class\u003d\"device\"\u003e[[id_label]]\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"7f231b9d_61ad0b30","line":9,"updated":"2017-06-14 12:57:52.000000000","message":"I think you need \"\" around that data-display value, just in case.","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"6937b21d864519daf8823b12e63cc62bdafe80f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"\u003ctable class\u003d\"detailInfoTable\"\u003e"},{"line_number":9,"context_line":"  \u003ccaption data-display\u003d[[name]]\u003e[[name]]\u003c/caption\u003e"},{"line_number":10,"context_line":"  \u003ctbody\u003e"},{"line_number":11,"context_line":"    \u003ctr\u003e"},{"line_number":12,"context_line":"      \u003cth class\u003d\"device\"\u003e[[id_label]]\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"7f231b9d_60d5e5e4","line":9,"in_reply_to":"7f231b9d_61ad0b30","updated":"2017-06-19 09:45:58.000000000","message":"Done","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"}],"openstack_dashboard/dashboards/project/network_topology/templates/network_topology/client_side/_balloon_net.html":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"5ad855e4ba9b1b5f786dc7b5f26ee99e45e5238c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      \u003ctd class\u003d\"delete\"\u003e"},{"line_number":29,"context_line":"        \u003cbutton class\u003d\"delete-port btn btn-danger btn-xs\""},{"line_number":30,"context_line":"          data-router-id\u003d\"[[router_id]]\" data-network-id\u003d\"[[network_id]]\""},{"line_number":31,"context_line":"          data-port-id\u003d\"[[id]]\"\u003e[[delete_subnet_label]]\u003c/button\u003e"},{"line_number":32,"context_line":"      \u003c/td\u003e"},{"line_number":33,"context_line":"    \u003c/tr\u003e"},{"line_number":34,"context_line":"    [[/subnet]]"}],"source_content_type":"text/html","patch_set":11,"id":"df140735_09c375ef","line":31,"updated":"2017-05-30 04:44:50.000000000","message":"help_text should be added here as well to be consistent.","commit_id":"7ad255565676f940ff94eded72c4fb87eade15ce"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"8f3fdb8c66b56ee65f5eee06a0c4fe23057bbf48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      \u003ctd class\u003d\"delete\"\u003e"},{"line_number":29,"context_line":"        \u003cbutton class\u003d\"delete-port btn btn-danger btn-xs\""},{"line_number":30,"context_line":"          data-router-id\u003d\"[[router_id]]\" data-network-id\u003d\"[[network_id]]\""},{"line_number":31,"context_line":"          data-port-id\u003d\"[[id]]\"\u003e[[delete_subnet_label]]\u003c/button\u003e"},{"line_number":32,"context_line":"      \u003c/td\u003e"},{"line_number":33,"context_line":"    \u003c/tr\u003e"},{"line_number":34,"context_line":"    [[/subnet]]"}],"source_content_type":"text/html","patch_set":11,"id":"df140735_41ab811c","line":31,"in_reply_to":"df140735_09c375ef","updated":"2017-05-30 10:18:54.000000000","message":"Done","commit_id":"7ad255565676f940ff94eded72c4fb87eade15ce"}],"openstack_dashboard/dashboards/project/network_topology/templates/network_topology/client_side/_balloon_port.html":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"5ad855e4ba9b1b5f786dc7b5f26ee99e45e5238c","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"{% load i18n sizeformat %}"},{"line_number":9,"context_line":"\u003cdiv class\u003d\"portTableHeader\"\u003e"},{"line_number":10,"context_line":"  \u003cdiv class\u003d\"title\"\u003e[[interfaces_label]]\u003c/div\u003e"},{"line_number":11,"context_line":"  \u003cdiv class\u003d\"action\"\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"df140735_69fd5139","line":8,"updated":"2017-05-30 04:44:50.000000000","message":"You don\u0027t need the sizeformat. i18n should be added to line 2.","commit_id":"7ad255565676f940ff94eded72c4fb87eade15ce"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"8f3fdb8c66b56ee65f5eee06a0c4fe23057bbf48","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block template %}"},{"line_number":7,"context_line":"{% jstemplate %}"},{"line_number":8,"context_line":"{% load i18n sizeformat %}"},{"line_number":9,"context_line":"\u003cdiv class\u003d\"portTableHeader\"\u003e"},{"line_number":10,"context_line":"  \u003cdiv class\u003d\"title\"\u003e[[interfaces_label]]\u003c/div\u003e"},{"line_number":11,"context_line":"  \u003cdiv class\u003d\"action\"\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"df140735_a1d5bdbb","line":8,"in_reply_to":"df140735_69fd5139","updated":"2017-05-30 10:18:54.000000000","message":"Done","commit_id":"7ad255565676f940ff94eded72c4fb87eade15ce"}],"openstack_dashboard/static/js/horizon.flatnetworktopology.js":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7642f32d32e0ad845cbeb13c6b2cf592e73d6d63","unresolved":false,"context_lines":[{"line_number":629,"context_line":"      var $this \u003d $(this);"},{"line_number":630,"context_line":"      var delete_modal \u003d horizon.datatables.confirm($this);"},{"line_number":631,"context_line":"      delete_modal.find(\u0027.btn-primary\u0027).click(function () {"},{"line_number":632,"context_line":"        self.delete_port($this.data(\u0027router-id\u0027),$this.data(\u0027port-id\u0027),$this.data(\u0027network-id\u0027));"},{"line_number":633,"context_line":"        horizon.modals.spinner.modal(\u0027hide\u0027);"},{"line_number":634,"context_line":"      });"},{"line_number":635,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":12,"id":"7f231b9d_615bcb53","line":632,"updated":"2017-06-14 12:57:52.000000000","message":"Are you sure you don\u0027t need self.delete_balloon(); here? It\u0027s there in the other file.","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"6937b21d864519daf8823b12e63cc62bdafe80f9","unresolved":false,"context_lines":[{"line_number":629,"context_line":"      var $this \u003d $(this);"},{"line_number":630,"context_line":"      var delete_modal \u003d horizon.datatables.confirm($this);"},{"line_number":631,"context_line":"      delete_modal.find(\u0027.btn-primary\u0027).click(function () {"},{"line_number":632,"context_line":"        self.delete_port($this.data(\u0027router-id\u0027),$this.data(\u0027port-id\u0027),$this.data(\u0027network-id\u0027));"},{"line_number":633,"context_line":"        horizon.modals.spinner.modal(\u0027hide\u0027);"},{"line_number":634,"context_line":"      });"},{"line_number":635,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":12,"id":"7f231b9d_638b8867","line":632,"in_reply_to":"7f231b9d_615bcb53","updated":"2017-06-19 09:45:58.000000000","message":"Change this behavior to disable a button.","commit_id":"4763a7acab52327f6a8ea71c30b4b244df2f9a6a"}]}
